[GitHub] [wicket] solomax opened a new pull request #434: [WICKET-6789] 'base-uri' is added to CSPDirective enum
solomax opened a new pull request #434: URL: https://github.com/apache/wicket/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: 'base-uri' CSP directive is missing
Hello Emond, I'll create PR :) Sorry I misspelled your name :( (from mobile, sorry for typos) On Sun, May 24, 2020, 21:31 Maxim Solodovnik wrote: > Hello Edmond, > > It seems 'base-uri' directive [1] is missing is "enum CSPDirective" > Is it on purpose? > > One of our users check current rules using some validator [2] > > [1] > https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri > [2] > https://issues.apache.org/jira/browse/OPENMEETINGS-2370?focusedCommentId=17114589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17114589 > > -- > Best regards, > Maxim >
Re: Make ComponentRenderer implement AutoCloseable?
Hi Thorsten, ComponentRender#destroy() destroys the application, there's not much more to it. In most cases you will want to reuse the application for performance reasons. A specific application can even be used as constructor argument, which might be the main web application that you don't want to be destroyed prematurely. So auto-closing i.e. destroying the renderer after each render might lead people into the wrong direction. Have fun Sven On 24.05.20 16:28, Thorsten Schöning wrote: Hi all, I'm using Wicket as a template engine to render reports in some backend with various different output formats. Everything is based on "ComponentRenderer", though, and that introduced a large memory leak in my case. Root cause simply was that I forgot to call "destroy". So how about implementing AutoCloseable by that class? In most IDEs that would have at least triggered a warning. Mit freundlichen Grüßen, Thorsten Schöning
'base-uri' CSP directive is missing
Hello Edmond, It seems 'base-uri' directive [1] is missing is "enum CSPDirective" Is it on purpose? One of our users check current rules using some validator [2] [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri [2] https://issues.apache.org/jira/browse/OPENMEETINGS-2370?focusedCommentId=17114589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17114589 -- Best regards, Maxim
Make ComponentRenderer implement AutoCloseable?
Hi all, I'm using Wicket as a template engine to render reports in some backend with various different output formats. Everything is based on "ComponentRenderer", though, and that introduced a large memory leak in my case. Root cause simply was that I forgot to call "destroy". So how about implementing AutoCloseable by that class? In most IDEs that would have at least triggered a warning. Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...05151- 9468- 55 Fax...05151- 9468- 88 Mobil..0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
[GitHub] [wicket] theigl opened a new pull request #433: WICKET-6788 Improve performance of markup escaping
theigl opened a new pull request #433: URL: https://github.com/apache/wicket/pull/433 Checks for `Character.UNASSIGNED` instead of looking up non-chars in a set. This solution more than doubles the throughput: ``` escapeMarkupHashSetthrpt5 395348,174 ± 48047,375 ops/s escapeMarkupCharacterType thrpt5 847227,062 ± 13051,584 ops/s ``` https://issues.apache.org/jira/browse/WICKET-6788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
