Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Jeremy Thomerson
On Mon, Jan 24, 2011 at 4:41 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Mon, Jan 24, 2011 at 4:40 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Mon, Jan 24, 2011 at 2:37 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: what if we factor out html packages out of

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Martin Grigorov
On Tue, Jan 25, 2011 at 9:18 AM, Jeremy Thomerson jer...@wickettraining.com wrote: On Mon, Jan 24, 2011 at 4:41 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Mon, Jan 24, 2011 at 4:40 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Mon, Jan 24, 2011 at 2:37 PM,

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Guillaume Smet
Hi Jeremy, On Tue, Jan 25, 2011 at 9:18 AM, Jeremy Thomerson jer...@wickettraining.com wrote: Then, I changed all other modules that were depending on -core to depend on plain wicket.  But, that didn't work. IMHO, it's a bad idea. If the goal is to have cleaner dependencies, you should make

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Martin Grigorov
[x] - Just forget about the aggregated wicket.jar and modify the wicket module a pom-only module. This means Maven users can eternally depend on wicket only, and not care about how we (re-)structure our code. Non-maven users will have to download all the separate jars, or use Ivy, or whatever.

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread tetsuo
What about having the aggregated jar only for the bundle (zip) download, not to be available in maven central? On Tue, Jan 25, 2011 at 7:17 AM, Martin Grigorov mgrigo...@apache.org wrote: [x] - Just forget about the aggregated wicket.jar and modify the wicket module a pom-only module.  This

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Max Bowsher
On 25/01/11 10:44, tetsuo wrote: What about having the aggregated jar only for the bundle (zip) download, not to be available in maven central? In my experience aggregated jars tend to prove more of confusion in the end, than a help, with users who misunderstand and end up with multiple copies

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread tetsuo
When you don't use maven. For example, most Ant-based projects I've worked with use spring.jar, instead of

convertToString must override

2011-01-25 Thread Christian Grobmeier
Hello all, just have set up a wicket dev environment and the wicket-util project throwed one error. convertToString must override Works with deleting it - not sure if this was the intention :-) Best Christian Index:

Strange writeObjectMethodCache in SerializableChecker

2011-01-25 Thread Emond Papegaaij
Hi all, At Topicus, we maintain a customized SerializableChecker with some additional checks. I was trying to fix some generics-warnings and noticed a strange thing about the writeObjectMethodCache. This variable is used in only 4 places, one is a clear, one a get and 2 are puts. Both puts

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread James Carman
On Mon, Jan 24, 2011 at 12:32 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: with the new split we have introduced iprovider interface which decouples the mess. a good example is that if now some part of request processing needs a configurable option it gets it via iprovider which in turn

Re: convertToString must override

2011-01-25 Thread Martin Grigorov
On Tue, Jan 25, 2011 at 1:29 PM, Christian Grobmeier grobme...@gmail.comwrote: Hello all, just have set up a wicket dev environment and the wicket-util project throwed one error. convertToString must override Works with deleting it - not sure if this was the intention :-) Best Christian

Re: Strange writeObjectMethodCache in SerializableChecker

2011-01-25 Thread Martin Grigorov
File a ticket + patch ;-) What else do you have in this custom SerializableChecker ? Maybe it is something that other users may benefit from and it can be included in the standard SerializableChecker and you'll not have to maintain it. On Tue, Jan 25, 2011 at 2:06 PM, Emond Papegaaij

Re: convertToString must override

2011-01-25 Thread Ernesto Reinaldo Barreiro
Change your compiler compliance level? On Tue, Jan 25, 2011 at 1:29 PM, Christian Grobmeier grobme...@gmail.com wrote: Hello all, just have set up a wicket dev environment and the wicket-util project throwed one error. convertToString must override Works with deleting it - not sure if this

Re: convertToString must override

2011-01-25 Thread Christian Grobmeier
Weird. I checked what you said and my JVM is complaining about overriding Number with Integer. Its Mac build SE-1.5 (OSX 10.6.6) Which JDK do you use ? With jdk1.5.0_22 this compiles without any problems. convertToString() comes from

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Pedro Santos
Spring distribution hasn't the spring.jar anymore: https://fisheye.springsource.org/browse/spring-framework/trunk/build-spring-framework/resources/readme.txt?r=2858r=2854r=2940r=3872 On Tue, Jan 25, 2011 at 10:27 AM, tetsuo ronald.tet...@gmail.com wrote: When you don't use maven. For example,

Re: Strange writeObjectMethodCache in SerializableChecker

2011-01-25 Thread Emond Papegaaij
Done: https://issues.apache.org/jira/browse/WICKET-3383 We extended the checker with checks for entities and attached LDMs, to prevent Hibernate sessions to leak through to the next request. I've also stripped the object paths to the bare minimum, which improves performace quite a bit. For

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Andrea Del Bene
Spring stopped distributing aggregate jar since version 3.0. We could consider to keep distributing aggregate jar for a certain number of future versions but in the end i think we should fully embrace modules organization. When you don't use maven. For example, most Ant-based projects I've

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread tetsuo
Which is kinda sad, since I still find too many Ant (and variants) -based projects out there (which is even more sad). Spring is becoming increasingly more difficult for beginners. Even the old MVC tutorial (which were a very good step-by-step script) isn't available anywhere anymore. It doesn't

Annotation for classes which should not be serialized

2011-01-25 Thread Martin Grigorov
Hi, Someone just asked in ##wicket something like: for some reason my entity is serialized. it is wrapped in LDM, but still something went wrong and instead just the entity id, the whole entity is serialized https://gist.github.com/795052 Here are suggest introducing an annotation which serves

Re: Annotation for classes which should not be serialized

2011-01-25 Thread Pedro Santos
Currently the serializable checker is only triggered when an NotSerializableException was thrown. Means that @WicketDontSerialize annotated beams will not get detected only by changing the SerializableChecker. Perhaps an IObjectStreamFactory that return an ObjectInputStream doing the check? Would

Re: Annotation for classes which should not be serialized

2011-01-25 Thread Martin Grigorov
On Tue, Jan 25, 2011 at 4:31 PM, Martin Grigorov martin.grigo...@gmail.comwrote: Hi, Someone just asked in ##wicket something like: for some reason my entity is serialized. it is wrapped in LDM, but still something went wrong and instead just the entity id, the whole entity is serialized

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Jeremy Thomerson
On Tue, Jan 25, 2011 at 7:06 AM, James Carman ja...@carmanconsulting.comwrote: It sounds like you've fixed some of the problem(s) that caused you to split stuff up in the first place, but you did it using *code design* which is the correct way to go about this. The module gymnastics approach

RC1 parameter name style guide

2011-01-25 Thread richard emberson
While going through RC1 wicket-util I noted that in the org.apache.wicket.util.upload package there are a number of places where the parameter names to methods and constructors are of the form pName (e.g., pSizeMax. pIn, pHeaders. pContentLength. etc.). I think that this is the first time I've

Re: RC1 parameter name style guide

2011-01-25 Thread Igor Vaynberg
that code was taking out of apache commons upload afair. -igor On Tue, Jan 25, 2011 at 9:16 AM, richard emberson richard.ember...@gmail.com wrote: While going through RC1 wicket-util I noted that in the org.apache.wicket.util.upload package there are a number of places where the parameter

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread James Carman
On Tue, Jan 25, 2011 at 11:50 AM, Jeremy Thomerson jer...@wickettraining.com wrote: The separate modules is a good way to enforce the separation.  If you have other ideas for enforcing them, I'd be happy to hear them. It doesn't really enforce anything. Folks can still put classes in the

Re: [discuss] How to resolve wicket aggregate classes / sources jar issues

2011-01-25 Thread Igor Vaynberg
yes, people can still make mistakes, but at least when they are fixed its easy to see all places affected. even currently it offers a lot of advantages. for example when working on request module you cannot mistaking add a dependency on Application or Component or somethign else core-specific

Re: RC1 parameter name style guide

2011-01-25 Thread James Carman
Sure blame us commons people :) On Jan 25, 2011 12:21 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: that code was taking out of apache commons upload afair. -igor On Tue, Jan 25, 2011 at 9:16 AM, richard emberson richard.ember...@gmail.com wrote: While going through RC1 wicket-util I