Looking for help with wicketstuff-core releases

2012-05-30 Thread Michael O'Cleirigh
Hello, I've been doing the wicketstuff-core builds since May 2010 and I've been pretty selfish in that I only added myself to the list of users allowed to publish org.wicketstuff artifacts through the oss.sonatype.org infrastructure. My wife had twin boys this past January so I have found th

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Sebastien
Hello Martin, As you did not repro the issue, I wanted to be sure it was repro on my side before testing the fix. The fact is that it was really difficult to reproduce: I had to make a really heavy life to tomcat for the exception to be thrown. (but when it is thrown once, it is thrown each time t

[Vote] Release Apache Wicket 1.5.7 (build 2)

2012-05-30 Thread Martin Grigorov
This vote is to release Apache Wicket 1.5.7 Git repo http://git-wip-us.apache.org/repos/asf/wicket.git Branch name build/wicket-1.5.7 Archived and signed Git repo http://people.apache.org/~mgrigorov/wicket-1.5.7/ Changelog https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231056

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Martin Grigorov
I made all public method of PageWindowManager synchronized as Andrea suggested. @Sebastien: please try 1.5-SNAPSHOT or 1.5.7 second build which I'll run now. On Wed, May 30, 2012 at 3:06 PM, Andrea Del Bene wrote: > Please take a look at WICKET-4577 before building  a new 1.5.7 > -- Martin G

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Andrea Del Bene
Please take a look at WICKET-4577 before building a new 1.5.7

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Sebastien
Hello Martin, If the git repo is up-to-date, I can test it this evening. Please let me know. Best regards, Sebastien On Wed, May 30, 2012 at 11:47 AM, Martin Grigorov wrote: > I agree. This is what I'm testing currently. > Actually only the private methods which use the maps need to be > synchr

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Martin Grigorov
I agree. This is what I'm testing currently. Actually only the private methods which use the maps need to be synchronized. But since I wasn't able to reproduce the problem and I have no time now to write a new multithreaded unit test for PageWindowManager I'm not 100% certain that the issue will b

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Andrea Del Bene
I don't wanna be too simplistic or too optimistic ( :-) ), but it should be enough to make 'synchronized' the public methods of PageWindowManager...This shouldn't cause performance issues since we have only few (two?) threads per user and is better then building a complex error-prone implementa

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Martin Grigorov
On Wed, May 30, 2012 at 10:48 AM, Andrea Del Bene wrote: > Hi, > > is it possible that the synchronization problem is due to a concurrent use > of DataStore inside AsynchronousDataStore? For example this could happen if > both AsynchronousDataStore and PageSavingRunnable call > 'dataStore.storeDat

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Andrea Del Bene
Hi, is it possible that the synchronization problem is due to a concurrent use of DataStore inside AsynchronousDataStore? For example this could happen if both AsynchronousDataStore and PageSavingRunnable call 'dataStore.storeData'. Hi, I'm not able so far to reproduce the problem. I tried w

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Martin Grigorov
This vote is canceled due to this potential problem. On Wed, May 30, 2012 at 10:19 AM, Martin Grigorov wrote: > Hi, > > I'm not able so far to reproduce the problem. I tried with > wicket-examples, our app and wicket-jquery-ui examples. > > But I see how this can happen! > > The new inversed inde

Re: [Vote] Release Apache Wicket 1.5.7

2012-05-30 Thread Martin Grigorov
Hi, I'm not able so far to reproduce the problem. I tried with wicket-examples, our app and wicket-jquery-ui examples. But I see how this can happen! The new inversed index should be in sync with the normal index all the time, i.e. when the normal is null the inversed is null too. But there is n