[GitHub] wicket issue #171: modified class resolution to account for OSGi classloader...

2016-06-08 Thread martin-g
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/171 Hi, Thank you for the Pull Request! Could you please provide more information why this change is needed ? For OSGi environment the application is supposed to use custom

Re: MetaDataHeaderItem # generateString()

2016-06-08 Thread Francois Meillet
https://issues.apache.org/jira/browse/WICKET-6178 François > Le 8 juin 2016 à 12:16, Martin Grigorov a écrit : > > Hi Francois, > > On Wed, Jun 8, 2016 at 11:50 AM, Francois Meillet < >

Re: MetaDataHeaderItem # generateString()

2016-06-08 Thread Martin Grigorov
Hi Francois, On Wed, Jun 8, 2016 at 11:50 AM, Francois Meillet < francois.meil...@gmail.com> wrote: > Hi Wicket Devs, > > I think MetaDataHeaderItem # generateString() should return specials > characters escaped like > StringEscapeUtils.escapeHtml(s) does. > > Apache Wicket 7.3.0 -

Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Francois Meillet
Agree to keep things lights Thanks Martin, François > Le 8 juin 2016 à 11:58, Martin Grigorov a écrit : > > Hi Francois, > > This has been done long time ago (Wicket 1.0/1.1). > The idea is to keep Wicket light, without dependencies. > Only the classes Wicket

Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Martin Grigorov
Hi Francois, This has been done long time ago (Wicket 1.0/1.1). The idea is to keep Wicket light, without dependencies. Only the classes Wicket internals needed were copied. In Wicket 7.0.0 we introduced dependency to commons-fileupload to be able to update it. This also included commons-io as

org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Francois Meillet
Hi, Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not directly the lib ? Thanks François