Re: Git team workflow

Hi, if you don‘t be sure if everything is right you can also push your changes into a separate branch at your repo and create a PR to the target branch at your own repo (with the github ui) This way you can review your changes before pushing them to the wickstuff or even provide a PR there.

Re: Git team workflow

Hello Dieter, You are the "component owner" so you can commit directly in case "you feel lucky (c)" and don't need a review PR is necessary in case you need second opinion or two :) On Fri, Dec 8, 2017 at 2:16 PM, Dieter Tremel wrote: > Hello wicketstuff team, > > as

Git team workflow

Hello wicketstuff team, as newbie wicketstuff contributor (gchart) I have to ask some questions around team workflow. Sorry if my knowledge here is not sufficient, I work mostly alone for a long time, so I had to improve my git and github handling a lot. And of course I don't want initiate any

[GitHub] wicket pull request #249: independent component renderer

Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/249 ---

[GitHub] wicket pull request #249: independent component renderer

Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/249#discussion_r155481407 --- Diff: wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java --- @@ -16,35 +16,321 @@ */ package

[GitHub] wicket pull request #249: independent component renderer

Github user svenmeier commented on a diff in the pull request: https://github.com/apache/wicket/pull/249#discussion_r155472740 --- Diff: wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java --- @@ -16,35 +16,321 @@ */ package

[GitHub] wicket pull request #249: independent component renderer

Github user solomax commented on a diff in the pull request: https://github.com/apache/wicket/pull/249#discussion_r155466396 --- Diff: wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java --- @@ -16,35 +16,321 @@ */ package

[GitHub] wicket pull request #249: independent component renderer

Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/249#discussion_r155464694 --- Diff: wicket-core/src/main/java/org/apache/wicket/core/util/string/ComponentRenderer.java --- @@ -16,35 +16,321 @@ */ package

[GitHub] wicket issue #249: independent component renderer

Github user solomax commented on the issue: https://github.com/apache/wicket/pull/249 We are currently using WicketTester for this, I'll try this later tonight and will give huge +1 :)) ---

[GitHub] wicket pull request #249: independent component renderer

GitHub user svenmeier opened a pull request: https://github.com/apache/wicket/pull/249 independent component renderer ComponentRenderer makes it easy to render components, but it still needs the thread to be attached to a WebApplication's ThreadContext: I've seen projects use

Re: wicket git commit: render independently from web or tester

Wow, you're fast :P Sven Am 07.12.2017 um 09:29 schrieb Maxim Solodovnik: Hello Sven, Is this correct import? import com.google.common.base.Supplier; On Thu, Dec 7, 2017 at 3:24 PM, wrote: Repository: wicket Updated Branches: refs/heads/sandbox/component-renderer

Re: wicket git commit: render independently from web or tester

Hello Sven, Is this correct import? import com.google.common.base.Supplier; On Thu, Dec 7, 2017 at 3:24 PM, wrote: > Repository: wicket > Updated Branches: > refs/heads/sandbox/component-renderer [created] 6e6c273fd > > > render independently from web or tester > > >