Re: Wicketstuff build

2018-02-17 Thread Maxim Solodovnik
It seems it is impossible to create "secret" Travis command line option ...
Is this true?

Am I right thinking the only "correct Travis" way is via Environment
variable?

On Sun, Feb 18, 2018 at 11:38 AM, Maxim Solodovnik 
wrote:

> Have added possibility to specify API key via command line:
> https://github.com/wicketstuff/core/commit/e7d8ed7721a2dbcdb04082dac5c290
> c2d17d454b
> Correct API key can be added in Travis config as well
>
> On Sun, Feb 18, 2018 at 2:42 AM, Andrea Del Bene 
> wrote:
>
>> Locally you can temporary use the @ignore tag, but I'm afraid there's no
>> way to bypass it on Travis. We can just wait long enough to re-run the
>> building, hoping that some one else hasn't already reached the query limit
>> in the meantime.
>>
>> PS: on 7.x branch I see test org.wicketstuff.security.SessionInvalidationTest
>> is failing. I haven't investigated the problem yet but it could be
>> something related to the changes to mock entities made with WICKET-6441.
>>
>>
>> On 17/02/2018 17:16, Maxim Solodovnik wrote:
>>
>>> Hello All,
>>>
>>> I have started local build of wickestuff right now and got following
>>> errors:
>>> I believe there might be limitation on query per day/per application
>>>
>>> What is the correct way to bypass this limitation?
>>>
>>> Thanks in advance!
>>>
>>>
>>> ---
>>>   T E S T S
>>> ---
>>> Running wicket.contrib.gmap.util.GMapTest
>>> log4j:WARN No appenders could be found for logger
>>> (org.apache.wicket.Application).
>>> log4j:WARN Please initialize the log4j system properly.
>>> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>>> more info.
>>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.358
>>> sec -
>>> in wicket.contrib.gmap.util.GMapTest
>>> Running wicket.contrib.gmap.util.GeocoderTest
>>> Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.433 sec
>>> <<< FAILURE! - in wicket.contrib.gmap.util.GeocoderTest
>>> testCenterAndFitZoomForAdress(wicket.contrib.gmap.util.GeocoderTest)
>>> Time
>>> elapsed: 0.359 sec  <<< ERROR!
>>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
>>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
>>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
>>> at
>>> org.wicketstuff.gmap.geocoder.Geocoder.centerAndFitZoomForAd
>>> ress(Geocoder.java:254)
>>> at
>>> wicket.contrib.gmap.util.GeocoderTest.testCenterAndFitZoomFo
>>> rAdress(GeocoderTest.java:61)
>>>
>>> testGeocoding(wicket.contrib.gmap.util.GeocoderTest)  Time elapsed:
>>> 0.074
>>> sec  <<< ERROR!
>>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
>>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
>>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
>>> at wicket.contrib.gmap.util.GeocoderTest.testGeocoding(Geocoder
>>> Test.java:41)
>>>
>>>
>>> Results :
>>>
>>> Tests in error:
>>>GeocoderTest.testCenterAndFitZoomForAdress:61 » Geocoder
>>> OVER_QUERY_LIMIT
>>>GeocoderTest.testGeocoding:41 » Geocoder OVER_QUERY_LIMIT
>>>
>>>
>>>
>>>
>>>
>>
>
>
> --
> WBR
> Maxim aka solomax
>



-- 
WBR
Maxim aka solomax


Re: Wicketstuff build

2018-02-17 Thread Maxim Solodovnik
Have added possibility to specify API key via command line:
https://github.com/wicketstuff/core/commit/e7d8ed7721a2dbcdb04082dac5c290c2d17d454b
Correct API key can be added in Travis config as well

On Sun, Feb 18, 2018 at 2:42 AM, Andrea Del Bene 
wrote:

> Locally you can temporary use the @ignore tag, but I'm afraid there's no
> way to bypass it on Travis. We can just wait long enough to re-run the
> building, hoping that some one else hasn't already reached the query limit
> in the meantime.
>
> PS: on 7.x branch I see test org.wicketstuff.security.SessionInvalidationTest
> is failing. I haven't investigated the problem yet but it could be
> something related to the changes to mock entities made with WICKET-6441.
>
>
> On 17/02/2018 17:16, Maxim Solodovnik wrote:
>
>> Hello All,
>>
>> I have started local build of wickestuff right now and got following
>> errors:
>> I believe there might be limitation on query per day/per application
>>
>> What is the correct way to bypass this limitation?
>>
>> Thanks in advance!
>>
>>
>> ---
>>   T E S T S
>> ---
>> Running wicket.contrib.gmap.util.GMapTest
>> log4j:WARN No appenders could be found for logger
>> (org.apache.wicket.Application).
>> log4j:WARN Please initialize the log4j system properly.
>> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
>> more info.
>> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.358 sec
>> -
>> in wicket.contrib.gmap.util.GMapTest
>> Running wicket.contrib.gmap.util.GeocoderTest
>> Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.433 sec
>> <<< FAILURE! - in wicket.contrib.gmap.util.GeocoderTest
>> testCenterAndFitZoomForAdress(wicket.contrib.gmap.util.GeocoderTest)
>> Time
>> elapsed: 0.359 sec  <<< ERROR!
>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
>> at
>> org.wicketstuff.gmap.geocoder.Geocoder.centerAndFitZoomForAd
>> ress(Geocoder.java:254)
>> at
>> wicket.contrib.gmap.util.GeocoderTest.testCenterAndFitZoomFo
>> rAdress(GeocoderTest.java:61)
>>
>> testGeocoding(wicket.contrib.gmap.util.GeocoderTest)  Time elapsed: 0.074
>> sec  <<< ERROR!
>> org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
>> at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
>> at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
>> at wicket.contrib.gmap.util.GeocoderTest.testGeocoding(Geocoder
>> Test.java:41)
>>
>>
>> Results :
>>
>> Tests in error:
>>GeocoderTest.testCenterAndFitZoomForAdress:61 » Geocoder
>> OVER_QUERY_LIMIT
>>GeocoderTest.testGeocoding:41 » Geocoder OVER_QUERY_LIMIT
>>
>>
>>
>>
>>
>


-- 
WBR
Maxim aka solomax


[GitHub] wicket issue #267: Fix to use locale of the session

2018-02-17 Thread try0
Github user try0 commented on the issue:

https://github.com/apache/wicket/pull/267
  
ï¼ martin-g
Thank you so much.
You’re welcome.


---


Re: [VOTE] Release Apache Wicket 6.29.0

2018-02-17 Thread Tobias Soloschenko
+1 :-)

kind regards

Tobias

> Am 17.02.2018 um 19:28 schrieb Andrea Del Bene :
> 
> This is a vote to release Apache Wicket 6.29.0
> 
> Please download the source distributions found in our staging area
> linked below.
> 
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
> 
> [ ] Yes, release Apache Wicket 6.29.0
> [ ] No, don't release Apache Wicket 6.29.0, because ...
> 
> Distributions, changelog, keys and signatures can be found at:
> 
> https://dist.apache.org/repos/dist/dev/wicket/6.29.0
> 
> Staging repository:
> 
> https://repository.apache.org/content/repositories/orgapachewicket-1107/
> 
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
> 
> Staging git repository data:
> 
> Repository:  g...@github.com:bitstorm/wicket.git
> Branch:  build/wicket-6.29.0
> Release tag: rel/wicket-6.29.0
> 
> 
> 
> 
> The signatures for the source release artefacts:
> 
> 
> Signature for apache-wicket-6.29.0.zip:
> 
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1
> 
> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhrh0QAKXGaVgypdlZgaK5b6M3Fxgu
> S5LW18OjhEQFQ4yYuz6CE3C/L54u6K4Es6SBhUgAVGuLwaRBdflOfcNA7DRm0Imh
> rHcssI6bt7DBxEjIu+XmXEqfgSmZ3P3VQQWGbPtbSMYBXSjhhYFdb8D286U0ec3T
> f/vD28ZZmdvRV7NuMKUe54cyMXFebmSfutwQWZqKs/Gx/HOZh4cU2lBbmLvPOuvy
> aT1nN7kLhrxROvzOgoyAOo5Dv7HlFrs7eJFQXr1Resz1FTMJrP6sNAQpY3QlcYUa
> rORqmxp8H4mXbSVkLk4Kquu6Q6tOcbijUZPZC4Vm5W+xPsBZrsYtJF8S76GZlbq1
> tBKlkmwweX/MirHnLwqHaMm43iz7dyf6FS5C9qi0j4GmMKGSh+Lv7Sk1wP3bvyc2
> 80loN03gJYCxrse7PcqO65STBjQ8fZlhpHt8yVxwdKJexPJd/aHJHmnoMsJ1FfHj
> LxNlHyya34XTpSZBE8Q+Qv47MOLsvGrkbD0876YwjMSQtDX9cUrRC95Hvtvxmqgm
> w9GlnnDY8q4Ts9ZZeJSDbanPY3zmAkVrpg+yqlY/pZsFCqh8Wv3L5DUNh+3cUBX+
> B7UyK+DJCXOld+81tESZWZhHAN6DXZWrWANrrtkeWO3qtdNLZTaOMAHaaoHPWJEK
> xo2Iapi8IzjYJr5jN7nq
> =ZuKl
> -END PGP SIGNATURE-
> 
> Signature for apache-wicket-6.29.0.tar.gz:
> 
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1
> 
> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhPY8P/j6Lwdz9Swa/mHs6EagLTq0s
> iArc8ZQzlt8GtnpVr6IIngDcFwvhvsWqCtSpPFmUt74xtZbA6oz6GBhEE0Dmsr9x
> 93Ov2aKYRU1pR/H5VkNWqdR67J6QT4amE81T+RzbfQbvcP7YFIIbPOTg4ox3Za61
> fu2NlkzB4u9qiPfqad6ylGoVu4mUde+klsnQiHL2dA3DmucChG08I9xjgzqQDIwo
> ph2gbieag9RjbgRQEKOYOQcBBS7B8VCNvFxslbchGJEQm6B2QVuQV3+nvyWbjQ0J
> u0tpbZA0Wev59dzpLRJDSFcccgBCCII+MP9RZPRuQSUDAyIg/PJ1LFtm/85hxV7C
> VqDTMuniLYZT8shTWw4VKQfVGmjso/eRQsNAG7BeMZqxBWQpQQ+6BMoy2piXAavp
> RZxO17Ct0V9dPVp7cTTHiet/Iz1oPwkceF5KmaQl1vLhicBbvLF6993ny7iP0Lyo
> t+Jh1v4TFf7Daxxgl6q1tO2zDZc94877FXwjZ7b/n37SoRENzTPj+sNhpS3jCZ+E
> QxXp/dYU0L6+mVLhJ4XPWAsTljdvnXwHf7S1RBSeEsGb9BM97l6Yh2WpWTgvLiwy
> lvdWNkWX1pd6fD1V/XT83FtlQDURPkGN6Bbbfmwh8pSPbzQMn2Q5EXlFTLcTsVhW
> QV/yE6KsG5K8AqjY9DdD
> =oA/r
> -END PGP SIGNATURE-
> 
> 
> 
> CHANGELOG for 6.29.0:
> 
> ** Bug
> 
> * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> * [WICKET-6501] - DefaultPageManagerProvider does not honour 
> StoreSettings.setAsynchronous(false)
> * [WICKET-6526] - Ajax Buttons do not check for the HTTP method and thus 
> don't respect Form#onMethodMismatch
> * [WICKET-6530] - Race-condition in session invalidation
> 


Re: Wicketstuff build

2018-02-17 Thread Andrea Del Bene
Locally you can temporary use the @ignore tag, but I'm afraid there's no 
way to bypass it on Travis. We can just wait long enough to re-run the 
building, hoping that some one else hasn't already reached the query 
limit in the meantime.


PS: on 7.x branch I see test 
org.wicketstuff.security.SessionInvalidationTest is failing. I haven't 
investigated the problem yet but it could be something related to the 
changes to mock entities made with WICKET-6441.


On 17/02/2018 17:16, Maxim Solodovnik wrote:

Hello All,

I have started local build of wickestuff right now and got following
errors:
I believe there might be limitation on query per day/per application

What is the correct way to bypass this limitation?

Thanks in advance!


---
  T E S T S
---
Running wicket.contrib.gmap.util.GMapTest
log4j:WARN No appenders could be found for logger
(org.apache.wicket.Application).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
more info.
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.358 sec -
in wicket.contrib.gmap.util.GMapTest
Running wicket.contrib.gmap.util.GeocoderTest
Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.433 sec
<<< FAILURE! - in wicket.contrib.gmap.util.GeocoderTest
testCenterAndFitZoomForAdress(wicket.contrib.gmap.util.GeocoderTest)  Time
elapsed: 0.359 sec  <<< ERROR!
org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
at
org.wicketstuff.gmap.geocoder.Geocoder.centerAndFitZoomForAdress(Geocoder.java:254)
at
wicket.contrib.gmap.util.GeocoderTest.testCenterAndFitZoomForAdress(GeocoderTest.java:61)

testGeocoding(wicket.contrib.gmap.util.GeocoderTest)  Time elapsed: 0.074
sec  <<< ERROR!
org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
at wicket.contrib.gmap.util.GeocoderTest.testGeocoding(GeocoderTest.java:41)


Results :

Tests in error:
   GeocoderTest.testCenterAndFitZoomForAdress:61 » Geocoder OVER_QUERY_LIMIT
   GeocoderTest.testGeocoding:41 » Geocoder OVER_QUERY_LIMIT








[VOTE] Release Apache Wicket 6.29.0

2018-02-17 Thread Andrea Del Bene

This is a vote to release Apache Wicket 6.29.0

Please download the source distributions found in our staging area
linked below.

I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.

[ ] Yes, release Apache Wicket 6.29.0
[ ] No, don't release Apache Wicket 6.29.0, because ...

Distributions, changelog, keys and signatures can be found at:

    https://dist.apache.org/repos/dist/dev/wicket/6.29.0

Staging repository:

https://repository.apache.org/content/repositories/orgapachewicket-1107/

The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.

Staging git repository data:

    Repository:  g...@github.com:bitstorm/wicket.git
    Branch:  build/wicket-6.29.0
    Release tag: rel/wicket-6.29.0




    The signatures for the source release artefacts:


Signature for apache-wicket-6.29.0.zip:

    -BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhrh0QAKXGaVgypdlZgaK5b6M3Fxgu
S5LW18OjhEQFQ4yYuz6CE3C/L54u6K4Es6SBhUgAVGuLwaRBdflOfcNA7DRm0Imh
rHcssI6bt7DBxEjIu+XmXEqfgSmZ3P3VQQWGbPtbSMYBXSjhhYFdb8D286U0ec3T
f/vD28ZZmdvRV7NuMKUe54cyMXFebmSfutwQWZqKs/Gx/HOZh4cU2lBbmLvPOuvy
aT1nN7kLhrxROvzOgoyAOo5Dv7HlFrs7eJFQXr1Resz1FTMJrP6sNAQpY3QlcYUa
rORqmxp8H4mXbSVkLk4Kquu6Q6tOcbijUZPZC4Vm5W+xPsBZrsYtJF8S76GZlbq1
tBKlkmwweX/MirHnLwqHaMm43iz7dyf6FS5C9qi0j4GmMKGSh+Lv7Sk1wP3bvyc2
80loN03gJYCxrse7PcqO65STBjQ8fZlhpHt8yVxwdKJexPJd/aHJHmnoMsJ1FfHj
LxNlHyya34XTpSZBE8Q+Qv47MOLsvGrkbD0876YwjMSQtDX9cUrRC95Hvtvxmqgm
w9GlnnDY8q4Ts9ZZeJSDbanPY3zmAkVrpg+yqlY/pZsFCqh8Wv3L5DUNh+3cUBX+
B7UyK+DJCXOld+81tESZWZhHAN6DXZWrWANrrtkeWO3qtdNLZTaOMAHaaoHPWJEK
xo2Iapi8IzjYJr5jN7nq
=ZuKl
-END PGP SIGNATURE-

Signature for apache-wicket-6.29.0.tar.gz:

    -BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhPY8P/j6Lwdz9Swa/mHs6EagLTq0s
iArc8ZQzlt8GtnpVr6IIngDcFwvhvsWqCtSpPFmUt74xtZbA6oz6GBhEE0Dmsr9x
93Ov2aKYRU1pR/H5VkNWqdR67J6QT4amE81T+RzbfQbvcP7YFIIbPOTg4ox3Za61
fu2NlkzB4u9qiPfqad6ylGoVu4mUde+klsnQiHL2dA3DmucChG08I9xjgzqQDIwo
ph2gbieag9RjbgRQEKOYOQcBBS7B8VCNvFxslbchGJEQm6B2QVuQV3+nvyWbjQ0J
u0tpbZA0Wev59dzpLRJDSFcccgBCCII+MP9RZPRuQSUDAyIg/PJ1LFtm/85hxV7C
VqDTMuniLYZT8shTWw4VKQfVGmjso/eRQsNAG7BeMZqxBWQpQQ+6BMoy2piXAavp
RZxO17Ct0V9dPVp7cTTHiet/Iz1oPwkceF5KmaQl1vLhicBbvLF6993ny7iP0Lyo
t+Jh1v4TFf7Daxxgl6q1tO2zDZc94877FXwjZ7b/n37SoRENzTPj+sNhpS3jCZ+E
QxXp/dYU0L6+mVLhJ4XPWAsTljdvnXwHf7S1RBSeEsGb9BM97l6Yh2WpWTgvLiwy
lvdWNkWX1pd6fD1V/XT83FtlQDURPkGN6Bbbfmwh8pSPbzQMn2Q5EXlFTLcTsVhW
QV/yE6KsG5K8AqjY9DdD
=oA/r
-END PGP SIGNATURE-



    CHANGELOG for 6.29.0:

** Bug

    * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
    * [WICKET-6501] - DefaultPageManagerProvider does not honour 
StoreSettings.setAsynchronous(false)
    * [WICKET-6526] - Ajax Buttons do not check for the HTTP method and 
thus don't respect Form#onMethodMismatch

    * [WICKET-6530] - Race-condition in session invalidation



Wicketstuff build

2018-02-17 Thread Maxim Solodovnik
Hello All,

I have started local build of wickestuff right now and got following
errors:
I believe there might be limitation on query per day/per application

What is the correct way to bypass this limitation?

Thanks in advance!


---
 T E S T S
---
Running wicket.contrib.gmap.util.GMapTest
log4j:WARN No appenders could be found for logger
(org.apache.wicket.Application).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
more info.
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.358 sec -
in wicket.contrib.gmap.util.GMapTest
Running wicket.contrib.gmap.util.GeocoderTest
Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.433 sec
<<< FAILURE! - in wicket.contrib.gmap.util.GeocoderTest
testCenterAndFitZoomForAdress(wicket.contrib.gmap.util.GeocoderTest)  Time
elapsed: 0.359 sec  <<< ERROR!
org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
at
org.wicketstuff.gmap.geocoder.Geocoder.centerAndFitZoomForAdress(Geocoder.java:254)
at
wicket.contrib.gmap.util.GeocoderTest.testCenterAndFitZoomForAdress(GeocoderTest.java:61)

testGeocoding(wicket.contrib.gmap.util.GeocoderTest)  Time elapsed: 0.074
sec  <<< ERROR!
org.wicketstuff.gmap.geocoder.GeocoderException: OVER_QUERY_LIMIT
at org.wicketstuff.gmap.geocoder.Geocoder.decode(Geocoder.java:130)
at org.wicketstuff.gmap.geocoder.Geocoder.geocode(Geocoder.java:182)
at wicket.contrib.gmap.util.GeocoderTest.testGeocoding(GeocoderTest.java:41)


Results :

Tests in error:
  GeocoderTest.testCenterAndFitZoomForAdress:61 » Geocoder OVER_QUERY_LIMIT
  GeocoderTest.testGeocoding:41 » Geocoder OVER_QUERY_LIMIT




-- 
WBR
Maxim aka solomax


[GitHub] wicket issue #267: Fix to use locale of the session

2018-02-17 Thread martin-g
Github user martin-g commented on the issue:

https://github.com/apache/wicket/pull/267
  
Thank you, @try0 !


---


[ANNOUNCE] Apache Wicket 8.0.0-M9 released

2018-02-17 Thread Andrea Del Bene

The Apache Wicket PMC is proud to announce Apache Wicket 8.0.0-M9!

Apache Wicket is an open source Java component oriented web application
framework that powers thousands of web applications and web sites for
governments, stores, universities, cities, banks, email providers, and
more. You can find more about Apache Wicket at https://wicket.apache.org

This release marks another minor release of Wicket 8. We
use semantic versioning for the development of Wicket, and as such no
API breaks are present breaks are present in this release compared to
8.0.0.

New and noteworthy
--

Before WICKET-6498 (https://issues.apache.org/jira/browse/WICKET-6498) users 
used to create a custom implementation of IHeaderResponseDecorator to place 
JavaScript items inside page body:

@Override
public void init()
{
   setHeaderResponseDecorator(new 
JavaScriptToBodyCustomResponseDecorator("footer-container"));
}


See user guide 
(https://ci.apache.org/projects/wicket/guide/7.x/single.html#_put_javascript_inside_page_body)
 for more details. Now each application has a default IHeaderResponseDecorator, 
which decorates header responses with a ResourceAggregator. Applications have 
to make sure, that each response is now explicitly decorated with a 
ResourceAggregator too:


@Override
public void init()
{
   setHeaderResponseDecorator(response ->
   {
return new ResourceAggregator(new 
JavaScriptFilteredIntoFooterHeaderResponse(response, "footer-container"));
   });
}


Caveats
--
WICKET-6498 might not work as expected due to a known issue with all major 
browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be 
executed before DOMContentLoaded is fired. For this reason WICKET-6498 should be 
avoided for production applications and used carefully.

Using this release
--

With Apache Maven update your dependency to (and don't forget to
update any other dependencies on Wicket projects to the same version):


org.apache.wicket
wicket-core
8.0.0-M9


Or download and build the distribution yourself, or use our
convenience binary package

 * Source: http://www.apache.org/dyn/closer.cgi/wicket/8.0.0-M9
 * Binary: http://www.apache.org/dyn/closer.cgi/wicket/8.0.0-M9/binaries

Upgrading from earlier versions
---

If you upgrade from 8.y.z this release is a drop in replacement. If
you come from a version prior to 8.0.0, please read our Wicket 8
migration guide found at

 * http://s.apache.org/wicket8migrate

Have fun!

— The Wicket team




The signatures for the source release artefacts:


Signature for apache-wicket-8.0.0-M9.zip:


-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
jIvOQJKU+bwlubLLneTg
=MOtP
-END PGP SIGNATURE-

Signature for apache-wicket-8.0.0-M9.tar.gz:


-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
CCJOHO3iofZ0wlGnB5J7
=/qPh
-END PGP SIGNATURE-




CHANGELOG for 8.0.0-M9:

** Bug


* [WICKET-6332] - NullPointerException in PageParameters#equals()
* [WICKET-6441] - MockHttpSession and MockSessionStore don't call 
onInvalidate() on invalidate()
* [WICKET-6448] - Provide behavior that disables a button after click
* [WICKET-6477] - Component.getDefaultModelObject() wraps in 
RuntimeException instead of WicketRuntimeException
* [WICKET-6484] - 

[GitHub] wicket pull request #267: Fix to use locale of the session

2018-02-17 Thread try0
Github user try0 closed the pull request at:

https://github.com/apache/wicket/pull/267


---


[GitHub] wicket issue #267: Fix to use locale of the session

2018-02-17 Thread try0
Github user try0 commented on the issue:

https://github.com/apache/wicket/pull/267
  
Hi klopfdreh

Thank you for integrating.
Okay, I see. 

I'm happy to have been able to contribute to Wicket.


---


Re: [VOTE] Release Apache Wicket 8.0.0-M9

2018-02-17 Thread Andrea Del Bene

This vote passes. Thank you all!


On 16/02/2018 14:45, Andrea Del Bene wrote:

Thank you Sven. I confirm my positive vote.

On Fri, Feb 16, 2018 at 2:25 PM, Sven Meier > wrote:


Hi all,

there's no need to make a fuss about this feature.

When Korbinian and I started working on deferred JavaScript, I was
under the impression:

a) that the JavaScript part is sorted out already
b) every framework supports it (to be kind of cool)
b) we have to rework major parts to bake this into Wicket

Now I understand that

x) deferred loading of JavaSript is fucked up in browsers
y) other frameworks are struggling with this too
z) only a tiny change was required in Wicket to allow people to
experiment with deferred JavaScript

We *need* a note in the release notes for z), as the handling of
IHeaderResponseDecorator has slightly. I don't consider this a big
deal, because users will have to change a *single* place only *if*
they use JavaScriptFilteredIntoFooterHeaderResponse at all.
Compare that with introducing Optional for the return of
RequestTarget#find(): that might *silently* break applications and
requires to rework possibly *hundreds* of code places.

Furthermore WICKET- 6498 added a single class
JavaScriptDeferHeaderResponse only - yes, it's experimental but
with no API surface to break in the future. Nobody has to use it
so I don't see the need to praise/warn about it in the release notes.
I don't consider it broken, browsers are broken. However I have no
problem to remove that class: we can just put it into confluence
or wicketstuff.

Once again: It is a *single* class with *no* API - that's nothing
compared to component queueing :P

Have fun
Sven




Am 16.02.2018 um 13:32 schrieb Andrea Del Bene:

On Feb 16, 2018 10:50 AM, "Martin Grigorov"
> wrote:

On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene
>
wrote:

That's what I'd write in the release note:

Caveats
--
WICKET-6498 might not work as expected due to a known
issues with all

major

browsers (Chrome, Firefox, IE > 10) which allows deferred
scripts to be
executed before DOMContentLoaded is fired. For this reason
WICKET-6498
should be avoided for production applications and used
carefully.

WDYT?

Why do we ship it if it is known to be broken ?
AFAIR we don't have such precedent before.


Have you forgotten about components queueing :-D :-D?



On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
korbinian.ba...@whiskyworld.de
> wrote:

in short: since IE 11 and chrome as well as FF the
browsers dont fire

the

DOMContentLoaded of scripts the way one would expect.
This happens as

the

browsers branch multiple threads that each thread put
together execution
groups of orders leading to inline-JS getting executed
and events on

these

fired without the knowledge of other JS resources as
long as these are
defered and / or / asnyc'd

Even worse, an app that may work well in local mode
may break in
production as network timing as well as client CPU
count (influences
thread) and speed of CPU and or GPU (yep... ) may
change the timings the
event DOMContentLoaded  gets fired;

even JQuery guys are plagued by this and have no real
solution to it now
IMHO https://github.com/jquery/jquery/issues/3271


I think we can get a real working one for wicket but
had no time yet to
try it out; Idea is to create the wicket object in the
head at first

inline

script before any JS resources (defered or not) so
that the page itself
cant break because of this


- Ursprüngliche Mail -

Von: "Andrea Del Bene" >
An: dev@wicket.apache.org

Gesendet: Donnerstag, 15. Februar 2018 16:48:18
Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9

[GitHub] wicket issue #267: Fix to use locale of the session

2018-02-17 Thread klopfdreh
Github user klopfdreh commented on the issue:

https://github.com/apache/wicket/pull/267
  
Hi @try0 
The fix is integrated, now:

master - 
https://github.com/apache/wicket/commit/6c91b495738c597a9c89f624d6f675cd6eb1f609
wicket-7.x - 
https://github.com/apache/wicket/commit/7ba197c68508f2e15abf5e4bdda046cd4fa14087

Would you be so kind and close this PR?

kind regards and thanks.


---


Re: pullrequest sent

2018-02-17 Thread Tobias Soloschenko
Hi,

I am going to integrate it, now.

kind regards

Tobias

> Am 17.02.2018 um 10:29 schrieb Ryo Tnd :
> 
> Dear Wicket developers,
> 
> My name is Ryo Tsunoda. I'm from Japan.
> I sent a PullRequest 5 days ago.
> https://github.com/apache/wicket/pull/267
> 
> I thought I sent you a message, but I didn't.
> Already Mr. martin-g has reviewed my PR.
> 
> 
> Sorry if my English is wrong.
> 
> Sincerely,
> Ryo Tsunoda


pullrequest sent

2018-02-17 Thread Ryo Tnd
Dear Wicket developers,

My name is Ryo Tsunoda. I'm from Japan.
I sent a PullRequest 5 days ago.
https://github.com/apache/wicket/pull/267

I thought I sent you a message, but I didn't.
Already Mr. martin-g has reviewed my PR.


Sorry if my English is wrong.

Sincerely,
Ryo Tsunoda