Re: [VOTE] Release Apache Wicket 6.29.0

2018-02-19 Thread Sebastien Briquet 
 [x] Yes, release Apache Wicket 6.29.0

Tested against Wicket jQuery UI (with java8 compiler)

DataTable toolbars

2018-02-19 Thread Vit Rozkovec 

Hi,

I've come across one inconsistency in the DataTable class:

    /**
     * @return the container with the toolbars at the top
     */
    public final ToolbarsContainer getTopToolbars()
    {
        return topToolbars;
    }

    /**
     * @return the container with the toolbars at the bottom
     */
    public final ToolbarsContainer getBottomToolbars()
    {
        return bottomToolbars;
    }



ToolbarsContainer is defined as private, so those methods cannot be used 
anyway. I suggest either changing the visibility of ToolbarsContainer or 
removing those methods.


At the moment if I need to refresh toolbars, I have to go via datatable 
component's get() method to remove all toolbar items and re-add them again.


Wicket 8x

Cheers
Vit

Re: [VOTE] Release Apache Wicket 6.29.0

2018-02-19 Thread Andrea Del Bene 
I think java 6 is simply to old for some Maven plugin we use for building.
I use to perform building process with Java 8 as default JDK and using
toolchains to locate a valid Java 6 when required. For the record I use the
OpenJDK 6 provided by Azul (https://www.azul.com/downloads/zulu/zulu-linux/)

On Mon, Feb 19, 2018 at 1:33 PM, Maxim Solodovnik 
wrote:

> I have Oracle jdk6 installed on my machine (/opt folder)
> As well as maven 3.2.5
> before build I did
>
> export JAVA_HOME=/opt/jdk1.6.0_45
> export M2_HOME=/opt/apache-maven-3.2.5
> export PATH=$JAVA_HOME/bin:$M2_HOME/bin:$PATH
>
> mvn -version
> Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
> 2014-12-15T00:29:23+07:00)
> Maven home: /opt/apache-maven-3.2.5
> Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
> Java home: /opt/jdk1.6.0_45/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.13.0-32-generic", arch: "amd64", family:
> "unix"
>
> mvn clean install
>
> Caused by: java.lang.UnsupportedClassVersionError:
> org/codehaus/mojo/clirr/ClirrCheckMojo : Unsupported major.minor
> version 51.0
>
>
>
> On Mon, Feb 19, 2018 at 5:20 PM, Andrea Del Bene 
> wrote:
> > On Sun, Feb 18, 2018 at 2:19 PM, Maxim Solodovnik 
> > wrote:
> >
> >> It seems I can't compile :(
> >> I have jdk6 and maven 3.2.5, but build fails with
> >> "org/codehaus/mojo/clirr/ClirrCheckMojo : Unsupported major.minor
> >> version 51.0"
> >> sorry can't vote :(
> >>
> >
> > Hi. Are you using a machine/container with java 6 as default JDK or are
> you
> > using maven toolchain with a higher version of Java?
> >
> >
> >>
> >> On Sun, Feb 18, 2018 at 5:31 PM, Sven Meier  wrote:
> >> > +1
> >> >
> >> > Many thanks
> >> > Sven
> >> >
> >> >
> >> >
> >> > Am 17.02.2018 um 23:47 schrieb Tobias Soloschenko:
> >> >>
> >> >> +1 :-)
> >> >>
> >> >> kind regards
> >> >>
> >> >> Tobias
> >> >>
> >> >>> Am 17.02.2018 um 19:28 schrieb Andrea Del Bene <
> an.delb...@gmail.com>:
> >> >>>
> >> >>> This is a vote to release Apache Wicket 6.29.0
> >> >>>
> >> >>> Please download the source distributions found in our staging area
> >> >>> linked below.
> >> >>>
> >> >>> I have included the signatures for both the source archives. This
> vote
> >> >>> lasts for 72 hours minimum.
> >> >>>
> >> >>> [ ] Yes, release Apache Wicket 6.29.0
> >> >>> [ ] No, don't release Apache Wicket 6.29.0, because ...
> >> >>>
> >> >>> Distributions, changelog, keys and signatures can be found at:
> >> >>>
> >> >>>  https://dist.apache.org/repos/dist/dev/wicket/6.29.0
> >> >>>
> >> >>> Staging repository:
> >> >>>
> >> >>> https://repository.apache.org/content/repositories/
> >> orgapachewicket-1107/
> >> >>>
> >> >>> The binaries are available in the above link, as are a staging
> >> >>> repository for Maven. Typically the vote is on the source, but
> should
> >> >>> you find a problem with one of the binaries, please let me know, I
> can
> >> >>> re-roll them some way or the other.
> >> >>>
> >> >>> Staging git repository data:
> >> >>>
> >> >>>  Repository:  g...@github.com:bitstorm/wicket.git
> >> >>>  Branch:  build/wicket-6.29.0
> >> >>>  Release tag: rel/wicket-6.29.0
> >> >>>
> >> >>>
> >> >>> 
> >> 
> >> >>>
> >> >>>  The signatures for the source release artefacts:
> >> >>>
> >> >>>
> >> >>> Signature for apache-wicket-6.29.0.zip:
> >> >>>
> >> >>>  -BEGIN PGP SIGNATURE-
> >> >>> Version: GnuPG v1
> >> >>>
> >> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhrh0QAKXGaVgypdlZgaK5b6M3Fxgu
> >> >>> S5LW18OjhEQFQ4yYuz6CE3C/L54u6K4Es6SBhUgAVGuLwaRBdflOfcNA7DRm0Imh
> >> >>> rHcssI6bt7DBxEjIu+XmXEqfgSmZ3P3VQQWGbPtbSMYBXSjhhYFdb8D286U0ec3T
> >> >>> f/vD28ZZmdvRV7NuMKUe54cyMXFebmSfutwQWZqKs/Gx/HOZh4cU2lBbmLvPOuvy
> >> >>> aT1nN7kLhrxROvzOgoyAOo5Dv7HlFrs7eJFQXr1Resz1FTMJrP6sNAQpY3QlcYUa
> >> >>> rORqmxp8H4mXbSVkLk4Kquu6Q6tOcbijUZPZC4Vm5W+xPsBZrsYtJF8S76GZlbq1
> >> >>> tBKlkmwweX/MirHnLwqHaMm43iz7dyf6FS5C9qi0j4GmMKGSh+Lv7Sk1wP3bvyc2
> >> >>> 80loN03gJYCxrse7PcqO65STBjQ8fZlhpHt8yVxwdKJexPJd/aHJHmnoMsJ1FfHj
> >> >>> LxNlHyya34XTpSZBE8Q+Qv47MOLsvGrkbD0876YwjMSQtDX9cUrRC95Hvtvxmqgm
> >> >>> w9GlnnDY8q4Ts9ZZeJSDbanPY3zmAkVrpg+yqlY/pZsFCqh8Wv3L5DUNh+3cUBX+
> >> >>> B7UyK+DJCXOld+81tESZWZhHAN6DXZWrWANrrtkeWO3qtdNLZTaOMAHaaoHPWJEK
> >> >>> xo2Iapi8IzjYJr5jN7nq
> >> >>> =ZuKl
> >> >>> -END PGP SIGNATURE-
> >> >>>
> >> >>> Signature for apache-wicket-6.29.0.tar.gz:
> >> >>>
> >> >>>  -BEGIN PGP SIGNATURE-
> >> >>> Version: GnuPG v1
> >> >>>
> >> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhPY8P/j6Lwdz9Swa/mHs6EagLTq0s
> >> >>> iArc8ZQzlt8GtnpVr6IIngDcFwvhvsWqCtSpPFmUt74xtZbA6oz6GBhEE0Dmsr9x
> >> >>> 93Ov2aKYRU1pR/H5VkNWqdR67J6QT4amE81T+RzbfQbvcP7YFIIbPOTg4ox3Za61
> >> >>> fu2NlkzB4u9qiPfqad6ylGoVu4mUde+klsnQiHL2dA3DmucChG08I9xjgzqQDIwo
> >> >>>

Re: [VOTE] Release Apache Wicket 6.29.0

2018-02-19 Thread Maxim Solodovnik 
I have Oracle jdk6 installed on my machine (/opt folder)
As well as maven 3.2.5
before build I did

export JAVA_HOME=/opt/jdk1.6.0_45
export M2_HOME=/opt/apache-maven-3.2.5
export PATH=$JAVA_HOME/bin:$M2_HOME/bin:$PATH

mvn -version
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-15T00:29:23+07:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /opt/jdk1.6.0_45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.13.0-32-generic", arch: "amd64", family: "unix"

mvn clean install

Caused by: java.lang.UnsupportedClassVersionError:
org/codehaus/mojo/clirr/ClirrCheckMojo : Unsupported major.minor
version 51.0



On Mon, Feb 19, 2018 at 5:20 PM, Andrea Del Bene  wrote:
> On Sun, Feb 18, 2018 at 2:19 PM, Maxim Solodovnik 
> wrote:
>
>> It seems I can't compile :(
>> I have jdk6 and maven 3.2.5, but build fails with
>> "org/codehaus/mojo/clirr/ClirrCheckMojo : Unsupported major.minor
>> version 51.0"
>> sorry can't vote :(
>>
>
> Hi. Are you using a machine/container with java 6 as default JDK or are you
> using maven toolchain with a higher version of Java?
>
>
>>
>> On Sun, Feb 18, 2018 at 5:31 PM, Sven Meier  wrote:
>> > +1
>> >
>> > Many thanks
>> > Sven
>> >
>> >
>> >
>> > Am 17.02.2018 um 23:47 schrieb Tobias Soloschenko:
>> >>
>> >> +1 :-)
>> >>
>> >> kind regards
>> >>
>> >> Tobias
>> >>
>> >>> Am 17.02.2018 um 19:28 schrieb Andrea Del Bene :
>> >>>
>> >>> This is a vote to release Apache Wicket 6.29.0
>> >>>
>> >>> Please download the source distributions found in our staging area
>> >>> linked below.
>> >>>
>> >>> I have included the signatures for both the source archives. This vote
>> >>> lasts for 72 hours minimum.
>> >>>
>> >>> [ ] Yes, release Apache Wicket 6.29.0
>> >>> [ ] No, don't release Apache Wicket 6.29.0, because ...
>> >>>
>> >>> Distributions, changelog, keys and signatures can be found at:
>> >>>
>> >>>  https://dist.apache.org/repos/dist/dev/wicket/6.29.0
>> >>>
>> >>> Staging repository:
>> >>>
>> >>> https://repository.apache.org/content/repositories/
>> orgapachewicket-1107/
>> >>>
>> >>> The binaries are available in the above link, as are a staging
>> >>> repository for Maven. Typically the vote is on the source, but should
>> >>> you find a problem with one of the binaries, please let me know, I can
>> >>> re-roll them some way or the other.
>> >>>
>> >>> Staging git repository data:
>> >>>
>> >>>  Repository:  g...@github.com:bitstorm/wicket.git
>> >>>  Branch:  build/wicket-6.29.0
>> >>>  Release tag: rel/wicket-6.29.0
>> >>>
>> >>>
>> >>> 
>> 
>> >>>
>> >>>  The signatures for the source release artefacts:
>> >>>
>> >>>
>> >>> Signature for apache-wicket-6.29.0.zip:
>> >>>
>> >>>  -BEGIN PGP SIGNATURE-
>> >>> Version: GnuPG v1
>> >>>
>> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhrh0QAKXGaVgypdlZgaK5b6M3Fxgu
>> >>> S5LW18OjhEQFQ4yYuz6CE3C/L54u6K4Es6SBhUgAVGuLwaRBdflOfcNA7DRm0Imh
>> >>> rHcssI6bt7DBxEjIu+XmXEqfgSmZ3P3VQQWGbPtbSMYBXSjhhYFdb8D286U0ec3T
>> >>> f/vD28ZZmdvRV7NuMKUe54cyMXFebmSfutwQWZqKs/Gx/HOZh4cU2lBbmLvPOuvy
>> >>> aT1nN7kLhrxROvzOgoyAOo5Dv7HlFrs7eJFQXr1Resz1FTMJrP6sNAQpY3QlcYUa
>> >>> rORqmxp8H4mXbSVkLk4Kquu6Q6tOcbijUZPZC4Vm5W+xPsBZrsYtJF8S76GZlbq1
>> >>> tBKlkmwweX/MirHnLwqHaMm43iz7dyf6FS5C9qi0j4GmMKGSh+Lv7Sk1wP3bvyc2
>> >>> 80loN03gJYCxrse7PcqO65STBjQ8fZlhpHt8yVxwdKJexPJd/aHJHmnoMsJ1FfHj
>> >>> LxNlHyya34XTpSZBE8Q+Qv47MOLsvGrkbD0876YwjMSQtDX9cUrRC95Hvtvxmqgm
>> >>> w9GlnnDY8q4Ts9ZZeJSDbanPY3zmAkVrpg+yqlY/pZsFCqh8Wv3L5DUNh+3cUBX+
>> >>> B7UyK+DJCXOld+81tESZWZhHAN6DXZWrWANrrtkeWO3qtdNLZTaOMAHaaoHPWJEK
>> >>> xo2Iapi8IzjYJr5jN7nq
>> >>> =ZuKl
>> >>> -END PGP SIGNATURE-
>> >>>
>> >>> Signature for apache-wicket-6.29.0.tar.gz:
>> >>>
>> >>>  -BEGIN PGP SIGNATURE-
>> >>> Version: GnuPG v1
>> >>>
>> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhPY8P/j6Lwdz9Swa/mHs6EagLTq0s
>> >>> iArc8ZQzlt8GtnpVr6IIngDcFwvhvsWqCtSpPFmUt74xtZbA6oz6GBhEE0Dmsr9x
>> >>> 93Ov2aKYRU1pR/H5VkNWqdR67J6QT4amE81T+RzbfQbvcP7YFIIbPOTg4ox3Za61
>> >>> fu2NlkzB4u9qiPfqad6ylGoVu4mUde+klsnQiHL2dA3DmucChG08I9xjgzqQDIwo
>> >>> ph2gbieag9RjbgRQEKOYOQcBBS7B8VCNvFxslbchGJEQm6B2QVuQV3+nvyWbjQ0J
>> >>> u0tpbZA0Wev59dzpLRJDSFcccgBCCII+MP9RZPRuQSUDAyIg/PJ1LFtm/85hxV7C
>> >>> VqDTMuniLYZT8shTWw4VKQfVGmjso/eRQsNAG7BeMZqxBWQpQQ+6BMoy2piXAavp
>> >>> RZxO17Ct0V9dPVp7cTTHiet/Iz1oPwkceF5KmaQl1vLhicBbvLF6993ny7iP0Lyo
>> >>> t+Jh1v4TFf7Daxxgl6q1tO2zDZc94877FXwjZ7b/n37SoRENzTPj+sNhpS3jCZ+E
>> >>> QxXp/dYU0L6+mVLhJ4XPWAsTljdvnXwHf7S1RBSeEsGb9BM97l6Yh2WpWTgvLiwy
>> >>> lvdWNkWX1pd6fD1V/XT83FtlQDURPkGN6Bbbfmwh8pSPbzQMn2Q5EXlFTLcTsVhW
>> >>> QV/yE6KsG5K8AqjY9DdD
>> >>> =oA/r
>> >>> -END PGP SIGNATURE-
>> >>>
>> >>> 
>> 
>> >>>
>> >>>

Re: [VOTE] Release Apache Wicket 6.29.0

2018-02-19 Thread Andrea Del Bene 
On Sun, Feb 18, 2018 at 2:19 PM, Maxim Solodovnik 
wrote:

> It seems I can't compile :(
> I have jdk6 and maven 3.2.5, but build fails with
> "org/codehaus/mojo/clirr/ClirrCheckMojo : Unsupported major.minor
> version 51.0"
> sorry can't vote :(
>

Hi. Are you using a machine/container with java 6 as default JDK or are you
using maven toolchain with a higher version of Java?


>
> On Sun, Feb 18, 2018 at 5:31 PM, Sven Meier  wrote:
> > +1
> >
> > Many thanks
> > Sven
> >
> >
> >
> > Am 17.02.2018 um 23:47 schrieb Tobias Soloschenko:
> >>
> >> +1 :-)
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >>> Am 17.02.2018 um 19:28 schrieb Andrea Del Bene :
> >>>
> >>> This is a vote to release Apache Wicket 6.29.0
> >>>
> >>> Please download the source distributions found in our staging area
> >>> linked below.
> >>>
> >>> I have included the signatures for both the source archives. This vote
> >>> lasts for 72 hours minimum.
> >>>
> >>> [ ] Yes, release Apache Wicket 6.29.0
> >>> [ ] No, don't release Apache Wicket 6.29.0, because ...
> >>>
> >>> Distributions, changelog, keys and signatures can be found at:
> >>>
> >>>  https://dist.apache.org/repos/dist/dev/wicket/6.29.0
> >>>
> >>> Staging repository:
> >>>
> >>> https://repository.apache.org/content/repositories/
> orgapachewicket-1107/
> >>>
> >>> The binaries are available in the above link, as are a staging
> >>> repository for Maven. Typically the vote is on the source, but should
> >>> you find a problem with one of the binaries, please let me know, I can
> >>> re-roll them some way or the other.
> >>>
> >>> Staging git repository data:
> >>>
> >>>  Repository:  g...@github.com:bitstorm/wicket.git
> >>>  Branch:  build/wicket-6.29.0
> >>>  Release tag: rel/wicket-6.29.0
> >>>
> >>>
> >>> 
> 
> >>>
> >>>  The signatures for the source release artefacts:
> >>>
> >>>
> >>> Signature for apache-wicket-6.29.0.zip:
> >>>
> >>>  -BEGIN PGP SIGNATURE-
> >>> Version: GnuPG v1
> >>>
> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhrh0QAKXGaVgypdlZgaK5b6M3Fxgu
> >>> S5LW18OjhEQFQ4yYuz6CE3C/L54u6K4Es6SBhUgAVGuLwaRBdflOfcNA7DRm0Imh
> >>> rHcssI6bt7DBxEjIu+XmXEqfgSmZ3P3VQQWGbPtbSMYBXSjhhYFdb8D286U0ec3T
> >>> f/vD28ZZmdvRV7NuMKUe54cyMXFebmSfutwQWZqKs/Gx/HOZh4cU2lBbmLvPOuvy
> >>> aT1nN7kLhrxROvzOgoyAOo5Dv7HlFrs7eJFQXr1Resz1FTMJrP6sNAQpY3QlcYUa
> >>> rORqmxp8H4mXbSVkLk4Kquu6Q6tOcbijUZPZC4Vm5W+xPsBZrsYtJF8S76GZlbq1
> >>> tBKlkmwweX/MirHnLwqHaMm43iz7dyf6FS5C9qi0j4GmMKGSh+Lv7Sk1wP3bvyc2
> >>> 80loN03gJYCxrse7PcqO65STBjQ8fZlhpHt8yVxwdKJexPJd/aHJHmnoMsJ1FfHj
> >>> LxNlHyya34XTpSZBE8Q+Qv47MOLsvGrkbD0876YwjMSQtDX9cUrRC95Hvtvxmqgm
> >>> w9GlnnDY8q4Ts9ZZeJSDbanPY3zmAkVrpg+yqlY/pZsFCqh8Wv3L5DUNh+3cUBX+
> >>> B7UyK+DJCXOld+81tESZWZhHAN6DXZWrWANrrtkeWO3qtdNLZTaOMAHaaoHPWJEK
> >>> xo2Iapi8IzjYJr5jN7nq
> >>> =ZuKl
> >>> -END PGP SIGNATURE-
> >>>
> >>> Signature for apache-wicket-6.29.0.tar.gz:
> >>>
> >>>  -BEGIN PGP SIGNATURE-
> >>> Version: GnuPG v1
> >>>
> >>> iQIcBAABAgAGBQJaiFhXAAoJEIePAfqo01bhPY8P/j6Lwdz9Swa/mHs6EagLTq0s
> >>> iArc8ZQzlt8GtnpVr6IIngDcFwvhvsWqCtSpPFmUt74xtZbA6oz6GBhEE0Dmsr9x
> >>> 93Ov2aKYRU1pR/H5VkNWqdR67J6QT4amE81T+RzbfQbvcP7YFIIbPOTg4ox3Za61
> >>> fu2NlkzB4u9qiPfqad6ylGoVu4mUde+klsnQiHL2dA3DmucChG08I9xjgzqQDIwo
> >>> ph2gbieag9RjbgRQEKOYOQcBBS7B8VCNvFxslbchGJEQm6B2QVuQV3+nvyWbjQ0J
> >>> u0tpbZA0Wev59dzpLRJDSFcccgBCCII+MP9RZPRuQSUDAyIg/PJ1LFtm/85hxV7C
> >>> VqDTMuniLYZT8shTWw4VKQfVGmjso/eRQsNAG7BeMZqxBWQpQQ+6BMoy2piXAavp
> >>> RZxO17Ct0V9dPVp7cTTHiet/Iz1oPwkceF5KmaQl1vLhicBbvLF6993ny7iP0Lyo
> >>> t+Jh1v4TFf7Daxxgl6q1tO2zDZc94877FXwjZ7b/n37SoRENzTPj+sNhpS3jCZ+E
> >>> QxXp/dYU0L6+mVLhJ4XPWAsTljdvnXwHf7S1RBSeEsGb9BM97l6Yh2WpWTgvLiwy
> >>> lvdWNkWX1pd6fD1V/XT83FtlQDURPkGN6Bbbfmwh8pSPbzQMn2Q5EXlFTLcTsVhW
> >>> QV/yE6KsG5K8AqjY9DdD
> >>> =oA/r
> >>> -END PGP SIGNATURE-
> >>>
> >>> 
> 
> >>>
> >>>  CHANGELOG for 6.29.0:
> >>>
> >>> ** Bug
> >>>
> >>>  * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> >>>  * [WICKET-6501] - DefaultPageManagerProvider does not honour
> >>> StoreSettings.setAsynchronous(false)
> >>>  * [WICKET-6526] - Ajax Buttons do not check for the HTTP method
> and
> >>> thus don't respect Form#onMethodMismatch
> >>>  * [WICKET-6530] - Race-condition in session invalidation
> >>>
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>