Re: [VOTE] Release Apache Wicket 8.0.0

+1 François > Le 18 mai 2018 à 11:59, Peter Ertl a écrit : > > +1 > >> Am 18.05.2018 um 11:58 schrieb Emond Papegaaij : >> >> +1 >> >> Tested our application with the complete test suite >> Checked signatures and hashes >> >> I did notice some

Re: [4/8] wicket git commit: Added missing java 9 module

In short, code migration was trivial, except for the Wildfly/Arquillian which required a lot of config troubleshooting :-) On Fri, May 18, 2018 at 12:32 PM, Andrea Del Bene wrote: > I did that particular change because with the new Wildfly/Arquillian > versions I got a

Re: [4/8] wicket git commit: Added missing java 9 module

I did that particular change because with the new Wildfly/Arquillian versions I got a NPE with MockHttpServletRequest#getSession(boolean b). In short this method returns null id the current session is temporary. According to Martin's commit (7ca927c) this was done in order to comply with servlet

Re: [4/8] wicket git commit: Added missing java 9 module

Hi, changes to MockHttpServletRequest and its test have been reverted in a later commit, so the final code doesn't contain the commented out code. On Fri, May 18, 2018 at 10:47 AM, Maxim Solodovnik wrote: > Is this commented out code really necessary? > Or maybe it should

Re: [VOTE] Release Apache Wicket 8.0.0

+1 Tested our application with the complete test suite Checked signatures and hashes I did notice some misplaced managed dependencies in the root pom for projects that no longer exist, but that should not stop the release. Best regards, Emond On donderdag 17 mei 2018 22:30:20 CEST Pedro

Re: [4/8] wicket git commit: Added missing java 9 module

Is this commented out code really necessary? Or maybe it should be fixed? On Fri, May 18, 2018 at 3:30 PM, wrote: > Added missing java 9 module > > > Project: http://git-wip-us.apache.org/repos/asf/wicket/repo > Commit: