martin-g commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476773719
:+1: if everything still works !
This is an automated message from the Apache
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476751902
I would say `cglib-nodep` is better option since we have `asm` as separate
dependency ...
@martin-g, @svenmeier, @bitstorm WDYT?
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476750648
There is a cglib-nodep that wicket-ioc could depend on, and then inherit the
asm dependency (which is used by other wicket modules).
Q:
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476748823
@mattrpav PR with the link to JIRA is perfectly fine :)
You did everything right :)
mattrpav edited a comment on issue #349: [WICKET-6647] Upgrade asm to 7.1 in
master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019
@solomax re the wicket-8.x patch-- what is the preferred workflow for
patches? Do you merge PR's from here or other?
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476748019
@solomax what is the preferred workflow for patches?
This is an automated
mattrpav commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476747443
@solomax apologies for the build warn. I created this PR to see if there was
some CI/CD tied to Wicket's PR's. This is a simple fix to exclude
solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master
URL: https://github.com/apache/wicket/pull/349#issuecomment-476743542
@mattrpav I got build error with this change:
```
WARNING]
Dependency convergence error for org.ow2.asm:asm:7.0 paths to dependency
mattrpav opened a new pull request #350: [WICKET-6647] Upgrade to asm 7.1 in 8.x
URL: https://github.com/apache/wicket/pull/350
This is an automated message from the Apache Git Service.
To respond to the message, please log
mattrpav opened a new pull request #349: [WICKET-6647] Upgrade asm to 7.1 in
master
URL: https://github.com/apache/wicket/pull/349
This is an automated message from the Apache Git Service.
To respond to the message, please
10 matches
Mail list logo