[GitHub] [wicket] martin-g commented on issue #363: Convert wicket ajax to typescript

martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-492088961 > I think for future Wicket releases we can consider other options such as AMD, UMD or CommonJS I do not see a reason for this. No one ever asked

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283633181 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283632320 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.jav

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631121 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.css

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283633541 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631020 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.css

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283632622 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631883 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.jav

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283631302 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.jav

[GitHub] [wicket] martin-g commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

martin-g commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283630264 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] andruhon edited a comment on issue #361: WICKET-6666 initial checkin of new ModalDialog

andruhon edited a comment on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492059377 Just tested the modal in Chrome, FF, Edge and IE11 all good. Looks a bit dodgy in IE11. > I doubt that is possible. Each dial

[GitHub] [wicket] andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

andruhon commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492059377 Just tested the modal in Chrome, FF, Edge and IE11 all good. Looks a bit dodgy in IE11. > I doubt that is possible. Each dialog works

[GitHub] [wicket] andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

andruhon commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283608085 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog-ski

[GitHub] [wicket] ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

ivaynberg commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492058445 > I believe that some abstract component such as AbstractModalDialog should be created in core to represent dialogs, it could be squeezed

[GitHub] [wicket] ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

ivaynberg commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283607451 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialogRef

[GitHub] [wicket] ivaynberg commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

ivaynberg commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492057737 it already supports select2 This is an automated message from the Apache

[GitHub] [wicket] andruhon commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

andruhon commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492038830 Another thing I really want it to do is to work nicely with the Select2 (maybe it already does). Select2 inside of the old ModalWindow was a

[GitHub] [wicket] andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

andruhon commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283532822 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialogRefe

[GitHub] [wicket] andruhon commented on issue #363: Convert wicket ajax to typescript

andruhon commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-492022858 Another important point to discuss is a format. The IIFE is currently configured is good to make it compatible with Wicket 8 stuff. Essentially what I h

[GitHub] [wicket] ivaynberg commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

ivaynberg commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283391608 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] martin-g commented on issue #363: Convert wicket ajax to typescript

martin-g commented on issue #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363#issuecomment-491822968 I am +1 to make these changes! But we should apply the changes from https://github.com/apache/wicket/pull/359 --

[GitHub] [wicket] andruhon commented on a change in pull request #361: WICKET-6666 initial checkin of new ModalDialog

andruhon commented on a change in pull request #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#discussion_r283336671 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalDialog.js

[GitHub] [wicket] andruhon commented on a change in pull request #359: Wicket js cleanup

andruhon commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r283334685 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ## @@ -1143,23 +1085,9

[GitHub] [wicket] andruhon opened a new pull request #363: Convert wicket ajax to typescript

andruhon opened a new pull request #363: Convert wicket ajax to typescript URL: https://github.com/apache/wicket/pull/363 Continuing discussion about converting wicket-ajax-jquery.js into TypeScript. Finally I reached the stage when all tests passing and I can run ajax section in wic

[GitHub] [wicket] bitstorm commented on a change in pull request #359: Wicket js cleanup

bitstorm commented on a change in pull request #359: Wicket js cleanup URL: https://github.com/apache/wicket/pull/359#discussion_r283276011 ## File path: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js ## @@ -1143,23 +1085,9

[GitHub] [wicket] martin-g merged pull request #362: update Dockerfile to point to tomcat:9.0-jre11

martin-g merged pull request #362: update Dockerfile to point to tomcat:9.0-jre11 URL: https://github.com/apache/wicket/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log