[GitHub] [wicket] martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM
martin-g commented on a change in pull request #386: WICKET-6531 Crash in
Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r332838963
##
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
##
@@ -235,6 +235,9 @@ public String toString()
{
try
{
+
+ available = "Oracle
Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
Review comment:
In that case we cannot use this PR.
What exactly is the crash in J9 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM
dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in
Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r332837909
##
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
##
@@ -235,6 +235,9 @@ public String toString()
{
try
{
+
+ available = "Oracle
Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
Review comment:
I checked this on several different VMs an operating systems and i don't
think we can tell if there is an Oracle vm or not.
`java.specification.vendor` is always `Oracle Corporation`
ORACLE JAVA 8 - UBUNTU
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 10 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = "Oracle Corporation"
AMAZON CORRETTO 11 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Amazon.com Inc.
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Amazon.com Inc.
IBM JDK 8 - AIX
java.specification.vendor = Oracle Corporation
java.vendor = IBM Corporation
java.vm.name = IBM J9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = IBM Corporation
OPENJDK J9 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Eclipse OpenJ9
java.vm.name = Eclipse OpenJ9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Eclipse OpenJ9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM
dawidss7 commented on a change in pull request #386: WICKET-6531 Crash in
Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r332837909
##
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
##
@@ -235,6 +235,9 @@ public String toString()
{
try
{
+
+ available = "Oracle
Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
Review comment:
I cheked this on several different VMs an operating systems and i don't
think we can tell if there is an Oracle vm or not.
`java.specification.vendor` is always `Oracle Corporation`
ORACLE JAVA 8 - UBUNTU
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Oracle Corporation
ORACLE JAVA 10 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Oracle Corporation
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = "Oracle Corporation"
AMAZON CORRETTO 11 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Amazon.com Inc.
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Amazon.com Inc.
IBM JDK 8 - AIX
java.specification.vendor = Oracle Corporation
java.vendor = IBM Corporation
java.vm.name = IBM J9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = IBM Corporation
OPENJDK J9 8 - WINDOWS
java.specification.vendor = Oracle Corporation
java.vendor = Eclipse OpenJ9
java.vm.name = Eclipse OpenJ9 VM
java.vm.specification.vendor = Oracle Corporation
java.vm.vendor = Eclipse OpenJ9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM
martin-g commented on a change in pull request #386: WICKET-6531 Crash in
Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r332831622
##
File path:
wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
##
@@ -235,6 +235,9 @@ public String toString()
{
try
{
+
+ available = "Oracle
Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
Review comment:
@dawidss7 Ping!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
martin-g commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-539834141 Sounds good to me! In this case there won't be a need for `` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] martin-g commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
martin-g commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r332830868
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -823,15 +861,25 @@
return;
}
+ var nonce;
+ var meta = root.getElementsByTagName("meta")[0];
+ if (!isUndef(meta)) {
+ // var nonceEl =
meta.getElementsByTagName("wicket-nonce")[0];
+ // if (!isUndef(nonceEl)) {
+ // nonce =
Wicket.DOM.text(nonceEl);
+ // }
+ nonce =
Wicket.DOM.text(meta.getElementsByTagName("wicket-nonce")[0]);
Review comment:
`` looks good to me!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r332819559
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
+ }
+ Wicket.Ajax.Call._suspended++;
+ var notify = Wicket.Ajax.Call.currentNotify;
+ var released = false;
+
+ return function () {
+ // release only once
+ if (released === false) {
+ released = true;
Review comment:
I fixed this, please see a new EffectsPage.js example
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-539800079 > If every JS snippet is ending up as a header item anyway, why not remove and from the Ajax response and transport everything as a ? > In the correct order of course. > >
[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r332809966
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
Review comment:
I'll go with throw
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r332809767
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
+ }
+ Wicket.Ajax.Call._suspended++;
+ var notify = Wicket.Ajax.Call.currentNotify;
+ var released = false;
+
+ return function () {
+ // release only once
+ if (released === false) {
+ released = true;
+ Wicket.Ajax.Call._suspended--;
+ if (Wicket.Ajax.Call._suspended === 0) {
+ notify();
+ }
+ }
+ }
+ };
+
+ Wicket.Ajax.Call.getFunctionsExecuterStatus = function() {
+ Wicket.Ajax.Call.currentNotify = undefined;
Review comment:
Right, I'll move this logic into process evaluation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r331840246
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
+ }
+ Wicket.Ajax.Call._suspended++;
+ var notify = Wicket.Ajax.Call.currentNotify;
+ var released = false;
+
+ return function () {
+ // release only once
+ if (released === false) {
+ released = true;
Review comment:
~Every notify returned should be called, for example this one works:~
~But if any of these three notifys will get lost the stuff will get stuck.~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [wicket] andruhon commented on a change in pull request #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify
andruhon commented on a change in pull request #384: WICKET-6703 replace eval
with jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#discussion_r332807766
##
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##
@@ -350,6 +350,44 @@
*/
Wicket.Ajax.Call = Wicket.Class.create();
+ Wicket.Ajax.Call._suspended = 0;
+
+ Wicket.Ajax.Call.currentNotify = undefined;
+
+ Wicket.Ajax.Call.suspend = function () {
+ if (typeof (Wicket.Ajax.Call.currentNotify) != "function") {
+ Wicket.Log.error("Can't suspend: no evaluation in
process");
+ return;
+ }
+ Wicket.Ajax.Call._suspended++;
+ var notify = Wicket.Ajax.Call.currentNotify;
+ var released = false;
+
+ return function () {
+ // release only once
+ if (released === false) {
+ released = true;
+ Wicket.Ajax.Call._suspended--;
+ if (Wicket.Ajax.Call._suspended === 0) {
+ notify();
+ }
+ }
+ }
+ };
+
+ Wicket.Ajax.Call.getFunctionsExecuterStatus = function() {
+ if (Wicket.Ajax.Call._suspended) {
+ // suspended
+ return FunctionsExecuter.ASYNC;
+ } else {
+ // execution finished, cleanup the last notify
+ Wicket.Ajax.Call.currentNotify = undefined;
Review comment:
I think this conflicts with
https://github.com/apache/wicket/pull/384#discussion_r331761728
the currentNotify should be called either when the call is not async, or
when last suspend/lock is released.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Re: FYI
Great news :) On Tue, 8 Oct 2019 at 14:41, Andrea Del Bene wrote: > Great! Thank you Martin! > > On Tue, Oct 8, 2019 at 5:10 AM Martin Grigorov > wrote: > > > On Mon, Oct 7, 2019, 16:33 Martin Grigorov wrote: > > > > > I've found a workaround: execute `mvn clean javadoc:aggregate` as a > > > separate step after `mvn deploy` > > > > > > In r1051190 at > > > > > > https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects > > > I've split the step into two steps. > > > > > > But now the build failed due to some NPM bug: > > > https://issues.apache.org/jira/browse/INFRA-19234 > > > Once this is resolved we will see whether the API docs appear at > > > https://ci.apache.org/projects/wicket/apidocs/9.x/index.html > > > > > > > The Javadoc is available now! > > > > > > > On Tue, Jul 23, 2019 at 6:55 PM Andrea Del Bene > > > wrote: > > > > > >> I think I might found a bug with maven-javadoc-plugin: > > >> > > >> https://issues.apache.org/jira/browse/MJAVADOC-618 > > >> > > >> On Mon, Jul 22, 2019 at 6:36 PM Andrea Del Bene > > > >> wrote: > > >> > > >> > After the fix applied by Martin we have another more strange message > > >> error > > >> > during javadoc:aggregate. I couldn't find any possible cause yet: > > >> > > > >> > [INFO] --- maven-javadoc-plugin:3.1.1:aggregate (default-cli) @ > > >> > wicket-parent --- > > >> > [INFO] Toolchain in maven-javadoc-plugin: > > >> > JDK[/usr/lib/jvm/adoptopenjdk-11-jdk-hotspot/] > > >> > [WARNING] Only outputDirectories and jars are accepted on the path > > >> > [ERROR] no reactor project: org.apache.wicket:wicket > > >> > [ERROR] Error while creating javadoc report: Only outputDirectories > > and > > >> > jars are accepted on the path > > >> > java.lang.IllegalArgumentException: Only outputDirectories and jars > > are > > >> > accepted on the path > > >> > at > > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath > > >> > (LocationManager.java:333) > > >> > at > > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath > > >> > (LocationManager.java:139) > > >> > at > > >> > > org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addJavadocOptions > > >> > (AbstractJavadocMojo.java:5001) > > >> > at > > >> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport > > >> > (AbstractJavadocMojo.java:2081) > > >> > ... > > >> > > > >> > On Sat, Jul 13, 2019 at 10:22 PM Martin Grigorov < > > mgrigo...@apache.org> > > >> > wrote: > > >> > > > >> >> Hi, > > >> >> > > >> >> I've committed a change to Wicket's Buildbot config that adds > > JAVA_HOME > > >> >> for > > >> >> the Java 11, 13 and 14 builds. > > >> >> Hopefully this will fix the problem! > > >> >> > > >> >> On Fri, Jul 12, 2019 at 5:01 PM Andrea Del Bene < > > an.delb...@gmail.com> > > >> >> wrote: > > >> >> > > >> >> > Problem with javadoc-maven-plugin 3.1.x and CI: > > >> >> > > > >> >> > https://issues.apache.org/jira/browse/INFRA-18741 > > >> >> > > > >> >> > -- > > >> >> > Andrea Del Bene. > > >> >> > Apache Wicket committer. > > >> >> > > > >> >> > > >> > > > >> > > > >> > -- > > >> > Andrea Del Bene. > > >> > Apache Wicket committer. > > >> > > > >> > > >> > > >> -- > > >> Andrea Del Bene. > > >> Apache Wicket committer. > > >> > > > > > > > > -- > Andrea Del Bene. > Apache Wicket committer. > -- WBR Maxim aka solomax
Re: FYI
Great! Thank you Martin! On Tue, Oct 8, 2019 at 5:10 AM Martin Grigorov wrote: > On Mon, Oct 7, 2019, 16:33 Martin Grigorov wrote: > > > I've found a workaround: execute `mvn clean javadoc:aggregate` as a > > separate step after `mvn deploy` > > > > In r1051190 at > > > https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects > > I've split the step into two steps. > > > > But now the build failed due to some NPM bug: > > https://issues.apache.org/jira/browse/INFRA-19234 > > Once this is resolved we will see whether the API docs appear at > > https://ci.apache.org/projects/wicket/apidocs/9.x/index.html > > > > The Javadoc is available now! > > > > On Tue, Jul 23, 2019 at 6:55 PM Andrea Del Bene > > wrote: > > > >> I think I might found a bug with maven-javadoc-plugin: > >> > >> https://issues.apache.org/jira/browse/MJAVADOC-618 > >> > >> On Mon, Jul 22, 2019 at 6:36 PM Andrea Del Bene > >> wrote: > >> > >> > After the fix applied by Martin we have another more strange message > >> error > >> > during javadoc:aggregate. I couldn't find any possible cause yet: > >> > > >> > [INFO] --- maven-javadoc-plugin:3.1.1:aggregate (default-cli) @ > >> > wicket-parent --- > >> > [INFO] Toolchain in maven-javadoc-plugin: > >> > JDK[/usr/lib/jvm/adoptopenjdk-11-jdk-hotspot/] > >> > [WARNING] Only outputDirectories and jars are accepted on the path > >> > [ERROR] no reactor project: org.apache.wicket:wicket > >> > [ERROR] Error while creating javadoc report: Only outputDirectories > and > >> > jars are accepted on the path > >> > java.lang.IllegalArgumentException: Only outputDirectories and jars > are > >> > accepted on the path > >> > at > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath > >> > (LocationManager.java:333) > >> > at > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath > >> > (LocationManager.java:139) > >> > at > >> > org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addJavadocOptions > >> > (AbstractJavadocMojo.java:5001) > >> > at > >> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport > >> > (AbstractJavadocMojo.java:2081) > >> > ... > >> > > >> > On Sat, Jul 13, 2019 at 10:22 PM Martin Grigorov < > mgrigo...@apache.org> > >> > wrote: > >> > > >> >> Hi, > >> >> > >> >> I've committed a change to Wicket's Buildbot config that adds > JAVA_HOME > >> >> for > >> >> the Java 11, 13 and 14 builds. > >> >> Hopefully this will fix the problem! > >> >> > >> >> On Fri, Jul 12, 2019 at 5:01 PM Andrea Del Bene < > an.delb...@gmail.com> > >> >> wrote: > >> >> > >> >> > Problem with javadoc-maven-plugin 3.1.x and CI: > >> >> > > >> >> > https://issues.apache.org/jira/browse/INFRA-18741 > >> >> > > >> >> > -- > >> >> > Andrea Del Bene. > >> >> > Apache Wicket committer. > >> >> > > >> >> > >> > > >> > > >> > -- > >> > Andrea Del Bene. > >> > Apache Wicket committer. > >> > > >> > >> > >> -- > >> Andrea Del Bene. > >> Apache Wicket committer. > >> > > > -- Andrea Del Bene. Apache Wicket committer.
