[GitHub] [wicket] papegaaij commented on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-23 Thread GitBox
papegaaij commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-578028265 I've restored the configurable class names (and did the same thing in component for the placeholder). Personally, I still do

Re: build of master branch failed because of date format

2020-01-23 Thread Martin Grigorov
Hi Maxim, This must be because of an old build of JDK11 on BuildBot. Let's open a ticket at INFRA to install the latest. On Fri, Jan 24, 2020 at 8:46 AM Maxim Solodovnik wrote: > Hello All, > > Recent builds of master branch are failed due to > > ZonedDateTimeConverterTest.convertToObject:49

build of master branch failed because of date format

2020-01-23 Thread Maxim Solodovnik
Hello All, Recent builds of master branch are failed due to ZonedDateTimeConverterTest.convertToObject:49 expected: <2016-07-11T01:02:03Z[Etc/UTC]> but was: <2016-07-11T01:02:03Z[Etc/UCT]> Maybe it worth to compare dates if "time zoneless" format? -- WBR Maxim aka solomax

[GitHub] [wicket] solomax commented on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-23 Thread GitBox
solomax commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-578007500 I would vote for adding customizable CSS class back This way CSS can be customized much easily (`important` will not be

[GitHub] [wicket] papegaaij edited a comment on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-23 Thread GitBox
papegaaij edited a comment on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-577890877 I totally understand the use case for configurable css classes in cases I see as 'user facing': elements a user will

[GitHub] [wicket] papegaaij commented on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-23 Thread GitBox
papegaaij commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-577890877 I totally understand the use case for configurable css classes in cases I see as 'user facing': elements a user will need to

[GitHub] [wicket] svenmeier commented on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-23 Thread GitBox
svenmeier commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-577874732 Over the last years I've tried to make Wicket's usage of CSS class names uniform and configurable - see CssUtils#key() - so

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-23 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577630998 @papegaaij Thanks a lot! Everything works as expected :) ps surprisingly my original question wasn't offtopic in this PR :)

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-23 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577610915 @solomax you are right, the item is unwrapped to set the nonce, but then the unwrapped item is rendered. I've fixed the code, please

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-23 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577600141 Yep, seems to be bug Filtered nature is dropped here

[GitHub] [wicket] martin-g commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-23 Thread GitBox
martin-g commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577583362 There might be a bug somewhere :-/ This is an automated message from

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-23 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-577582507 @martin-g I'm trying to implement this via FilteredHeaderItem, but this seems to be extremely not easy: CSSItem added as