[ANNOUNCE] WicketStuff 8.11.0 Released

2020-11-24 Thread Maxim Solodovnik
WicketStuff core 8.11.0 based on Apache Wicket 8.11.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (4): Switching to the next development version Xstream is updated Dependencies and plugins are updated wicketstuff-core-8.11.0

Re: [VOTE] Release Apache Wicket 8.11.0

2020-11-22 Thread Maxim Solodovnik
+1 all main checks are passed :) On Mon, 23 Nov 2020 at 01:50, Andrea Del Bene wrote: > +1 to release > > Test user guide examples. > > On 22/11/20 05:09, Tobias Soloschenko wrote: > > +1 > > > > kind regards > > > > Tobias > > > >> Am 20.11.2020 um 23:41 schrieb Sven Meier : > >> > >> +1 for

[ANNOUNCE] WicketStuff 9.2.0 Released

2020-11-19 Thread Maxim Solodovnik
WicketStuff core 9.2.0 based on Apache Wicket 9.2.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (5): Switching to the next development version Xstream is updated Versions are fixed Dependencies and plugins are updated

Re: [VOTE] Release Apache Wicket 9.2.0

2020-11-16 Thread Maxim Solodovnik
+1 tested - signatures, - local build - wicket stuff build, examples - main app On Mon, 16 Nov 2020 at 17:51, Ernesto Reinaldo Barreiro wrote: > +1 for release: our selenium tests are green with 9.2.0. Server side errors > are gone too. > > On Mon, Nov 16, 2020 at 1:18 AM Andrea Del Bene >

Inconsistency in deprecation

2020-11-13 Thread Maxim Solodovnik
Hello All, As far as I can see CsrfPreventionRequestCycleListener is now deprecated But WebSocketAwareCsrfPreventionRequestCycleListener is not Should it also be deprecated? Are there any good examples on how to use FetchMetadataResourceIsolationPolicy? -- Best regards, Maxim

Re: new release 9.2.0 ?

2020-10-28 Thread Maxim Solodovnik
+1 fixes to PageSerializers are worth to be released! :)) And maybe it's time to start Wicket10? or maybe collect ideas :)) On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko wrote: > +1 for release > > kind regards > > Tobias > > > Am 28.10.2020 um 23:27 schrieb Sven Meier : > > > > Hi all, >

Re: [ANNOUNCE] WicketStuff 9.1.0 Released

2020-10-12 Thread Maxim Solodovnik
gt; Many thanks. Can > >> > >> https://github.com/sebfz1/wicket-jquery-ui > >> > >> Be released too? > >> > >> > >> On Mon, Oct 12, 2020 at 8:56 AM Maxim Solodovnik > >> wrote: > >> > >>> WicketStuff core 9.1.0 based on Apache W

[ANNOUNCE] WicketStuff 9.1.0 Released

2020-10-11 Thread Maxim Solodovnik
WicketStuff core 9.1.0 based on Apache Wicket 9.1.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (7): Switching to the next development version Fixes issue #699: firstDayOfWeek should be displayed as expected wicketstuff-datetime

[ANNOUNCE] WicketStuff 8.10.0 Released

2020-10-11 Thread Maxim Solodovnik
WicketStuff core 8.10.0 based on Apache Wicket 8.10.0 is released and soon will be available at Maven Central! The changelog is: Andrea Del Bene (1): Applied scope test to xml dependencies Maxim Solodovnik (3): Switching to the next development version Release preparation

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-08 Thread Maxim Solodovnik
+1 all my tests are passed :) On Thu, 8 Oct 2020 at 00:46, Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.1.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote >

Re: [VOTE] Release Apache Wicket 8.10.0

2020-10-04 Thread Maxim Solodovnik
+1 signatures, wicket and wicketstuff build, some wicketstuff examples are OK On Mon, 5 Oct 2020 at 02:18, Tobias Soloschenko wrote: > +1 > > kind regards > > Tobias > > > Am 04.10.2020 um 21:16 schrieb Sven Meier : > > > > +1 tested examples and zip signature > > > > Sven > > > > > >> On

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
My vote is -1 Our main application is not working with this version On Sat, 3 Oct 2020 at 22:57, Maxim Solodovnik wrote: > Thanks a lot Sven :) > sorry I have not tested before > > On Sat, 3 Oct 2020 at 22:30, Sven Meier wrote: > >> Ok, found the issue: >>

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
with this regression. > > Have fun > Sven > > > On 03.10.20 14:04, Maxim Solodovnik wrote: > > OK > > > > the problem is caused by adding `FilteringHeaderResponse` > > > https://github.com/solomax/ajax-download/blob/master/src/main/java/org/apache/WicketAppli

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
OK the problem is caused by adding `FilteringHeaderResponse` https://github.com/solomax/ajax-download/blob/master/src/main/java/org/apache/WicketApplication.java#L50 here is the quickstart https://github.com/solomax/ajax-download On Sat, 3 Oct 2020 at 18:11, Maxim Solodovnik wrote: > ls

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
/openmeetings/WEB-INF/lib/wicket-webjars-3.0.0-M4.jar same result, will try to create quickstart On Sat, 3 Oct 2020 at 17:18, Maxim Solodovnik wrote: > Tomcat 9.0.38.0 (I doubt it is important) > > all jars are in webapps/openmeetings/WEB-INF/lib > > ls -1 wicket* > > wicket

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
and try again On Sat, 3 Oct 2020 at 16:59, Sven Meier wrote: > The CSP example works fine. > > Do you have Wicket 9.0 and 9.1 on your classpath? > > Sven > > > On 03.10.20 08:13, Maxim Solodovnik wrote: > > Hello Sven, > > > > I was aware of this JI

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Maxim Solodovnik
be https://issues.apache.org/jira/browse/WICKET-6821 > > Do you configure your CSP in #init()? > > Sven > > > Am 3. Oktober 2020 06:18:21 MESZ schrieb Maxim Solodovnik < > solomax...@gmail.com>: > >sorry for double posting, > > > >here are the first results: CSPNonc

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-02 Thread Maxim Solodovnik
sorry for double posting, here are the first results: CSPNonceHeaderResponseDecorator was set up, but breakpoint in it's `render` method wasn't hit something weird On Sat, 3 Oct 2020 at 08:47, Maxim Solodovnik wrote: > Hello All, > > I have started testing this new release

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-02 Thread Maxim Solodovnik
Hello All, I have started testing this new release yesterday Checksum and signature as well as local build from sources are OK BUT my main application is not working at all due to zero resources are loaded due to CSP errors (we do have CSP rules in charge and CSP enabled) Everything works as

Re: Migration of jenkins.a.o to cloudbees

2020-08-14 Thread Maxim Solodovnik
AFAIK wicket doesn't use Jenkins On Fri, 14 Aug 2020 at 19:37, Martijn Dashorst wrote: > Is this something we are aware of, and is this done? > > > Tomorrow is the deadline for migrating to ci-builds.a.o and for > builds.a.o to be turned off. > > A script to move builds from one to the other: >

[ANNOUNCE] WicketStuff 7.17.0 Released

2020-07-21 Thread Maxim Solodovnik
WicketStuff core 7.17.0 based on Apache Wicket 7.17.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (4): Switching to the next development version Fixed issue #690: commons-io is updated Dependencies are updated (partially

Re: [VOTE] Release Apache Wicket 7.17.0

2020-07-18 Thread Maxim Solodovnik
+1 tested: - signatures - build from sources (-Pbuildbot) - wicketstuff build - random wicketstuff examples On Fri, 17 Jul 2020 at 04:38, Andrea Del Bene wrote: > This is a vote to release Apache Wicket 7.17.0 > > Please download the source distributions found in our staging area > linked

[ANNOUNCE] WicketStuff 8.9.0 Released

2020-07-18 Thread Maxim Solodovnik
WicketStuff core 8.9.0 based on Apache Wicket 8.9.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (4): Switching to the next development version Release preparation: dependencies are updated Possibly fixes #694: alternative way

[ANNOUNCE] WicketStuff 9.0.0 Released

2020-07-16 Thread Maxim Solodovnik
WicketStuff core 9.0.0 based on Apache Wicket 9.0.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (6): Switching to the next development version Merge branch 'master' of github.com:wicketstuff/core Tests should be fixed

Re: [VOTE] Release Apache Wicket 8.9.0

2020-07-13 Thread Maxim Solodovnik
+1 Tested: - signatures - build from sources - wicketstuff build - some wicketstuff examples On Mon, 13 Jul 2020 at 13:18, Sven Meier wrote: > +1 > > checked some examples and sha > > Sven > > > On 11.07.20 19:10, Andrea Del Bene wrote: > > This is a vote to release Apache Wicket 8.9.0 > > > >

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
ory. I've uploaded the correct content, you should be able to > verify the signatures now. > > On 09/07/20 18:36, Maxim Solodovnik wrote: > > +1 for release > > > > Tested > > - build from sources > > - wickestuff build and running some apps > >

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
+1 for release Tested - build from sources - wickestuff build and running some apps - our main app build and run I believe KEYS file need to be updated On Thu, 9 Jul 2020 at 22:14, Maxim Solodovnik wrote: > Hello Andrea, > > I can't check signature :( > My steps are: > *gp

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
Hello Andrea, I can't check signature :( My steps are: *gpg --import KEYS* ## https://downloads.apache.org/wicket/KEYS *gpg --verify apache-wicket-9.0.0.tar.gz.asc* gpg: assuming signed data in 'apache-wicket-9.0.0.tar.gz' gpg: Signature made Wed 08 Jul 2020 05:37:02 +07 gpg:using

Re: Release Wicket 9.0.0?

2020-06-09 Thread Maxim Solodovnik
+1 :) On Tue, 9 Jun 2020 at 15:36, Thomas Heigl wrote: > Hi all, > > I merged my last open PR yesterday and it looks like there are no other > open issues or PRs. > > Since there was a consensus to release already at the end of April, I'd > like to bring this up again. Should we release 9.0.0?

Re: Contribution - CSP support for Wicket

2020-06-04 Thread Maxim Solodovnik
+1 On Fri, 5 Jun 2020 at 10:17, Tobias Soloschenko wrote: > Hi, > > to my opinion they just want to contribute to Wicket. I would simply > explain how the process of contribution works at ASF (PRs, etc.) and give > them some information what challenges we were faced with till now. > > kind

Re: 'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Emond, I'll create PR :) Sorry I misspelled your name :( (from mobile, sorry for typos) On Sun, May 24, 2020, 21:31 Maxim Solodovnik wrote: > Hello Edmond, > > It seems 'base-uri' directive [1] is missing is "enum CSPDirective" > Is it on purpose? > > On

'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Edmond, It seems 'base-uri' directive [1] is missing is "enum CSPDirective" Is it on purpose? One of our users check current rules using some validator [2] [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri [2]

Re: [ANNOUNCE] New Committer - Thomas Heigl

2020-05-22 Thread Maxim Solodovnik
Welcome! On Sat, 23 May 2020 at 03:52, Tobias Soloschenko wrote: > Welcome Thomas! :-) > > kind regards > > Tobias > > > Am 22.05.2020 um 21:08 schrieb Andrea Del Bene : > > > > The Apache Wicket team is happy to announce that Thomas Heigl has been > voted in as a committer on Apache Wicket

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-07 Thread Maxim Solodovnik
nal class Map1 extends AbstractImmutableMap { @Stable private final K k0; @Stable private final V v0; ... Which seems to be the same as we have now > > Martijn > > On Wed, May 6, 2020 at 2:18 PM Maxim Solodovnik > wrote:

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
MicroMap can easily be replaced with Map.of(key, value) I can deprecate it for wicket9 in same PR, should I? On Wed, 6 May 2020 at 18:06, Maxim Solodovnik wrote: > I would propose to remove it in Wicket9, but don't want to slow down the > release :) > Will create PR :) > > On

Re: ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
nd would make it clear that when in > > doubt: use the JDK provided one. > > > > Martijn > > > > > > On Wed, May 6, 2020 at 12:36 PM Martin Grigorov > > wrote: > > > >> On Wed, May 6, 2020 at 1:20 PM Maxim Solodovnik > >> wrote: &g

ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
Hello All, ConcurrentHashSet can be safely removed from wicket codebase due to since Java8 it is possible to use ConcurrentHashMap.newKeySet() Can we @deprecate in in wicket9 and remove in Wicket10? -- Best regards, Maxim

Re: Time to release 9.0.0 ?

2020-04-30 Thread Maxim Solodovnik
+1 let's release final version :) On Thu, 30 Apr 2020 at 14:40, Martin Grigorov wrote: > > Hi team, > > Few weeks have passed since Wicket 9.0.0-M5 and there are no stopper issues > being reported. > Let's release 9.0.0! > > I see few of you discuss refactoring some pretty critical area (from >

[ANNOUNCE] WicketStuff 8.8.0 Released

2020-04-29 Thread Maxim Solodovnik
WicketStuff core 8.8.0 based on Apache Wicket 8.8.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (3): Switching to the next development version Dependencies and plugins are updated wicketstuff 8.8.0 is released The WicketStuff

Re: wicket-bootstrap date-time-picker

2020-04-28 Thread Maxim Solodovnik
Done https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/860 Thanks :) On Tue, 28 Apr 2020 at 12:00, Martin Grigorov wrote: > > Hi Maxim, > > On Mon, Apr 27, 2020 at 6:28 PM Maxim Solodovnik > wrote: > > > Hello Martin, > > > > I found some weird be

wicket-bootstrap date-time-picker

2020-04-27 Thread Maxim Solodovnik
Hello Martin, I found some weird behavior of bootstrap-date-time-picker It seems `date` option https://tempusdominus.github.io/bootstrap-4/Options/#date need to be provided if `maxDate` https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate was specified (otherwise current date will be

Re: 8.x release?....TAKE 2! :-)

2020-04-18 Thread Maxim Solodovnik
<=2 On Sat, 18 Apr 2020 at 22:29, Andrea Del Bene wrote: > I think we can proceed releasing also 8.8.0 version. This is the current > changelog: > > > bug > > * [WICKET-6746 ] - > HttpsMapper cannot deal with resources over websockets

Re: 8.x release?....TAKE 2! :-)

2020-04-18 Thread Maxim Solodovnik
I mean +1 Sorry, fat fingers :) On Sat, 18 Apr 2020 at 23:04, Maxim Solodovnik wrote: > <=2 > > On Sat, 18 Apr 2020 at 22:29, Andrea Del Bene > wrote: > >> I think we can proceed releasing also 8.8.0 version. This is the current >> changelog: >> >>

Re: CSP regression

2020-04-16 Thread Maxim Solodovnik
) I'm going to workaround this in our source code [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/connect-src On Wed, 25 Mar 2020 at 18:07, Maxim Solodovnik wrote: > Hello All, > > it seem it was false alarm > sorry for the noise :( > > O

[ANNOUNCE] WicketStuff 9.0.0-M5.1 Released

2020-04-08 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M5.1 based on Apache Wicket 9.0.0-M5 is released and soon will be available at Maven Central! Unfortunately WicketStuff core 9.0.0-M5 is broken, please use this release instead The changelog is: Maxim Solodovnik (12): Switching to the next development version

[ANNOUNCE] WicketStuff 9.0.0-M5 Released

2020-04-07 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M5 based on Apache Wicket 9.0.0-M5 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (12): Switching to the next development version Inline styles are removed Merge branch 'master' of github.com:wicketstuff/core

Re: Wicketstuff M5 release

2020-04-07 Thread Maxim Solodovnik
Application class in the examples, without bothering to test whether it is > needed or not. > > Martin > > On Tue, Apr 7, 2020 at 3:14 PM Maxim Solodovnik > wrote: > > > Hello All, > > > > I'm working at wicketstuff release, and trying to check examples > >

Wicketstuff M5 release

2020-04-07 Thread Maxim Solodovnik
Hello All, I'm working at wicketstuff release, and trying to check examples It seems many of them are broken regardless of CSP :( Shall I continue to check example by example and disable CSP for most of them WDYT would it be OK to release as is? -- Best regards, Maxim

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-05 Thread Maxim Solodovnik
Hello Sebastien, to bypass Content Security Policy: The page’s settings blocked the loading of a resource at inline (“style-src”). 2 jquery-3.4.1-ver-1586053743308.js :4817:39 I have added log-point to this line and print all `elem` to console these errors are caused by Ajax updates `elem`

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-02 Thread Maxim Solodovnik
+1 On Thu, Apr 2, 2020, 18:23 Martin Grigorov wrote: > +1 > > On Thu, Apr 2, 2020 at 12:43 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 9.0.0-M5 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 2

2020-04-02 Thread Maxim Solodovnik
I see no other way :( On Thu, 2 Apr 2020 at 14:29, Andrea Del Bene wrote: > > On 4/1/20 5:39 AM, Martin Grigorov wrote: > > Hi, > > > > The CHANGELOG should not contain > > https://issues.apache.org/jira/browse/WICKET-6750 since it is not > Resolved. > > I don't know how it managed to go into

Re: svn commit: r38773 - /dev/wicket/9.0.0-M5/CHANGELOG-9.x

2020-04-01 Thread Maxim Solodovnik
CHANGELOG is also packaged into tar.gz/zip On Thu, 2 Apr 2020 at 02:59, wrote: > Author: adelbene > Date: Wed Apr 1 19:59:20 2020 > New Revision: 38773 > > Log: > Removed WICKET-6750 from CHANGELOG > > Modified: > dev/wicket/9.0.0-M5/CHANGELOG-9.x > > Modified:

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 2

2020-03-31 Thread Maxim Solodovnik
+1 tested * signatures/hashes * local build * wicketstuff build (examples need to be reviewed and fixed, will do later) * our main app On Wed, 1 Apr 2020 at 11:03, Martin Grigorov wrote: > +1 to release > > Tested local build, random Wicket examples and my Scala based application. > > On Tue,

Re: Is it time for release?

2020-03-31 Thread Maxim Solodovnik
t; > Sven > > > > On 30.03.20 08:23, Maxim Solodovnik wrote: > >> Hello All, > >> > >> Are there any incomplete tasks yet? > >> Shall we start new VOTE? :))) > >> > >> On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro > >&

Re: Is it time for release?

2020-03-30 Thread Maxim Solodovnik
Hello All, Are there any incomplete tasks yet? Shall we start new VOTE? :))) On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro wrote: > Hahaha... as always Martin is too fast :-) > > On Mon, Mar 9, 2020 at 10:40 AM Maxim Solodovnik > wrote: > > > Martin commited me

Re: [wicket] branch master updated: WICKET-6563 add CachingPageStore

2020-03-27 Thread Maxim Solodovnik
Hello Sven, Are there any changes for wicketstuff-datastore required? On Fri, 27 Mar 2020 at 20:18, wrote: > This is an automated email from the ASF dual-hosted git repository. > > svenmeier pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/wicket.git > > >

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-26 Thread Maxim Solodovnik
Still no issues reported after 2 days of work at our demo server Seems this solution can be released :) On Wed, 25 Mar 2020 at 18:24, Maxim Solodovnik wrote: > first results: everything seems to work as expected > will continue testing > > On Wed, 25 Mar 2020 at 01:12, Sven

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-25 Thread Maxim Solodovnik
' class in progressbar.js. Just do a grep on > > 'wicket--hidden' and double-check those components in the examples. > > > > Best regards, > > Emond > > > > On Tue, Mar 24, 2020 at 6:29 AM Maxim Solodovnik > wrote: > >> Let's try to remove this

Re: CSP regression

2020-03-25 Thread Maxim Solodovnik
Hello All, it seem it was false alarm sorry for the noise :( On Tue, 24 Mar 2020 at 15:19, Maxim Solodovnik wrote: > Hmmm, > > I'll check. > The errors are definitely in DevTools (I'm using report-only CSP) > Not sure if it is first or second time > Will double-check and repo

Re: CSP regression

2020-03-24 Thread Maxim Solodovnik
rces do have > nonces. Maybe you're seeing the same errors as I when opening the dev > tools? Somehow Chrome is unable to load the css resources in the dev > tools when the dev tools are opened after loading the page. After a > refresh, it's fine again. > > Emond > > O

CSP regression

2020-03-24 Thread Maxim Solodovnik
Hello All, just found regression with CSP nonce for CSS resources seems to be not added, which results security errors Can it be caused by latest code optimizations? -- WBR Maxim aka solomax

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-23 Thread Maxim Solodovnik
;hidden" tags too :( > > >> > > >> https://jsfiddle.net/p8s7Lrk2/2/ > > >> > > >> c) and a simple fix for "hidden" tags - no !important required ... 8) > > >> > > >> https://jsfiddle.net/p8s7Lrk2/3/

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-17 Thread Maxim Solodovnik
is difficult about that? > > Actually it is recommended to have it in your normalize.css (formerly > reset.css). > > Here one without !important: > > https://github.com/necolas/normalize.css/blob/master/normalize.css > > Sven > > > On 13.03.20 15:21, Maxim Solodovn

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-13 Thread Maxim Solodovnik
Additional note: Bootstrap has following CSS [hidden] { display: none !important; } which makes life much more diffiicult ... On Fri, 13 Mar 2020 at 21:17, Martin Grigorov wrote: > > On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov > wrote: > > > Hi Sven, > > > > > > > > > >

Re: [wicket] branch master updated: WICKET-6727: only render CSP on RenderPageRequestHandler

2020-03-13 Thread Maxim Solodovnik
Hello Edmond, It seems you accidentally re-format license header ... On Fri, 13 Mar 2020 at 15:44, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > papegaaij pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/wicket.git > > >

Re: Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Maxim Solodovnik
Maybe this dependency can be added to dependencies of jetty-maven-plugin ? On Thu, 12 Mar 2020 at 23:23, Martin Grigorov wrote: > > On Thu, Mar 12, 2020, 16:41 Martijn Dashorst > wrote: > > > Because it is, just like the servlet-api, a specification that is provided > > by the container. When

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Maxim Solodovnik
+1 for getCspSettings But I guess it will be M5 ... :) On Thu, 12 Mar 2020 at 15:42, Emond Papegaaij wrote: > > Hi, > > Agreed, but first, the documentation needs to be updated with the new > API. I like most of the changes, except for the new method name for >

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-11 Thread Maxim Solodovnik
+1 Tested: 1) signatures 2) build from sources 3) our main app will start checking wicketstuff later this week On Wed, 11 Mar 2020 at 03:50, Andrea Del Bene wrote: > > This is a vote to release Apache Wicket 9.0.0-M5 > > Please download the source distributions found in our staging area >

Re: Is it time for release?

2020-03-09 Thread Maxim Solodovnik
> > > > > > On Sat, Mar 7, 2020, 10:31 AM Ernesto Reinaldo Barreiro < > > > reier...@gmail.com> > > > wrote: > > > > > > > +1 > > > > > > > > On Sat, Mar 7, 2020 at 5:14 AM Maxim Solodovnik > > > >

Is it time for release?

2020-03-06 Thread Maxim Solodovnik
subj :) -- WBR Maxim aka solomax

Re: CSP and UI libraries

2020-02-28 Thread Maxim Solodovnik
It is possible but this CSP will not be `strict` anymore :))) On Fri, 28 Feb 2020 at 15:23, Sebastien Briquet wrote: > > Thank you so much Emond! I will try that! -- WBR Maxim aka solomax

Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Sorry for bringing such news :( On Fri, 28 Feb 2020 at 10:05, Sebastien Briquet wrote: > > Thank you very much for letting me know! > I didn't exactly know what to expect until I would put my hands in it, but > now I'm a little bit worried, haha ! > > Best regards, > Sebastien -- WBR Maxim

Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Hello Sebastien, Unfortunately this task might be challenging :( Kendo will not work in strict CSP mode :( https://docs.telerik.com/kendo-ui/troubleshoot/content-security-policy Other places to look at (should be easy to correct): DisplayNoneBehavior MessageDialog :))) On Thu, 27 Feb 2020 at

Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Yes, All my prs were made with strict csp enabled Additional minor change is required to make tests pass Will create pr right after release On Thu, Feb 27, 2020, 20:32 Martin Grigorov wrote: > Thanks, Emond! > > @Maxim: since you started using Wicket 9.x Bootstrap 4.x recently: do you > use it

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Maxim Solodovnik
[+] leave as is with .wicket--hidden & wicket-core.css IMO we should sheep the version which will work as expected out-of-the-box According to my tests `hidden` attribute doesn't work (even `display: flex` breaks it) On Wed, 26 Feb 2020 at 15:22, Andrea Del Bene wrote: > > +1 to vote. I find

Re: UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
Was too fast :(( You IRC command actually started the build: "forced: by IRC user on channel ##wicket: retry" Will try to be more careful next time On Thu, 13 Feb 2020 at 23:05, Maxim Solodovnik wrote: > Thanks Martin, > > empty commit a bit ugly, but seems to be the onl

Re: UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
; (I've just tried it and for some reason it doesn't work. Maybe I've > forgotten the correct commands to wicket-bot) > > 2) git commit --allow-empty -m "Trigger build" && git push > > Both without UI. > > On Thu, Feb 13, 2020 at 4:15 PM Maxim Solodovnik > wrote

UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
Hello All, Is there any UI to restart broken build? -- WBR Maxim aka solomax

Re: buildbot failure in on wicket-master

2020-02-10 Thread Maxim Solodovnik
This should be some temporary network issues (failing test trying to connect URL url = new URL(" http://wicket.apache.org/learn/books/wia.png;); ) On Tue, 11 Feb 2020 at 04:40, Emond Papegaaij wrote: > I don't what happened here, but I'm pretty sure that I didn't break > this with a simple

Browser DevTools and wicket-ajax-jquery

2020-02-08 Thread Maxim Solodovnik
Hello All, recently I found it is hard to check/edit CSS in browser DevTools After some investigation i found the issue is cased by "cross browser way to check when the css is loaded" in wicket-ajax-jquery I would like to propose to change it as follows ---

Re: [wicket] branch csp updated: WICKET-6725: fixed special Form placeholder rendering

2020-01-29 Thread Maxim Solodovnik
Hello Martin, please see the discussion here: https://github.com/apache/wicket/commit/e1bdfe74cc7d3c0fdb67712a665cb15164868bc1 :)) On Wed, 29 Jan 2020 at 15:12, Martin Grigorov wrote: > On Tue, Jan 28, 2020 at 10:19 PM wrote: > > > This is an automated email from the ASF dual-hosted git

Re: build of master branch failed because of date format

2020-01-24 Thread Maxim Solodovnik
/browse/INFRA-19481 > > > > maybe we can send a friendly reminder. > > > > On Fri, Jan 24, 2020 at 8:35 AM Martin Grigorov > > wrote: > > > >> Hi Maxim, > >> > >> This must be because of an old build of JDK11 on BuildBot. > >

build of master branch failed because of date format

2020-01-23 Thread Maxim Solodovnik
Hello All, Recent builds of master branch are failed due to ZonedDateTimeConverterTest.convertToObject:49 expected: <2016-07-11T01:02:03Z[Etc/UTC]> but was: <2016-07-11T01:02:03Z[Etc/UCT]> Maybe it worth to compare dates if "time zoneless" format? -- WBR Maxim aka solomax

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Just have tested Chrome might change the position of such tag in the DOM :( (inside table) sorry for the noise On Wed, 15 Jan 2020 at 23:54, Maxim Solodovnik wrote: > Maybe some non-html tag can be rendered as placeholder? (for ex. > ) > It will be invisible :) > > > On Wed

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
> > > > > >>> Hi, > > > > > >>> > > > > > >>> Sven, we do need styling to hide components. > > > > > >>> Component.renderPlaceholderTag renders an empty tag for > whatever it > > > >

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
tin Grigorov wrote: > Hi Maxim, > > On Wed, Jan 15, 2020 at 8:54 AM Maxim Solodovnik > wrote: > > > Hello All, > > > > According to my tests > > textarea with hidden attribute works the same way as `display: none` > > (latest Chrome, FF, Chromium) &

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
d in Page. > > >>> > > >>> About the contents of the stylesheet, it will probably not contain > > >>> much styling, but it will be more than just wicket--hidden. For > > >>> example, the styling for the form submit handling markup needs to g

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
isn't > worth it IMHO. > > Sven > > > On 14.01.20 16:23, Maxim Solodovnik wrote: > > For example it can be added as > > `Application.get().getHeaderContributorListeners()` > > > > On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik > wrote: > >

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
For example it can be added as `Application.get().getHeaderContributorListeners()` On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik wrote: > `!important` is not the silver bullet (as well as inline style) > > `renderHead` is not as important as `onConfigure`, so I believe it > shoul

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
therwise override the visibility and cause the > component to be visible anyway (like display: flex). > > Best regards, > Emond > > On Tue, Jan 14, 2020 at 9:10 AM Maxim Solodovnik > wrote: > > > > The problem as I see it > > The component will be rendered withou

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
The problem as I see it The component will be rendered without page (and without CSS file itself) so element with this class will actually be visible On Tue, 14 Jan 2020 at 15:08, Martin Grigorov wrote: > On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik > wrote: > > > An r

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
An related question: Will this code `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)` work as expected? On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik wrote: > Is this comment make sense: > https://github.com/apache/wicket/

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-13 Thread Maxim Solodovnik
Is this comment make sense: https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645 ? On Tue, 14 Jan 2020 at 14:13, Martin Grigorov wrote: > On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik > wrote: > > > Wasn't aware of `hidden` attribute &g

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-13 Thread Maxim Solodovnik
Wasn't aware of `hidden` attribute (and it seems to be widely supported https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden) Thanks :) On Tue, 14 Jan 2020 at 14:01, Martin Grigorov wrote: > Hi, > > 1) I see that such CSS resource might be used for other needs, not just >

Re: [ANNOUNCE] WicketStuff 9.0.0-M4 Released

2020-01-11 Thread Maxim Solodovnik
Thanks Andrea, Wicket is significant part of my life :) I'll try to do as much as I can :) On Sat, 11 Jan 2020 at 19:52, Andrea Del Bene wrote: > Thanks Maxim for your effort with WicketStuff! > > On Sat, Jan 11, 2020, 9:27 AM Maxim Solodovnik > wrote: > > > WicketStuf

[ANNOUNCE] WicketStuff 9.0.0-M4 Released

2020-01-11 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M4 based on Apache Wicket 9.0.0-M4 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (11): Tests command is added to improve OracleJDK detection Java vendor detection is updated Switching to the next development

[ANNOUNCE] WicketStuff 8.7.0 Released

2020-01-10 Thread Maxim Solodovnik
#676 Reduce the amount of logged text during test execution Revert "JamonMonitoredRequestCycleTest fails on Windows in case JVMs are reused. (#679)" Maxim Solodovnik (4): Switching to the next development version Build should be fixed Jackson is updated wicket

[ANNOUNCE] WicketStuff 7.16.0 Released

2020-01-10 Thread Maxim Solodovnik
WicketStuff core 7.16.0 based on Apache Wicket 7.16.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (4): Switching to the next development version Jamon tests are fixed Some dependencies are updated wicketstuff-core-7.16.0

Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
e: > > > > > > > > > > > On Fri, Jan 10, 2020 at 11:02 AM Martin Grigorov > > > > wrote: > > > > > >> > > >> > > >> On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik < > solomax...@gmail.com> > >

Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
`clean package` sounds more reasonable to me :) On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik wrote: > `fast` profile skips javadoc > > On Fri, 10 Jan 2020 at 15:56, Martin Grigorov > wrote: > >> Hi Emond, >> >> Locally while testing new JDK builds

  1   2   3   4   5   6   7   8   >