Re: Migration of jenkins.a.o to cloudbees

2020-08-14 Thread Maxim Solodovnik
AFAIK wicket doesn't use Jenkins

On Fri, 14 Aug 2020 at 19:37, Martijn Dashorst 
wrote:

> Is this something we are aware of, and is this done?
>
> > Tomorrow is the deadline for migrating to ci-builds.a.o and for
> builds.a.o to be turned off.
>
> A script to move builds from one to the other:
>
>
> https://cwiki.apache.org/confluence/display/INFRA/Migrating+Jenkins+jobs+from+Jenkins+to+Cloudbees
>
> Martijn
>


-- 
Best regards,
Maxim


[ANNOUNCE] WicketStuff 7.17.0 Released

2020-07-21 Thread Maxim Solodovnik
WicketStuff core 7.17.0 based on Apache Wicket 7.17.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (4):
  Switching to the next development version
  Fixed issue #690: commons-io is updated
  Dependencies are updated (partially)
  wicketstuff-core 7.17.0 is released


The WicketStuff team


Re: [VOTE] Release Apache Wicket 7.17.0

2020-07-18 Thread Maxim Solodovnik
+1

tested:
- signatures
- build from sources (-Pbuildbot)
- wicketstuff build
- random wicketstuff examples


On Fri, 17 Jul 2020 at 04:38, Andrea Del Bene  wrote:

> This is a vote to release Apache Wicket 7.17.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.17.0
> [ ] No, don't release Apache Wicket 7.17.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
>  https://dist.apache.org/repos/dist/dev/wicket/7.17.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1152/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>  Repository:  g...@github.com:bitstorm/wicket.git
>  Branch:  build/wicket-7.17.0
>  Release tag: rel/wicket-7.17.0
>
>
> 
>
>  The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.17.0.zip:
>
>  -BEGIN PGP SIGNATURE-
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8Qh/kACgkQh48B+qjT
> VuFaKQ//YHutIO2mTuZuWqOsR+B00aTJax372YZsAXB24vERxgrsOXUuKixmxojZ
> Mlx0NbXncIKSO9cAfaklJbn8NpqMp6WNVUJeg5KNxmGVVI4a2ivmZEguTU39xJy8
> 6qYZ5+wOZRNx3owD9Um7OCvb9/osMhL7VkhoUnlH68gFVw/P/Nn9bYVfE5CTc6Tu
> 1HcnaX37YnYPG2jC7fUNHRSw2gYziwWmPLkdXHwgwepjKif1WqKsYuAU+anhpspi
> +K89lQzWBo4/ACjsienuhLaohikZOxzcIwZ1KYk4uvJA1o/3e7+aIt7v98398qBz
> lrCOOe8q07E0l+vMjYHCcnUpCiU69gMWHJKit3prSdmjnfu+D1D+uANFSEQLKRQY
> Y3RAEXw/64xLSKVM10edSpMOqNHcnQdgdPM1aicfNQ61NvWctF4JxYwviq0RF30K
> gBPed86rGBgTT9hL6ZTOEaos6Xk1PzMK55MVKfoNnVNx6s52PC78VWPIpFLXEJbo
> V84uDRWw+OaJ1QnN0GQPNdUFsHRLatKrrt3Nt4VFQpQt9hpjYr+gEmHkitbBWmZq
> V9f02IJ4vb/7Nip/2aDIm0PqSTy7hvJxkU353s6U1a1eCngpNm4TkHbNyNKJic23
> D+Ip2K9ATpBDlT+JUPWKJypv5QdWUC2SP4TrhlmUQvxN7m/goAU=
> =84lr
> -END PGP SIGNATURE-
>
> Signature for apache-wicket-7.17.0.tar.gz:
>
>  -BEGIN PGP SIGNATURE-
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8Qh/gACgkQh48B+qjT
> VuHcJA/8DDoJDGX/q+aBFua2YFor0nPZv73tURLRrSXGpcacH9S/l4xusLg50A6c
> CU5uW23wfvmJSMXy+X0mZdppHlk8hgtt66c8Bj7kuSiCN65Bfvx9VD8b9IP3clhN
> OtVDU/h5lAI5QGDQ68TvXLEfErFWzrsQ/oyIPMi7TSTpqiX0Rrz9CoPHd7Jn1K44
> S/2VFNPheKR9Vq3INkA8bYp++AT/6swIQl/iWIPKh4K3VIE3YNWiaJmRWufb6ue0
> B41GWg2IBWJK06SUJsRtThwrRPEVaVaNDM05idEI2YFhIhGAsP+ZSE0SHVG1WpBy
> CVdhuUiXROjYWJh+rX8JRmffVO51Ycp8YVw4m5TIdnJDlyHnWZjua6an9pucm+Nw
> 5GSAR90zX5T/ZFneKcdpVeWsAq3YikXI68h5smj0auzNiz6Z9fsSu7OIMGcg6cbC
> 6ls71lPpB7cJWCUSMoLfRADk76lvJkMX4xvonxYrgQYY/B41LmIsRfpimAvcM1uU
> CtWF26hkmU3QHpdyVBLQjMt/hRpb3Ocm/MUq/MFvPsYp5i3qw/Z5R10ymx9Ci3D9
> ibW4h/eZg5CGSj0yevCFDNv+usLMuQLwAE2U1Y4uUxR46GBICMTK2zH3tc/5tKqL
> iBaZVmeq0Ohs4/T0IigGfbELS7BEJXIDPgTvV/QYs7cISFqHSa4=
> =rLvh
> -END PGP SIGNATURE-
>
> 
>
>  CHANGELOG for 7.17.0:
>
>
> ** Bug
>
>  * [WICKET-6758] - NPE in AbstractWebSocketProcessor after session
> times out
>  * [WICKET-6764] - RedirectToUrlException change the second question
> mark in URL from "?" to "%3F"
>  * [WICKET-6782] - WebSocket onError/onAbort is not being called
>  * [WICKET-6784] - StockQuote example does not work because the web
> service is no more available
>  * [WICKET-6791] - Offload WebSocket push when initiated in Wicket
> request cycle
>
> ** Improvement
>
>  * [WICKET-6767] - Do not log error for broken pipes in websocket
> connections
>  * [WICKET-6781] - Timezone can be determined on client side (7.x
> and 8.x)
>  * [WICKET-6792] - Packages#absolutePath keeps unnecessary current
> dir dot "."
>  * [WICKET-6800] - Use LinkedHashSet instead of LinkedList for
> AjaxRequestHandler#listeners
>
> ** Task
>
>  * [WICKET-6779] - Upgrade JQuery 3 to 3.5.1
>
>

-- 
Best regards,
Maxim


[ANNOUNCE] WicketStuff 8.9.0 Released

2020-07-18 Thread Maxim Solodovnik
WicketStuff core 8.9.0 based on Apache Wicket 8.9.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (4):
  Switching to the next development version
  Release preparation: dependencies are updated
  Possibly fixes #694: alternative way to resolve class
  wicketstuff-8.9.0 is released


The WicketStuff team


[ANNOUNCE] WicketStuff 9.0.0 Released

2020-07-16 Thread Maxim Solodovnik
WicketStuff core 9.0.0 based on Apache Wicket 9.0.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (6):
  Switching to the next development version
  Merge branch 'master' of github.com:wicketstuff/core
  Tests should be fixed
  Release preparation: dependencies are updated
  Possibly fixes #694: alternative way to resolve class
  Wicketstuff 9.0.0 is released

dependabot[bot] (3):
  Bump ignite-core in /datastores-parent/datastore-ignite (#692)
  Bump log4j.version from 2.13.1 to 2.13.3 (#695)
  Bump log4j-core (#696)

The WicketStuff team


Re: [VOTE] Release Apache Wicket 8.9.0

2020-07-13 Thread Maxim Solodovnik
+1

Tested:
- signatures
- build from sources
- wicketstuff build
- some wicketstuff examples

On Mon, 13 Jul 2020 at 13:18, Sven Meier  wrote:

> +1
>
> checked some examples and sha
>
> Sven
>
>
> On 11.07.20 19:10, Andrea Del Bene wrote:
> > This is a vote to release Apache Wicket 8.9.0
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 8.9.0
> > [ ] No, don't release Apache Wicket 8.9.0, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> > https://dist.apache.org/repos/dist/dev/wicket/8.9.0
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1148/
> >
> > The binaries are available in the above link, as are a staging
> > repository for Maven. Typically the vote is on the source, but should
> > you find a problem with one of the binaries, please let me know, I can
> > re-roll them some way or the other.
> >
> > Staging git repository data:
> >
> > Repository:  g...@github.com:bitstorm/wicket.git
> > Branch:  build/wicket-8.9.0
> > Release tag: rel/wicket-8.9.0
> >
> >
> > 
> >
> > The signatures for the source release artefacts:
> >
> >
> > Signature for apache-wicket-8.9.0.zip:
> >
> > -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8J7WgACgkQh48B+qjT
> > VuEz5w//UdCdkzpwDEWmusPlpU2RyoTv8XPxRWbr3ZKEdeWEw9CJKm4Mz0lJ3RuQ
> > UfJhkl8vraxVPFSXUJidnH6Zrvp7GBOBG/kzSmlP6tuZU0ZmCKCJFUg6OMDfBO5T
> > MU7eDE7oSB0w4FnXkP0YTnTOnAmWu1/kOy4aKgaEtrNcHj0hVt62UdDxgdkZ29l0
> > PuklUCzqJLg4dWWQ52/U1rfqB3XVPCgLY7XTnqcwi/T5f5xo0xLMTfcWyNxvUKHQ
> > v2umt3roDTI0sU6JUEqcimlX4sfz/N/0+hIIx8a7/Kcdh9M1cBwjt7tk9YDOUbJ3
> > leyHqwcMe0iNTpadNr+0n3i5W8ebQf7mRh2JSuPCTWCfbd5LpInYi9FqTHw3pMKU
> > B/z92OvPTUqsJH4g5eCkFRALPjj7E8ehidv/hBNj5EhiBfEIQXLGhvZXY/CtLQOq
> > W3bDgvz4L+RRuyc3TjIwIGDwt5nyocnywweujg2ZFgLllnzeiHkZ926echkri0uA
> > LyfdDFja9p1jkLH7PzPOpEQDnGWkJyVxiZdIc0T3PjQxxC3BpuudI7kSP3WJ29dL
> > yCCRdfGfyAsCZ03LLCy7ieJhf0t8jJGND9k5pS0+35tOQaDUTnFtE93aWf/RSoD3
> > 8TfI891GRWS4AxqxhLwoKHWuAOD3jstq23+J12v1X+kLNspn7Ow=
> > =J8la
> > -END PGP SIGNATURE-
> >
> > Signature for apache-wicket-8.9.0.tar.gz:
> >
> > -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8J7WcACgkQh48B+qjT
> > VuFqEw//ZJhe42SnRdqwPEFHlgkUccDhlJiUb0pk+H0txaTH3+jDf/wuFmeGzfvS
> > mNe+aSE+jOVxSQ8JwJT2Y5AbSldYYyrFZ3xrALeatWkdfoW2WT99MKvjxiNJrLKq
> > XOZVfVPW1EDVNmxBdDSRAlo30mjnPzjjmuTOcf1cti6K4Ix+bdYss6oKx0637tmU
> > WY10XiqvA/6uAnc05wurazVfmbib46sCw1KVA82/pcRIF4wpDv42mRs8+B3tgTBk
> > v1g/Hpe2Ue5UNYKedckdhad/LTNblK/ZGUgFXsbmAlG6eDaFlH2KRRJdpBzUaCpa
> > tGO2LSo70GEb9zovEmQeVj2bKuFmmUA+b1VQDLwPz9e5b27vsNz3VDG7BmaKntB3
> > MWmjnuCjG+IhbVjAfaQjg/zMC4BxIlBVNLrMtphtm7u+6fnBHgYndqcx6vB5DtKd
> > FzfD+JauBNI2xK+C+Ix/Ok9RVTd1Wq9tFw7sjK/GD54AXeSTRrtXrmQLhPSVWGMG
> > CItE8AUTGivy/8Pi6CYtiWJY5gLqaXg2lymqx5DvCXufKBgeNE56pDnLGATRf+ZK
> > 848NTpwHA9uumuscGlQ91T/YL0sZiFkfqzhGyqY4AHCdHfLVRGUuCU6fmE5o7gnm
> > 89bk6vx6RBt34jxqDjuliuFN1jV813ZaPX9QHPxp+58GDkJ6zZM=
> > =WcON
> > -END PGP SIGNATURE-
> >
> > 
> >
> > CHANGELOG for 8.9.0:
> >
> > ** Bug
> >
> > * [WICKET-6742] - Stacktrace in Fragment example
> > * [WICKET-6764] - RedirectToUrlException change the second
> > question mark in URL from "?" to "%3F"
> > * [WICKET-6771] - Performance issues accessing component metadata
> > while iterating
> > * [WICKET-6782] - WebSocket onError/onAbort is not being called
> > * [WICKET-6784] - StockQuote example does not work because the web
> > service is no more available
> > * [WICKET-6791] - Offload WebSocket push when initiated in Wicket
> > request cycle
> > * [WICKET-6793] - OOM in AsynchronousPageStore
> >
> > ** Improvement
> >
> > * [WICKET-6767] - Do not log error for broken pipes in websocket
> > connections
> > * [WICKET-6772] - Use StandardCharset for URL encoding and decoding
> > * [WICKET-6773] - Improve performance of getting behaviors for
> > components
> > * [WICKET-6781] - Timezone can be determined on client side (7.x
> > and 8.x)
> > * [WICKET-6792] - Packages#absolutePath keeps unnecessary current
> > dir dot "."
> > * [WICKET-6796] - Report the component path when failing to set a
> > new object to a read only model
> > * [WICKET-6800] - Use LinkedHashSet instead of LinkedList for
> > AjaxRequestHandler#listeners
> >
> > ** Task
> >
> > * [WICKET-6779] - Upgrade JQuery 3 to 3.5.1
> > * [WICKET-6783] - Utility classes available in JDK should be
> > deprecated/removed
> >
>


-- 
Best regards,
Maxim


Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
signature is Ok now :)

On Fri, 10 Jul 2020 at 00:13, Andrea Del Bene  wrote:

> Hi Maxim,
>
> thanks for spotting this problem. Yesterday when I restarted the
> building using the usual public key
> (D1AE986470B5A49C3E6A27B2878F01FAA8D356E1) I forgot to remove the dev
> repository. I've uploaded the correct content, you should be able to
> verify the signatures now.
>
> On 09/07/20 18:36, Maxim Solodovnik wrote:
> > +1 for release
> >
> > Tested
> > - build from sources
> > - wickestuff build and running some apps
> > - our main app build and run
> >
> > I believe KEYS file need to be updated 
> >
> > On Thu, 9 Jul 2020 at 22:14, Maxim Solodovnik 
> wrote:
> >
> >> Hello Andrea,
> >>
> >> I can't check signature :(
> >> My steps are:
> >> *gpg --import KEYS* ## https://downloads.apache.org/wicket/KEYS
> >> *gpg --verify apache-wicket-9.0.0.tar.gz.asc*
> >> gpg: assuming signed data in 'apache-wicket-9.0.0.tar.gz'
> >> gpg: Signature made Wed 08 Jul 2020 05:37:02 +07
> >> gpg:using RSA key
> B99BE0163901FF80D63FBC59F85E2B099DB18A8C
> >> gpg: Can't check signature: No public key
> >>
> >>
> >> On Thu, 9 Jul 2020 at 21:05, Tobias Soloschenko
> >>  wrote:
> >>
> >>> +1
> >>>
> >>> kind regards
> >>>
> >>> Tobias
> >>>
> >>>> Am 09.07.2020 um 11:44 schrieb Thomas Heigl :
> >>>>
> >>>> Hi,
> >>>>
> >>>> [x] Yes, release Apache Wicket 9.0.0
> >>>>
> >>>> I ran CI tests and manually tested my main application.
> >>>>
> >>>> Best regards,
> >>>>
> >>>> Thomas
> >>>>
> >>>>> On Wed, Jul 8, 2020 at 12:25 PM Andrea Del Bene <
> an.delb...@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>> This is a vote to release Apache Wicket 9.0.0
> >>>>>
> >>>>> Please download the source distributions found in our staging area
> >>>>> linked below.
> >>>>>
> >>>>> I have included the signatures for both the source archives. This
> vote
> >>>>> lasts for 72 hours minimum.
> >>>>>
> >>>>> [ ] Yes, release Apache Wicket 9.0.0
> >>>>> [ ] No, don't release Apache Wicket 9.0.0, because ...
> >>>>>
> >>>>> Distributions, changelog, keys and signatures can be found at:
> >>>>>
> >>>>>  https://dist.apache.org/repos/dist/dev/wicket/9.0.0
> >>>>>
> >>>>> Staging repository:
> >>>>>
> >>>>>
> >>>
> https://repository.apache.org/content/repositories/orgapachewicket-1147/
> >>>>> The binaries are available in the above link, as are a staging
> >>>>> repository for Maven. Typically the vote is on the source, but should
> >>>>> you find a problem with one of the binaries, please let me know, I
> can
> >>>>> re-roll them some way or the other.
> >>>>>
> >>>>> Staging git repository data:
> >>>>>
> >>>>>  Repository:  g...@github.com:bitstorm/wicket.git
> >>>>>  Branch:  build/wicket-9.0.0
> >>>>>  Release tag: rel/wicket-9.0.0
> >>>>>
> >>>>>
> >>>>>
> >>>
> 
> >>>>>  The signatures for the source release artefacts:
> >>>>>
> >>>>>
> >>>>> Signature for apache-wicket-9.0.0.zip:
> >>>>>
> >>>>>  -BEGIN PGP SIGNATURE-
> >>>>>
> >>>>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8FnLsACgkQh48B+qjT
> >>>>> VuGvaBAAsY5f4r/snjzemc3w70Vcu2LkrZFIb0Eu04tpvppvwjuuK5+w51gyBusq
> >>>>> 9AluWISTY1DyguhA1rVGXNqlWs0EhMGOmHa6fAFe7c9cmZnZeaEumk/VSLXg5+/k
> >>>>> fhXWCzxamWK0kZTRHAshzBGKft5LIkoSYgawu75AJlT2ZbQvllV8ju7xf5/XOpAx
> >>>>> +UxxxZ0OrNqw2rwrnnMcxOsVPW69jyxby8vrYN8BdEeDKd/WSB2oXN5cBiDOXH2t
> >>>>> I798u2VT83aIcTOqDbb3pL86RXugYtmek2WbJHiejP/1EVsIohMyS0Ti1c8hLUlg
> >>>>> D7htOLWqUpbxcJ6EThEj4E7StDYBR+L4On4PooOZc6/sorDVATZY8rciqHlfIAK4
> >>>>&g

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
+1 for release

Tested
- build from sources
- wickestuff build and running some apps
- our main app build and run

I believe KEYS file need to be updated 

On Thu, 9 Jul 2020 at 22:14, Maxim Solodovnik  wrote:

> Hello Andrea,
>
> I can't check signature :(
> My steps are:
> *gpg --import KEYS* ## https://downloads.apache.org/wicket/KEYS
> *gpg --verify apache-wicket-9.0.0.tar.gz.asc*
> gpg: assuming signed data in 'apache-wicket-9.0.0.tar.gz'
> gpg: Signature made Wed 08 Jul 2020 05:37:02 +07
> gpg:using RSA key B99BE0163901FF80D63FBC59F85E2B099DB18A8C
> gpg: Can't check signature: No public key
>
>
> On Thu, 9 Jul 2020 at 21:05, Tobias Soloschenko
>  wrote:
>
>> +1
>>
>> kind regards
>>
>> Tobias
>>
>> > Am 09.07.2020 um 11:44 schrieb Thomas Heigl :
>> >
>> > Hi,
>> >
>> > [x] Yes, release Apache Wicket 9.0.0
>> >
>> > I ran CI tests and manually tested my main application.
>> >
>> > Best regards,
>> >
>> > Thomas
>> >
>> >> On Wed, Jul 8, 2020 at 12:25 PM Andrea Del Bene 
>> >> wrote:
>> >>
>> >> This is a vote to release Apache Wicket 9.0.0
>> >>
>> >> Please download the source distributions found in our staging area
>> >> linked below.
>> >>
>> >> I have included the signatures for both the source archives. This vote
>> >> lasts for 72 hours minimum.
>> >>
>> >> [ ] Yes, release Apache Wicket 9.0.0
>> >> [ ] No, don't release Apache Wicket 9.0.0, because ...
>> >>
>> >> Distributions, changelog, keys and signatures can be found at:
>> >>
>> >> https://dist.apache.org/repos/dist/dev/wicket/9.0.0
>> >>
>> >> Staging repository:
>> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachewicket-1147/
>> >>
>> >> The binaries are available in the above link, as are a staging
>> >> repository for Maven. Typically the vote is on the source, but should
>> >> you find a problem with one of the binaries, please let me know, I can
>> >> re-roll them some way or the other.
>> >>
>> >> Staging git repository data:
>> >>
>> >> Repository:  g...@github.com:bitstorm/wicket.git
>> >> Branch:  build/wicket-9.0.0
>> >> Release tag: rel/wicket-9.0.0
>> >>
>> >>
>> >>
>> 
>> >>
>> >> The signatures for the source release artefacts:
>> >>
>> >>
>> >> Signature for apache-wicket-9.0.0.zip:
>> >>
>> >> -BEGIN PGP SIGNATURE-
>> >>
>> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8FnLsACgkQh48B+qjT
>> >> VuGvaBAAsY5f4r/snjzemc3w70Vcu2LkrZFIb0Eu04tpvppvwjuuK5+w51gyBusq
>> >> 9AluWISTY1DyguhA1rVGXNqlWs0EhMGOmHa6fAFe7c9cmZnZeaEumk/VSLXg5+/k
>> >> fhXWCzxamWK0kZTRHAshzBGKft5LIkoSYgawu75AJlT2ZbQvllV8ju7xf5/XOpAx
>> >> +UxxxZ0OrNqw2rwrnnMcxOsVPW69jyxby8vrYN8BdEeDKd/WSB2oXN5cBiDOXH2t
>> >> I798u2VT83aIcTOqDbb3pL86RXugYtmek2WbJHiejP/1EVsIohMyS0Ti1c8hLUlg
>> >> D7htOLWqUpbxcJ6EThEj4E7StDYBR+L4On4PooOZc6/sorDVATZY8rciqHlfIAK4
>> >> rTh0S1UAe8QGwtFxYZ03BCaIIqh4BLVF4O3xtdo9YtPUAmXlfE9OIAWASpZ7nTLT
>> >> oZZAwdSklHZSsHglRdIeAr0whOstG02NrKRnZ9+RD4Gn/rDyTHCQCBkREFW7qlsT
>> >> 8CqCja3rU22YA/BsyesoUlE8U+JD8coIDhFhPEsy6EWKwmos//USI0NVCO3FRysd
>> >> TtF/NaG0YK1q+dhN4PZv63MQ78DiTh3dw1gfR6lmKal+Cu2qGpj+oZZE9hVK5uh5
>> >> +gV4bvFANwltrW9b0G0KnNl5YDJHbEYmK0G0WoLHuGnLmP7Itpc=
>> >> =TQeK
>> >> -END PGP SIGNATURE-
>> >>
>> >> Signature for apache-wicket-9.0.0.tar.gz:
>> >>
>> >> -BEGIN PGP SIGNATURE-
>> >>
>> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8FnLsACgkQh48B+qjT
>> >> VuHGiw//cp5/72mWU7I/OJ/v5xz6Tc+rwJUSKEYUigIgyVIwxpjaBKlq+KjM2Fvv
>> >> 9PdYh3utP1lVBDWPt8bSAsLDXKgiMR8tVvOluZ0BHPM5HIX4lk1iw1qpsCY/Xhpp
>> >> L5Z6oS80vHvhE2AdSsJK0PxMA+VmzIqSGnQoed/0EKHvNCNgFhdh2n4k1Of+C75o
>> >> Y9d5HFQYQtzmyzz6uRlgOX6WGGn7A2r5rVxa6SrNyDcBf+8WilHTh+ocI199nQ6T
>> >> LZYaXDhCY7QQ1YSGxHYB5frMgR1HxDMD8hNEjDU4ejbB276XEWnuWZkzvTsQ6Hrl
>> >> y3DxFwyUXx9tNOaYXzqGQH/F/X89kCnbupwGnHFsg5wIGox3EEaiuqRi/2dC60t7
>> >> 3Jg5Tj+4/dA+Qe6mI8bFy656rO5hVefSJ1CTC+LzbRqSqk59M4

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-09 Thread Maxim Solodovnik
Hello Andrea,

I can't check signature :(
My steps are:
*gpg --import KEYS* ## https://downloads.apache.org/wicket/KEYS
*gpg --verify apache-wicket-9.0.0.tar.gz.asc*
gpg: assuming signed data in 'apache-wicket-9.0.0.tar.gz'
gpg: Signature made Wed 08 Jul 2020 05:37:02 +07
gpg:using RSA key B99BE0163901FF80D63FBC59F85E2B099DB18A8C
gpg: Can't check signature: No public key


On Thu, 9 Jul 2020 at 21:05, Tobias Soloschenko
 wrote:

> +1
>
> kind regards
>
> Tobias
>
> > Am 09.07.2020 um 11:44 schrieb Thomas Heigl :
> >
> > Hi,
> >
> > [x] Yes, release Apache Wicket 9.0.0
> >
> > I ran CI tests and manually tested my main application.
> >
> > Best regards,
> >
> > Thomas
> >
> >> On Wed, Jul 8, 2020 at 12:25 PM Andrea Del Bene 
> >> wrote:
> >>
> >> This is a vote to release Apache Wicket 9.0.0
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 9.0.0
> >> [ ] No, don't release Apache Wicket 9.0.0, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >> https://dist.apache.org/repos/dist/dev/wicket/9.0.0
> >>
> >> Staging repository:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachewicket-1147/
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >> Repository:  g...@github.com:bitstorm/wicket.git
> >> Branch:  build/wicket-9.0.0
> >> Release tag: rel/wicket-9.0.0
> >>
> >>
> >> 
> >>
> >> The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-9.0.0.zip:
> >>
> >> -BEGIN PGP SIGNATURE-
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8FnLsACgkQh48B+qjT
> >> VuGvaBAAsY5f4r/snjzemc3w70Vcu2LkrZFIb0Eu04tpvppvwjuuK5+w51gyBusq
> >> 9AluWISTY1DyguhA1rVGXNqlWs0EhMGOmHa6fAFe7c9cmZnZeaEumk/VSLXg5+/k
> >> fhXWCzxamWK0kZTRHAshzBGKft5LIkoSYgawu75AJlT2ZbQvllV8ju7xf5/XOpAx
> >> +UxxxZ0OrNqw2rwrnnMcxOsVPW69jyxby8vrYN8BdEeDKd/WSB2oXN5cBiDOXH2t
> >> I798u2VT83aIcTOqDbb3pL86RXugYtmek2WbJHiejP/1EVsIohMyS0Ti1c8hLUlg
> >> D7htOLWqUpbxcJ6EThEj4E7StDYBR+L4On4PooOZc6/sorDVATZY8rciqHlfIAK4
> >> rTh0S1UAe8QGwtFxYZ03BCaIIqh4BLVF4O3xtdo9YtPUAmXlfE9OIAWASpZ7nTLT
> >> oZZAwdSklHZSsHglRdIeAr0whOstG02NrKRnZ9+RD4Gn/rDyTHCQCBkREFW7qlsT
> >> 8CqCja3rU22YA/BsyesoUlE8U+JD8coIDhFhPEsy6EWKwmos//USI0NVCO3FRysd
> >> TtF/NaG0YK1q+dhN4PZv63MQ78DiTh3dw1gfR6lmKal+Cu2qGpj+oZZE9hVK5uh5
> >> +gV4bvFANwltrW9b0G0KnNl5YDJHbEYmK0G0WoLHuGnLmP7Itpc=
> >> =TQeK
> >> -END PGP SIGNATURE-
> >>
> >> Signature for apache-wicket-9.0.0.tar.gz:
> >>
> >> -BEGIN PGP SIGNATURE-
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl8FnLsACgkQh48B+qjT
> >> VuHGiw//cp5/72mWU7I/OJ/v5xz6Tc+rwJUSKEYUigIgyVIwxpjaBKlq+KjM2Fvv
> >> 9PdYh3utP1lVBDWPt8bSAsLDXKgiMR8tVvOluZ0BHPM5HIX4lk1iw1qpsCY/Xhpp
> >> L5Z6oS80vHvhE2AdSsJK0PxMA+VmzIqSGnQoed/0EKHvNCNgFhdh2n4k1Of+C75o
> >> Y9d5HFQYQtzmyzz6uRlgOX6WGGn7A2r5rVxa6SrNyDcBf+8WilHTh+ocI199nQ6T
> >> LZYaXDhCY7QQ1YSGxHYB5frMgR1HxDMD8hNEjDU4ejbB276XEWnuWZkzvTsQ6Hrl
> >> y3DxFwyUXx9tNOaYXzqGQH/F/X89kCnbupwGnHFsg5wIGox3EEaiuqRi/2dC60t7
> >> 3Jg5Tj+4/dA+Qe6mI8bFy656rO5hVefSJ1CTC+LzbRqSqk59M4DWMeyMXoS3e/lW
> >> TZV0/3rP0nAixDzlgsB/j77KNmIa/hX+SKdJbMzbII/hP4qJAgqtwO4qntMgTuD6
> >> WqW3Qq7Fm+2TH/bLGbKDx1qu6TVUkBGimkwFc+EzeCpMOlCYXibqKyGYQtEVijGU
> >> o0MeybEDpzvScL6fBJiHHMiVUN2JsXTqI/wti/FTzqnxCj3SW/WHjFluJlsE5B2M
> >> XJgr6QE3aZ6Xz4erfJ6oJRq7joxPkKaaxefJmki4jYwP0XWiNVs=
> >> =sMh2
> >> -END PGP SIGNATURE-
> >>
> >> 
> >>
> >> CHANGELOG for 9.0.0:
> >>
> >>
> >> ** Bug
> >>
> >> * [WICKET-6742] - Stacktrace in Fragment example
> >> * [WICKET-6764] - RedirectToUrlException change the second question
> >> mark in URL from "?" to "%3F"
> >> * [WICKET-6768] - TagTester#createTagsByAttribute() cannot find
> >> hidden elements
> >> * [WICKET-6771] - Performance issues accessing component metadata
> >> while iterating
> >> * [WICKET-6782] - WebSocket onError/onAbort is not being called
> >> * [WICKET-6784] - StockQuote example does not work because the web
> >> service is no more available
> >> * [WICKET-6791] - Offload WebSocket push when initiated in Wicket
> >> request cycle
> >> * [WICKET-6793] - OOM in AsynchronousPageStore
> >>
> >> ** Improvement
> >>
> >> * [WICKET-5406] - Better Content Security Policy Support
> >> * [WICKET-6763] - SelectOptions unnecessary complicated markup
> >> * [WICKET-6766] - Keep page ids in tests like 

Re: Release Wicket 9.0.0?

2020-06-09 Thread Maxim Solodovnik
+1 :)

On Tue, 9 Jun 2020 at 15:36, Thomas Heigl  wrote:

> Hi all,
>
> I merged my last open PR yesterday and it looks like there are no other
> open issues or PRs.
>
> Since there was a consensus to release already at the end of April, I'd
> like to bring this up again. Should we release 9.0.0?
>
> Alternatively, we could do a last milestone (there are 25 issues resolved
> for M6) and I can test it in production for a couple of days before we
> release 9.0.0.
>
> Best regards,
>
> Thomas
>


-- 
Best regards,
Maxim


Re: Contribution - CSP support for Wicket

2020-06-04 Thread Maxim Solodovnik
+1

On Fri, 5 Jun 2020 at 10:17, Tobias Soloschenko
 wrote:

> Hi,
>
> to my opinion they just want to contribute to Wicket. I would simply
> explain how the process of contribution works at ASF (PRs, etc.) and give
> them some information what challenges we were faced with till now.
>
> kind regards
>
> Tobias
>
> > Am 05.06.2020 um 02:18 schrieb Andrew Kondratev :
> >
> > Hi colleagues! I just received this email. Not sure what this all means.
> >
> > -- Forwarded message -
> > От: Santiago Díaz 
> > Date: чт, 4 июн. 2020 г. в 21:47
> > Subject: Contribution - CSP support for Wicket
> > To: 
> >
> >
> > Hello Andrew,
> >
> > My name is Santiago, I'm a Security Engineer at Google. I am currently
> > making preparations to receive a small group of interns for this summer's
> > Google internships and found your email during the course of my research.
> >
> > *Context*
> > Here at Google we have a lot of experience deploying security mechanisms
> > (like Content Security Policy, Trusted Types, Fetch Metadata,
> Cross-Origin
> > Opener Policy and others) at scale. We understand the pains of designing
> > strong security policies, finding blockers for their deployment and
> > locating pieces of code that need refactoring.
> >
> > *Why are you receiving this email?*
> > For this year's internships (and considering the current global
> situation)
> > we would like to contribute to selected open source projects, bringing
> some
> > of our experience to *encourage adoption of some of these security
> > enhancements*. Wicket is one of the projects we have shortlisted and we'd
> > be happy to collaborate with you!
> >
> > I found out that there is an ongoing discussion over at
> > https://issues.apache.org/jira/browse/WICKET-5406 to improve CSP
> support in
> > Wicket and that *you have been running some experiments on what that
> would
> > look like*.
> >
> > Having said that, it would be great if we could boost your work instead
> of
> > reinventing the wheel. As such, I would like to know if you'd be open to
> > our contributions and if so, whether you'd be willing to give me some
> > context on what has been done, what issues you've come across and whether
> > you have any thoughts on what would be the best way for us to contribute.
> >
> > Thank you for reading and I'm looking forward to hearing from you! :)
> >
> > S.
>


-- 
Best regards,
Maxim


Re: 'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Emond,

I'll create PR :)

Sorry I misspelled your name :(

(from mobile, sorry for typos)

On Sun, May 24, 2020, 21:31 Maxim Solodovnik  wrote:

> Hello Edmond,
>
> It seems 'base-uri' directive [1] is missing is "enum CSPDirective"
> Is it on purpose?
>
> One of our users check current rules using some validator [2]
>
> [1]
> https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri
> [2]
> https://issues.apache.org/jira/browse/OPENMEETINGS-2370?focusedCommentId=17114589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17114589
>
> --
> Best regards,
> Maxim
>


'base-uri' CSP directive is missing

2020-05-24 Thread Maxim Solodovnik
Hello Edmond,

It seems 'base-uri' directive [1] is missing is "enum CSPDirective"
Is it on purpose?

One of our users check current rules using some validator [2]

[1]
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri
[2]
https://issues.apache.org/jira/browse/OPENMEETINGS-2370?focusedCommentId=17114589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17114589

-- 
Best regards,
Maxim


Re: [ANNOUNCE] New Committer - Thomas Heigl

2020-05-22 Thread Maxim Solodovnik
Welcome!

On Sat, 23 May 2020 at 03:52, Tobias Soloschenko
 wrote:

> Welcome Thomas! :-)
>
> kind regards
>
> Tobias
>
> > Am 22.05.2020 um 21:08 schrieb Andrea Del Bene :
> >
> > The Apache Wicket team is happy to announce that Thomas Heigl has been
> voted in as a committer on Apache Wicket and also as a PMC member of the
> project! Thomas is an active member of the Wicket community since 2011 and
> lately has greatly contributed fixing bugs and providing ideas and pull
> requests to improve Wicket performance.
> >
> > We're looking forward to working with Thomas in the near future, so
> please join us in welcoming him to our project!
> >
> > Andrea Del Bene
> > Apache Wicket PMC chair.
> >
>


-- 
Best regards,
Maxim


Re: ConcurrentHashSet to be removed from wicket code base

2020-05-07 Thread Maxim Solodovnik
Hello Martijn,

On Thu, 7 May 2020 at 19:02, Martijn Dashorst 
wrote:

> IIRC Micromap was created for serialization and memory efficiency. Has that
> changed?
>

>From what I can see using "so to declaration" in JDK11
Map.of(key, value) returns

static final class Map1 extends AbstractImmutableMap {
@Stable
private final K k0;
@Stable
private final V v0;
...

Which seems to be the same as we have now 


>
> Martijn
>
> On Wed, May 6, 2020 at 2:18 PM Maxim Solodovnik 
> wrote:
>
> > MicroMap can easily be replaced with Map.of(key, value)
> >
> > I can deprecate it for wicket9 in same PR, should I?
> >
> > On Wed, 6 May 2020 at 18:06, Maxim Solodovnik 
> > wrote:
> >
> > > I would propose to remove it in Wicket9, but don't want to slow down
> the
> > > release :)
> > > Will create PR :)
> > >
> > > On Wed, 6 May 2020 at 17:56, Andrea Del Bene 
> > wrote:
> > >
> > >> +1 to replace it with ConcurrentHashMap.newKeySet()
> > >>
> > >> On 06/05/20 12:53, Martijn Dashorst wrote:
> > >> > I'd go further and deprecate it in wicket 8 as well... Since the
> > >> > replacement is in Java 8.
> > >> >
> > >> > I would be +1 on removing it from Wicket 9 final if it came to a
> vote.
> > >> It
> > >> > is not a core class in Wicket, it was not supposed to be used widely
> > >> > (mostly for our internal stuff), and would make it clear that when
> in
> > >> > doubt: use the JDK provided one.
> > >> >
> > >> > Martijn
> > >> >
> > >> >
> > >> > On Wed, May 6, 2020 at 12:36 PM Martin Grigorov <
> mgrigo...@apache.org
> > >
> > >> > wrote:
> > >> >
> > >> >> On Wed, May 6, 2020 at 1:20 PM Maxim Solodovnik <
> > solomax...@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >>> Hello All,
> > >> >>>
> > >> >>> ConcurrentHashSet can be safely removed from wicket codebase due
> to
> > >> >>> since Java8 it is possible to use ConcurrentHashMap.newKeySet()
> > >> >>>
> > >> >>> Can we @deprecate in in wicket9 and remove in Wicket10?
> > >> >>>
> > >> >> +1
> > >> >>
> > >> >>
> > >> >>> --
> > >> >>> Best regards,
> > >> >>> Maxim
> > >> >>>
> > >> >
> > >>
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>


-- 
Best regards,
Maxim


Re: ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
MicroMap can easily be replaced with Map.of(key, value)

I can deprecate it for wicket9 in same PR, should I?

On Wed, 6 May 2020 at 18:06, Maxim Solodovnik  wrote:

> I would propose to remove it in Wicket9, but don't want to slow down the
> release :)
> Will create PR :)
>
> On Wed, 6 May 2020 at 17:56, Andrea Del Bene  wrote:
>
>> +1 to replace it with ConcurrentHashMap.newKeySet()
>>
>> On 06/05/20 12:53, Martijn Dashorst wrote:
>> > I'd go further and deprecate it in wicket 8 as well... Since the
>> > replacement is in Java 8.
>> >
>> > I would be +1 on removing it from Wicket 9 final if it came to a vote.
>> It
>> > is not a core class in Wicket, it was not supposed to be used widely
>> > (mostly for our internal stuff), and would make it clear that when in
>> > doubt: use the JDK provided one.
>> >
>> > Martijn
>> >
>> >
>> > On Wed, May 6, 2020 at 12:36 PM Martin Grigorov 
>> > wrote:
>> >
>> >> On Wed, May 6, 2020 at 1:20 PM Maxim Solodovnik 
>> >> wrote:
>> >>
>> >>> Hello All,
>> >>>
>> >>> ConcurrentHashSet can be safely removed from wicket codebase due to
>> >>> since Java8 it is possible to use ConcurrentHashMap.newKeySet()
>> >>>
>> >>> Can we @deprecate in in wicket9 and remove in Wicket10?
>> >>>
>> >> +1
>> >>
>> >>
>> >>> --
>> >>> Best regards,
>> >>> Maxim
>> >>>
>> >
>>
>
>
> --
> Best regards,
> Maxim
>


-- 
Best regards,
Maxim


Re: ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
I would propose to remove it in Wicket9, but don't want to slow down the
release :)
Will create PR :)

On Wed, 6 May 2020 at 17:56, Andrea Del Bene  wrote:

> +1 to replace it with ConcurrentHashMap.newKeySet()
>
> On 06/05/20 12:53, Martijn Dashorst wrote:
> > I'd go further and deprecate it in wicket 8 as well... Since the
> > replacement is in Java 8.
> >
> > I would be +1 on removing it from Wicket 9 final if it came to a vote. It
> > is not a core class in Wicket, it was not supposed to be used widely
> > (mostly for our internal stuff), and would make it clear that when in
> > doubt: use the JDK provided one.
> >
> > Martijn
> >
> >
> > On Wed, May 6, 2020 at 12:36 PM Martin Grigorov 
> > wrote:
> >
> >> On Wed, May 6, 2020 at 1:20 PM Maxim Solodovnik 
> >> wrote:
> >>
> >>> Hello All,
> >>>
> >>> ConcurrentHashSet can be safely removed from wicket codebase due to
> >>> since Java8 it is possible to use ConcurrentHashMap.newKeySet()
> >>>
> >>> Can we @deprecate in in wicket9 and remove in Wicket10?
> >>>
> >> +1
> >>
> >>
> >>> --
> >>> Best regards,
> >>> Maxim
> >>>
> >
>


-- 
Best regards,
Maxim


ConcurrentHashSet to be removed from wicket code base

2020-05-06 Thread Maxim Solodovnik
Hello All,

ConcurrentHashSet can be safely removed from wicket codebase due to
since Java8 it is possible to use ConcurrentHashMap.newKeySet()

Can we @deprecate in in wicket9 and remove in Wicket10?

-- 
Best regards,
Maxim


Re: Time to release 9.0.0 ?

2020-04-30 Thread Maxim Solodovnik
+1
let's release final version :)

On Thu, 30 Apr 2020 at 14:40, Martin Grigorov  wrote:
>
> Hi team,
>
> Few weeks have passed since Wicket 9.0.0-M5 and there are no stopper issues
> being reported.
> Let's release 9.0.0!
>
> I see few of you discuss refactoring some pretty critical area (from
> performance PoV) of Wicket - the Component state, and suggesting some
> bigger refactoring. I'd like this refactoring to be left for a later
> release. If there are no API breaks it could be 9.0.1 but if there will API
> breaks then it will have to wait for Wicket 10.
>
> WDYT ?
>
> Martin



-- 
Best regards,
Maxim


[ANNOUNCE] WicketStuff 8.8.0 Released

2020-04-29 Thread Maxim Solodovnik
WicketStuff core 8.8.0 based on Apache Wicket 8.8.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (3):
  Switching to the next development version
  Dependencies and plugins are updated
  wicketstuff 8.8.0 is released

The WicketStuff team


Re: wicket-bootstrap date-time-picker

2020-04-28 Thread Maxim Solodovnik
Done
https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/860

Thanks :)

On Tue, 28 Apr 2020 at 12:00, Martin Grigorov  wrote:
>
> Hi Maxim,
>
> On Mon, Apr 27, 2020 at 6:28 PM Maxim Solodovnik 
> wrote:
>
> > Hello Martin,
> >
> > I found some weird behavior of bootstrap-date-time-picker
> > It seems `date` option
> > https://tempusdominus.github.io/bootstrap-4/Options/#date
> > need to be provided if `maxDate`
> > https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate
> > was specified
> >
> > (otherwise current date will be displayed regardless of Model value...)
> >
> > How do you think would it be OK to add additional `IKey` here
> >
> > https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/wicket-9.x-bootstrap-4.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/datetime/DatetimePickerConfig.java#L67
> > (with setters)
> >
> > Or any other changes are required?
> >
>
> Please add any missing options you need!
> Thank you!
>
> Martin
>
>
> >
> >
> > --
> > Best regards,
> > Maxim
> >



-- 
Best regards,
Maxim


wicket-bootstrap date-time-picker

2020-04-27 Thread Maxim Solodovnik
Hello Martin,

I found some weird behavior of bootstrap-date-time-picker
It seems `date` option
https://tempusdominus.github.io/bootstrap-4/Options/#date
need to be provided if `maxDate`
https://tempusdominus.github.io/bootstrap-4/Options/#minmaxdate
was specified

(otherwise current date will be displayed regardless of Model value...)

How do you think would it be OK to add additional `IKey` here
https://github.com/l0rdn1kk0n/wicket-bootstrap/blob/wicket-9.x-bootstrap-4.x/bootstrap-extensions/src/main/java/de/agilecoders/wicket/extensions/markup/html/bootstrap/form/datetime/DatetimePickerConfig.java#L67
(with setters)

Or any other changes are required?


-- 
Best regards,
Maxim


Re: 8.x release?....TAKE 2! :-)

2020-04-18 Thread Maxim Solodovnik
<=2

On Sat, 18 Apr 2020 at 22:29, Andrea Del Bene  wrote:

> I think we can proceed releasing also 8.8.0 version. This is the current
> changelog:
>
>
> bug
>
>   * [WICKET-6746 ] -
> HttpsMapper cannot deal with resources over websockets
>   * [WICKET-6752 ] -
> Some dependencies contain CVEs
>   * [WICKET-6753 ] -
> res/modal.js using aria-labelledby where it should be using aria-label
>   * [WICKET-6754 ] -
> Iteration stops with nested containers
>   * [WICKET-6755 ] -
> MockServletContext does not decode real path
>   * [WICKET-6756 ] -
> Avoid URL.getFile() when actually expecting paths.
>   * [WICKET-6757 ] -
> Avoid URL.getFile during mime type detection.
>   * [WICKET-6758 ] -
> NPE in AbstractWebSocketProcessor after session times out
>
>
> Improvement
>
>   * [WICKET-6759 ] -
> Support disabling error notification for websockets
>   * [WICKET-6760 ] -
> Nested Form placeholder should preserve tag name
>   * [WICKET-6761 ] -
> Support multiple connections to the same websocket resource from a
> single session
>   * [WICKET-6762 ] -
> Support manual initialization of websocket connections
>
>

-- 
Best regards,
Maxim


Re: 8.x release?....TAKE 2! :-)

2020-04-18 Thread Maxim Solodovnik
I mean +1
Sorry, fat fingers :)

On Sat, 18 Apr 2020 at 23:04, Maxim Solodovnik  wrote:

> <=2
>
> On Sat, 18 Apr 2020 at 22:29, Andrea Del Bene 
> wrote:
>
>> I think we can proceed releasing also 8.8.0 version. This is the current
>> changelog:
>>
>>
>> bug
>>
>>   * [WICKET-6746 <https://issues.apache.org/jira/browse/WICKET-6746>] -
>> HttpsMapper cannot deal with resources over websockets
>>   * [WICKET-6752 <https://issues.apache.org/jira/browse/WICKET-6752>] -
>> Some dependencies contain CVEs
>>   * [WICKET-6753 <https://issues.apache.org/jira/browse/WICKET-6753>] -
>> res/modal.js using aria-labelledby where it should be using aria-label
>>   * [WICKET-6754 <https://issues.apache.org/jira/browse/WICKET-6754>] -
>> Iteration stops with nested containers
>>   * [WICKET-6755 <https://issues.apache.org/jira/browse/WICKET-6755>] -
>> MockServletContext does not decode real path
>>   * [WICKET-6756 <https://issues.apache.org/jira/browse/WICKET-6756>] -
>> Avoid URL.getFile() when actually expecting paths.
>>   * [WICKET-6757 <https://issues.apache.org/jira/browse/WICKET-6757>] -
>> Avoid URL.getFile during mime type detection.
>>   * [WICKET-6758 <https://issues.apache.org/jira/browse/WICKET-6758>] -
>> NPE in AbstractWebSocketProcessor after session times out
>>
>>
>> Improvement
>>
>>   * [WICKET-6759 <https://issues.apache.org/jira/browse/WICKET-6759>] -
>> Support disabling error notification for websockets
>>   * [WICKET-6760 <https://issues.apache.org/jira/browse/WICKET-6760>] -
>> Nested Form placeholder should preserve tag name
>>   * [WICKET-6761 <https://issues.apache.org/jira/browse/WICKET-6761>] -
>> Support multiple connections to the same websocket resource from a
>> single session
>>   * [WICKET-6762 <https://issues.apache.org/jira/browse/WICKET-6762>] -
>> Support manual initialization of websocket connections
>>
>>
>
> --
> Best regards,
> Maxim
>


-- 
Best regards,
Maxim


Re: CSP regression

2020-04-16 Thread Maxim Solodovnik
Hello All,

Recently found limitation of current CSP implementation [1]

Note: connect-src 'self' does not resolve to websocket schemas in all
browsers, more info: https://github.com/w3c/webappsec-csp/issues/7

I believe this should be addressed or at least documented
(Seems to fail in Safari only)

I'm going to workaround this in our source code

[1]
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/connect-src


On Wed, 25 Mar 2020 at 18:07, Maxim Solodovnik  wrote:

> Hello All,
>
> it seem it was false alarm
> sorry for the noise :(
>
> On Tue, 24 Mar 2020 at 15:19, Maxim Solodovnik 
> wrote:
>
>> Hmmm,
>>
>> I'll check.
>> The errors are definitely in DevTools (I'm using report-only CSP)
>> Not sure if it is first or second time
>> Will double-check and report back
>>
>> On Tue, 24 Mar 2020 at 15:17, Emond Papegaaij 
>> wrote:
>> >
>> > Hi Maxim,
>> >
>> > Are you sure? I just tried the examples and CSS resources do have
>> > nonces. Maybe you're seeing the same errors as I when opening the dev
>> > tools? Somehow Chrome is unable to load the css resources in the dev
>> > tools when the dev tools are opened after loading the page. After a
>> > refresh, it's fine again.
>> >
>> > Emond
>> >
>> > On Tue, Mar 24, 2020 at 8:53 AM Maxim Solodovnik 
>> wrote:
>> > >
>> > > Hello All,
>> > >
>> > > just found regression with CSP
>> > > nonce for CSS resources seems to be not added, which results security
>> errors
>> > > Can it be caused by latest code optimizations?
>> > >
>> > > --
>> > > WBR
>> > > Maxim aka solomax
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
> --
> WBR
> Maxim aka solomax
>


-- 
Best regards,
Maxim


[ANNOUNCE] WicketStuff 9.0.0-M5.1 Released

2020-04-08 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M5.1 based on Apache Wicket 9.0.0-M5 is released
and soon will be available at Maven Central!

Unfortunately WicketStuff core 9.0.0-M5 is broken, please use this
release instead

The changelog is:

Maxim Solodovnik (12):
  Switching to the next development version
  Inline styles are removed
  Merge branch 'master' of github.com:wicketstuff/core
  Tests should be fixed
  wicket-datetime tests are fixed
  Minor changes in CSS style ID and spacing
  Merge branch 'master' of github.com:wicketstuff/core
  Tests should be fixed
  Dependencies and plugins are updated
  Select2 is updated, CSP disabled for some examples
  Some CSP improvements
  WicketStuff 9.0.0-M5.1 is released

Sven Meier (2):
  DelegatedPage is stored in session
  SessionQuotaManagingDataStore can be asynchronous

Andrea Del Bene (1):
  Update readme.md

renoth (1):
  #688 Select2 Settings should honor default (#689)

The WicketStuff team


[ANNOUNCE] WicketStuff 9.0.0-M5 Released

2020-04-07 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M5 based on Apache Wicket 9.0.0-M5 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (12):
  Switching to the next development version
  Inline styles are removed
  Merge branch 'master' of github.com:wicketstuff/core
  Tests should be fixed
  wicket-datetime tests are fixed
  Minor changes in CSS style ID and spacing
  Merge branch 'master' of github.com:wicketstuff/core
  Tests should be fixed
  Dependencies and plugins are updated
  Select2 is updated, CSP disabled for some examples
  Some CSP improvements
  wicketstuff-core-9.0.0-M5 is released

Andrea Del Bene (1):
  Update readme.md

renoth (1):
  #688 Select2 Settings should honor default (#689)

The WicketStuff team


Re: Wicketstuff M5 release

2020-04-07 Thread Maxim Solodovnik
Thanks Martin,

will start release process :)
Some additional improvements can be added in next release :))

On Tue, 7 Apr 2020 at 19:34, Martin Grigorov  wrote:

> Hi Maxim,
>
> I'm OK to release as is!
>
> Otherwise you/we can just add the disable line to each and every
> Application class in the examples, without bothering to test whether it is
> needed or not.
>
> Martin
>
> On Tue, Apr 7, 2020 at 3:14 PM Maxim Solodovnik 
> wrote:
>
> > Hello All,
> >
> > I'm working at wicketstuff release, and trying to check examples
> > It seems many of them are broken regardless of CSP :(
> > Shall I continue to check example by example and disable CSP for most of
> > them
> > WDYT would it be OK to release as is?
> >
> > --
> > Best regards,
> > Maxim
> >
>


-- 
Best regards,
Maxim


Wicketstuff M5 release

2020-04-07 Thread Maxim Solodovnik
Hello All,

I'm working at wicketstuff release, and trying to check examples
It seems many of them are broken regardless of CSP :(
Shall I continue to check example by example and disable CSP for most of
them
WDYT would it be OK to release as is?

-- 
Best regards,
Maxim


Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-05 Thread Maxim Solodovnik
Hello Sebastien,

to bypass
Content Security Policy: The page’s settings blocked the loading of a
resource at inline (“style-src”). 2 jquery-3.4.1-ver-1586053743308.js
:4817:39

I have added log-point to this line and print all `elem` to console
these errors are caused by Ajax updates
`elem` usually contains elements with inline style attributes

On Sun, 5 Apr 2020 at 13:41, Sebastien Briquet  wrote:

> Hi,
>
> I'm currently testing M5 against Wicket JQuery UI / Wicket Kendo UI.
> With CSP disabled, it seems to work as expected!
>
> I'm upgrading the sample application to make it work with CSP enabled. So
> far it works (even not yet complete), but some things seems to be out of my
> hands, like:
>
> Content Security Policy: The page’s settings blocked the loading of a
> resource at inline (“style-src”). 2 jquery-3.4.1-ver-1586053743308.js
> :4817:39
> <
> http://localhost:8080/wicket-jquery-ui/wicket/resource/org.apache.wicket.resource.JQueryResourceReference/jquery/jquery-3.4.1-ver-1586053743308.js
> >
>
> It seems to come from the bundled jQuery, here is the line:
> tmp = getAll( fragment.appendChild( elem ), "script" );
>
> The CSP error seems legit, but I don't know how we can circumvent it (did
> not investigate yet)... I do have few others but I need to double check if
> it comes from my jQuery usage or not...
>
> Anyway, I think it is good enough to release this Milestone so users can
> test and report before the Final.
> [x] Yes, release Apache Wicket 9.0.0-M5
>
> Thanks for the big work!
> Sebastien
>


-- 
Best regards,
Maxim


Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-02 Thread Maxim Solodovnik
+1

On Thu, Apr 2, 2020, 18:23 Martin Grigorov  wrote:

> +1
>
> On Thu, Apr 2, 2020 at 12:43 PM Andrea Del Bene 
> wrote:
>
> > This is a vote to release Apache Wicket 9.0.0-M5
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 9.0.0-M5
> > [ ] No, don't release Apache Wicket 9.0.0-M5, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> >  https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M5
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1141/
> >
> > The binaries are available in the above link, as are a staging
> > repository for Maven. Typically the vote is on the source, but should
> > you find a problem with one of the binaries, please let me know, I can
> > re-roll them some way or the other.
> >
> > Staging git repository data:
> >
> >  Repository:  g...@github.com:bitstorm/wicket.git
> >  Branch:  build/wicket-9.0.0-M5
> >  Release tag: rel/wicket-9.0.0-M5
> >
> >
> > 
> >
> >  The signatures for the source release artefacts:
> >
> >
> > Signature for apache-wicket-9.0.0-M5.zip:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6FsXoACgkQh48B+qjT
> > VuEZiA//fgy42gNrnUBO6Cbs6ZvJwzMLURlVuD/mrHZx5iLgnr7p9qgJzEZSfdF/
> > U0JPztMq6/crgi+aXPCjxzKdnGNlu665g3Xxyc3dr+N8psoWptGsBREBTtynQU2n
> > Pu9ir1THAE9qdr4MbqRZbH5wQGklPnLTfoTV6BS0HK4mmPCblK7eYBZlz7QnbOAL
> > MwuShMRLZ0phKZ3rwXFSJcWoZGyx6cmHPjs04VJkCdbtcOwBMNIzoU5CgbShvVt9
> > eXobPkOniJ2Ijr/B1ROVMrFOC7uduJilFj2dk+icZZgrO6177pDO57bX1It3Ts3J
> > UbOJKdtBIHMD9XNe1ANPodMMwxA5Q0hUpjsehPqZVFgYpEfHxyPENVkjlabqHOt/
> > 8ySL79MfOGzckNPUrR16HS0RTrBjsSrLnif5bHcaFyIg6UL0RrdOlJaI6CU01V/Y
> > zPBtI3Dm1R4acUCrU08nScoeR+uS7F6oTSQD2X+pEsBG6euX0q1fV4HhtVQSRIFU
> > pSrSAavkQjUL0tl6ik8HeGOlMFXT66U0Q6gnI/KmxcHZAroWU6j2qvYOcfawIEkw
> > qZfgo0ZnJN4/VxAl51+On64LkaxpCCBCh8+yZ2DW7efcKDWElXpC1IOhvuFTYDgt
> > WouuIOaT0Hdura6SBdp6WYwwLzUP/nk1s6A6EfYtpanlWxblzLE=
> > =062g
> > -END PGP SIGNATURE-
> >
> > Signature for apache-wicket-9.0.0-M5.tar.gz:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6FsXoACgkQh48B+qjT
> > VuHV3Q//QlqtUlnAtEn2KN0XdinerjOrG8Ny9M7/apRqVjij57Ye+LrIPWnd0+Bj
> > WqTVx/4nuJ/HcC+e1fwrSkekSZW0n2ecO9GKo/k7KyDRxsbKnPyCP3JjqJfhDf/R
> > 6seFXrGJWLfQo844kuLJz5Ug3wjEqiOQk2HmgXTQmUdcGlTsXAioSkHttLNQjLZC
> > bF2LD3ZqwJw0R/7o1t4WAi1h7iriGKGrehgk6k/9h8DKTvKGduEDfWtSPu4R8Ogr
> > /i71FQt5w+87wKLP/viUHkIg0+KAHGmVu9Qz1AYHLc20oJv63N273ZeiIRuFWmCj
> > jw+1WfJUQvxFxfV1CxNCl/IBGPjD4FS3sygg867uEgShNFVNzVA+vplEDRl3i9e9
> > GaMgQsfVBi8eZzoGtgga0cQhgOU4hvOwv8lHNaC6XHYV18/p6j9P1tthtPsL2Krk
> > AzFfJ3Ym/gRf2thKop4iMn2xU16bu1D33zSPJ3C0kGlWqHQFw5+gBLNLOthv3YyV
> > LZGqSmsPg2sNcWDPqaUGQAVGNXmogjpbw6X9aEx2VtXfLQItRMNJq6lpoCtPQryK
> > UhgTTb4z4wE1dUDhyuIAVgKXgtUdKg7Q8oxmIfV4zl4OdRzBCYuHJ8md0Q7Tg0PC
> > BiSUhll+1igfRg1tUYItJ7TtV6uqdRZIg+YMsZ98ZKp24xcy1rI=
> > =GdAn
> > -END PGP SIGNATURE-
> >
> > 
> >
> >  CHANGELOG for 9.0.0-M5:
> >
> > ** Bug
> >
> >  * [WICKET-6715] - FileUpload class should not  implement
> IClusterable
> >  * [WICKET-6745] - CSP: inline JS in server and client time response
> > filters
> >  * [WICKET-6746] - HttpsMapper cannot deal with resources over
> > websockets
> >  * [WICKET-6752] - Some dependencies contain CVEs
> >  * [WICKET-6753] - res/modal.js using aria-labelledby where it
> > should be using aria-label
> >  * [WICKET-6754] - Iteration stops with nested containers
> >  * [WICKET-6755] - MockServletContext does not decode real path
> >  * [WICKET-6756] - Avoid URL.getFile() when actually expecting paths.
> >  * [WICKET-6757] - Avoid URL.getFile during mime type detection.
> >  * [WICKET-6758] - NPE in AbstractWebSocketProcessor after session
> > times out
> >
> > ** New Feature
> >
> >  * [WICKET-6727] - Configurable CSP
> >  * [WICKET-6729] - allow adding IHeaderResponseDecorator without
> > replacing all others
> >  * [WICKET-6730] - Global access to secure random data
> >
> > ** Improvement
> >
> >  * [WICKET-6724] - CSP: Inline Javascript in AjaxLink
> >  * [WICKET-6725] - CSP: display:none in
> Component.renderPlaceholderTag
> >  * [WICKET-6726] - CSP: inline styling and js in Form submitbutton
> > handling
> >  * [WICKET-6731] - CSP: inline JS in SubmitLink
> >  * [WICKET-6732] - CSP: inline JS in Link and ExternalLink
> >  * [WICKET-6733] - CSP: enable by default
> >  * [WICKET-6735] - CSP: inline styling in
> > FormComponentFeedbackBorder/Indicator
> >  * [WICKET-6736] - CSP: Inline styling in 

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 2

2020-04-02 Thread Maxim Solodovnik
I see no other way :(

On Thu, 2 Apr 2020 at 14:29, Andrea Del Bene  wrote:

>
> On 4/1/20 5:39 AM, Martin Grigorov wrote:
> > Hi,
> >
> > The CHANGELOG should not contain
> > https://issues.apache.org/jira/browse/WICKET-6750 since it is not
> Resolved.
>
> I don't know how it managed to go into the CHANGELOG. I've fixed it at
> code base level but it requires a to start again a new release to fix
> also distribution archives.
>
> Should we cancel this vote?
>
> > On Tue, Mar 31, 2020 at 9:56 PM Andrea Del Bene 
> > wrote:
> >
> >> This is a vote to release Apache Wicket 9.0.0-M5
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 9.0.0-M5
> >> [ ] No, don't release Apache Wicket 9.0.0-M5, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >>   https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M5
> >>
> >> Staging repository:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachewicket-1140/
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >>   Repository:  g...@github.com:bitstorm/wicket.git
> >>   Branch:  build/wicket-9.0.0-M5
> >>   Release tag: rel/wicket-9.0.0-M5
> >>
> >>
> >> 
> >>
> >>   The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-9.0.0-M5.zip:
> >>
> >>   -BEGIN PGP SIGNATURE-
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6DejwACgkQh48B+qjT
> >> VuEPnQ/9Gc7bH7Y/s6PZceoLV0t9gkhtsJaC8jhuZhOWCqj1Uu/3VfJPRYma2eSs
> >> z7XpgU1+x8qTMMUm27Z0HWMjUrMOevH5B0w4z9bb3yq9kmgwHGqH0o8lenjlZBAB
> >> sKQKKNFcdEP4uzIOW5B6TWa9MHzkwQjKS2SYMSNfRsZps7p0pHylcb2S9QvEB/7R
> >> ajSaNvF8C9J1vjkm8Qcutj8SUa+CwxuySe6rhCzj4VjslNMNTxUlyZxeicTipL3K
> >> dB2UkG1ziTcHsgYLmDXOyta4eloMSGC+X/8UFNJsob7KkdQxqT64VW++8VQ166ND
> >> UOkDZBPwTRislVf6c1cnLVZg+cIdNeNK9i2KDEIIChLhPStBpA9MVnaKAQjIYC7O
> >> EZcYzliQmr1dVIx/6XakgaCsIRifkkPyEkCIdg0fnMSoaKs4qc5Q0p1IXiWO6vJP
> >> mpnrtC7WzQ9ThnvQek6A1kz3ls3QlE9fqtDUmvE+XE/9E4Xko9ufe2tscPZ4Dr1b
> >> RUCRix+hmtisRWCjcTZ9oqxtzB+vxDYsuVAo0Q1+ckSf/xSIlzrtfidtOgifft0v
> >> FMKOlplmBzSmcmZrTJ2/DgpNgvX+tJJaBIEXUrXgFyuf1bRJBiwse9x/EGpBRcjC
> >> 3HlOcXG3o/W+SrVutxez49kt3Eaksa2AI+CYUvDJjl7wgHA3J9A=
> >> =fMOR
> >> -END PGP SIGNATURE-
> >>
> >> Signature for apache-wicket-9.0.0-M5.tar.gz:
> >>
> >>   -BEGIN PGP SIGNATURE-
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6DejwACgkQh48B+qjT
> >> VuFP/A/7BPiVX8FkifrsxVMcD7jgbiCEGTxO6adDIoZNPYA9vrapE3XCEVY9qyaW
> >> vHjqs/qFRtnhZY8dLcC6GKX5nnvIP0PoFvfw48yMx6/xidNoNnNrcxDzg4fpB3uW
> >> KzaqKbHb/tH7ndTsB/EF5CRejUxuQXYqiUIYDToHQwc/XT6to7TUpPL7FM/lEfUk
> >> xSdCK4EhsD1U4XvhZYKL7R1SfhyC5tvmm609UXLxFli7DBn5Sq/mcPlbA+BWbQQF
> >> GtLxFwYTrYONPfSyABUzi7CkKgeSXoK3ffnQlDqc5L8/cUYJQurU55jP5GP39Urk
> >> wGv3D2/glxEIeDUN77U0PxQzHDULwCXlX2Ng+npbUTS7COc8wTSpYFH+WzeyVATU
> >> RO5WIDG0RF1/y9CWm3S0gdXfeWSO0bP1VWX7MOeefVBm1c6vgHYdHctmwiHX9owB
> >> 4wfKqT9LbKMuaMY/A9ZpGt24X6N7ujAVMEIBJ+UGF2sSCnMNJK5XCSgnUkMNZwex
> >> 6h+rM6NUMl3nc8z6FEXPLvdJDdtx73O0LtL0REV5bINlIpRmXqMvTF1RvdhKR0jl
> >> vWFH5xBzW7/sKmJ5zQkh/Nw+VG9l0qewqwBh5sOHzWZXROqsVvrDXvGwXIOJKNMW
> >> 2881MlEJLLB9V59N7PIC7shxKl300W36Z1fIRSp3c9DiEoC4Y+E=
> >> =G/ZG
> >> -END PGP SIGNATURE-
> >>
> >> 
> >>
> >>   CHANGELOG for 9.0.0-M5:
> >>
> >> ** Bug
> >>
> >>   * [WICKET-6715] - FileUpload class should not  implement
> IClusterable
> >>   * [WICKET-6745] - CSP: inline JS in server and client time
> response
> >> filters
> >>   * [WICKET-6746] - HttpsMapper cannot deal with resources over
> >> websockets
> >>   * [WICKET-6752] - Some dependencies contain CVEs
> >>   * [WICKET-6753] - res/modal.js using aria-labelledby where it
> >> should be using aria-label
> >>   * [WICKET-6754] - Iteration stops with nested containers
> >>   * [WICKET-6755] - MockServletContext does not decode real path
> >>   * [WICKET-6756] - Avoid URL.getFile() when actually expecting
> paths.
> >>   * [WICKET-6757] - Avoid URL.getFile during mime type detection.
> >>   * [WICKET-6758] - NPE in AbstractWebSocketProcessor after session
> >> times out
> >>
> >> ** New Feature
> >>
> >>   * [WICKET-6727] - Configurable CSP
> >>   * [WICKET-6729] - allow adding IHeaderResponseDecorator without
> >> replacing all others
> >>   * [WICKET-6730] - Global access to secure random data
> >>
> >> ** Improvement
> >>
> >>   * 

Re: svn commit: r38773 - /dev/wicket/9.0.0-M5/CHANGELOG-9.x

2020-04-01 Thread Maxim Solodovnik
CHANGELOG is also packaged into tar.gz/zip

On Thu, 2 Apr 2020 at 02:59,  wrote:

> Author: adelbene
> Date: Wed Apr  1 19:59:20 2020
> New Revision: 38773
>
> Log:
> Removed WICKET-6750 from CHANGELOG
>
> Modified:
> dev/wicket/9.0.0-M5/CHANGELOG-9.x
>
> Modified: dev/wicket/9.0.0-M5/CHANGELOG-9.x
>
> ==
> --- dev/wicket/9.0.0-M5/CHANGELOG-9.x (original)
> +++ dev/wicket/9.0.0-M5/CHANGELOG-9.x Wed Apr  1 19:59:20 2020
> @@ -39,7 +39,6 @@ Release Notes - Wicket - Version 9.0.0-M
>  * [WICKET-6740] - CSP: inline JS in Button
>  * [WICKET-6741] - CSP: inline JS in FormComponentUpdatingBehavior
>  * [WICKET-6749] - CSP: Inline styling in ExceptionErrorPage.html
> -* [WICKET-6750] - add capability to cancel ongoing AJAX requests from
> client side
>  * [WICKET-6759] - Support disabling error notification for websockets
>  * [WICKET-6760] - Nested Form placeholder should preserve tag name
>  * [WICKET-6761] - Support multiple connections to the same websocket
> resource from a single session
>
>
>

-- 
WBR
Maxim aka solomax


Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 2

2020-03-31 Thread Maxim Solodovnik
+1

tested
* signatures/hashes
* local build
* wicketstuff build (examples need to be reviewed and fixed, will do later)
* our main app

On Wed, 1 Apr 2020 at 11:03, Martin Grigorov  wrote:

> +1 to release
>
> Tested local build, random Wicket examples and my Scala based application.
>
> On Tue, Mar 31, 2020 at 9:56 PM Andrea Del Bene 
> wrote:
>
> > This is a vote to release Apache Wicket 9.0.0-M5
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 9.0.0-M5
> > [ ] No, don't release Apache Wicket 9.0.0-M5, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> >  https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M5
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1140/
> >
> > The binaries are available in the above link, as are a staging
> > repository for Maven. Typically the vote is on the source, but should
> > you find a problem with one of the binaries, please let me know, I can
> > re-roll them some way or the other.
> >
> > Staging git repository data:
> >
> >  Repository:  g...@github.com:bitstorm/wicket.git
> >  Branch:  build/wicket-9.0.0-M5
> >  Release tag: rel/wicket-9.0.0-M5
> >
> >
> > 
> >
> >  The signatures for the source release artefacts:
> >
> >
> > Signature for apache-wicket-9.0.0-M5.zip:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6DejwACgkQh48B+qjT
> > VuEPnQ/9Gc7bH7Y/s6PZceoLV0t9gkhtsJaC8jhuZhOWCqj1Uu/3VfJPRYma2eSs
> > z7XpgU1+x8qTMMUm27Z0HWMjUrMOevH5B0w4z9bb3yq9kmgwHGqH0o8lenjlZBAB
> > sKQKKNFcdEP4uzIOW5B6TWa9MHzkwQjKS2SYMSNfRsZps7p0pHylcb2S9QvEB/7R
> > ajSaNvF8C9J1vjkm8Qcutj8SUa+CwxuySe6rhCzj4VjslNMNTxUlyZxeicTipL3K
> > dB2UkG1ziTcHsgYLmDXOyta4eloMSGC+X/8UFNJsob7KkdQxqT64VW++8VQ166ND
> > UOkDZBPwTRislVf6c1cnLVZg+cIdNeNK9i2KDEIIChLhPStBpA9MVnaKAQjIYC7O
> > EZcYzliQmr1dVIx/6XakgaCsIRifkkPyEkCIdg0fnMSoaKs4qc5Q0p1IXiWO6vJP
> > mpnrtC7WzQ9ThnvQek6A1kz3ls3QlE9fqtDUmvE+XE/9E4Xko9ufe2tscPZ4Dr1b
> > RUCRix+hmtisRWCjcTZ9oqxtzB+vxDYsuVAo0Q1+ckSf/xSIlzrtfidtOgifft0v
> > FMKOlplmBzSmcmZrTJ2/DgpNgvX+tJJaBIEXUrXgFyuf1bRJBiwse9x/EGpBRcjC
> > 3HlOcXG3o/W+SrVutxez49kt3Eaksa2AI+CYUvDJjl7wgHA3J9A=
> > =fMOR
> > -END PGP SIGNATURE-
> >
> > Signature for apache-wicket-9.0.0-M5.tar.gz:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl6DejwACgkQh48B+qjT
> > VuFP/A/7BPiVX8FkifrsxVMcD7jgbiCEGTxO6adDIoZNPYA9vrapE3XCEVY9qyaW
> > vHjqs/qFRtnhZY8dLcC6GKX5nnvIP0PoFvfw48yMx6/xidNoNnNrcxDzg4fpB3uW
> > KzaqKbHb/tH7ndTsB/EF5CRejUxuQXYqiUIYDToHQwc/XT6to7TUpPL7FM/lEfUk
> > xSdCK4EhsD1U4XvhZYKL7R1SfhyC5tvmm609UXLxFli7DBn5Sq/mcPlbA+BWbQQF
> > GtLxFwYTrYONPfSyABUzi7CkKgeSXoK3ffnQlDqc5L8/cUYJQurU55jP5GP39Urk
> > wGv3D2/glxEIeDUN77U0PxQzHDULwCXlX2Ng+npbUTS7COc8wTSpYFH+WzeyVATU
> > RO5WIDG0RF1/y9CWm3S0gdXfeWSO0bP1VWX7MOeefVBm1c6vgHYdHctmwiHX9owB
> > 4wfKqT9LbKMuaMY/A9ZpGt24X6N7ujAVMEIBJ+UGF2sSCnMNJK5XCSgnUkMNZwex
> > 6h+rM6NUMl3nc8z6FEXPLvdJDdtx73O0LtL0REV5bINlIpRmXqMvTF1RvdhKR0jl
> > vWFH5xBzW7/sKmJ5zQkh/Nw+VG9l0qewqwBh5sOHzWZXROqsVvrDXvGwXIOJKNMW
> > 2881MlEJLLB9V59N7PIC7shxKl300W36Z1fIRSp3c9DiEoC4Y+E=
> > =G/ZG
> > -END PGP SIGNATURE-
> >
> > 
> >
> >  CHANGELOG for 9.0.0-M5:
> >
> > ** Bug
> >
> >  * [WICKET-6715] - FileUpload class should not  implement
> IClusterable
> >  * [WICKET-6745] - CSP: inline JS in server and client time response
> > filters
> >  * [WICKET-6746] - HttpsMapper cannot deal with resources over
> > websockets
> >  * [WICKET-6752] - Some dependencies contain CVEs
> >  * [WICKET-6753] - res/modal.js using aria-labelledby where it
> > should be using aria-label
> >  * [WICKET-6754] - Iteration stops with nested containers
> >  * [WICKET-6755] - MockServletContext does not decode real path
> >  * [WICKET-6756] - Avoid URL.getFile() when actually expecting paths.
> >  * [WICKET-6757] - Avoid URL.getFile during mime type detection.
> >  * [WICKET-6758] - NPE in AbstractWebSocketProcessor after session
> > times out
> >
> > ** New Feature
> >
> >  * [WICKET-6727] - Configurable CSP
> >  * [WICKET-6729] - allow adding IHeaderResponseDecorator without
> > replacing all others
> >  * [WICKET-6730] - Global access to secure random data
> >
> > ** Improvement
> >
> >  * [WICKET-6724] - CSP: Inline Javascript in AjaxLink
> >  * [WICKET-6725] - CSP: display:none in
> Component.renderPlaceholderTag
> >  * [WICKET-6726] - CSP: inline styling and js in Form submitbutton
> > handling
> >  * [WICKET-6731] - CSP: inline JS in SubmitLink
> >  * [WICKET-6732] - CSP: inline JS in 

Re: Is it time for release?

2020-03-31 Thread Maxim Solodovnik
According to the number of commits: go! :)))

On Tue, 31 Mar 2020 at 14:49, Andrea Del Bene  wrote:

> ready, steadyMartin? :-)
>
> On 3/31/20 8:58 AM, Sven Meier wrote:
> > Hi Maxim,
> >
> > I'd say all changes are complete :).
> >
> > Have fun
> > Sven
> >
> > On 30.03.20 08:23, Maxim Solodovnik wrote:
> >> Hello All,
> >>
> >> Are there any incomplete tasks yet?
> >> Shall we start new VOTE? :)))
> >>
> >> On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro
> >> 
> >> wrote:
> >>
> >>> Hahaha... as always Martin is too fast :-)
> >>>
> >>> On Mon, Mar 9, 2020 at 10:40 AM Maxim Solodovnik  >
> >>> wrote:
> >>>
> >>>> Martin commited method rename yesterday :)
> >>>>
> >>>> On Mon, 9 Mar 2020 at 15:35, Ernesto Reinaldo Barreiro
> >>>>  wrote:
> >>>>> -1: Thanks Martin. After your comment I just remember Adrea mentioned
> >>>>> refactoring settings for new CSP feature to be aligned with other
> >>> wicket
> >>>>> settings.
> >>>>>
> >>>>> On Sun, Mar 8, 2020 at 6:57 AM Martin Grigorov  >
> >>>> wrote:
> >>>>>> On Sat, Mar 7, 2020 at 2:06 PM Andrea Del Bene <
> an.delb...@gmail.com
> >>>>>> wrote:
> >>>>>>
> >>>>>>> +1
> >>>>>>> For the 9.0.0-M5 I guess, the other versions dont have much new
> >>>>>> material. I
> >>>>>>> wanted to rework CSP configuration a little bit but I didn't have
> >>>> much
> >>>>>>> spare time to do it. I can postpone it after M5.
> >>>>>>>
> >>>>>> Please wait a bit with the release.
> >>>>>> Everyone hopes that we will release .Final after M5.
> >>>>>> I will do some changes now.
> >>>>>>
> >>>>>>
> >>>>>>> On Sat, Mar 7, 2020, 10:31 AM Ernesto Reinaldo Barreiro <
> >>>>>>> reier...@gmail.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> On Sat, Mar 7, 2020 at 5:14 AM Maxim Solodovnik <
> >>>> solomax...@gmail.com>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> subj :)
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> WBR
> >>>>>>>>> Maxim aka solomax
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Regards - Ernesto Reinaldo Barreiro
> >>>>>>>>
> >>>>>
> >>>>> --
> >>>>> Regards - Ernesto Reinaldo Barreiro
> >>>>
> >>>>
> >>>> --
> >>>> WBR
> >>>> Maxim aka solomax
> >>>>
> >>>
> >>> --
> >>> Regards - Ernesto Reinaldo Barreiro
> >>>
> >>
>


-- 
WBR
Maxim aka solomax


Re: Is it time for release?

2020-03-30 Thread Maxim Solodovnik
Hello All,

Are there any incomplete tasks yet?
Shall we start new VOTE? :)))

On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro 
wrote:

> Hahaha... as always Martin is too fast :-)
>
> On Mon, Mar 9, 2020 at 10:40 AM Maxim Solodovnik 
> wrote:
>
> > Martin commited method rename yesterday :)
> >
> > On Mon, 9 Mar 2020 at 15:35, Ernesto Reinaldo Barreiro
> >  wrote:
> > >
> > > -1: Thanks Martin. After your comment I just remember Adrea mentioned
> > > refactoring settings for new CSP feature to be aligned with other
> wicket
> > > settings.
> > >
> > > On Sun, Mar 8, 2020 at 6:57 AM Martin Grigorov 
> > wrote:
> > >
> > > > On Sat, Mar 7, 2020 at 2:06 PM Andrea Del Bene  >
> > > > wrote:
> > > >
> > > > > +1
> > > > > For the 9.0.0-M5 I guess, the other versions dont have much new
> > > > material. I
> > > > > wanted to rework CSP configuration a little bit but I didn't have
> > much
> > > > > spare time to do it. I can postpone it after M5.
> > > > >
> > > >
> > > > Please wait a bit with the release.
> > > > Everyone hopes that we will release .Final after M5.
> > > > I will do some changes now.
> > > >
> > > >
> > > > >
> > > > > On Sat, Mar 7, 2020, 10:31 AM Ernesto Reinaldo Barreiro <
> > > > > reier...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > On Sat, Mar 7, 2020 at 5:14 AM Maxim Solodovnik <
> > solomax...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > subj :)
> > > > > > >
> > > > > > > --
> > > > > > > WBR
> > > > > > > Maxim aka solomax
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Regards - Ernesto Reinaldo Barreiro
> > > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Regards - Ernesto Reinaldo Barreiro
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>


-- 
WBR
Maxim aka solomax


Re: [wicket] branch master updated: WICKET-6563 add CachingPageStore

2020-03-27 Thread Maxim Solodovnik
Hello Sven,

Are there any changes for wicketstuff-datastore required?

On Fri, 27 Mar 2020 at 20:18,  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> svenmeier pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/wicket.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>  new 8df3528  WICKET-6563 add CachingPageStore
> 8df3528 is described below
>
> commit 8df3528dc44a08b7d375c20e764a3664cd6a5f30
> Author: Sven Meier 
> AuthorDate: Fri Mar 27 10:13:13 2020 +0100
>
> WICKET-6563 add CachingPageStore
> ---
>  .../apache/wicket/DefaultPageManagerProvider.java  |   9 +-
>  .../apache/wicket/pageStore/CachingPageStore.java  | 109
> +
>  .../wicket/pageStore/InSessionPageStore.java   |  82 ++--
>  .../wicket/DefaultPageManagerProviderTest.java |   6 +-
>  .../core/request/mapper/TestMapperContext.java |   7 +-
>  .../wicket/page/PersistentPageManagerTest.java |   2 +-
>  .../wicket/pageStore/InSessionPageStoreTest.java   |  18 +++-
>  .../wicket/versioning/PageVersioningTest.java  |   4 +-
>  8 files changed, 174 insertions(+), 63 deletions(-)
>
> diff --git
> a/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
> b/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
> index e128266..540b1b3 100644
> ---
> a/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
> +++
> b/wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java
> @@ -21,6 +21,7 @@ import java.io.File;
>  import org.apache.wicket.page.IPageManager;
>  import org.apache.wicket.page.PageManager;
>  import org.apache.wicket.pageStore.AsynchronousPageStore;
> +import org.apache.wicket.pageStore.CachingPageStore;
>  import org.apache.wicket.pageStore.CryptingPageStore;
>  import org.apache.wicket.pageStore.DiskPageStore;
>  import org.apache.wicket.pageStore.FilePageStore;
> @@ -103,7 +104,7 @@ public class DefaultPageManagerProvider implements
> IPageManagerProvider
>
> store = newAsynchronousStore(store);
>
> -   store = newSessionStore(store);
> +   store = newCachingStore(store);
>
> store = newRequestStore(store);
>
> @@ -125,7 +126,7 @@ public class DefaultPageManagerProvider implements
> IPageManagerProvider
> }
>
> /**
> -* Cache pages in the request until it is finished.
> +* Keep pages in the request until it is finished.
>  *
>  * @see RequestPageStore
>  */
> @@ -139,9 +140,9 @@ public class DefaultPageManagerProvider implements
> IPageManagerProvider
>  *
>  * @see InSessionPageStore
>  */
> -   protected IPageStore newSessionStore(IPageStore pageStore)
> +   protected IPageStore newCachingStore(IPageStore pageStore)
> {
> -   return new InSessionPageStore(pageStore, 1,
> getSerializer());
> +   return new CachingPageStore(pageStore, new
> InSessionPageStore(1, getSerializer()));
> }
>
> /**
> diff --git
> a/wicket-core/src/main/java/org/apache/wicket/pageStore/CachingPageStore.java
> b/wicket-core/src/main/java/org/apache/wicket/pageStore/CachingPageStore.java
> new file mode 100644
> index 000..d4eff87
> --- /dev/null
> +++
> b/wicket-core/src/main/java/org/apache/wicket/pageStore/CachingPageStore.java
> @@ -0,0 +1,109 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.wicket.pageStore;
> +
> +import org.apache.wicket.page.IManageablePage;
> +
> +/**
> + * A store of pages that uses an {@link IPageStore} as a cache in front
> of another store to delegate to.
> + */
> +public class CachingPageStore extends DelegatingPageStore
> +{
> +
> +   private IPageStore cache;
> +
> +   /**
> +* Constructor.
> +* @param delegate store to delegate to
> +* @param cache store to use as cache
> +*/
> +   public CachingPageStore(IPageStore delegate, IPageStore cache)
> +   {
> +   super(delegate);
> +
> +   this.cache = cache;
> +   

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-26 Thread Maxim Solodovnik
Still no issues reported after 2 days of work at our demo server
Seems this solution can be released :)

On Wed, 25 Mar 2020 at 18:24, Maxim Solodovnik  wrote:

> first results: everything seems to work as expected
> will continue testing
>
> On Wed, 25 Mar 2020 at 01:12, Sven Meier  wrote:
>
>> Hi,
>>
>> ok, let's give it a try!
>>
>> All hidden elements (hidden form fields or placeholders) are hidden via
>> "hidden" attribute now.
>>
>> Have fun
>> Sven
>>
>>
>> On 24.03.20 08:15, Emond Papegaaij wrote:
>> > Hi all,
>> >
>> > If you want to go ahead and remove the core CSS, please make sure all
>> > components keep working. For example, in wicket extensions I had to
>> > use the 'wicket--hidden' class in progressbar.js. Just do a grep on
>> > 'wicket--hidden' and double-check those components in the examples.
>> >
>> > Best regards,
>> > Emond
>> >
>> > On Tue, Mar 24, 2020 at 6:29 AM Maxim Solodovnik 
>> wrote:
>> >> Let's try to remove this CSS and check :)
>> >> I'm currently using latest wicket SNAPSHOT at master so most probably
>> >> will provide some feedback :)
>> >>
>> >> On Fri, 20 Mar 2020 at 19:51, Martin Grigorov 
>> wrote:
>> >>> In this case I am fine to go with 'hidden'.
>> >>> We can introduce wicket-core.css later if needed.
>> >>>
>> >>> On Fri, Mar 20, 2020 at 1:44 PM Sven Meier  wrote:
>> >>>
>> >>>> Hi Martin,
>> >>>>
>> >>>> these stylings?
>> >>>>
>> >>>>   width: 0px;
>> >>>>   height: 0px;
>> >>>>   position: absolute;
>> >>>>   left: -100px;
>> >>>>   top: -100px;
>> >>>>   overflow: hidden;
>> >>>>
>> >>>> They are a 10-year old workaround
>> >>>>
>> >>>>
>> >>>>
>> https://github.com/apache/wicket/commit/b00f8ed1647f7a69a38aba562efa98bb8eb84d97
>> >>>>
>> >>>> ... for a problem that no longer exists:
>> >>>>
>> >>>>
>> >>>>
>> https://stackoverflow.com/questions/8318428/submit-form-fields-inside-displaynone-element
>> >>>>
>> >>>> A simple "display:none"/"hidden" is sufficient.
>> >>>>
>> >>>> Sven
>> >>>>
>> >>>>
>> >>>> On 20.03.20 10:29, Martin Grigorov wrote:
>> >>>>> Hi Sven,
>> >>>>>
>> >>>>> What about wicket--hidden-fields ?
>> >>>>> We still need wicket-core.css for it.
>> >>>>>
>> >>>>> Martin
>> >>>>>
>> >>>>> On Wed, Mar 18, 2020 at 11:25 PM Sven Meier 
>> wrote:
>> >>>>>
>> >>>>>> Hi all,
>> >>>>>>
>> >>>>>> I've built an example to better demonstrate my argument:
>> >>>>>>
>> >>>>>> a) "hidden" tags work fine out-of-the-box :)
>> >>>>>>
>> >>>>>>https://jsfiddle.net/p8s7Lrk2/1/
>> >>>>>>
>> >>>>>> b) changing display of tags changes "hidden" tags too :(
>> >>>>>>
>> >>>>>>https://jsfiddle.net/p8s7Lrk2/2/
>> >>>>>>
>> >>>>>> c) and a simple fix for "hidden" tags - no !important required ...
>> 8)
>> >>>>>>
>> >>>>>>https://jsfiddle.net/p8s7Lrk2/3/
>> >>>>>>
>> >>>>>> In my opinion there's no need to invent "wicket--hidden" when
>> "hidden"
>> >>>>>> works already as expected/needed (a).
>> >>>>>> And furthermore Wicket does not need to provide a fix (c) for
>> something
>> >>>>>> the web designer screwed up (b) in the first place.
>> >>>>>>
>> >>>>>> Have fun
>> >>>>>> Sven
>> >>>>>>
>> >>>>>>
>> >>>>>> On 17.03.20 13:01, Maxim Solodovnik wrote:
>> >>>>>>> Hello Sven,
&g

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-25 Thread Maxim Solodovnik
first results: everything seems to work as expected
will continue testing

On Wed, 25 Mar 2020 at 01:12, Sven Meier  wrote:

> Hi,
>
> ok, let's give it a try!
>
> All hidden elements (hidden form fields or placeholders) are hidden via
> "hidden" attribute now.
>
> Have fun
> Sven
>
>
> On 24.03.20 08:15, Emond Papegaaij wrote:
> > Hi all,
> >
> > If you want to go ahead and remove the core CSS, please make sure all
> > components keep working. For example, in wicket extensions I had to
> > use the 'wicket--hidden' class in progressbar.js. Just do a grep on
> > 'wicket--hidden' and double-check those components in the examples.
> >
> > Best regards,
> > Emond
> >
> > On Tue, Mar 24, 2020 at 6:29 AM Maxim Solodovnik 
> wrote:
> >> Let's try to remove this CSS and check :)
> >> I'm currently using latest wicket SNAPSHOT at master so most probably
> >> will provide some feedback :)
> >>
> >> On Fri, 20 Mar 2020 at 19:51, Martin Grigorov 
> wrote:
> >>> In this case I am fine to go with 'hidden'.
> >>> We can introduce wicket-core.css later if needed.
> >>>
> >>> On Fri, Mar 20, 2020 at 1:44 PM Sven Meier  wrote:
> >>>
> >>>> Hi Martin,
> >>>>
> >>>> these stylings?
> >>>>
> >>>>   width: 0px;
> >>>>   height: 0px;
> >>>>   position: absolute;
> >>>>   left: -100px;
> >>>>   top: -100px;
> >>>>   overflow: hidden;
> >>>>
> >>>> They are a 10-year old workaround
> >>>>
> >>>>
> >>>>
> https://github.com/apache/wicket/commit/b00f8ed1647f7a69a38aba562efa98bb8eb84d97
> >>>>
> >>>> ... for a problem that no longer exists:
> >>>>
> >>>>
> >>>>
> https://stackoverflow.com/questions/8318428/submit-form-fields-inside-displaynone-element
> >>>>
> >>>> A simple "display:none"/"hidden" is sufficient.
> >>>>
> >>>> Sven
> >>>>
> >>>>
> >>>> On 20.03.20 10:29, Martin Grigorov wrote:
> >>>>> Hi Sven,
> >>>>>
> >>>>> What about wicket--hidden-fields ?
> >>>>> We still need wicket-core.css for it.
> >>>>>
> >>>>> Martin
> >>>>>
> >>>>> On Wed, Mar 18, 2020 at 11:25 PM Sven Meier  wrote:
> >>>>>
> >>>>>> Hi all,
> >>>>>>
> >>>>>> I've built an example to better demonstrate my argument:
> >>>>>>
> >>>>>> a) "hidden" tags work fine out-of-the-box :)
> >>>>>>
> >>>>>>https://jsfiddle.net/p8s7Lrk2/1/
> >>>>>>
> >>>>>> b) changing display of tags changes "hidden" tags too :(
> >>>>>>
> >>>>>>https://jsfiddle.net/p8s7Lrk2/2/
> >>>>>>
> >>>>>> c) and a simple fix for "hidden" tags - no !important required ...
> 8)
> >>>>>>
> >>>>>>https://jsfiddle.net/p8s7Lrk2/3/
> >>>>>>
> >>>>>> In my opinion there's no need to invent "wicket--hidden" when
> "hidden"
> >>>>>> works already as expected/needed (a).
> >>>>>> And furthermore Wicket does not need to provide a fix (c) for
> something
> >>>>>> the web designer screwed up (b) in the first place.
> >>>>>>
> >>>>>> Have fun
> >>>>>> Sven
> >>>>>>
> >>>>>>
> >>>>>> On 17.03.20 13:01, Maxim Solodovnik wrote:
> >>>>>>> Hello Sven,
> >>>>>>>
> >>>>>>> I always thought:having override like this will require re-testing
> all
> >>>>>>> 3rd-party components manually
> >>>>>>> (I don't have that much time)
> >>>>>>> So I'm using library as-is and override as minimum as possible :)
> >>>>>>>
> >>>>>>> On Tue, 17 Mar 2020 at 18:56, Sven Meier  wrote:
> >>>>>>>> Hi Maxim,
> >>>>>>>>
> >>>>>>&

Re: CSP regression

2020-03-25 Thread Maxim Solodovnik
Hello All,

it seem it was false alarm
sorry for the noise :(

On Tue, 24 Mar 2020 at 15:19, Maxim Solodovnik  wrote:

> Hmmm,
>
> I'll check.
> The errors are definitely in DevTools (I'm using report-only CSP)
> Not sure if it is first or second time
> Will double-check and report back
>
> On Tue, 24 Mar 2020 at 15:17, Emond Papegaaij 
> wrote:
> >
> > Hi Maxim,
> >
> > Are you sure? I just tried the examples and CSS resources do have
> > nonces. Maybe you're seeing the same errors as I when opening the dev
> > tools? Somehow Chrome is unable to load the css resources in the dev
> > tools when the dev tools are opened after loading the page. After a
> > refresh, it's fine again.
> >
> > Emond
> >
> > On Tue, Mar 24, 2020 at 8:53 AM Maxim Solodovnik 
> wrote:
> > >
> > > Hello All,
> > >
> > > just found regression with CSP
> > > nonce for CSS resources seems to be not added, which results security
> errors
> > > Can it be caused by latest code optimizations?
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
>
>
>
> --
> WBR
> Maxim aka solomax
>


-- 
WBR
Maxim aka solomax


Re: CSP regression

2020-03-24 Thread Maxim Solodovnik
Hmmm,

I'll check.
The errors are definitely in DevTools (I'm using report-only CSP)
Not sure if it is first or second time
Will double-check and report back

On Tue, 24 Mar 2020 at 15:17, Emond Papegaaij  wrote:
>
> Hi Maxim,
>
> Are you sure? I just tried the examples and CSS resources do have
> nonces. Maybe you're seeing the same errors as I when opening the dev
> tools? Somehow Chrome is unable to load the css resources in the dev
> tools when the dev tools are opened after loading the page. After a
> refresh, it's fine again.
>
> Emond
>
> On Tue, Mar 24, 2020 at 8:53 AM Maxim Solodovnik  wrote:
> >
> > Hello All,
> >
> > just found regression with CSP
> > nonce for CSS resources seems to be not added, which results security errors
> > Can it be caused by latest code optimizations?
> >
> > --
> > WBR
> > Maxim aka solomax



-- 
WBR
Maxim aka solomax


CSP regression

2020-03-24 Thread Maxim Solodovnik
Hello All,

just found regression with CSP
nonce for CSS resources seems to be not added, which results security errors
Can it be caused by latest code optimizations?

-- 
WBR
Maxim aka solomax


Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-23 Thread Maxim Solodovnik
Let's try to remove this CSS and check :)
I'm currently using latest wicket SNAPSHOT at master so most probably
will provide some feedback :)

On Fri, 20 Mar 2020 at 19:51, Martin Grigorov  wrote:
>
> In this case I am fine to go with 'hidden'.
> We can introduce wicket-core.css later if needed.
>
> On Fri, Mar 20, 2020 at 1:44 PM Sven Meier  wrote:
>
> > Hi Martin,
> >
> > these stylings?
> >
> >  width: 0px;
> >  height: 0px;
> >  position: absolute;
> >  left: -100px;
> >  top: -100px;
> >  overflow: hidden;
> >
> > They are a 10-year old workaround
> >
> >
> > https://github.com/apache/wicket/commit/b00f8ed1647f7a69a38aba562efa98bb8eb84d97
> >
> > ... for a problem that no longer exists:
> >
> >
> > https://stackoverflow.com/questions/8318428/submit-form-fields-inside-displaynone-element
> >
> > A simple "display:none"/"hidden" is sufficient.
> >
> > Sven
> >
> >
> > On 20.03.20 10:29, Martin Grigorov wrote:
> > > Hi Sven,
> > >
> > > What about wicket--hidden-fields ?
> > > We still need wicket-core.css for it.
> > >
> > > Martin
> > >
> > > On Wed, Mar 18, 2020 at 11:25 PM Sven Meier  wrote:
> > >
> > >> Hi all,
> > >>
> > >> I've built an example to better demonstrate my argument:
> > >>
> > >> a) "hidden" tags work fine out-of-the-box :)
> > >>
> > >>   https://jsfiddle.net/p8s7Lrk2/1/
> > >>
> > >> b) changing display of tags changes "hidden" tags too :(
> > >>
> > >>   https://jsfiddle.net/p8s7Lrk2/2/
> > >>
> > >> c) and a simple fix for "hidden" tags - no !important required ... 8)
> > >>
> > >>   https://jsfiddle.net/p8s7Lrk2/3/
> > >>
> > >> In my opinion there's no need to invent "wicket--hidden" when "hidden"
> > >> works already as expected/needed (a).
> > >> And furthermore Wicket does not need to provide a fix (c) for something
> > >> the web designer screwed up (b) in the first place.
> > >>
> > >> Have fun
> > >> Sven
> > >>
> > >>
> > >> On 17.03.20 13:01, Maxim Solodovnik wrote:
> > >>> Hello Sven,
> > >>>
> > >>> I always thought:having override like this will require re-testing all
> > >>> 3rd-party components manually
> > >>> (I don't have that much time)
> > >>> So I'm using library as-is and override as minimum as possible :)
> > >>>
> > >>> On Tue, 17 Mar 2020 at 18:56, Sven Meier  wrote:
> > >>>> Hi Maxim,
> > >>>>
> > >>>> what is difficult about that?
> > >>>>
> > >>>> Actually it is recommended to have it in your normalize.css (formerly
> > >>>> reset.css).
> > >>>>
> > >>>> Here one without !important:
> > >>>>
> > >>>> https://github.com/necolas/normalize.css/blob/master/normalize.css
> > >>>>
> > >>>> Sven
> > >>>>
> > >>>>
> > >>>> On 13.03.20 15:21, Maxim Solodovnik wrote:
> > >>>>> Additional note:
> > >>>>>
> > >>>>> Bootstrap has following CSS
> > >>>>>
> > >>>>> [hidden] {
> > >>>>>  display: none !important;
> > >>>>> }
> > >>>>>
> > >>>>> which makes life much more diffiicult ...
> > >>>>>
> > >>>>> On Fri, 13 Mar 2020 at 21:17, Martin Grigorov 
> > >> wrote:
> > >>>>>> On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov <
> > mgrigo...@apache.org
> > >>>>>> wrote:
> > >>>>>>
> > >>>>>>> Hi Sven,
> > >>>>>>>
> > >>>>>>> 
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>/* rule from the application that should be used
> > when
> > >> the
> > >>>>>>> element is visible */
> > >>>>>>>div {
&g

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-17 Thread Maxim Solodovnik
Hello Sven,

I always thought:having override like this will require re-testing all
3rd-party components manually
(I don't have that much time)
So I'm using library as-is and override as minimum as possible :)

On Tue, 17 Mar 2020 at 18:56, Sven Meier  wrote:
>
> Hi Maxim,
>
> what is difficult about that?
>
> Actually it is recommended to have it in your normalize.css (formerly
> reset.css).
>
> Here one without !important:
>
> https://github.com/necolas/normalize.css/blob/master/normalize.css
>
> Sven
>
>
> On 13.03.20 15:21, Maxim Solodovnik wrote:
> > Additional note:
> >
> > Bootstrap has following CSS
> >
> > [hidden] {
> >display: none !important;
> > }
> >
> > which makes life much more diffiicult ...
> >
> > On Fri, 13 Mar 2020 at 21:17, Martin Grigorov  wrote:
> >> On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov 
> >> wrote:
> >>
> >>> Hi Sven,
> >>>
> >>> 
> >>>
> >>>  
> >>>  
> >>>  /* rule from the application that should be used when the
> >>> element is visible */
> >>>  div {
> >>>  display: flex;
> >>>  margin-bottom: 200px;
> >>>  }
> >>>
> >>>  /* Rule coming from wicket-core.css */
> >>>  .wicket--hidden {
> >>>  display: none;
> >>>  }
> >>>
> >>>  
> >>>  
> >>>
> >>>  
> >>>  
> >>>  Element when visible: 
> >>>  A1 B1 C1 D1
> >>>  
> >>>  
> >>>  
> >>>  Element when hidden (there is no B1 because Wicket renders
> >>> just the tag, without any children): 
> >>>  A2  C2 D2
> >>>  
> >>>  C2  D2 are still 200px down
> >>> because 'hidden' is not like 'display: none'!
> >>>  The application developer will have to do something more for
> >>> the placeholder case to hide it.
> >>>  
> >>>
> >>>  
> >>>  Element with wicket--hidden class
> >>>  A3 B3 C3
> >>> D3
> >>>  
> >>>  C3  D3 are not 200px down 
> >>> because
> >>> of 'display: none'!
> >>>  The application developer has nothing to do!
> >>>  
> >>>  
> >>>
> >>> 
> >>>
> >>> It shows two things:
> >>>
> >>> 1) since Wicket placeholder tags do not have children elements [1] there
> >>> is not really a need to use 'hidden' or 'display: none'
> >>>
> >> As I explained below we do need to use display: none.
> >> I've forgot to update this line.
> >>
> >>
> >>> 2) if we really want to hide the element without leaving extra work for
> >>> web designers then we have to use display: none
> >>>
> >>>
> >>> 1.
> >>> https://github.com/apache/wicket/blob/10d10a92dda2e5834508f52d7807fe361f20fbea/wicket-core/src/main/java/org/apache/wicket/Component.java#L2370
> >>>
> >>>
> >>>
> >>> On Thu, Mar 12, 2020 at 4:35 PM Sven Meier  wrote:
> >>>
> >>>> Hi all,
> >>>>
> >>>> I've looked at all responses and most arguments in favor of a "core.css"
> >>>> boil down to:
> >>>>
> >>>>   > `hidden` attribute doesn't work (even `display: flex` breaks it)
> >>>>
> >>>>   > Using the hidden attribute puts the responsibility with the developer
> >>>>   > where this should be on the framework. The hidden attribute just
> >>>> doesn't work.
> >>>>
> >>>>   > When something as simple as using flex or display:block on a div 
> >>>> breaks
> >>>>   > the hidden attribute [1] we should not depend on it working.
> >>>>
> >>>> Sorry, but I don't share that assessment: 'hidden' works just fine!
> >>>> Every browser supports it and it has a strong semantic meaning we can
> >>>> utilize.
> >>>>
> >>>> If you (or your web 

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-13 Thread Maxim Solodovnik
Additional note:

Bootstrap has following CSS

[hidden] {
  display: none !important;
}

which makes life much more diffiicult ...

On Fri, 13 Mar 2020 at 21:17, Martin Grigorov  wrote:
>
> On Fri, Mar 13, 2020 at 4:13 PM Martin Grigorov 
> wrote:
>
> > Hi Sven,
> >
> > 
> >
> > 
> > 
> > /* rule from the application that should be used when the
> > element is visible */
> > div {
> > display: flex;
> > margin-bottom: 200px;
> > }
> >
> > /* Rule coming from wicket-core.css */
> > .wicket--hidden {
> > display: none;
> > }
> >
> > 
> > 
> >
> > 
> > 
> > Element when visible: 
> > A1 B1 C1 D1
> > 
> > 
> > 
> > Element when hidden (there is no B1 because Wicket renders
> > just the tag, without any children): 
> > A2  C2 D2
> > 
> > C2  D2 are still 200px down
> > because 'hidden' is not like 'display: none'!
> > The application developer will have to do something more for
> > the placeholder case to hide it.
> > 
> >
> > 
> > Element with wicket--hidden class
> > A3 B3 C3
> > D3
> > 
> > C3  D3 are not 200px down because
> > of 'display: none'!
> > The application developer has nothing to do!
> > 
> > 
> >
> > 
> >
> > It shows two things:
> >
> > 1) since Wicket placeholder tags do not have children elements [1] there
> > is not really a need to use 'hidden' or 'display: none'
> >
>
> As I explained below we do need to use display: none.
> I've forgot to update this line.
>
>
> >
> > 2) if we really want to hide the element without leaving extra work for
> > web designers then we have to use display: none
> >
> >
> > 1.
> > https://github.com/apache/wicket/blob/10d10a92dda2e5834508f52d7807fe361f20fbea/wicket-core/src/main/java/org/apache/wicket/Component.java#L2370
> >
> >
> >
> > On Thu, Mar 12, 2020 at 4:35 PM Sven Meier  wrote:
> >
> >> Hi all,
> >>
> >> I've looked at all responses and most arguments in favor of a "core.css"
> >> boil down to:
> >>
> >>  > `hidden` attribute doesn't work (even `display: flex` breaks it)
> >>
> >>  > Using the hidden attribute puts the responsibility with the developer
> >>  > where this should be on the framework. The hidden attribute just
> >> doesn't work.
> >>
> >>  > When something as simple as using flex or display:block on a div breaks
> >>  > the hidden attribute [1] we should not depend on it working.
> >>
> >> Sorry, but I don't share that assessment: 'hidden' works just fine!
> >> Every browser supports it and it has a strong semantic meaning we can
> >> utilize.
> >>
> >> If you (or your web designer) decides to style hidden elements as
> >> floating, static, flex, pink or with marquee ... feel free to do so.
> >>
> >
> > No. The web designer styles the element when it is supposed to be visible.
> > But then when some condition is met Wicket may render it as a placeholder
> > for Ajax requests and then this element will be rendered.
> > It does not have text content but the CSS rules will be still applied and
> > the web designer will have to add more rules for the cases when 'hidden' is
> > there.
> > Most probably something like:
> > div[hidden] {
> >display:none;
> > }
> >
> >
> >> Wicket doesn't need to ship a CSS file to fix anything here.
> >> Note that the way we are hiding components in Wicket never exposes any
> >> sensible information anyways. This topic is just about layout and
> >> styling and that is completely in the responsibility of your developer
> >> ...  and works out-of-the-box if you don't break it!
> >>
> >
> > What about the cases when the children need to be invisible ?
> > .wicket--hidden-fields
> >
> >
> >>
> >>  >Wicket ... has been dependent on its own styles, spread out through
> >> our code in odd ways
> >>  > I consider not having a wicket stylesheet file a bug, not a feature
> >>
> >> I couldn't disagree more. These "odd ways" is one of many cool features
> >> of Wicket named "components". BTW we Wicket devs have never been very
> >> successful in crafting CSS anyways, we shouldn't start with this now :P.
> >>
> >
> > We don't really start.
> > We do not mandate styling. We just hide whatever is supposed to be hidden.
> > Nothing more.
> >
> > As agreed (?!) earlier .wicket--color-red should be just a marker CSS
> > class. The content should be provided by the application. Just like
> > FeedbackPanel's CSS classes. I will remove it now!
> >
> >
> >>
> >> I'll start a vote soon.
> >>
> >> Sidenote : This doesn't mean I'm against the CSP feature in general!
> >> After some iterations we arrived at a very cool solution (with some
> >> minor detail questions remaining).
> >>
> >> Have fun
> >> Sven
> >>
> >> On 27.02.20 22:18, Emond Papegaaij wrote:
> >> > Hi Andrew,
> >> >

Re: [wicket] branch master updated: WICKET-6727: only render CSP on RenderPageRequestHandler

2020-03-13 Thread Maxim Solodovnik
Hello Edmond,

It seems you accidentally re-format license header ...

On Fri, 13 Mar 2020 at 15:44,  wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> papegaaij pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/wicket.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>  new 1619809  WICKET-6727: only render CSP on RenderPageRequestHandler
> 1619809 is described below
>
> commit 16198099d8a965f17c85d2de7a6dce36b000ec26
> Author: Emond Papegaaij 
> AuthorDate: Fri Mar 13 09:44:36 2020 +0100
>
> WICKET-6727: only render CSP on RenderPageRequestHandler
> ---
>  .../apache/wicket/csp/CSPRequestCycleListener.java |  8 +--
>  .../apache/wicket/examples/csp/NonceDemoPage.html  |  1 +
>  .../apache/wicket/examples/csp/NonceDemoPage.java  | 71 
> --
>  3 files changed, 45 insertions(+), 35 deletions(-)
>
> diff --git 
> a/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
>  
> b/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
> index f0acc52..3250174 100644
> --- 
> a/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
> +++ 
> b/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
> @@ -16,8 +16,8 @@
>   */
>  package org.apache.wicket.csp;
>
> -import org.apache.wicket.core.request.handler.BufferedResponseRequestHandler;
>  import org.apache.wicket.core.request.handler.IPageClassRequestHandler;
> +import org.apache.wicket.core.request.handler.RenderPageRequestHandler;
>  import org.apache.wicket.request.IRequestHandler;
>  import org.apache.wicket.request.IRequestHandlerDelegate;
>  import org.apache.wicket.request.cycle.IRequestCycleListener;
> @@ -81,11 +81,11 @@ public class CSPRequestCycleListener implements 
> IRequestCycleListener
> {
> return 
> mustProtect(((IRequestHandlerDelegate)handler).getDelegateHandler());
> }
> -   if (handler instanceof IPageClassRequestHandler)
> +   if (handler instanceof RenderPageRequestHandler)
> {
> -   return 
> settings.mustProtectPageRequest((IPageClassRequestHandler)handler);
> +   return 
> settings.mustProtectPageRequest((RenderPageRequestHandler)handler);
> }
> -   return !(handler instanceof BufferedResponseRequestHandler);
> +   return false;
> }
>
>  }
> diff --git 
> a/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.html
>  
> b/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.html
> index 32549a7..d22b416 100644
> --- 
> a/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.html
> +++ 
> b/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.html
> @@ -13,6 +13,7 @@
>  
>  
>  Click a button above to replace this 
> text
> +This text will stay black even though 
> color:red is added by the button above
>wicket:id="clickMeCount">
>  
>  This delayed 
> shown text should be green and bold
> diff --git 
> a/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.java
>  
> b/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.java
> index dce8079..4fe81b0 100644
> --- 
> a/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.java
> +++ 
> b/wicket-examples/src/main/java/org/apache/wicket/examples/csp/NonceDemoPage.java
> @@ -1,21 +1,16 @@
>  /*
> - * Licensed to the Apache Software Foundation (ASF) under one or more
> - * contributor license agreements.  See the NOTICE file distributed with
> - * this work for additional information regarding copyright ownership.
> - * The ASF licenses this file to You under the Apache License, Version 2.0
> - * (the "License"); you may not use this file except in compliance with
> - * the License.  You may obtain a copy of the License at
> - *
> - *  http://www.apache.org/licenses/LICENSE-2.0
> - *
> - * Unless required by applicable law or agreed to in writing, software
> - * distributed under the License is distributed on an "AS IS" BASIS,
> - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> - * See the License for the specific language governing permissions and
> - * limitations under the License.
> + * Licensed to the Apache Software Foundation (ASF) under one or more 
> contributor license
> + * agreements. See the NOTICE file distributed with this work for additional 
> information regarding
> + * copyright ownership. The ASF licenses this file to You under the Apache 
> License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance with the 
> License. You may obtain a
> + * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
> required by 

Re: Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Maxim Solodovnik
Maybe this dependency can be added to dependencies of jetty-maven-plugin ?

On Thu, 12 Mar 2020 at 23:23, Martin Grigorov  wrote:
>
> On Thu, Mar 12, 2020, 16:41 Martijn Dashorst 
> wrote:
>
> > Because it is, just like the servlet-api, a specification that is provided
> > by the container. When your container does not supply that specification,
> > you have to override the scope yourself and supply the API that way. E.G.
> > Wildfly supplies that API, as does Glassfish, etc.
> >
> > The examples could override the scope, but not sure if that is the correct
> > answer for all deployments.
> >
>
> Which deployments do we want to support for the examples?
> Since a while "mvn jetty:run" does not work because of CDI. Now Tomcat too.
> I suggest to either add this dependency or remove the CDI example.
>
>
> > Martijn
> >
> >
> > On Thu, Mar 12, 2020 at 3:17 PM Martin Grigorov 
> > wrote:
> >
> > > Hi,
> > >
> > > Does anyone know why jakarta.enterprise:jakarta.enterprise.cdi-api
> > > dependency [1] has provided
> > > scope in dependency management ?
> > > I'm hitting NoClassDefFoundError
> > > for javax.enterprise.inject.spi.BeanManager while deploying
> > > wicket-examples.war in Tomcat.
> > >
> > >
> > > 1.
> > >
> > >
> > https://github.com/apache/wicket/blob/1245ee2998930f3b9169ca8afa4018d49e2346e4/pom.xml#L221-L226
> > >
> >
> >
> > --
> > Become a Wicket expert, learn from the best: http://wicketinaction.com
> >



-- 
WBR
Maxim aka solomax


Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Maxim Solodovnik
+1 for getCspSettings

But I guess it will be M5 ... :)

On Thu, 12 Mar 2020 at 15:42, Emond Papegaaij  wrote:
>
> Hi,
>
> Agreed, but first, the documentation needs to be updated with the new
> API. I like most of the changes, except for the new method name for
> 'getContentSecurityPolicySettings()'. IMHO it's too long and everyone
> calls it CSP. I'd rather stick with 'getCspSettings()'. The
> documentation in 'ContentSecurityPolicySettings' is already missing
> 'Policy'.
>
> Best regards,
> Emond
>
> On Thu, Mar 12, 2020 at 8:16 AM Martin Grigorov  wrote:
> >
> > Hi,
> >
> > Sven just made some API breaking changes with
> > https://gitbox.apache.org/repos/asf?p=wicket.git;h=88e8d36, for good!
> > If we want the next release to be the final one then I suggest to cancel
> > this vote and start over with the new change.
> >
> > Martin
> >
> > On Tue, Mar 10, 2020 at 10:50 PM Andrea Del Bene 
> > wrote:
> >
> > > This is a vote to release Apache Wicket 9.0.0-M5
> > >
> > > Please download the source distributions found in our staging area
> > > linked below.
> > >
> > > I have included the signatures for both the source archives. This vote
> > > lasts for 72 hours minimum.
> > >
> > > [ ] Yes, release Apache Wicket 9.0.0-M5
> > > [ ] No, don't release Apache Wicket 9.0.0-M5, because ...
> > >
> > > Distributions, changelog, keys and signatures can be found at:
> > >
> > >  https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M5
> > >
> > > Staging repository:
> > >
> > > https://repository.apache.org/content/repositories/orgapachewicket-1137/
> > >
> > > The binaries are available in the above link, as are a staging
> > > repository for Maven. Typically the vote is on the source, but should
> > > you find a problem with one of the binaries, please let me know, I can
> > > re-roll them some way or the other.
> > >
> > > Staging git repository data:
> > >
> > >  Repository:  g...@github.com:bitstorm/wicket.git
> > >  Branch:  build/wicket-9.0.0-M5
> > >  Release tag: rel/wicket-9.0.0-M5
> > >
> > >
> > > 
> > >
> > >  The signatures for the source release artefacts:
> > >
> > >
> > > Signature for apache-wicket-9.0.0-M5.zip:
> > >
> > >  -BEGIN PGP SIGNATURE-
> > >
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl5n/CoACgkQh48B+qjT
> > > VuHd2RAAijpTFLBY5tr9GOjZPk0y//Kog/8IYi9dJjkOtJtFky7UhNzlmFVx7Yz7
> > > hbc5ecLeeXz3oLZHkECjKda5086aopXzFzsS8jLQM1/yqZ4jD2zd1E7evw+Kxj+v
> > > cOi6+XxV8m508R7qs8pob9rs5Z/wfDocEOvVBM4SNxFCmFxENUvwImgEq89Vg2pQ
> > > iMjFK2zUk4L82cc1hEN3+GKfe1LvnlDJIp2ebP+ntlBr8Nrc7MR/jOrJxSRr+wBp
> > > /U6y9jEVSuR5rrN4KKFvSLDfGOdOvug6JVhzVFJ6lKjqSKPNQ4Ml+ZWe2cEdu/qD
> > > VYEn4kaioVX539424HugXQK1Z4jvNA0NJVmvWuYOsZYQeRGlccOzAsgXuYUNFllR
> > > UmCw1mpFLz0OMSfFdv125gj4MxSOsl+H5eY4LJuZWBfk/6BXRBDINJo4kjaq7tq1
> > > GLfVoHB5dvrDp3R9WsFzGQJA4InrF8w+/m08p1haRiny0Vqch4s/zTG82nrp9bPR
> > > Iyrt97SAWquXeMwRXqdA68cBvB5UjTkbdI6BtP7pNMGtklaV2R9vbdU18opIJf0K
> > > ANzjxROr+DkgEcmthLIKlkErKr+UfeAZU84lRMfaD4QlWFB4jmwW+BEBiCMUSia2
> > > 8IHaOJ8OBMXuBD7dK9dnpm6FoOY8qCYGAwBPzM5l2bzj+50s9a0=
> > > =qrHX
> > > -END PGP SIGNATURE-
> > >
> > > Signature for apache-wicket-9.0.0-M5.tar.gz:
> > >
> > >  -BEGIN PGP SIGNATURE-
> > >
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl5n/CkACgkQh48B+qjT
> > > VuHvRA//ekwcb/9Lb1q1g33chXIpXAxXQJe/mOdX2rDPQUQIN2Diw8V2a9ZuFdFb
> > > 7AUKXfMHBk9zOZO7HKWI1FBUp0UW9VC8p4ut+5ssBWjEaF/FKxzh/rG4J7vG9Tul
> > > oD6KlAE4h7dx/lERbpKZy9Vs/Po65+oIypf3sD+iVFms7I0jxiE/81P8kMSEuD2S
> > > l4pzXnKmMkuzfSkTJLOak6K6Rho8a+rsvWzr/NjG3yJ23M04Oi589Eft66MEMZFw
> > > N8VgWRuBBIQkIzIlCmLu1xTbk/j95Qnt5lgCs2E4gCVfH0qlmsTroFVCjDW97WEX
> > > /Iq7Dk0XUjMP7u9d+JXceLObFVi8/rng803M260h2WbRC0zbSq78RSdDk1fNQWlM
> > > 5OXvS2Q0dp73+gn1VBc3lt/7TzUeIzq2aQlG3GsOBTH3ZU+G8HCaGmIL7b4Ge27J
> > > rtxLG6bnBIEXmr96cDXPDqdIuthMCIHB1DcitHPDCyHISXXCC+1ZJXcLACi/dgVF
> > > trbjJJFpaVYQeNLFLUYZZZzvCUFClAfE47ieSRmWUIjMNn2Ob6EslYHqK7qxlbzE
> > > eUFSkhpfzU31RGXoaEwTJLe8uweIJ/lWouy8PajsiMGmVHeWjorMn37UTLoZxIKo
> > > uUHpAZoFp1DHYPqOWPPxrymHctYEMAtSfbmLSV590qaCIYr3fiw=
> > > =UkVf
> > > -END PGP SIGNATURE-
> > >
> > > 
> > >
> > >  CHANGELOG for 9.0.0-M5:
> > >
> > > ** Bug
> > >
> > >  * [WICKET-6745] - CSP: inline JS in server and client time response
> > > filters
> > >  * [WICKET-6746] - HttpsMapper cannot deal with resources over
> > > websockets
> > >  * [WICKET-6752] - Some dependencies contain CVEs
> > >  * [WICKET-6753] - res/modal.js using aria-labelledby where it
> > > should be using aria-label
> > >  * [WICKET-6754] - Iteration stops with nested containers
> > >
> > > ** New Feature
> > >
> > >  * [WICKET-6727] - Configurable CSP
> > >  * [WICKET-6729] - allow adding IHeaderResponseDecorator without
> > > replacing all others
> > >  * [WICKET-6730] - Global access to secure random 

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-11 Thread Maxim Solodovnik
+1

Tested:
1) signatures
2) build from sources
3) our main app

will start checking wicketstuff later this week

On Wed, 11 Mar 2020 at 03:50, Andrea Del Bene  wrote:
>
> This is a vote to release Apache Wicket 9.0.0-M5
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 9.0.0-M5
> [ ] No, don't release Apache Wicket 9.0.0-M5, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
>  https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M5
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1137/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>  Repository:  g...@github.com:bitstorm/wicket.git
>  Branch:  build/wicket-9.0.0-M5
>  Release tag: rel/wicket-9.0.0-M5
>
>
> 
>
>  The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-9.0.0-M5.zip:
>
>  -BEGIN PGP SIGNATURE-
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl5n/CoACgkQh48B+qjT
> VuHd2RAAijpTFLBY5tr9GOjZPk0y//Kog/8IYi9dJjkOtJtFky7UhNzlmFVx7Yz7
> hbc5ecLeeXz3oLZHkECjKda5086aopXzFzsS8jLQM1/yqZ4jD2zd1E7evw+Kxj+v
> cOi6+XxV8m508R7qs8pob9rs5Z/wfDocEOvVBM4SNxFCmFxENUvwImgEq89Vg2pQ
> iMjFK2zUk4L82cc1hEN3+GKfe1LvnlDJIp2ebP+ntlBr8Nrc7MR/jOrJxSRr+wBp
> /U6y9jEVSuR5rrN4KKFvSLDfGOdOvug6JVhzVFJ6lKjqSKPNQ4Ml+ZWe2cEdu/qD
> VYEn4kaioVX539424HugXQK1Z4jvNA0NJVmvWuYOsZYQeRGlccOzAsgXuYUNFllR
> UmCw1mpFLz0OMSfFdv125gj4MxSOsl+H5eY4LJuZWBfk/6BXRBDINJo4kjaq7tq1
> GLfVoHB5dvrDp3R9WsFzGQJA4InrF8w+/m08p1haRiny0Vqch4s/zTG82nrp9bPR
> Iyrt97SAWquXeMwRXqdA68cBvB5UjTkbdI6BtP7pNMGtklaV2R9vbdU18opIJf0K
> ANzjxROr+DkgEcmthLIKlkErKr+UfeAZU84lRMfaD4QlWFB4jmwW+BEBiCMUSia2
> 8IHaOJ8OBMXuBD7dK9dnpm6FoOY8qCYGAwBPzM5l2bzj+50s9a0=
> =qrHX
> -END PGP SIGNATURE-
>
> Signature for apache-wicket-9.0.0-M5.tar.gz:
>
>  -BEGIN PGP SIGNATURE-
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl5n/CkACgkQh48B+qjT
> VuHvRA//ekwcb/9Lb1q1g33chXIpXAxXQJe/mOdX2rDPQUQIN2Diw8V2a9ZuFdFb
> 7AUKXfMHBk9zOZO7HKWI1FBUp0UW9VC8p4ut+5ssBWjEaF/FKxzh/rG4J7vG9Tul
> oD6KlAE4h7dx/lERbpKZy9Vs/Po65+oIypf3sD+iVFms7I0jxiE/81P8kMSEuD2S
> l4pzXnKmMkuzfSkTJLOak6K6Rho8a+rsvWzr/NjG3yJ23M04Oi589Eft66MEMZFw
> N8VgWRuBBIQkIzIlCmLu1xTbk/j95Qnt5lgCs2E4gCVfH0qlmsTroFVCjDW97WEX
> /Iq7Dk0XUjMP7u9d+JXceLObFVi8/rng803M260h2WbRC0zbSq78RSdDk1fNQWlM
> 5OXvS2Q0dp73+gn1VBc3lt/7TzUeIzq2aQlG3GsOBTH3ZU+G8HCaGmIL7b4Ge27J
> rtxLG6bnBIEXmr96cDXPDqdIuthMCIHB1DcitHPDCyHISXXCC+1ZJXcLACi/dgVF
> trbjJJFpaVYQeNLFLUYZZZzvCUFClAfE47ieSRmWUIjMNn2Ob6EslYHqK7qxlbzE
> eUFSkhpfzU31RGXoaEwTJLe8uweIJ/lWouy8PajsiMGmVHeWjorMn37UTLoZxIKo
> uUHpAZoFp1DHYPqOWPPxrymHctYEMAtSfbmLSV590qaCIYr3fiw=
> =UkVf
> -END PGP SIGNATURE-
>
> 
>
>  CHANGELOG for 9.0.0-M5:
>
> ** Bug
>
>  * [WICKET-6745] - CSP: inline JS in server and client time response
> filters
>  * [WICKET-6746] - HttpsMapper cannot deal with resources over
> websockets
>  * [WICKET-6752] - Some dependencies contain CVEs
>  * [WICKET-6753] - res/modal.js using aria-labelledby where it
> should be using aria-label
>  * [WICKET-6754] - Iteration stops with nested containers
>
> ** New Feature
>
>  * [WICKET-6727] - Configurable CSP
>  * [WICKET-6729] - allow adding IHeaderResponseDecorator without
> replacing all others
>  * [WICKET-6730] - Global access to secure random data
>
> ** Improvement
>
>  * [WICKET-6724] - CSP: Inline Javascript in AjaxLink
>  * [WICKET-6725] - CSP: display:none in Component.renderPlaceholderTag
>  * [WICKET-6726] - CSP: inline styling and js in Form submitbutton
> handling
>  * [WICKET-6731] - CSP: inline JS in SubmitLink
>  * [WICKET-6732] - CSP: inline JS in Link and ExternalLink
>  * [WICKET-6733] - CSP: enable by default
>  * [WICKET-6735] - CSP: inline styling in
> FormComponentFeedbackBorder/Indicator
>  * [WICKET-6736] - CSP: Inline styling in BrowserInfoForm
>  * [WICKET-6737] - CSP: violations in examples
>  * [WICKET-6738] - CSP: inline styling in UploadProgressBar
>  * [WICKET-6739] - CSP: inline JS in Palette
>  * [WICKET-6740] - CSP: inline JS in Button
>  * [WICKET-6741] - CSP: inline JS in FormComponentUpdatingBehavior
>  * [WICKET-6749] - CSP: Inline styling in ExceptionErrorPage.html
>  * [WICKET-6750] - add capability to cancel ongoing AJAX requests
> from client side
>
> ** Task
>
>  * [WICKET-6687] - Cleanup the code from attribute inline styles and
> attribute inline 

Re: Is it time for release?

2020-03-09 Thread Maxim Solodovnik
Martin commited method rename yesterday :)

On Mon, 9 Mar 2020 at 15:35, Ernesto Reinaldo Barreiro
 wrote:
>
> -1: Thanks Martin. After your comment I just remember Adrea mentioned
> refactoring settings for new CSP feature to be aligned with other wicket
> settings.
>
> On Sun, Mar 8, 2020 at 6:57 AM Martin Grigorov  wrote:
>
> > On Sat, Mar 7, 2020 at 2:06 PM Andrea Del Bene 
> > wrote:
> >
> > > +1
> > > For the 9.0.0-M5 I guess, the other versions dont have much new
> > material. I
> > > wanted to rework CSP configuration a little bit but I didn't have much
> > > spare time to do it. I can postpone it after M5.
> > >
> >
> > Please wait a bit with the release.
> > Everyone hopes that we will release .Final after M5.
> > I will do some changes now.
> >
> >
> > >
> > > On Sat, Mar 7, 2020, 10:31 AM Ernesto Reinaldo Barreiro <
> > > reier...@gmail.com>
> > > wrote:
> > >
> > > > +1
> > > >
> > > > On Sat, Mar 7, 2020 at 5:14 AM Maxim Solodovnik 
> > > > wrote:
> > > >
> > > > > subj :)
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > > >
> > > >
> > > >
> > > > --
> > > > Regards - Ernesto Reinaldo Barreiro
> > > >
> > >
> >
>
>
> --
> Regards - Ernesto Reinaldo Barreiro



-- 
WBR
Maxim aka solomax


Is it time for release?

2020-03-06 Thread Maxim Solodovnik
subj :)

-- 
WBR
Maxim aka solomax


Re: CSP and UI libraries

2020-02-28 Thread Maxim Solodovnik
It is possible
but this CSP will not be `strict` anymore :)))

On Fri, 28 Feb 2020 at 15:23, Sebastien Briquet  wrote:
>
> Thank you so much Emond! I will try that!



-- 
WBR
Maxim aka solomax


Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Sorry for bringing such news :(

On Fri, 28 Feb 2020 at 10:05, Sebastien Briquet  wrote:
>
> Thank you very much for letting me know!
> I didn't exactly know what to expect until I would put my hands in it, but
> now I'm a little bit worried, haha !
>
> Best regards,
> Sebastien



-- 
WBR
Maxim aka solomax


Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Hello Sebastien,

Unfortunately this task might be challenging :(
Kendo will not work in strict CSP mode :(
https://docs.telerik.com/kendo-ui/troubleshoot/content-security-policy

Other places to look at (should be easy to correct):
DisplayNoneBehavior
MessageDialog
:)))

On Thu, 27 Feb 2020 at 20:00, Sebastien Briquet  wrote:
>
> Hi Martin,
>
> Actually that's a good point! I will try to upgrade Wicket jQuery UI to
> wicket 9/CSP to see how it behaves...
>
> Thanks and best regards,
> Sebastien



-- 
WBR
Maxim aka solomax


Re: CSP and UI libraries

2020-02-27 Thread Maxim Solodovnik
Yes,
All my prs were made with strict csp enabled
Additional minor change is required to make tests pass
Will create pr right after release

On Thu, Feb 27, 2020, 20:32 Martin Grigorov  wrote:

> Thanks, Emond!
>
> @Maxim: since you started using Wicket 9.x Bootstrap 4.x recently: do you
> use it with CSP enabled ?
>
> On Thu, Feb 27, 2020 at 3:17 PM Emond Papegaaij  >
> wrote:
>
> > Hi Martin and Sebastien,
> >
> > I see no need for checking if CSP is enabled or not. It is not hard to
> > write your code to comply to even the strictest CSP. If it works with
> > the strict CSP, it will also work when CSP is disabled or with a less
> > strict CSP. Simply follow the few rules explained in the user guide.
> > Note that if your library needs to check if a nonce is required, this
> > is already supported, see
> > ContentSecurityPolicyEnforcer.isNonceEnabled().
> >
> > Our application uses WiQuery and several other frameworks, and I only
> > had to make minor changes to make this application fully compliant
> > with the strict CSP. No changes were required to WiQuery. A small
> > change is required to the ChartJS library we use
> > (https://github.com/haster/java-chartjs) because ChartJS tries to
> > insert a stylesheet into the head. This stylesheet has to be rendered
> > via Wicket to get the nonce.
> >
> > Best regards,
> > Emond
> >
> > On Thu, Feb 27, 2020 at 2:00 PM Sebastien Briquet 
> > wrote:
> > >
> > > Hi Martin,
> > >
> > > Actually that's a good point! I will try to upgrade Wicket jQuery UI to
> > > wicket 9/CSP to see how it behaves...
> > >
> > > Thanks and best regards,
> > > Sebastien
> >
>


Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Maxim Solodovnik
[+] leave as is with .wicket--hidden & wicket-core.css

IMO we should sheep the version which will work as expected out-of-the-box
According to my tests `hidden` attribute doesn't work (even `display:
flex` breaks it)

On Wed, 26 Feb 2020 at 15:22, Andrea Del Bene  wrote:
>
> +1 to vote. I find your concerns legitimate
>
> On Tue, Feb 25, 2020 at 9:54 PM Sven Meier  wrote:
>
> > Hi all,
> >
> > we have a disagreement on how to style hidden elements in Wicket 9.x.
> >
> > Due to the new CSP support we can no longer use inline styling to hide
> > elements.
> > WICKET-6725 introduces new CSS classes and a file wicket-core.css.
> >
> > I don't think this is a good approach:
> >
> > - it adds a CSS file that is referenced by each page (after Wicket doing
> > fine without it for 15 years)
> > - the CSS is a mingle-mangle of out-of-date stylings (see
> > .wicket--hidden-fields)
> > - it's a kitchen-sink for left-over styles (see .wicket--color-red)
> > - it introduces a new class naming scheme not used anywhere else (wicket--)
> >
> > IMHO we should remove that file again (and the required infrastructure
> > in ResourceSettings/WebApplication) and just
> > use the HTML5 "hidden" attribute instead, whenever we want to hide
> > something (Component, Form, ...).
> > This "just works" in all browsers and is semantically correct. It has
> > one caveat when an application's CSS changes the default styling of
> > hidden elements (see
> > https://css-tricks.com/the-hidden-attribute-is-visibly-weak), but that's
> > in the responsibility of the application developer.
> > AjaxIndicatorAppender can just render a CSS class and leave the styling
> > to the application developer, nobody will be happy with the default
> > "red" anyway.
> >
> > Thus I'll be starting a vote in the next days with the following two
> > options:
> >
> > [] leave as is with .wicket--hidden & wicket-core.css
> >
> > [] use HTML5 "hidden" attribute instead
> >
> > This isn't the vote yet, it's just the announcement.
> > Maybe others see a third (forth?) option or want to raise their concerns
> > first.
> >
> > Sven
> >
> >
> >
>
> --
> Andrea Del Bene.
> Apache Wicket committer.



-- 
WBR
Maxim aka solomax


Re: UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
Was too fast :((

You IRC command actually started the build: "forced: by IRC user 
on channel ##wicket: retry"
Will try to be more careful next time

On Thu, 13 Feb 2020 at 23:05, Maxim Solodovnik  wrote:

> Thanks Martin,
>
> empty commit a bit ugly, but seems to be the only way :(
>
> On Thu, 13 Feb 2020 at 23:02, Martin Grigorov 
> wrote:
>
>> There are the ways I know of:
>>
>> 1) in IRC, server: freenode, channel: ##wicket: force build BUILDER_NAME
>> e.g.: force build wicket-master
>>
>> (I've just tried it and for some reason it doesn't work. Maybe I've
>> forgotten the correct commands to wicket-bot)
>>
>> 2) git commit --allow-empty -m "Trigger build" && git push
>>
>> Both without UI.
>>
>> On Thu, Feb 13, 2020 at 4:15 PM Maxim Solodovnik 
>> wrote:
>>
>> > Hello All,
>> >
>> > Is there any UI to restart broken build?
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>> >
>>
>
>
> --
> WBR
> Maxim aka solomax
>


-- 
WBR
Maxim aka solomax


Re: UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
Thanks Martin,

empty commit a bit ugly, but seems to be the only way :(

On Thu, 13 Feb 2020 at 23:02, Martin Grigorov  wrote:

> There are the ways I know of:
>
> 1) in IRC, server: freenode, channel: ##wicket: force build BUILDER_NAME
> e.g.: force build wicket-master
>
> (I've just tried it and for some reason it doesn't work. Maybe I've
> forgotten the correct commands to wicket-bot)
>
> 2) git commit --allow-empty -m "Trigger build" && git push
>
> Both without UI.
>
> On Thu, Feb 13, 2020 at 4:15 PM Maxim Solodovnik 
> wrote:
>
> > Hello All,
> >
> > Is there any UI to restart broken build?
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>


-- 
WBR
Maxim aka solomax


UI to restart broken build

2020-02-13 Thread Maxim Solodovnik
Hello All,

Is there any UI to restart broken build?

-- 
WBR
Maxim aka solomax


Re: buildbot failure in on wicket-master

2020-02-10 Thread Maxim Solodovnik
This should be some temporary network issues
(failing test trying to connect URL url = new URL("
http://wicket.apache.org/learn/books/wia.png;); )

On Tue, 11 Feb 2020 at 04:40, Emond Papegaaij 
wrote:

> I don't what happened here, but I'm pretty sure that I didn't break
> this with a simple CSS change. The test runs fine on my machine. Did
> something change in the infra?
>
> Emond
>
> On Mon, Feb 10, 2020 at 9:46 PM  wrote:
> >
> > The Buildbot has detected a new failure on builder wicket-master while
> building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master/builds/1245
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: bb_slave6_ubuntu
> >
> > Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-commit' triggered this build
> > Build Source Stamp: [branch master]
> 4d8d8503524dd46c087a398f061685ab310e7856
> > Blamelist: Emond Papegaaij 
> >
> > BUILD FAILED: failed compile
> >
> > Sincerely,
> >  -The Buildbot
> >
> >
> >
>


-- 
WBR
Maxim aka solomax


Browser DevTools and wicket-ajax-jquery

2020-02-08 Thread Maxim Solodovnik
Hello All,

recently I found it is hard to check/edit CSS in browser DevTools
After some investigation i found the issue is cased by "cross browser way
to check when the css is loaded" in wicket-ajax-jquery

I would like to propose to change it as follows
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -1821,28 +1821,21 @@
$css.attr(this.name,
this.value);
});

-   // add element to head
-   Wicket.Head.addElement(css);
-
-   // cross browser way to
check when the css is loaded
-   // taken from
http://www.backalleycoder.com/2011/03/20/link-tag-css-stylesheet-load-event/
-   // this makes a second GET
request to the css but it gets it either from the cache or
-   // downloads just the first
several bytes and realizes that the MIME is wrong and ignores the rest
-   var img =
document.createElement('img');
var notifyCalled = false;
-   img.onerror = function () {
+   css.onerror = function () {
if (!notifyCalled) {

notifyCalled = true;
notify();
}
};
-   img.src = css.href;
-   if (img.complete) {
- if (!notifyCalled) {
-   notifyCalled = true;
-   notify();
- }
+   css.onload = function () {
+   if (!notifyCalled) {
+
notifyCalled = true;
+   notify();
+   }
}
+   // add element to head
+   Wicket.Head.addElement(css);

return
FunctionsExecuter.ASYNC;
});


It work as expected in Chrome/Chromium/FF/IE11 latest
Unfortunately I was unable to test using Edge
Is it worth PR?

-- 
WBR
Maxim aka solomax


Re: [wicket] branch csp updated: WICKET-6725: fixed special Form placeholder rendering

2020-01-29 Thread Maxim Solodovnik
Hello Martin,

please see the discussion here:
https://github.com/apache/wicket/commit/e1bdfe74cc7d3c0fdb67712a665cb15164868bc1
 :))

On Wed, 29 Jan 2020 at 15:12, Martin Grigorov  wrote:

> On Tue, Jan 28, 2020 at 10:19 PM  wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > papegaaij pushed a commit to branch csp
> > in repository https://gitbox.apache.org/repos/asf/wicket.git
> >
> >
> > The following commit(s) were added to refs/heads/csp by this push:
> >  new fb290e8  WICKET-6725: fixed special Form placeholder rendering
> > fb290e8 is described below
> >
> > commit fb290e818a278eb69f4fa64d77514d8f3ee3068c
> > Author: Emond Papegaaij 
> > AuthorDate: Tue Jan 28 21:18:50 2020 +0100
> >
> > WICKET-6725: fixed special Form placeholder rendering
> > ---
> >  .../main/java/org/apache/wicket/markup/html/form/Form.java| 11
> > +++
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> >
> > diff --git
> > a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
> > b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
> > index a39160a..2ffc52b 100644
> > ---
> > a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
> > +++
> > b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java
> > @@ -1698,14 +1698,9 @@ public class Form extends WebMarkupContainer
> > else
> > {
> > // rewrite inner form tag as div
> > -   response.write(" > -   if (getOutputMarkupId())
> > -   {
> > -   response.write(" id=\"");
> > -   response.write(getMarkupId());
> > -   response.write("\"");
> > -   }
> > -   response.write(">");
> > +   response.write(
> > +   String.format(" class=\"%s\"
> > data-wicket-placeholder=\"\">",
> > +   getAjaxRegionMarkupId(),
> > getString(CssUtils.key(Component.class, "hidden";
> >
>
> Why did you replace the usage of getOutputMarkupId()+getMarkupId()
> with getAjaxRegionMarkupId() ?
> Please use better commit messages! It is not clear whether you wanted to
> actually make this change or broke it unintentionally.
>
>
> > }
> > }
> >
> >
> >
>


-- 
WBR
Maxim aka solomax


Re: build of master branch failed because of date format

2020-01-24 Thread Maxim Solodovnik
Thanks :)

On Fri, 24 Jan 2020 at 18:14, Andrea Del Bene  wrote:

> and in the meantime 11.0.6 has been released :-)
>
> On Fri, Jan 24, 2020 at 11:42 AM Andrea Del Bene 
> wrote:
>
> > I've already opened it back in November:
> >
> > https://issues.apache.org/jira/browse/INFRA-19481
> >
> > maybe we can send a friendly reminder.
> >
> > On Fri, Jan 24, 2020 at 8:35 AM Martin Grigorov 
> > wrote:
> >
> >> Hi Maxim,
> >>
> >> This must be because of an old build of JDK11 on BuildBot.
> >> Let's open a ticket at INFRA to install the latest.
> >>
> >> On Fri, Jan 24, 2020 at 8:46 AM Maxim Solodovnik 
> >> wrote:
> >>
> >> > Hello All,
> >> >
> >> > Recent builds of master branch are failed due to
> >> >
> >> > ZonedDateTimeConverterTest.convertToObject:49 expected:
> >> > <2016-07-11T01:02:03Z[Etc/UTC]> but was:
> >> > <2016-07-11T01:02:03Z[Etc/UCT]>
> >> >
> >> >
> >> > Maybe it worth to compare dates if "time zoneless" format?
> >> >
> >> > --
> >> > WBR
> >> > Maxim aka solomax
> >> >
> >>
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>


-- 
WBR
Maxim aka solomax


build of master branch failed because of date format

2020-01-23 Thread Maxim Solodovnik
Hello All,

Recent builds of master branch are failed due to

ZonedDateTimeConverterTest.convertToObject:49 expected:
<2016-07-11T01:02:03Z[Etc/UTC]> but was:
<2016-07-11T01:02:03Z[Etc/UCT]>


Maybe it worth to compare dates if "time zoneless" format?

-- 
WBR
Maxim aka solomax


Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Just have tested
Chrome might change the position of such tag in the DOM :( (inside table)

sorry for the noise

On Wed, 15 Jan 2020 at 23:54, Maxim Solodovnik  wrote:

> Maybe some non-html tag can be rendered as placeholder? (for ex.
> )
> It will be invisible :)
>
>
> On Wed, Jan 15, 2020, 17:44 Emond Papegaaij 
> wrote:
>
>> > > According to my tests
>> > > textarea with hidden attribute works the same way as `display: none`
>> > > (latest Chrome, FF, Chromium)
>> > >
>>
>> Maxim and Andrew: Yes, the display: none is very important. (That's
>> why it even has !important). The hidden attribute has the lowest
>> priority possible. Any matching CSS rule will override it's behavior.
>> For example, if you have this html:
>> 
>> li { display: list-item; }
>> This will be visible
>> 
>> The li is visible, even though it has the hidden attribute. This is
>> not what we want. Keep in mind that this is about components with
>> isVisible() == false. The only reason we render something is because a
>> placeholder is needed for Ajax updates.
>>
>> > Additionally, I think we should not use just
>> > [hidden] {
>> > ...
>> > }
>> >
>> > in wicker-core.css because this will affect *all* elements in the page.
>> And
>> > the applications may not want Wicket styling for their own hidden
>> elements.
>> > The CSS rule should be namespaced with "wicket-something", like
>> > wicket-xyz[hidden] {...}
>>
>> I totally agree with Martin here. hidden already has semantics, we
>> shouldn't tamper with that. Adding 'display: none!important' to hidden
>> breaks the behavior described above.
>>
>> > > So I would vote for using `hidden="hidden"` for placeholders and
>> preserving
>> > > `data-wicket-placeholder`
>> > > (due to hidden can be used in regular markup while
>> > > `data-wicket-placeholder` is clear way to determine the placeholders)
>>
>> The data-wicket-placeholder is indeed needed. All placeholders are
>> hidden, but not all hidden elements are placeholders. As stated above,
>> I'd vote against using the hidden attribute. We need something with a
>> wicket namespace here. We can have the CSS match
>> [data-wicket-placeholder], but I'm not a big fan of matching data
>> attributes in CSS.
>>
>> Best regards,
>> Emond
>>
>> > >
>> > > On Wed, 15 Jan 2020 at 04:55, Andrew Kondratev 
>> > > wrote:
>> > >
>> > > > Hi Everyone!
>> > > >
>> > > > Is this "none !important" actually needed? Elements with hidden
>> attribute
>> > > > are hidden by themselves, except the cases when they have some
>> display
>> > > > overrides (see
>> > > >
>> > >
>> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
>> > > > ).
>> > > > If developer/user does override he or she could take care of this by
>> > > > himself.
>> > > >
>> > > > If the only style in core css is this wicket--hidden the whole css
>> is,
>> > > > probably unnecessary.
>> > > >
>> > > > ср, 15 янв. 2020 г. в 10:38, Sven Meier :
>> > > >
>> > > > > Hi Edmond,
>> > > > >
>> > > > > then I'll ask again:
>> > > > >
>> > > > > Why not render a "hidden" attribute and style it in the core css:
>> > > > >
>> > > > > |[hidden] { display: none !important}|
>> > > > >
>> > > > > We could get rid of the "data-wicket-placeholder" attribute as
>> well,
>> > > and
>> > > > > let wicket-ajax check on the "hidden" attribute instead.
>> > > > >
>> > > > > Sven
>> > > > >
>> > > > > On 14.01.20 21:06, Emond Papegaaij wrote:
>> > > > > >>   >Using the hidden attribute is no option either,
>> > > > > >>   >because it is overridden by any css that sets display.
>> > > > > >>
>> > > > > >> why is that a no-option, hidden elements can be styled too:
>> > > > > > Dropping the styling altogether will force our users to package
>> their
>> > > > > > own styling for artifacts generated by Wicket. These style

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
rselves? I can put the registration
> of
> > > the
> > > > > > IHeaderContributor in a protected method in WebApplication. That
> way
> > > > > > you can change the behavior in a subclass. You can already
> change the
> > > > > > stylesheet if you need to.
> > > > > >
> > > > > >> Do you mean FormComponentFeedbackBorder's "color:red;" style?
> > > > > >> I wouldn't want that to be located in a 'kitchen-sink' CSS file
> in
> > > the
> > > > > >> future.
> > > > > > Yes, that's the styling I meant. There are more examples. IMHO
> those
> > > > > > are typical candidates for CSS classes, but without styling
> packaged
> > > > > > with Wicket (like with FeedbackPanel). The styling is not going
> to
> > > > > > match the users application anyway. Who would want to use red as
> a
> > > > > > color for a border? Even for me, being colorblind, that color is
> way
> > > > > > too saturated.
> > > > > >
> > > > > > Best regards,
> > > > > > Emond
> > > > > >
> > > > > >> Have fun
> > > > > >> Sven||
> > > > > >> ||
> > > > > >>
> > > > > >>
> > > > > >> On 14.01.20 20:31, Emond Papegaaij wrote:
> > > > > >>> Hi,
> > > > > >>>
> > > > > >>> Sven, we do need styling to hide components.
> > > > > >>> Component.renderPlaceholderTag renders an empty tag for
> whatever it
> > > > > >>> reads from your markup. That fact that it is empty, does not
> mean
> > > it
> > > > > >>> is invisible. For example, in my application I had empty
> list-items
> > > > > >>> (li) popping up all over the place. Using the hidden attribute
> is
> > > no
> > > > > >>> option either, because it is overridden by any css that sets
> > > display.
> > > > > >>> We need something that takes precedence over most styling and
> hides
> > > > > >>> the component for sure.
> > > > > >>>
> > > > > >>> Maxim, I didn't know about the application wide
> > > IHeaderContributors.
> > > > > >>> I'll give that a try, it seems cleaner to me than overriding
> > > > > >>> renderHead in Page.
> > > > > >>>
> > > > > >>> About the contents of the stylesheet, it will probably not
> contain
> > > > > >>> much styling, but it will be more than just wicket--hidden. For
> > > > > >>> example, the styling for the form submit handling markup needs
> to
> > > go
> > > > > >>> there as well. I also found some other places with inline
> styling,
> > > > > >>> like FormComponentFeedbackBorder. We need to decide what to do
> with
> > > > > >>> those as well.
> > > > > >>>
> > > > > >>> Best regards,
> > > > > >>> Emond
> > > > > >>>
> > > > > >>> On Tue, Jan 14, 2020 at 7:19 PM Sven Meier 
> > > wrote:
> > > > > >>>> Hi Maxim,
> > > > > >>>>
> > > > > >>>> an empty div with hidden inputs does not take any space.
> > > > > >>>>
> > > > > >>>> Try it with wicket-examples.
> > > > > >>>>
> > > > > >>>> Have fun
> > > > > >>>> Sven
> > > > > >>>>
> > > > > >>>> Am 14. Januar 2020 18:07:23 MEZ schrieb Maxim Solodovnik <
> > > > > solomax...@gmail.com>:
> > > > > >>>>> I thought the main idea is to keep placeholder for any
> element
> > > both
> > > > > >>>>> invisible and "take no space"
> > > > > >>>>> hidden attribute might work instead of `display: none`
> > > > > >>>>> The latter also hides all descendants [1], so I guess it
> should
> > > be
> > > > > >>>>> preferable
> > > > > >>>>&

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Hello Martin,

I did more tests :)
Browser Chrome latest

plain HTML











4 tabs
enter different text in all areas

via DevTools
1) first tab: div => hidden
2) second tab: textarea => hidden
3) third tab: div => display: none
4) fourth tab: textarea => display: none

submit them one by one and check Network tab:
Result: value for `ta` was passed in all 4 cases 

Maybe the test is wrong?

On Wed, 15 Jan 2020 at 14:19, Martin Grigorov  wrote:

> Hi Maxim,
>
> On Wed, Jan 15, 2020 at 8:54 AM Maxim Solodovnik 
> wrote:
>
> > Hello All,
> >
> > According to my tests
> > textarea with hidden attribute works the same way as `display: none`
> > (latest Chrome, FF, Chromium)
> >
>
> What exactly did you test ?
> According to
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> :
> Hidden elements shouldn't be linked from non-hidden elements, and elements
> that are descendants of a hidden element are still active, which means that
> script elements can still execute and form elements can still submit.
>
> This sounds like if you use 'hidden' attribute on a  that wraps some
> form elements, those elements will submit their values when you submit
> their form. With display:none the elements won't submit their values.
>
> Additionally, I think we should not use just
> [hidden] {
> ...
> }
>
> in wicker-core.css because this will affect *all* elements in the page. And
> the applications may not want Wicket styling for their own hidden elements.
> The CSS rule should be namespaced with "wicket-something", like
> wicket-xyz[hidden] {...}
>
>
> > hidden also hides all descendants
> >
> > So I would vote for using `hidden="hidden"` for placeholders and
> preserving
> > `data-wicket-placeholder`
> > (due to hidden can be used in regular markup while
> > `data-wicket-placeholder` is clear way to determine the placeholders)
> >
> > On Wed, 15 Jan 2020 at 04:55, Andrew Kondratev 
> > wrote:
> >
> > > Hi Everyone!
> > >
> > > Is this "none !important" actually needed? Elements with hidden
> attribute
> > > are hidden by themselves, except the cases when they have some display
> > > overrides (see
> > >
> >
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> > > ).
> > > If developer/user does override he or she could take care of this by
> > > himself.
> > >
> > > If the only style in core css is this wicket--hidden the whole css is,
> > > probably unnecessary.
> > >
> > > ср, 15 янв. 2020 г. в 10:38, Sven Meier :
> > >
> > > > Hi Edmond,
> > > >
> > > > then I'll ask again:
> > > >
> > > > Why not render a "hidden" attribute and style it in the core css:
> > > >
> > > > |[hidden] { display: none !important}|
> > > >
> > > > We could get rid of the "data-wicket-placeholder" attribute as well,
> > and
> > > > let wicket-ajax check on the "hidden" attribute instead.
> > > >
> > > > Sven
> > > >
> > > > On 14.01.20 21:06, Emond Papegaaij wrote:
> > > > >>   >Using the hidden attribute is no option either,
> > > > >>   >because it is overridden by any css that sets display.
> > > > >>
> > > > >> why is that a no-option, hidden elements can be styled too:
> > > > > Dropping the styling altogether will force our users to package
> their
> > > > > own styling for artifacts generated by Wicket. These styles are not
> > to
> > > > > make your application look nice, but to make certain Wicket
> internals
> > > > > work as expected. In the case of wicket--hidden, not much else can
> be
> > > > > done than use 'display:none'. In the case of the Form parts, more
> > > > > elaborate styling is need to keep the extra fields hidden without
> > > > > using display:none. Why put the burden on the user of Wicket when
> we
> > > > > can package those styling ourselves? I can put the registration of
> > the
> > > > > IHeaderContributor in a protected method in WebApplication. That
> way
> > > > > you can change the behavior in a subclass. You can already change
> the
> > > > > stylesheet if you need 

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
Hello All,

According to my tests
textarea with hidden attribute works the same way as `display: none`
(latest Chrome, FF, Chromium)

hidden also hides all descendants

So I would vote for using `hidden="hidden"` for placeholders and preserving
`data-wicket-placeholder`
(due to hidden can be used in regular markup while
`data-wicket-placeholder` is clear way to determine the placeholders)

On Wed, 15 Jan 2020 at 04:55, Andrew Kondratev  wrote:

> Hi Everyone!
>
> Is this "none !important" actually needed? Elements with hidden attribute
> are hidden by themselves, except the cases when they have some display
> overrides (see
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> ).
> If developer/user does override he or she could take care of this by
> himself.
>
> If the only style in core css is this wicket--hidden the whole css is,
> probably unnecessary.
>
> ср, 15 янв. 2020 г. в 10:38, Sven Meier :
>
> > Hi Edmond,
> >
> > then I'll ask again:
> >
> > Why not render a "hidden" attribute and style it in the core css:
> >
> > |[hidden] { display: none !important}|
> >
> > We could get rid of the "data-wicket-placeholder" attribute as well, and
> > let wicket-ajax check on the "hidden" attribute instead.
> >
> > Sven
> >
> > On 14.01.20 21:06, Emond Papegaaij wrote:
> > >>   >Using the hidden attribute is no option either,
> > >>   >because it is overridden by any css that sets display.
> > >>
> > >> why is that a no-option, hidden elements can be styled too:
> > > Dropping the styling altogether will force our users to package their
> > > own styling for artifacts generated by Wicket. These styles are not to
> > > make your application look nice, but to make certain Wicket internals
> > > work as expected. In the case of wicket--hidden, not much else can be
> > > done than use 'display:none'. In the case of the Form parts, more
> > > elaborate styling is need to keep the extra fields hidden without
> > > using display:none. Why put the burden on the user of Wicket when we
> > > can package those styling ourselves? I can put the registration of the
> > > IHeaderContributor in a protected method in WebApplication. That way
> > > you can change the behavior in a subclass. You can already change the
> > > stylesheet if you need to.
> > >
> > >> Do you mean FormComponentFeedbackBorder's "color:red;" style?
> > >> I wouldn't want that to be located in a 'kitchen-sink' CSS file in the
> > >> future.
> > > Yes, that's the styling I meant. There are more examples. IMHO those
> > > are typical candidates for CSS classes, but without styling packaged
> > > with Wicket (like with FeedbackPanel). The styling is not going to
> > > match the users application anyway. Who would want to use red as a
> > > color for a border? Even for me, being colorblind, that color is way
> > > too saturated.
> > >
> > > Best regards,
> > > Emond
> > >
> > >> Have fun
> > >> Sven||
> > >> ||
> > >>
> > >>
> > >> On 14.01.20 20:31, Emond Papegaaij wrote:
> > >>> Hi,
> > >>>
> > >>> Sven, we do need styling to hide components.
> > >>> Component.renderPlaceholderTag renders an empty tag for whatever it
> > >>> reads from your markup. That fact that it is empty, does not mean it
> > >>> is invisible. For example, in my application I had empty list-items
> > >>> (li) popping up all over the place. Using the hidden attribute is no
> > >>> option either, because it is overridden by any css that sets display.
> > >>> We need something that takes precedence over most styling and hides
> > >>> the component for sure.
> > >>>
> > >>> Maxim, I didn't know about the application wide IHeaderContributors.
> > >>> I'll give that a try, it seems cleaner to me than overriding
> > >>> renderHead in Page.
> > >>>
> > >>> About the contents of the stylesheet, it will probably not contain
> > >>> much styling, but it will be more than just wicket--hidden. For
> > >>> example, the styling for the form submit handling markup needs to go
> > >>> there as well. I also found some other places with inline styling,
> > >>> like FormComponentFeedbackBorder. We need to decide what to do with

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
I thought the main idea is to keep placeholder for any element both
invisible and "take no space"
hidden attribute might work instead of `display: none`
The latter also hides all descendants [1], so I guess it should be
preferable

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/display

On Wed, 15 Jan 2020 at 00:01, Sven Meier  wrote:

> Hi,
>
> do we really need this CSS?
>
> AFAIK the 'hidden' markup from Form and Component placeholders do not
> need any styling actually, they look fine without it.
> We should add a CSS class to the markup of course, but leave its styling
> to each project.
>
> Cases in wicket-examples (UploadProgressBar, deprecated ModalWindow and
> AjaxIndicatorAppender) could switch to a different solution (e.g. their
> own CSS).
>
> If wicket-base.css contains ".wicket--hidden" only, the effort isn't
> worth it IMHO.
>
> Sven
>
>
> On 14.01.20 16:23, Maxim Solodovnik wrote:
> > For example it can be added as
> > `Application.get().getHeaderContributorListeners()`
> >
> > On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik 
> wrote:
> >
> >> `!important` is not the silver bullet (as well as inline style)
> >>
> >> `renderHead` is not as important as `onConfigure`, so I believe it
> >> shouldn't be made mandatory
> >> Maybe there is some `hackish` way to inject this css only once for any
> >> component hierarchy?
> >>
> >> On Tue, 14 Jan 2020 at 15:55, Emond Papegaaij <
> emond.papega...@gmail.com>
> >> wrote:
> >>
> >>> Rendering components without a page will indeed require you to include
> >>> the core css file yourself. I think that's better than adding the css
> >>> file with every component, as that will impose a massive overhead.
> >>> I've renamed the css file to wicket-core.css as suggested by Martin.
> >>> The idea is to collect all styling used with wicket-core in this css
> >>> file. I do not like the idea to use a behavior for adding the
> >>> stylesheet, as that will increase the size of every page. Maybe a
> >>> temporary behavior can be used, but that will need to be re-added on
> >>> every render then. Maybe, we can add a check to super.renderHead, like
> >>> we do with onConfgure and onInitialize?
> >>>
> >>> Using the hidden attribute is not a good idea, for the same reason as
> >>> I chose to use !important in the css file: any matching css rule that
> >>> is more specify will otherwise override the visibility and cause the
> >>> component to be visible anyway (like display: flex).
> >>>
> >>> Best regards,
> >>> Emond
> >>>
> >>> On Tue, Jan 14, 2020 at 9:10 AM Maxim Solodovnik  >
> >>> wrote:
> >>>> The problem as I see it
> >>>> The component will be rendered without page (and without CSS file
> >>> itself)
> >>>> so element with this class will actually be visible 
> >>>>
> >>>> On Tue, 14 Jan 2020 at 15:08, Martin Grigorov 
> >>> wrote:
> >>>>> On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik <
> >>> solomax...@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>>> An related question:
> >>>>>> Will this code
> >>>>>>
> >>>>>>
> >>>
> `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
> >>>>>> work as expected?
> >>>>>>
> >>>>> This method will render the component with class="wicket--hidden" on
> >>> its
> >>>>> HTML element. With TagTester you can verify
> >>>>> CSP checks are done only by the browsers.
> >>>>>
> >>>>>
> >>>>>>
> >>>>>> On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik <
> >>> solomax...@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Is this comment make sense:
> >>>>>>>
> >>>
> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
> >>>>>>> ?
> >>>>>>>
> >>>>>>> On Tue, 14 Jan 2020 at 14:13, Martin Grigorov <
> >>> mgrigo...@apache.org>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> On Tue, Jan

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
For example it can be added as
`Application.get().getHeaderContributorListeners()`

On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik  wrote:

> `!important` is not the silver bullet (as well as inline style)
>
> `renderHead` is not as important as `onConfigure`, so I believe it
> shouldn't be made mandatory
> Maybe there is some `hackish` way to inject this css only once for any
> component hierarchy?
>
> On Tue, 14 Jan 2020 at 15:55, Emond Papegaaij 
> wrote:
>
>> Rendering components without a page will indeed require you to include
>> the core css file yourself. I think that's better than adding the css
>> file with every component, as that will impose a massive overhead.
>> I've renamed the css file to wicket-core.css as suggested by Martin.
>> The idea is to collect all styling used with wicket-core in this css
>> file. I do not like the idea to use a behavior for adding the
>> stylesheet, as that will increase the size of every page. Maybe a
>> temporary behavior can be used, but that will need to be re-added on
>> every render then. Maybe, we can add a check to super.renderHead, like
>> we do with onConfgure and onInitialize?
>>
>> Using the hidden attribute is not a good idea, for the same reason as
>> I chose to use !important in the css file: any matching css rule that
>> is more specify will otherwise override the visibility and cause the
>> component to be visible anyway (like display: flex).
>>
>> Best regards,
>> Emond
>>
>> On Tue, Jan 14, 2020 at 9:10 AM Maxim Solodovnik 
>> wrote:
>> >
>> > The problem as I see it
>> > The component will be rendered without page (and without CSS file
>> itself)
>> > so element with this class will actually be visible 
>> >
>> > On Tue, 14 Jan 2020 at 15:08, Martin Grigorov 
>> wrote:
>> >
>> > > On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik <
>> solomax...@gmail.com>
>> > > wrote:
>> > >
>> > > > An related question:
>> > > > Will this code
>> > > >
>> > > >
>> > >
>> `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
>> > > > work as expected?
>> > > >
>> > >
>> > > This method will render the component with class="wicket--hidden" on
>> its
>> > > HTML element. With TagTester you can verify
>> > > CSP checks are done only by the browsers.
>> > >
>> > >
>> > > >
>> > > >
>> > > > On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik <
>> solomax...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Is this comment make sense:
>> > > > >
>> > > >
>> > >
>> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
>> > > > > ?
>> > > > >
>> > > > > On Tue, 14 Jan 2020 at 14:13, Martin Grigorov <
>> mgrigo...@apache.org>
>> > > > > wrote:
>> > > > >
>> > > > >> On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik <
>> > > solomax...@gmail.com>
>> > > > >> wrote:
>> > > > >>
>> > > > >> > Wasn't aware of `hidden` attribute
>> > > > >> > (and it seems to be widely supported
>> > > > >> >
>> > > > >>
>> > > >
>> > >
>> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
>> > > > >> > )
>> > > > >> >
>> > > > >>
>> > > > >> Thanks for the reference, Maxim!
>> > > > >>
>> > > > >> It says "elements that are descendants of a hidden element are
>> still
>> > > > >> active, which means that script elements can still execute and
>> form
>> > > > >> elements can still submit" and this is different than display:
>> none.
>> > > > >> So we should stick with CSS display!
>> > > > >>
>> > > > >>
>> > > > >> > Thanks :)
>> > > > >> >
>> > > > >> > On Tue, 14 Jan 2020 at 14:01, Martin Grigorov <
>> mgrigo...@apache.org
>> > > >
>> > > > >> > wrote:
>> > > > >> >
&g

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
`!important` is not the silver bullet (as well as inline style)

`renderHead` is not as important as `onConfigure`, so I believe it
shouldn't be made mandatory
Maybe there is some `hackish` way to inject this css only once for any
component hierarchy?

On Tue, 14 Jan 2020 at 15:55, Emond Papegaaij 
wrote:

> Rendering components without a page will indeed require you to include
> the core css file yourself. I think that's better than adding the css
> file with every component, as that will impose a massive overhead.
> I've renamed the css file to wicket-core.css as suggested by Martin.
> The idea is to collect all styling used with wicket-core in this css
> file. I do not like the idea to use a behavior for adding the
> stylesheet, as that will increase the size of every page. Maybe a
> temporary behavior can be used, but that will need to be re-added on
> every render then. Maybe, we can add a check to super.renderHead, like
> we do with onConfgure and onInitialize?
>
> Using the hidden attribute is not a good idea, for the same reason as
> I chose to use !important in the css file: any matching css rule that
> is more specify will otherwise override the visibility and cause the
> component to be visible anyway (like display: flex).
>
> Best regards,
> Emond
>
> On Tue, Jan 14, 2020 at 9:10 AM Maxim Solodovnik 
> wrote:
> >
> > The problem as I see it
> > The component will be rendered without page (and without CSS file itself)
> > so element with this class will actually be visible 
> >
> > On Tue, 14 Jan 2020 at 15:08, Martin Grigorov 
> wrote:
> >
> > > On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik <
> solomax...@gmail.com>
> > > wrote:
> > >
> > > > An related question:
> > > > Will this code
> > > >
> > > >
> > >
> `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
> > > > work as expected?
> > > >
> > >
> > > This method will render the component with class="wicket--hidden" on
> its
> > > HTML element. With TagTester you can verify
> > > CSP checks are done only by the browsers.
> > >
> > >
> > > >
> > > >
> > > > On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik  >
> > > > wrote:
> > > >
> > > > > Is this comment make sense:
> > > > >
> > > >
> > >
> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
> > > > > ?
> > > > >
> > > > > On Tue, 14 Jan 2020 at 14:13, Martin Grigorov <
> mgrigo...@apache.org>
> > > > > wrote:
> > > > >
> > > > >> On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik <
> > > solomax...@gmail.com>
> > > > >> wrote:
> > > > >>
> > > > >> > Wasn't aware of `hidden` attribute
> > > > >> > (and it seems to be widely supported
> > > > >> >
> > > > >>
> > > >
> > >
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> > > > >> > )
> > > > >> >
> > > > >>
> > > > >> Thanks for the reference, Maxim!
> > > > >>
> > > > >> It says "elements that are descendants of a hidden element are
> still
> > > > >> active, which means that script elements can still execute and
> form
> > > > >> elements can still submit" and this is different than display:
> none.
> > > > >> So we should stick with CSS display!
> > > > >>
> > > > >>
> > > > >> > Thanks :)
> > > > >> >
> > > > >> > On Tue, 14 Jan 2020 at 14:01, Martin Grigorov <
> mgrigo...@apache.org
> > > >
> > > > >> > wrote:
> > > > >> >
> > > > >> > > Hi,
> > > > >> > >
> > > > >> > > 1) I see that such CSS resource might be used for other
> needs, not
> > > > >> just
> > > > >> > > this particular case but would it be an option to use "hidden"
> > > > >> attribute
> > > > >> > in
> > > > >> > > this case instead of CSS "display" ?
> > > > >> > >
> > > > >> > > 2) wicket-core.css instead of wicket-base.css

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
The problem as I see it
The component will be rendered without page (and without CSS file itself)
so element with this class will actually be visible 

On Tue, 14 Jan 2020 at 15:08, Martin Grigorov  wrote:

> On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik 
> wrote:
>
> > An related question:
> > Will this code
> >
> >
> `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
> > work as expected?
> >
>
> This method will render the component with class="wicket--hidden" on its
> HTML element. With TagTester you can verify
> CSP checks are done only by the browsers.
>
>
> >
> >
> > On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik 
> > wrote:
> >
> > > Is this comment make sense:
> > >
> >
> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
> > > ?
> > >
> > > On Tue, 14 Jan 2020 at 14:13, Martin Grigorov 
> > > wrote:
> > >
> > >> On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik <
> solomax...@gmail.com>
> > >> wrote:
> > >>
> > >> > Wasn't aware of `hidden` attribute
> > >> > (and it seems to be widely supported
> > >> >
> > >>
> >
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> > >> > )
> > >> >
> > >>
> > >> Thanks for the reference, Maxim!
> > >>
> > >> It says "elements that are descendants of a hidden element are still
> > >> active, which means that script elements can still execute and form
> > >> elements can still submit" and this is different than display: none.
> > >> So we should stick with CSS display!
> > >>
> > >>
> > >> > Thanks :)
> > >> >
> > >> > On Tue, 14 Jan 2020 at 14:01, Martin Grigorov  >
> > >> > wrote:
> > >> >
> > >> > > Hi,
> > >> > >
> > >> > > 1) I see that such CSS resource might be used for other needs, not
> > >> just
> > >> > > this particular case but would it be an option to use "hidden"
> > >> attribute
> > >> > in
> > >> > > this case instead of CSS "display" ?
> > >> > >
> > >> > > 2) wicket-core.css instead of wicket-base.css ?
> > >> > >
> > >> > > On Mon, Jan 13, 2020 at 9:43 PM  wrote:
> > >> > >
> > >> > > > This is an automated email from the ASF dual-hosted git
> > repository.
> > >> > > >
> > >> > > > papegaaij pushed a commit to branch csp
> > >> > > > in repository https://gitbox.apache.org/repos/asf/wicket.git
> > >> > > >
> > >> > > >
> > >> > > > The following commit(s) were added to refs/heads/csp by this
> push:
> > >> > > >  new 6d91a6a  WICKET-6725: replace display:none by
> > >> wicket--hidden
> > >> > css
> > >> > > > class
> > >> > > > 6d91a6a is described below
> > >> > > >
> > >> > > > commit 6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2
> > >> > > > Author: Emond Papegaaij 
> > >> > > > AuthorDate: Mon Jan 13 20:43:01 2020 +0100
> > >> > > >
> > >> > > > WICKET-6725: replace display:none by wicket--hidden css
> class
> > >> > > > ---
> > >> > > >  .../src/main/java/org/apache/wicket/Component.java |  2 +-
> > >> > > >  .../src/main/java/org/apache/wicket/Page.java  | 11 +++
> > >> > > >  .../wicket/css/WicketBaseCSSResourceReference.java | 36
> > >> > > > ++
> > >> > > >  .../java/org/apache/wicket/css/wicket-base.css |  3 ++
> > >> > > >  .../apache/wicket/settings/ResourceSettings.java   | 31
> > >> > > > +++
> > >> > > >  .../ajax/markup/html/AjaxIndicatorAppender.java|  2 +-
> > >> > > >  6 files changed, 83 insertions(+), 2 deletions(-)
> > >> > > >
> > >> > > > diff --git
> > >> a/wicket-core/src/main/java/org/apache/wicket/Component.java
> > >> > > > b/wicket-core/src/main

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Maxim Solodovnik
An related question:
Will this code
`org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
work as expected?


On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik  wrote:

> Is this comment make sense:
> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
> ?
>
> On Tue, 14 Jan 2020 at 14:13, Martin Grigorov 
> wrote:
>
>> On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik 
>> wrote:
>>
>> > Wasn't aware of `hidden` attribute
>> > (and it seems to be widely supported
>> >
>> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
>> > )
>> >
>>
>> Thanks for the reference, Maxim!
>>
>> It says "elements that are descendants of a hidden element are still
>> active, which means that script elements can still execute and form
>> elements can still submit" and this is different than display: none.
>> So we should stick with CSS display!
>>
>>
>> > Thanks :)
>> >
>> > On Tue, 14 Jan 2020 at 14:01, Martin Grigorov 
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > 1) I see that such CSS resource might be used for other needs, not
>> just
>> > > this particular case but would it be an option to use "hidden"
>> attribute
>> > in
>> > > this case instead of CSS "display" ?
>> > >
>> > > 2) wicket-core.css instead of wicket-base.css ?
>> > >
>> > > On Mon, Jan 13, 2020 at 9:43 PM  wrote:
>> > >
>> > > > This is an automated email from the ASF dual-hosted git repository.
>> > > >
>> > > > papegaaij pushed a commit to branch csp
>> > > > in repository https://gitbox.apache.org/repos/asf/wicket.git
>> > > >
>> > > >
>> > > > The following commit(s) were added to refs/heads/csp by this push:
>> > > >  new 6d91a6a  WICKET-6725: replace display:none by
>> wicket--hidden
>> > css
>> > > > class
>> > > > 6d91a6a is described below
>> > > >
>> > > > commit 6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2
>> > > > Author: Emond Papegaaij 
>> > > > AuthorDate: Mon Jan 13 20:43:01 2020 +0100
>> > > >
>> > > > WICKET-6725: replace display:none by wicket--hidden css class
>> > > > ---
>> > > >  .../src/main/java/org/apache/wicket/Component.java |  2 +-
>> > > >  .../src/main/java/org/apache/wicket/Page.java  | 11 +++
>> > > >  .../wicket/css/WicketBaseCSSResourceReference.java | 36
>> > > > ++
>> > > >  .../java/org/apache/wicket/css/wicket-base.css |  3 ++
>> > > >  .../apache/wicket/settings/ResourceSettings.java   | 31
>> > > > +++
>> > > >  .../ajax/markup/html/AjaxIndicatorAppender.java|  2 +-
>> > > >  6 files changed, 83 insertions(+), 2 deletions(-)
>> > > >
>> > > > diff --git
>> a/wicket-core/src/main/java/org/apache/wicket/Component.java
>> > > > b/wicket-core/src/main/java/org/apache/wicket/Component.java
>> > > > index 9da8ec5..d2da23b 100644
>> > > > --- a/wicket-core/src/main/java/org/apache/wicket/Component.java
>> > > > +++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
>> > > > @@ -2367,7 +2367,7 @@ public abstract class Component
>> > > > response.write(name);
>> > > > response.write(" id=\"");
>> > > > response.write(getAjaxRegionMarkupId());
>> > > > -   response.write("\" style=\"display:none\"
>> > > > data-wicket-placeholder=\"\">> > > > +   response.write("\" class=\"wicket--hidden\"
>> > > > data-wicket-placeholder=\"\">> > > > response.write(name);
>> > > > response.write(">");
>> > > > }
>> > > > diff --git a/wicket-core/src/main/java/org/apache/wicket/Page.java
>> > > > b/wicket-core/src/main/java/org/apache/wicket/Page.java
>> > > > index 3f0f5b5..3d70ad8 100644
>> > > > --- a/wicket-core/src/main/java/org/apache/wicket/Page.java
>> > > > +++ b/wicket-core/src/m

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-13 Thread Maxim Solodovnik
Is this comment make sense:
https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
?

On Tue, 14 Jan 2020 at 14:13, Martin Grigorov  wrote:

> On Tue, Jan 14, 2020 at 9:05 AM Maxim Solodovnik 
> wrote:
>
> > Wasn't aware of `hidden` attribute
> > (and it seems to be widely supported
> >
> https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
> > )
> >
>
> Thanks for the reference, Maxim!
>
> It says "elements that are descendants of a hidden element are still
> active, which means that script elements can still execute and form
> elements can still submit" and this is different than display: none.
> So we should stick with CSS display!
>
>
> > Thanks :)
> >
> > On Tue, 14 Jan 2020 at 14:01, Martin Grigorov 
> > wrote:
> >
> > > Hi,
> > >
> > > 1) I see that such CSS resource might be used for other needs, not just
> > > this particular case but would it be an option to use "hidden"
> attribute
> > in
> > > this case instead of CSS "display" ?
> > >
> > > 2) wicket-core.css instead of wicket-base.css ?
> > >
> > > On Mon, Jan 13, 2020 at 9:43 PM  wrote:
> > >
> > > > This is an automated email from the ASF dual-hosted git repository.
> > > >
> > > > papegaaij pushed a commit to branch csp
> > > > in repository https://gitbox.apache.org/repos/asf/wicket.git
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/csp by this push:
> > > >  new 6d91a6a  WICKET-6725: replace display:none by wicket--hidden
> > css
> > > > class
> > > > 6d91a6a is described below
> > > >
> > > > commit 6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2
> > > > Author: Emond Papegaaij 
> > > > AuthorDate: Mon Jan 13 20:43:01 2020 +0100
> > > >
> > > > WICKET-6725: replace display:none by wicket--hidden css class
> > > > ---
> > > >  .../src/main/java/org/apache/wicket/Component.java |  2 +-
> > > >  .../src/main/java/org/apache/wicket/Page.java  | 11 +++
> > > >  .../wicket/css/WicketBaseCSSResourceReference.java | 36
> > > > ++
> > > >  .../java/org/apache/wicket/css/wicket-base.css |  3 ++
> > > >  .../apache/wicket/settings/ResourceSettings.java   | 31
> > > > +++
> > > >  .../ajax/markup/html/AjaxIndicatorAppender.java|  2 +-
> > > >  6 files changed, 83 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git
> a/wicket-core/src/main/java/org/apache/wicket/Component.java
> > > > b/wicket-core/src/main/java/org/apache/wicket/Component.java
> > > > index 9da8ec5..d2da23b 100644
> > > > --- a/wicket-core/src/main/java/org/apache/wicket/Component.java
> > > > +++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
> > > > @@ -2367,7 +2367,7 @@ public abstract class Component
> > > > response.write(name);
> > > > response.write(" id=\"");
> > > > response.write(getAjaxRegionMarkupId());
> > > > -   response.write("\" style=\"display:none\"
> > > > data-wicket-placeholder=\"\"> > > > +   response.write("\" class=\"wicket--hidden\"
> > > > data-wicket-placeholder=\"\"> > > > response.write(name);
> > > > response.write(">");
> > > > }
> > > > diff --git a/wicket-core/src/main/java/org/apache/wicket/Page.java
> > > > b/wicket-core/src/main/java/org/apache/wicket/Page.java
> > > > index 3f0f5b5..3d70ad8 100644
> > > > --- a/wicket-core/src/main/java/org/apache/wicket/Page.java
> > > > +++ b/wicket-core/src/main/java/org/apache/wicket/Page.java
> > > > @@ -24,10 +24,13 @@ import java.util.Set;
> > > >
> > > >  import org.apache.wicket.authorization.UnauthorizedActionException;
> > > >  import org.apache.wicket.core.util.lang.WicketObjects;
> > > > +import org.apache.wicket.css.WicketBaseCSSResourceReference;
> > > >  import org.apache.wicket.feedback.FeedbackDelay;
> > > >  import org.apache.wicket.markup.MarkupException;
> > > >  import org.apache.wicket.markup.MarkupStream;
> > > >  import org.apache.wi

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-13 Thread Maxim Solodovnik
Wasn't aware of `hidden` attribute
(and it seems to be widely supported
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden)
Thanks :)

On Tue, 14 Jan 2020 at 14:01, Martin Grigorov  wrote:

> Hi,
>
> 1) I see that such CSS resource might be used for other needs, not just
> this particular case but would it be an option to use "hidden" attribute in
> this case instead of CSS "display" ?
>
> 2) wicket-core.css instead of wicket-base.css ?
>
> On Mon, Jan 13, 2020 at 9:43 PM  wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > papegaaij pushed a commit to branch csp
> > in repository https://gitbox.apache.org/repos/asf/wicket.git
> >
> >
> > The following commit(s) were added to refs/heads/csp by this push:
> >  new 6d91a6a  WICKET-6725: replace display:none by wicket--hidden css
> > class
> > 6d91a6a is described below
> >
> > commit 6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2
> > Author: Emond Papegaaij 
> > AuthorDate: Mon Jan 13 20:43:01 2020 +0100
> >
> > WICKET-6725: replace display:none by wicket--hidden css class
> > ---
> >  .../src/main/java/org/apache/wicket/Component.java |  2 +-
> >  .../src/main/java/org/apache/wicket/Page.java  | 11 +++
> >  .../wicket/css/WicketBaseCSSResourceReference.java | 36
> > ++
> >  .../java/org/apache/wicket/css/wicket-base.css |  3 ++
> >  .../apache/wicket/settings/ResourceSettings.java   | 31
> > +++
> >  .../ajax/markup/html/AjaxIndicatorAppender.java|  2 +-
> >  6 files changed, 83 insertions(+), 2 deletions(-)
> >
> > diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java
> > b/wicket-core/src/main/java/org/apache/wicket/Component.java
> > index 9da8ec5..d2da23b 100644
> > --- a/wicket-core/src/main/java/org/apache/wicket/Component.java
> > +++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
> > @@ -2367,7 +2367,7 @@ public abstract class Component
> > response.write(name);
> > response.write(" id=\"");
> > response.write(getAjaxRegionMarkupId());
> > -   response.write("\" style=\"display:none\"
> > data-wicket-placeholder=\"\"> > +   response.write("\" class=\"wicket--hidden\"
> > data-wicket-placeholder=\"\"> > response.write(name);
> > response.write(">");
> > }
> > diff --git a/wicket-core/src/main/java/org/apache/wicket/Page.java
> > b/wicket-core/src/main/java/org/apache/wicket/Page.java
> > index 3f0f5b5..3d70ad8 100644
> > --- a/wicket-core/src/main/java/org/apache/wicket/Page.java
> > +++ b/wicket-core/src/main/java/org/apache/wicket/Page.java
> > @@ -24,10 +24,13 @@ import java.util.Set;
> >
> >  import org.apache.wicket.authorization.UnauthorizedActionException;
> >  import org.apache.wicket.core.util.lang.WicketObjects;
> > +import org.apache.wicket.css.WicketBaseCSSResourceReference;
> >  import org.apache.wicket.feedback.FeedbackDelay;
> >  import org.apache.wicket.markup.MarkupException;
> >  import org.apache.wicket.markup.MarkupStream;
> >  import org.apache.wicket.markup.MarkupType;
> > +import org.apache.wicket.markup.head.CssHeaderItem;
> > +import org.apache.wicket.markup.head.IHeaderResponse;
> >  import org.apache.wicket.markup.html.WebPage;
> >  import org.apache.wicket.markup.resolver.IComponentResolver;
> >  import org.apache.wicket.model.IModel;
> > @@ -1003,6 +1006,14 @@ public abstract class Page extends MarkupContainer
> > }
> > }
> >
> > +   @Override
> > +   public void renderHead(IHeaderResponse response)
> > +   {
> > +   super.renderHead(response);
> > +   response.render(
> > +
> >
> CssHeaderItem.forReference(getApplication().getResourceSettings().getWicketBaseCSS()));
> > +   }
> > +
> > /**
> >  * THIS METHOD IS NOT PART OF THE WICKET PUBLIC API. DO NOT CALL.
> >  *
> > diff --git
> >
> a/wicket-core/src/main/java/org/apache/wicket/css/WicketBaseCSSResourceReference.java
> >
> b/wicket-core/src/main/java/org/apache/wicket/css/WicketBaseCSSResourceReference.java
> > new file mode 100644
> > index 000..9247216
> > --- /dev/null
> > +++
> >
> b/wicket-core/src/main/java/org/apache/wicket/css/WicketBaseCSSResourceReference.java
> > @@ -0,0 +1,36 @@
> > +/*
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements.  See the NOTICE file distributed with
> > + * this work for additional information regarding copyright ownership.
> > + * The ASF licenses this file to You under the Apache License, Version
> 2.0
> > + * (the "License"); you may not use this file except in compliance with
> > + * the License.  You may obtain a copy of the License at
> > + *
> > + *  http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing, software
> > + * distributed under the License 

Re: [ANNOUNCE] WicketStuff 9.0.0-M4 Released

2020-01-11 Thread Maxim Solodovnik
Thanks Andrea,

Wicket is significant part of my life :)
I'll try to do as much as I can :)

On Sat, 11 Jan 2020 at 19:52, Andrea Del Bene  wrote:

> Thanks Maxim for your effort with WicketStuff!
>
> On Sat, Jan 11, 2020, 9:27 AM Maxim Solodovnik 
> wrote:
>
> > WicketStuff core 9.0.0-M4 based on Apache Wicket 9.0.0-M4 is released
> > and soon will be available at Maven Central!
> >
> > The changelog is:
> >
> > Maxim Solodovnik (11):
> >   Tests command is added to improve OracleJDK detection
> >   Java vendor detection is updated
> >   Switching to the next development version
> >   Build should be fixed
> >   HazelcastDataSource is fixed to use correct serializer
> >   Tests are updated
> >   jackson-databind is updated
> >   Better implementation of serializer injection
> >   Libraries are updated
> >   Redundant trailing spaces are removed
> >   wicketstuff-core-9.0.0-M4 is released
> >
> > Andrea Del Bene (6):
> >   Response content type set as first step.
> >   updated jackson library to resolve security alert.
> >   Update readme.md
> >   Merge pull request #683 from
> >
> >
> wicketstuff/dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.9.10.1
> >   Update readme.md
> >   Update readme.md
> >
> > Sven Meier (3):
> >   updated readme, added static getter
> >   WICKET-6708 use post parameters
> >   WICKET-6148 removed on prefix
> >
> > Martin Tzvetanov Grigorov (2):
> >   Upgrade Scala to 2.13.1
> >   Bump Hamcrest to 2.2
> >
> > Thorsten Schöning (2):
> >   URL.getFile doesn't decode paths in file-URLs in case spaces are
> > used. (#678)
> >   JamonMonitoredRequestCycleTest fails on Windows in case JVMs are
> > reused. (#679)
> >
> > Christoph Jost (1):
> >   fix for list flattening #685
> >
> > dependabot[bot] (1):
> >   Bump jackson-databind from 2.9.10 to 2.9.10.1
> >
> > xzr (1):
> >   reintroduce dispatchToNonVisibleComponents
> >
> >
> > The WicketStuff team
> >
>


-- 
WBR
Maxim aka solomax


[ANNOUNCE] WicketStuff 9.0.0-M4 Released

2020-01-11 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M4 based on Apache Wicket 9.0.0-M4 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (11):
  Tests command is added to improve OracleJDK detection
  Java vendor detection is updated
  Switching to the next development version
  Build should be fixed
  HazelcastDataSource is fixed to use correct serializer
  Tests are updated
  jackson-databind is updated
  Better implementation of serializer injection
  Libraries are updated
  Redundant trailing spaces are removed
  wicketstuff-core-9.0.0-M4 is released

Andrea Del Bene (6):
  Response content type set as first step.
  updated jackson library to resolve security alert.
  Update readme.md
  Merge pull request #683 from
wicketstuff/dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.9.10.1
  Update readme.md
  Update readme.md

Sven Meier (3):
  updated readme, added static getter
  WICKET-6708 use post parameters
  WICKET-6148 removed on prefix

Martin Tzvetanov Grigorov (2):
  Upgrade Scala to 2.13.1
  Bump Hamcrest to 2.2

Thorsten Schöning (2):
  URL.getFile doesn't decode paths in file-URLs in case spaces are
used. (#678)
  JamonMonitoredRequestCycleTest fails on Windows in case JVMs are
reused. (#679)

Christoph Jost (1):
  fix for list flattening #685

dependabot[bot] (1):
  Bump jackson-databind from 2.9.10 to 2.9.10.1

xzr (1):
  reintroduce dispatchToNonVisibleComponents


The WicketStuff team


[ANNOUNCE] WicketStuff 8.7.0 Released

2020-01-10 Thread Maxim Solodovnik
WicketStuff core 8.7.0 based on Apache Wicket 8.7.0 is released
and soon will be available at Maven Central!

The changelog is:

Andrea Del Bene (1):
  Response content type set as first step.

Christoph Jost (1):
  fix for list flattening #685

Martin Tzvetanov Grigorov (2):
  Issue #676 Reduce the amount of logged text during test execution
  Revert "JamonMonitoredRequestCycleTest fails on Windows in case JVMs
are reused. (#679)"

Maxim Solodovnik (4):
  Switching to the next development version
  Build should be fixed
  Jackson is updated
  wicketstuff-core-8.7.0 is released

Sven Meier (2):
  updated readme, added static getter
  WICKET-6708 use post parameters

Thorsten Schöning (2):
  URL.getFile doesn't decode paths in file-URLs in case spaces are
used. (#678)
  JamonMonitoredRequestCycleTest fails on Windows in case JVMs are
reused. (#679)

xzr (1):
  reintroduce dispatchToNonVisibleComponents


The WicketStuff team


[ANNOUNCE] WicketStuff 7.16.0 Released

2020-01-10 Thread Maxim Solodovnik
WicketStuff core 7.16.0 based on Apache Wicket 7.16.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (4):
  Switching to the next development version
  Jamon tests are fixed
  Some dependencies are updated
  wicketstuff-core-7.16.0 is released

Sven Meier (1):
  WICKET-6708 use post parameters


The WicketStuff team


Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
there is failOnError option
https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#failOnError
It can be turned on :))

On Fri, 10 Jan 2020 at 17:27, Emond Papegaaij 
wrote:

> Indeed, the build does not fail, it barfs various nasty errors and
> ends with 'BUILD SUCCESS' :) It does however not build the javadoc.
> I've filed https://issues.apache.org/jira/browse/MJAVADOC-633
>
> Best regards,
> Emond
>
> On Fri, Jan 10, 2020 at 10:19 AM Martin Grigorov 
> wrote:
> >
> > On Fri, Jan 10, 2020 at 11:12 AM Martin Grigorov 
> > wrote:
> >
> > >
> > >
> > > On Fri, Jan 10, 2020 at 11:02 AM Martin Grigorov  >
> > > wrote:
> > >
> > >>
> > >>
> > >> On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik <
> solomax...@gmail.com>
> > >> wrote:
> > >>
> > >>> `clean package` sounds more reasonable to me :)
> > >>>
> > >>
> > >> agreed, but let's change that only once we have a fix/workaround for
> the
> > >> problem
> > >>
> > >
> > > it seems it does not break the build, so it is OK to make this change
> now
> > > I will do it
> > >
> >
> > Done!
> >
> >
> > >
> > >
> > >>
> > >>
> > >>>
> > >>> On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik  >
> > >>> wrote:
> > >>>
> > >>> > `fast` profile skips javadoc 
> > >>> >
> > >>> > On Fri, 10 Jan 2020 at 15:56, Martin Grigorov <
> mgrigo...@apache.org>
> > >>> > wrote:
> > >>> >
> > >>> >> Hi Emond,
> > >>> >>
> > >>> >> Locally while testing new JDK builds I always use: mvn14 clean
> install
> > >>> >> -Pfast,java14
> > >>> >> mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn
> > >>> >> and I don't remember having issues with javadoc since a long time.
> > >>> >>
> > >>> >> On Fri, Jan 10, 2020 at 10:45 AM Emond Papegaaij <
> > >>> >> emond.papega...@gmail.com>
> > >>> >> wrote:
> > >>> >>
> > >>> >> > Hi all,
> > >>> >> >
> > >>> >> > I just noticed a problem with building Wicket on JDK 14, which
> is
> > >>> not
> > >>> >> > detected by our current build setup. On JDK 13+, javadoc fails
> with:
> > >>> >> >
> > >>> >> > [ERROR] MavenReportException: Error while generating Javadoc:
> > >>> >> > Exit code: 1 - javadoc: error - invalid flag:
> > >>> --no-module-directories
> > >>> >> >
> > >>> >> > Command line was: /usr/lib/jvm/java-14-openjdk-amd64/bin/javadoc
> > >>> >> > -J-Xmx256m -J-Xms128m --no-module-directories @options @packages
> > >>> >> >
> > >>> >> > Shouldn't our build detect such issues? At the moment we run
> 'mvn
> > >>> >> > clean test'. Maybe we should run 'mvn clean package' instead?
> I'll
> > >>> >> > submit a bug report on maven-javadoc-plugin later today. It
> seems
> > >>> the
> > >>> >> > maintainers are not yet aware of this issue.
> > >>> >> >
> > >>> >> > Best regards,
> > >>> >> > Emond
> > >>> >> >
> > >>> >>
> > >>> >
> > >>> >
> > >>> > --
> > >>> > WBR
> > >>> > Maxim aka solomax
> > >>> >
> > >>>
> > >>>
> > >>> --
> > >>> WBR
> > >>> Maxim aka solomax
> > >>>
> > >>
>


-- 
WBR
Maxim aka solomax


Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
`clean package` sounds more reasonable to me :)

On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik  wrote:

> `fast` profile skips javadoc 
>
> On Fri, 10 Jan 2020 at 15:56, Martin Grigorov 
> wrote:
>
>> Hi Emond,
>>
>> Locally while testing new JDK builds I always use: mvn14 clean install
>> -Pfast,java14
>> mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn
>> and I don't remember having issues with javadoc since a long time.
>>
>> On Fri, Jan 10, 2020 at 10:45 AM Emond Papegaaij <
>> emond.papega...@gmail.com>
>> wrote:
>>
>> > Hi all,
>> >
>> > I just noticed a problem with building Wicket on JDK 14, which is not
>> > detected by our current build setup. On JDK 13+, javadoc fails with:
>> >
>> > [ERROR] MavenReportException: Error while generating Javadoc:
>> > Exit code: 1 - javadoc: error - invalid flag: --no-module-directories
>> >
>> > Command line was: /usr/lib/jvm/java-14-openjdk-amd64/bin/javadoc
>> > -J-Xmx256m -J-Xms128m --no-module-directories @options @packages
>> >
>> > Shouldn't our build detect such issues? At the moment we run 'mvn
>> > clean test'. Maybe we should run 'mvn clean package' instead? I'll
>> > submit a bug report on maven-javadoc-plugin later today. It seems the
>> > maintainers are not yet aware of this issue.
>> >
>> > Best regards,
>> > Emond
>> >
>>
>
>
> --
> WBR
> Maxim aka solomax
>


-- 
WBR
Maxim aka solomax


Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
`fast` profile skips javadoc 

On Fri, 10 Jan 2020 at 15:56, Martin Grigorov  wrote:

> Hi Emond,
>
> Locally while testing new JDK builds I always use: mvn14 clean install
> -Pfast,java14
> mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn
> and I don't remember having issues with javadoc since a long time.
>
> On Fri, Jan 10, 2020 at 10:45 AM Emond Papegaaij <
> emond.papega...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > I just noticed a problem with building Wicket on JDK 14, which is not
> > detected by our current build setup. On JDK 13+, javadoc fails with:
> >
> > [ERROR] MavenReportException: Error while generating Javadoc:
> > Exit code: 1 - javadoc: error - invalid flag: --no-module-directories
> >
> > Command line was: /usr/lib/jvm/java-14-openjdk-amd64/bin/javadoc
> > -J-Xmx256m -J-Xms128m --no-module-directories @options @packages
> >
> > Shouldn't our build detect such issues? At the moment we run 'mvn
> > clean test'. Maybe we should run 'mvn clean package' instead? I'll
> > submit a bug report on maven-javadoc-plugin later today. It seems the
> > maintainers are not yet aware of this issue.
> >
> > Best regards,
> > Emond
> >
>


-- 
WBR
Maxim aka solomax


Re: buildbot failure in on wicket-master-java12

2020-01-09 Thread Maxim Solodovnik
I would vote for removing JDK12
no need to test outdated non-LTS versions IMO

On Thu, 9 Jan 2020 at 15:06, Martin Grigorov  wrote:

> Hi team,
>
> The build for Java 12 has failed due to the removal of the multiple test
> methods for the different versions of JDK for
> ZonedDateTimeConverter#convertToObject().
> JDK 12 is not maintained by JDK providers and this is the reason the change
> from UCT to UTC is not there.
>
> Question: should I revert the removal of the multiple test methods or
> should I remove the testing for JDK 12 in BuildBot ?
> I prefer the latter.
>
> On Thu, Jan 9, 2020 at 9:35 AM  wrote:
>
> > The Buildbot has detected a new failure on builder wicket-master-java12
> > while building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master-java12/builds/174
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: bb_slave1_ubuntu
> >
> > Build Reason: The SingleBranchScheduler scheduler named
> > 'on-wicket-master-java12-commit' triggered this build
> > Build Source Stamp: [branch master]
> > 65e2266d8b205d3768986c3e6ad548cfb3759d35
> > Blamelist: Martin Tzvetanov Grigorov 
> >
> > BUILD FAILED: failed compile
> >
> > Sincerely,
> >  -The Buildbot
> >
> >
> >
> >
>


-- 
WBR
Maxim aka solomax


Re: [VOTE] Release Apache Wicket 7.16.0

2020-01-06 Thread Maxim Solodovnik
+1 tested
Signatures
Local build
Wicketstuff build

On Mon, Jan 6, 2020, 14:42 Martin Grigorov  wrote:

> +1 to release!
>
> Tested local build!
>
> On Sat, Jan 4, 2020 at 4:51 PM Andrea Del Bene 
> wrote:
>
> > This is a vote to release Apache Wicket 7.16.0
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 7.16.0
> > [ ] No, don't release Apache Wicket 7.16.0, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> >  https://dist.apache.org/repos/dist/dev/wicket/7.16.0
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1135/
> >
> > The binaries are available in the above link, as are a staging
> > repository for Maven. Typically the vote is on the source, but should
> > you find a problem with one of the binaries, please let me know, I can
> > re-roll them some way or the other.
> >
> > Staging git repository data:
> >
> >  Repository:  g...@github.com:bitstorm/wicket.git
> >  Branch:  build/wicket-7.16.0
> >  Release tag: rel/wicket-7.16.0
> >
> >
> > 
> >
> >  The signatures for the source release artefacts:
> >
> >
> > Signature for apache-wicket-7.16.0.zip:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl4QoiAACgkQh48B+qjT
> > VuEcMg//V/HLgAeFzSyvdj+GSvtq3r8aZgmTh+TLJ5zMiFVyu9hfPmh7T5V3EY3+
> > Qn+CHdXh3kD/G6jLYAhEUw9iqU5duxFqBqXRzdTtmIwxK2VTdfI2iJhyTnmKGXS8
> > vaUV8cjC8YMXtEjkibQGErbbV5jXRwohF029F7Zck1A7+U0PN58K0feMz7mXMIXT
> > Gxl3dC0wXYa1SptctjeZSAxVCR4QZc/txIvCah00LlV0GDY24XMfxovd6oDsb6+W
> > +VjuNbAmleV7D534IPTh9VE9ObcHwqXi7JbPk5f/uL3BUTis+baZp0e+3kGpY4Il
> > uLdUcGF4juDjc+lY1phxoPbni4XnHfEkDQLez40/jlMWO3Vx7BUkCFVolFOC5hAa
> > 8hmFURXSytXXDD4f3/yCMZr95Sdh4SP+FeQtryckE7K08lrblOHaQJn/dF08tcVN
> > QOrFJ5k1LfDk3biB7U8bzGQJ1py0UctKyDzw15QY3FQb/stypn/brs7hMAXLQbZp
> > knu9AhuTGvu2Q2kqqn78UwG+zq6hcZBVR4+XGkX9KHMxN3K16nKBnkdv2v6bLt1E
> > Qyw1lBZj20Uo2dkpidyN6esDzX8j8US8c0CNylak/4xA1er7+MvkiAQhVjDlvqTH
> > LbIO5Pyszlq9n1Vw6RSZjbWnhZL/Tv7CIux4zsdTLYMbaohZPZM=
> > =9BT0
> > -END PGP SIGNATURE-
> >
> > Signature for apache-wicket-7.16.0.tar.gz:
> >
> >  -BEGIN PGP SIGNATURE-
> >
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl4QoiAACgkQh48B+qjT
> > VuFEoQ//VxsVwquHRi4ZAHQK6KOlEmqRvF1DGqu9Eawqb8SQGNiqAmkWEjkfIaG0
> > gBwpZUr1g0CY2F3NbPQMuPaokIn41QIGoeKCMapCYtzI8NjeEHEBHydDqs+9vHLw
> > mbmuZdZeFmrUFH1DhhuBZY6XgczvlTKxw17HW6OBkqLqE0G6WTFVjMDTlFnXPqOd
> > 7IdXmIfSynxCSORzDvwjZUrtRSrrc/6T10kiaIDNNoBkwqBva2Dnk20i6yLgwoZW
> > PBZyjosQhKj0FeP8RfD30S51MfJ3QMflY9iOYdN3oGxxNcAxQCHZXkzZA/dqvLcj
> > TB1VJtmJ/O2wuASNDfa85FmbH7B+sFM4yp6rYsTsWLcWFLXm6y2r8iBER9AD04P8
> > vUbqh4s7x8wWHX4T6n5xMq8nlSyoMokAEu+sEA2vkd32a1qrUSnKhI0qJK8Xlgz1
> > DCeca2txqWTTr2qmK9xydBEcNUo9uNDS6Z6YpOY3AX3P9oA7TXBKBAyzRvZ/I5aN
> > iZUVgYwvGPH7VfIF7YR3fRBvik2LwpfAq1kE19WZugKTCXWihgjHDKfZKxpnzOL+
> > p5+WcEnf6NzsHSzoaAU/az0Wvem4yCj2B49uZUeMZfrgRoLt/DWB4mOBj/uhb+8K
> > GkN/vehn3d9ZHJ76ImhkV1EGGgfAkSq1O7nHE2E2NxrZOVe8Ueo=
> > =3rL9
> > -END PGP SIGNATURE-
> >
> > 
> >
> >  CHANGELOG for 7.16.0:
> >
> > ** Bug
> >
> >  * [WICKET-6531] - Crash in Unsafe.getObject when running on the J9
> VM
> >  * [WICKET-6704] - JavaSerializer.serialize causes the JVM crash !
> >  * [WICKET-6706] - Websocket Endpoint logs exception when user
> > leaves page
> >  * [WICKET-6707] - Property setter parameter type is assumed to be
> > equal to getter return type
> >  * [WICKET-6708] - FormComponent should read only the GET/POST
> > parameters of the request, not both
> >
> >
>


Re: Happy new year!...and...

2020-01-01 Thread Maxim Solodovnik
Happy NY Andrea :)

+1 to merge and release :)

On Thu, 2 Jan 2020 at 00:17, Andrea Del Bene  wrote:

> Hi,
>
> happy new year to everyone! From what I seen in the last days we have
> reached a stable point for WICKET-
> (https://github.com/apache/wicket/pull/375). Shall we merge it into
> master and go ahead with a new milestone (and relative maintenance
> releases)?
>
> Andrea.
>
>

-- 
WBR
Maxim aka solomax


wicket-native-websocket-core as dependency in module-info.java

2019-12-15 Thread Maxim Solodovnik
Hello All,

I start adding module-info.java to our Java11 project
It seems we should correct Automatic-Module names not to have `-` in
it (current name is `org.apache.wicket.native-websocket.core`)

Are there any objections if I'll change
https://github.com/apache/wicket/blob/master/wicket-native-websocket/wicket-native-websocket-core/pom.xml#L34
to have
org.apache.wicket.native.websocket.core
?

-- 
WBR
Maxim aka solomax


Re: UCT -> UTC, here we go again...

2019-11-24 Thread Maxim Solodovnik
Maybe it worth to update tests so they will not rely on JDK default date
format?


On Mon, 25 Nov 2019 at 04:27, Andrea Del Bene  wrote:

> And I think it was backported here:
>
> https://bugs.openjdk.java.net/browse/JDK-8228473
>
> On 11/23/19 11:18 PM, Tobias Soloschenko wrote:
> > Martin also asked if the fix is downported from JDK 13 to 12 / 11 and it
> is a bit more complicated
> >
> > kind regards
> >
> > Tobias
> >
> >> Am 23.11.2019 um 22:35 schrieb Sven Meier :
> >>
> >> Hi Andrea,
> >>
> >> confirmed!
> >>
> >> Sven
> >>
> >>> On 23.11.19 18:57, Andrea Del Bene wrote:
> >>> Hi,
> >>>
> >>> I've just found that with the last OpenJDK 11.0.5 taken from
> AdoptOpenJDK I'm not able to build master branch as the following test
> fails:
> >>>
> >>> [ERROR] Failures:
> >>> [ERROR] ZonedDateTimeConverterTest.convertToObject_java12Minus:50
> expected: <2016-07-11T01:02:03Z[Etc/UCT]> but was:
> <2016-07-11T01:02:03Z[Etc/UTC]>
> >>>
> >>> I suspect is the same problem found some time ago by Martin:
> >>>
> >>> https://markmail.org/message/g5cbnw47kt7yrj7t
> >>>
> >>> Could you confirm this problem.
> >>>
> >>> Thank you.
> >>>
> >>> Andrea.
> >>>
>


-- 
WBR
Maxim aka solomax


Re: New release cycle.

2019-11-14 Thread Maxim Solodovnik
+1

I would add WICKET-6703 to wicket-9

On Fri, 15 Nov 2019 at 14:17, Martin Grigorov  wrote:
>
> + 1
>
> On Thu, Nov 14, 2019 at 11:07 AM Andrea Del Bene 
> wrote:
>
> > WDYT? :-)
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >



-- 
WBR
Maxim aka solomax


Re: FYI

2019-10-08 Thread Maxim Solodovnik
Great news :)

On Tue, 8 Oct 2019 at 14:41, Andrea Del Bene  wrote:

> Great! Thank you Martin!
>
> On Tue, Oct 8, 2019 at 5:10 AM Martin Grigorov 
> wrote:
>
> > On Mon, Oct 7, 2019, 16:33 Martin Grigorov  wrote:
> >
> > > I've found a workaround: execute `mvn clean javadoc:aggregate` as a
> > > separate step after `mvn deploy`
> > >
> > > In r1051190 at
> > >
> >
> https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects
> > > I've split the step into two steps.
> > >
> > > But now the build failed due to some NPM bug:
> > > https://issues.apache.org/jira/browse/INFRA-19234
> > > Once this is resolved we will see whether the API docs appear at
> > > https://ci.apache.org/projects/wicket/apidocs/9.x/index.html
> > >
> >
> > The Javadoc is available now!
> >
> >
> > > On Tue, Jul 23, 2019 at 6:55 PM Andrea Del Bene 
> > > wrote:
> > >
> > >> I think I might found a bug with maven-javadoc-plugin:
> > >>
> > >> https://issues.apache.org/jira/browse/MJAVADOC-618
> > >>
> > >> On Mon, Jul 22, 2019 at 6:36 PM Andrea Del Bene  >
> > >> wrote:
> > >>
> > >> > After the fix applied by Martin we have another more strange message
> > >> error
> > >> > during javadoc:aggregate. I couldn't find any possible cause yet:
> > >> >
> > >> > [INFO] --- maven-javadoc-plugin:3.1.1:aggregate (default-cli) @
> > >> > wicket-parent ---
> > >> > [INFO] Toolchain in maven-javadoc-plugin:
> > >> > JDK[/usr/lib/jvm/adoptopenjdk-11-jdk-hotspot/]
> > >> > [WARNING] Only outputDirectories and jars are accepted on the path
> > >> > [ERROR] no reactor project: org.apache.wicket:wicket
> > >> > [ERROR] Error while creating javadoc report: Only outputDirectories
> > and
> > >> > jars are accepted on the path
> > >> > java.lang.IllegalArgumentException: Only outputDirectories and jars
> > are
> > >> > accepted on the path
> > >> > at
> > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath
> > >> > (LocationManager.java:333)
> > >> > at
> > >> org.codehaus.plexus.languages.java.jpms.LocationManager.resolvePath
> > >> > (LocationManager.java:139)
> > >> > at
> > >> >
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.addJavadocOptions
> > >> > (AbstractJavadocMojo.java:5001)
> > >> > at
> > >> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> > >> > (AbstractJavadocMojo.java:2081)
> > >> > ...
> > >> >
> > >> > On Sat, Jul 13, 2019 at 10:22 PM Martin Grigorov <
> > mgrigo...@apache.org>
> > >> > wrote:
> > >> >
> > >> >> Hi,
> > >> >>
> > >> >> I've committed a change to Wicket's Buildbot config that adds
> > JAVA_HOME
> > >> >> for
> > >> >> the Java 11, 13 and 14 builds.
> > >> >> Hopefully this will fix the problem!
> > >> >>
> > >> >> On Fri, Jul 12, 2019 at 5:01 PM Andrea Del Bene <
> > an.delb...@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >> > Problem with javadoc-maven-plugin 3.1.x and CI:
> > >> >> >
> > >> >> > https://issues.apache.org/jira/browse/INFRA-18741
> > >> >> >
> > >> >> > --
> > >> >> > Andrea Del Bene.
> > >> >> > Apache Wicket committer.
> > >> >> >
> > >> >>
> > >> >
> > >> >
> > >> > --
> > >> > Andrea Del Bene.
> > >> > Apache Wicket committer.
> > >> >
> > >>
> > >>
> > >> --
> > >> Andrea Del Bene.
> > >> Apache Wicket committer.
> > >>
> > >
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>


-- 
WBR
Maxim aka solomax


Re: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

2019-10-01 Thread Maxim Solodovnik
Is it possible it is caused by Java version?
Travis uses

java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)





I locally using

java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)



On Mon, 30 Sep 2019 at 22:04, Thorsten Schöning 
wrote:

> Guten Tag Martin Grigorov,
> am Montag, 30. September 2019 um 15:25 schrieben Sie:
>
> > It will be good to find what in your environment causes the problem.
> > Maybe it is some environment variable, or your system locale, or
> something
> > else.
>
> My Windows is pretty standard, I'm not even running AV-software,
> including on-board Defender. That has been disabled using group
> policies. The only difference to others is my German locale most
> likely. Looking at Process Monitor, Wicket seems to search for
> localized files for all test including HTML and text, never finds
> those for de_DE and all those other tests succeed anyway. Doesn't look
> like the actual problem to me.
>
> > For me this test passes. It must pass at Maxim's machine as well because
> he
> > built the release.
> > Could someone else with Windows run the test and report ?
>
> I've found an additional way to make the build succeed WITHOUT
> ignoring the formerly mentioned test: Switching the option to reuse
> forked JMV by surefire to "false" in pom.xml.
>
> > false
>
> Switching between true and false make the build failing vs.
> succeeding. What's additionally interesting is that in case the build
> fails, executing the command line from the error message manually in
> some other cmd.exe seems to succeed:
>
> > cmd.exe /X /C ""C:\Program Files\Java\jdk-8\bin\java.exe" -Xmx1024m -jar
> C:\Users\tschoening\AppData\Local\Temp\surefire3649246175279820451\surefirebooter4577796592449395223.jar
> C:\Users\tschoening\AppData\Local\Temp\surefire3649246175279820451
> 2019-09-30T16-38-42_368-jvmRun1 surefire9181599006974311426tmp
> surefire_07065828248506771667tmp""
>
> > 3,1,windows-1252,[org.apache.wicket.page.PageAccessSynchronizer] DEBUG
> - 'main' released lock to page with id '1'\0D\0A
> > 3,1,windows-1252,[org.apache.wicket.page.PageAccessSynchronizer] DEBUG
> - 'main' notifying blocked threads\0D\0A
> >
> 3,1,windows-1252,[org.apache.wicket.protocol.http.servlet.ServletWebRequest]
> DEBUG - Calculating context relative path from: context path '/context'\2C
> filterPrefix 'servlet/'\2C uri '/context/servlet/'\0D\0A
> >
> 6,1,org.wicketstuff.jamon.request.cycle.JamonMonitoredRequestCycleTest,shouldCreateTwoMonitorsForPagesThatAreNavigatedToTwice(org.wicketstuff.jamon.request.cycle.JamonMonitoredRequestCycleTest),null,null,null
> >
> 2,1,org.apache.maven.surefire.junit4.JUnit4Provider,org.wicketstuff.jamon.request.cycle.JamonMonitoredRequestCycleTest,null,null,null
> > Z,0,BYE!
>
> Which very much reads like a proper "goodbye" like mentioned in the
> error message at the beginning. My feeling is that for some reason
> surefire is not able to properly recognize that goodbye in some
> combinations of tests anymore if those were run within the same JVM.
>
> > If there is JVM crash then there must be a hs_errPID.txt file in the
> Maven
> > process working folder. It will give you more information what went
> wrong.
>
> I don't find such file, neither searching the file system, nor looking
> at the logs of Process Monitor during running the build.
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning   E-Mail: thorsten.schoen...@am-soft.de
> AM-SoFT IT-Systeme  http://www.AM-SoFT.de/
>
> Telefon...05151-  9468- 55
> Fax...05151-  9468- 88
> Mobil..0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>

-- 
WBR
Maxim aka solomax


[ANNOUNCE] WicketStuff 9.0.1-M3 Released

2019-09-21 Thread Maxim Solodovnik
WicketStuff core 9.0.1-M3 based on Apache Wicket 9.0.0-M3 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (7):
  Project is switched to the next development version
  Dependencies are updated
  Merge branch 'master' of github.com:wicketstuff/core
  Library versions are updated
  Library versions are updated
  Scala lib version is decreased
  WicketStuff Core 9.0.0-M3 is released

Martin Tzvetanov Grigorov (6):
  [scala] Upgrade Scala to 2.13.0
  Upgrade scala-maven-plugin to 4.1.0
  Update scala-maven-plugin to 4.1.1
  Issue #668 - Apply manually the fix by Gabriel Landon
  Update maven-bundle-plugin to 4.2.1
  Update scala-maven-plugin to 4.2.0

Andrea Del Bene (5):
  Merge pull request #665 from
andruhon/port-restannotations-customisations-from-8
  Update README.md
  Update Jackson to fix security issue
  Added support for DI with mounted rest resource
  try with new ubuntu machine

Florian Lacreuse (3):
  Update Select2 to 4.0.9 (#671)
  Update Select2 Bootstrap theme to Bootstrap 4. (#673)
  Update Select2 to 4.0.10 (#675)

Andrew Kondratev (1):
  Apply customisations from wicketstuff#641

Christopher Colemani (1):
  Switched to https from http as google now rejects all non secured
requests (#670)

MargotPiva (1):
  Select2 stateless displaying initial values (#674)

The WicketStuff team


Re: [ANNOUNCE] WicketStuff 9.0.0-M3 Released

2019-09-20 Thread Maxim Solodovnik
Thanks Martin,

will try to re-release tomorrow morning (nexus seems to be more accessible
in the morning GMT+7 :)))

On Fri, 20 Sep 2019 at 15:22, Martin Grigorov  wrote:

> Hi Maxim,
>
> You may ask Sonatype to check what went wrong.
>
> Or just make a new release, as you proposed.
>
> On Fri, Sep 20, 2019, 06:58 Maxim Solodovnik  wrote:
>
>> Hello Martin,
>>
>> I'm afraid there is something wrong with this release :(
>>
>> It is not listed here [1]
>> And seems to be incomplete here [2]
>>
>> Shall I create 9.0.1-M3?
>> There were no issues during `clean deploy`
>> The repo was closed successfully, so it seems to be the problem with
>> Nexus release ...
>>
>> [1]
>> https://oss.sonatype.org/#nexus-search;gav~org.wicketstuff~wicketstuff-corekw,versionexpand
>> [2]
>> https://repo1.maven.org/maven2/org/wicketstuff/wicketstuff-core/9.0.0-M3/
>>
>> On Thu, 19 Sep 2019 at 19:53, Martin Grigorov 
>> wrote:
>>
>>> Thank you, Maxim!
>>>
>>> On Thu, Sep 19, 2019 at 3:47 PM Maxim Solodovnik 
>>> wrote:
>>>
>>> > WicketStuff core 9.0.0-M3 based on Apache Wicket 9.0.0-M3 is released
>>> > and soon will be available at Maven Central!
>>> >
>>> > The changelog is:
>>> >
>>> > Maxim Solodovnik (7):
>>> >   Project is switched to the next development version
>>> >   Dependencies are updated
>>> >   Merge branch 'master' of github.com:wicketstuff/core
>>> >   Library versions are updated
>>> >   Library versions are updated
>>> >   Scala lib version is decreased
>>> >   WicketStuff Core 9.0.0-M3 is released
>>> >
>>> > Martin Tzvetanov Grigorov (6):
>>> >   [scala] Upgrade Scala to 2.13.0
>>> >   Upgrade scala-maven-plugin to 4.1.0
>>> >   Update scala-maven-plugin to 4.1.1
>>> >   Issue #668 - Apply manually the fix by Gabriel Landon
>>> >   Update maven-bundle-plugin to 4.2.1
>>> >   Update scala-maven-plugin to 4.2.0
>>> >
>>> > Andrea Del Bene (5):
>>> >   Merge pull request #665 from
>>> > andruhon/port-restannotations-customisations-from-8
>>> >   Update README.md
>>> >   Update Jackson to fix security issue
>>> >   Added support for DI with mounted rest resource
>>> >   try with new ubuntu machine
>>> >
>>> > Florian Lacreuse (3):
>>> >   Update Select2 to 4.0.9 (#671)
>>> >   Update Select2 Bootstrap theme to Bootstrap 4. (#673)
>>> >   Update Select2 to 4.0.10 (#675)
>>> >
>>> > Andrew Kondratev (1):
>>> >   Apply customisations from wicketstuff#641
>>> >
>>> > Christopher Colemani (1):
>>> >   Switched to https from http as google now rejects all non secured
>>> > requests (#670)
>>> >
>>> > MargotPiva (1):
>>> >   Select2 stateless displaying initial values (#674)
>>> >
>>> > The WicketStuff team
>>> >
>>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>

-- 
WBR
Maxim aka solomax


Re: [ANNOUNCE] WicketStuff 9.0.0-M3 Released

2019-09-19 Thread Maxim Solodovnik
Hello Martin,

I'm afraid there is something wrong with this release :(

It is not listed here [1]
And seems to be incomplete here [2]

Shall I create 9.0.1-M3?
There were no issues during `clean deploy`
The repo was closed successfully, so it seems to be the problem with Nexus
release ...

[1]
https://oss.sonatype.org/#nexus-search;gav~org.wicketstuff~wicketstuff-corekw,versionexpand
[2]
https://repo1.maven.org/maven2/org/wicketstuff/wicketstuff-core/9.0.0-M3/

On Thu, 19 Sep 2019 at 19:53, Martin Grigorov  wrote:

> Thank you, Maxim!
>
> On Thu, Sep 19, 2019 at 3:47 PM Maxim Solodovnik 
> wrote:
>
> > WicketStuff core 9.0.0-M3 based on Apache Wicket 9.0.0-M3 is released
> > and soon will be available at Maven Central!
> >
> > The changelog is:
> >
> > Maxim Solodovnik (7):
> >   Project is switched to the next development version
> >   Dependencies are updated
> >   Merge branch 'master' of github.com:wicketstuff/core
> >   Library versions are updated
> >   Library versions are updated
> >   Scala lib version is decreased
> >   WicketStuff Core 9.0.0-M3 is released
> >
> > Martin Tzvetanov Grigorov (6):
> >   [scala] Upgrade Scala to 2.13.0
> >   Upgrade scala-maven-plugin to 4.1.0
> >   Update scala-maven-plugin to 4.1.1
> >   Issue #668 - Apply manually the fix by Gabriel Landon
> >   Update maven-bundle-plugin to 4.2.1
> >   Update scala-maven-plugin to 4.2.0
> >
> > Andrea Del Bene (5):
> >   Merge pull request #665 from
> > andruhon/port-restannotations-customisations-from-8
> >   Update README.md
> >   Update Jackson to fix security issue
> >   Added support for DI with mounted rest resource
> >   try with new ubuntu machine
> >
> > Florian Lacreuse (3):
> >   Update Select2 to 4.0.9 (#671)
> >   Update Select2 Bootstrap theme to Bootstrap 4. (#673)
> >   Update Select2 to 4.0.10 (#675)
> >
> > Andrew Kondratev (1):
> >   Apply customisations from wicketstuff#641
> >
> > Christopher Colemani (1):
> >   Switched to https from http as google now rejects all non secured
> > requests (#670)
> >
> > MargotPiva (1):
> >   Select2 stateless displaying initial values (#674)
> >
> > The WicketStuff team
> >
>


-- 
WBR
Maxim aka solomax


[ANNOUNCE] WicketStuff 9.0.0-M3 Released

2019-09-19 Thread Maxim Solodovnik
WicketStuff core 9.0.0-M3 based on Apache Wicket 9.0.0-M3 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (7):
  Project is switched to the next development version
  Dependencies are updated
  Merge branch 'master' of github.com:wicketstuff/core
  Library versions are updated
  Library versions are updated
  Scala lib version is decreased
  WicketStuff Core 9.0.0-M3 is released

Martin Tzvetanov Grigorov (6):
  [scala] Upgrade Scala to 2.13.0
  Upgrade scala-maven-plugin to 4.1.0
  Update scala-maven-plugin to 4.1.1
  Issue #668 - Apply manually the fix by Gabriel Landon
  Update maven-bundle-plugin to 4.2.1
  Update scala-maven-plugin to 4.2.0

Andrea Del Bene (5):
  Merge pull request #665 from
andruhon/port-restannotations-customisations-from-8
  Update README.md
  Update Jackson to fix security issue
  Added support for DI with mounted rest resource
  try with new ubuntu machine

Florian Lacreuse (3):
  Update Select2 to 4.0.9 (#671)
  Update Select2 Bootstrap theme to Bootstrap 4. (#673)
  Update Select2 to 4.0.10 (#675)

Andrew Kondratev (1):
  Apply customisations from wicketstuff#641

Christopher Colemani (1):
  Switched to https from http as google now rejects all non secured
requests (#670)

MargotPiva (1):
  Select2 stateless displaying initial values (#674)

The WicketStuff team


Re: Javadoc link for 9.x is broken

2019-09-19 Thread Maxim Solodovnik
I can see no javadocs at: https://ci.apache.org/projects/wicket/apidocs/9.x/
 :(

On Thu, 19 Sep 2019 at 16:42, Andrea Del Bene  wrote:

> Hi,
>
> there's a problem with the last 3.1.* versions of Maven Javadoc Plugin.
> I've opened an issue some time ago, but is still open.
> https://issues.apache.org/jira/browse/MJAVADOC-618
>
> We might consider to downgrade it as long as the issue is not solved.
>
> On Thu, Sep 19, 2019 at 6:08 AM Maxim Solodovnik 
> wrote:
>
> > Hello All,
> >
> > While building wicketstuff-core I noticed lots of javadoc errors
> > Javadoc was unable to get wicket 9.x API from URL (
> > https://ci.apache.org/projects/wicket/apidocs/9.x/)
> >
> > how this can be fixed?
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>


-- 
WBR
Maxim aka solomax


Javadoc link for 9.x is broken

2019-09-18 Thread Maxim Solodovnik
Hello All,

While building wicketstuff-core I noticed lots of javadoc errors
Javadoc was unable to get wicket 9.x API from URL (
https://ci.apache.org/projects/wicket/apidocs/9.x/)

how this can be fixed?

-- 
WBR
Maxim aka solomax


Re: Build problems for Wicket 7.15.0 and Java 8 regarding Javadoc.

2019-09-17 Thread Maxim Solodovnik
Hello Thorsten,

you can build using `mvn clean install -Pbuildbot`
This way toolchains will be used

On Tue, 17 Sep 2019 at 14:35, Thorsten Schöning 
wrote:

> Guten Tag Martin Grigorov,
> am Dienstag, 17. September 2019 um 03:54 schrieben Sie:
>
> > Wicket 7.x is being built with Java 7, not with Java 8.
>
> Support to build with Java 8 has been implemented in the past. Why is
> removing that not a regression? Especially because you don't nail
> things to JDK 7 like WicketStuff seems to do using toolchains.
>
> Your own docs don't distinguish between runtime and building things as
> well:
>
> > This Wicket version requires at least the following Java version:
> > JDK 7.0 or newer.
>
> https://wicket.apache.org/start/wicket-7.x.html#status
>
> There are others building Wicket 7 with Java 8 as well and you did
> commit changes to support that:
>
> https://issues.apache.org/jira/browse/WICKET-6615
>
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3cabaaada6-4581-e009-607f-4ecd04b88...@meiers.net%3E
>
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201811.mbox/%3ccajmbs8jh687unhazbryr+xhejysckkl89mpnk7ysgtmcbre...@mail.gmail.com%3E
>
> Doesn't make much sense to commit support for JDK 8 more than once
> and remove it "silently" afterwards. Especially because the current
> master for Wicket 9 contains support to be build with JDK 12 and 13 as
> well instead of JDK 9 only. Any plans to remove that already? :-)
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning   E-Mail: thorsten.schoen...@am-soft.de
> AM-SoFT IT-Systeme  http://www.AM-SoFT.de/
>
> Telefon...05151-  9468- 55
> Fax...05151-  9468- 88
> Mobil..0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>

-- 
WBR
Maxim aka solomax


Re: [VOTE] Release Apache Wicket 9.0.0-M3 - Take three

2019-09-14 Thread Maxim Solodovnik
+1

Tested:
1) signatures
2) wicket build
3) wicketstuff build
4) our main application


On Fri, 13 Sep 2019 at 16:50, Ernesto Reinaldo Barreiro 
wrote:

> +1 to release: tested my main customer's application. All seems to work
> properly.
>
>
> I'm getting now sporadics
>
> java.io.EOFException
> at
> org.apache.tomcat.util.net
> .NioEndpoint$NioSocketWrapper.fillReadBuffer(NioEndpoint.java:1289)
> at
> org.apache.tomcat.util.net
> .NioEndpoint$NioSocketWrapper.read(NioEndpoint.java:1223)
> at
>
> org.apache.tomcat.websocket.server.WsFrameServer.onDataAvailable(WsFrameServer.java:72)
> at
>
> org.apache.tomcat.websocket.server.WsFrameServer.doOnDataAvailable(WsFrameServer.java:171)
> at
>
> org.apache.tomcat.websocket.server.WsFrameServer.notifyDataAvailable(WsFrameServer.java:151)
> at
>
> org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.upgradeDispatch(WsHttpUpgradeHandler.java:148)
> at
>
> org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:54)
> at
>
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:53)
> at
>
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:806)
> at
> org.apache.tomcat.util.net
> .NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1498)
> at
> org.apache.tomcat.util.net
> .SocketProcessorBase.run(SocketProcessorBase.java:49)
> at
>
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
>
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
>
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.base/java.lang.Thread.run(Thread.java:834)
>
> But need to double check if this happens on our 8.x version of app.
>
> On Fri, Sep 13, 2019 at 11:48 AM Martin Grigorov 
> wrote:
>
> > +1 to release
> >
> > On Wed, Sep 11, 2019 at 11:56 PM Andrea Del Bene 
> > wrote:
> >
> > > This is a vote to release Apache Wicket 9.0.0-M3
> > >
> > > Please download the source distributions found in our staging area
> > > linked below.
> > >
> > > I have included the signatures for both the source archives. This vote
> > > lasts for 72 hours minimum.
> > >
> > > [ ] Yes, release Apache Wicket 9.0.0-M3
> > > [ ] No, don't release Apache Wicket 9.0.0-M3, because ...
> > >
> > > Distributions, changelog, keys and signatures can be found at:
> > >
> > >  https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M3
> > >
> > > Staging repository:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachewicket-1132
> > >
> > >
> > > The binaries are available in the above link, as are a staging
> > > repository for Maven. Typically the vote is on the source, but should
> > > you find a problem with one of the binaries, please let me know, I can
> > > re-roll them some way or the other.
> > >
> > > Staging git repository data:
> > >
> > >  Repository:  g...@github.com:bitstorm/wicket.git
> > >  Branch:  build/wicket-9.0.0-M3
> > >  Release tag: rel/wicket-9.0.0-M3
> > >
> > >
> > >
> 
> > >
> > >  The signatures for the source release artefacts:
> > >
> > >
> > > Signature for apache-wicket-9.0.0-M3.zip:
> > >
> > >  -BEGIN PGP SIGNATURE-
> > >
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl15VBYACgkQh48B+qjT
> > > VuG31g/+K+eABqmeM3CiZn8tLNHyLbvjyHRmEllMvkEO5anXB0yPyNmBRp5PPe5k
> > > 1dWY3MhP2ASaRXMxD666EW9LkjGQcwe04ymey6r/rW+Xyq1atmZ3sWMcqR5u+Eqx
> > > msjYwf601IX+1CS0Z/4pTZQ/PKJvNIFtgCjGBpxMPcvaDoSbOSdqVnGkS2JzlWIf
> > > e1qHVMKuJ+q2/BhJpHnBxbVxzER5tKkY50ZvsI1NH/hfp71/mlmRFNvNwAanqHYV
> > > u8MhxsoPouqN13rG/HvuObXdfny+Tkamnq6qosQEa4PwrwQpAavcTCIAAejtbI05
> > > Z4iwTYyoXzI6HjvO6dcfgwLFp86J5/BegYLsK2D+gtNfhFx2Rew4z6PoKh0TN8Ug
> > > m/+hBxHtgHzqq5m3ipJMVxpqP8m8gzmLARqzWX4sxDpFUeM6a1TTs839S+JIRAH6
> > > yCwwGN4sGhTUaTiI/bciHsGAK5oJFoKNPwZL/WGcT2jy2z2mQ8zIO9vh+APSVLYu
> > > tCHiy37+bZ2rr8JSoGC3AnSW2j8XMaE3Xvlt0BEGM73zCQ5CqrghpL462TfnQvHu
> > > ZIm6pZHcPtlJ7FIRYf2/8krURwH878T2cHFAzkP9AgQ+cIicd7Y3/0Ywo/YLsEI4
> > > iKkTK7XekU1RwK6fVImM2HtfdzpQXLhJ3dU6hD3Laz+IOnlaE5U=
> > > =sNDJ
> > > -END PGP SIGNATURE-
> > >
> > > Signature for apache-wicket-9.0.0-M3.tar.gz:
> > >
> > >  -BEGIN PGP SIGNATURE-
> > >
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl15VBYACgkQh48B+qjT
> > > VuFi3Q//U3hj8HkDem99qtN3i5aMXip7aNcuyVy1szxl1lhv2uOObt8+kRphl/3Q
> > > IOHBLcV4MkvDvKwSJQFptdFcUypfhXutSpVGo6Q8n6tTPxvfAl+xc7HHAaT6fROU
> > > icPLD2XDmhukQd95i3hqjGbjBAbZko4yRKyGpvPxoAl/t6C0foAHkUxLNEHHIos8
> > > yoJLWVp9k4Neoti2CwMFtjqDHxf3mrLfowz7aTMGAcF8e2I95AvOf+sEnJdB/+z1
> > > iB/7RYJBXTb31WXVG9SziniCSBdLQOmhPJTpG/20OMd0TyRVZNP3L2vH+96G7brr
> > > qeksBVcVSlOCuYFV4cvWPwqTH5PHMTiNrrSqPlpMyWniJwck8oFu2PZu5tjgppXf
> > > mbGPjmOsFMeB/cSmqX3qhq/OKdEkgUO3tMhrDQ+c11CD6FvIn5BZkl4prRiyyiz9
> > > bRPdEdN0oIuFjGJE8Kzie3/ms9QtpGvz1wQiHd/rrweuErEBxKRg06Tq8swEmuFf
> > > 

[ANNOUNCE] WicketStuff 8.6.0 Released

2019-09-14 Thread Maxim Solodovnik
WicketStuff core 8.6.0 based on Apache Wicket 8.6.1 is released
and soon will be available at Maven Central!

The changelog is:

Andrea Del Bene (3):
  Added support for DI with mounted rest resource
  Fix for java 8 downgrade
  try to use newer ubuntu

Florian Lacreuse (2):
  Update Select2 to 4.0.9 (#671)
  Update Select2 to 4.0.10 (#675)

Maxim Solodovnik (2):
  Switching to the next development version
  WicketStuff Core 8.6.0 is released

MargotPiva (1):
  Select2 stateless displaying initial values (#674)

Martin Tzvetanov Grigorov (1):
  Issue #668 - Apply manually the fix by Gabriel Landon


The WicketStuff team


[ANNOUNCE] WicketStuff 7.15.0 Released

2019-09-14 Thread Maxim Solodovnik
WicketStuff core 7.15.0 based on Apache Wicket 7.15.0 is released
and soon will be available at Maven Central!

The changelog is:

Maxim Solodovnik (4):
  Switching to the next development version
  URLs are being correctly compared, code clean-up
  Geo tests are fixed
  WicketStuff Core 7.15.0 is released

Christopher Colemani (1):
  Fixes #669: secure url is being used

Gabriel Landon (1):
  revert #652 (put back ajax redirection) (#668)

The WicketStuff team


  1   2   3   4   5   6   7   >