[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-21 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-557256075    Thank you everyone! Have a great weekend!

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613 `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, Wicket.Ajax.suspendCall());",

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-30 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-548195495 @svenmeier I had a look at the code. It all makes sense. I'll test it soon.

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-16 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-542953162 Any thoughts on this? Should I proceed with cleaning up tests?

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-10 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-540887826 All right, I've implemented the stuff discussed above. All "evaluate" and "priority-evaluate" tags are now gone from

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox
andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify URL: https://github.com/apache/wicket/pull/384#issuecomment-539800079 > If every JS snippet is ending up as a header item anyway, why not remove and from the Ajax response and transport