[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482056433 > Hello @martin-g, > The original request was to simplify message sending to some "subset" of websocket connections > Not sure how this code change will help ... Hi, If IKey of message is same as IKey of connection (page that sent message), then I can get all connections and exclude the one that have same IKey of message. That was my use case. @martin-g Is this reasoning correct? If, so your changes suffice IMHO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482020794 @martin-g As requester of this feature if there is any risk of breaking existing application I would prefer to use some "workaround". Also the new version of our application is already migrated to Wicket 8. And probably Wicket 9 will be out before we get it into production... So, we will almost certainly be able to use correct implementation on Wicket 9. Thanks again! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [wicket] reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket…
reiern70 commented on issue #352: WICKET-6649 Store the applicationName, sessionId and key in WebSocket… URL: https://github.com/apache/wicket/pull/352#issuecomment-482020970 > I understood the request as: `make the Application, Session and IKey available in TextMessage, BinaryMessage and IWebSocketConnection, so the application can use them when deciding to whom to send response message`. > @reiern70 did I understand you correctly ? Yes you did. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
