[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-477232378 @mattrpav can you check if `cglib-nodep+latest_asm` will work as expected and update your PR?

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476751902 I would say `cglib-nodep` is better option since we have `asm` as separate dependency ... @martin-g, @svenmeier, @bitstorm WDYT?

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476748823 @mattrpav PR with the link to JIRA is perfectly fine :) You did everything right :)

[GitHub] [wicket] solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master

solomax commented on issue #349: [WICKET-6647] Upgrade asm to 7.1 in master URL: https://github.com/apache/wicket/pull/349#issuecomment-476743542 @mattrpav I got build error with this change: ``` WARNING] Dependency convergence error for org.ow2.asm:asm:7.0 paths to dependency