[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-21 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-557256075
 
 
     
   Thank you everyone! Have a great weekend! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-11-05 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-550057613
 
 
   `target.prependJavaScript((String.format("jQuery('#%s').fadeOut(500, 
Wicket.Ajax.suspendCall());", c3.getMarkupId(;` this line in demo certainly 
needs some explanation. At a first glance it's not very obvious where the 
suspension is released.
   
   Somewhat like this:
   `// i.e. suspendCall suspends the ajax queue here, the suspendCall itself 
returns a function which does release a lock once called. The fadeOut will call 
this function when animation is finished and the lock will be released.`
   Potentially the notify can be pulled into variable to make things clear.
   
   Also, I think it would be nice to have a demo with multiple locks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-30 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-548195495
 
 
   @svenmeier I had a look at the code. It all makes sense. I'll test it soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-16 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-542953162
 
 
   Any thoughts on this? Should I proceed with cleaning up tests?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-10 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-540887826
 
 
   All right, I've implemented the stuff discussed above. All "evaluate" and 
"priority-evaluate" tags are now gone from AJAX XML as well as meta and 
wicket-nonce. I had to add a new attribute to JS header contributions to mark 
those which must be rendered after components.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [wicket] andruhon commented on issue #384: WICKET-6703 replace eval with jQuery.globalEval; add suspend/notify

2019-10-08 Thread GitBox 
andruhon commented on issue #384: WICKET-6703 replace eval with 
jQuery.globalEval; add suspend/notify
URL: https://github.com/apache/wicket/pull/384#issuecomment-539800079
 
 
   > If every JS snippet is ending up as a header item anyway, why not remove 
 and  from the Ajax response and transport 
everything as a ?
   > In the correct order of course.
   > 
   >