[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-08 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-480915022 Is it OK to merge this PR? This is an automated

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479963931 `mvn jetty:run-exploded` seems to work :) This is an

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479955654 @martin-g it seems `mvn jetty:run` is not working in `wicket-examples`, how are you running it for quick tests?

[GitHub] [wicket] solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed

2019-04-04 Thread GitBox
solomax commented on issue #351: [WICKET-6648] initiate and onBeforeDownload signatures are changed URL: https://github.com/apache/wicket/pull/351#issuecomment-479948236 I'll add, should be easy :) This is an automated