[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-12-09 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-563339765 @ivaynberg any objections against continuing the new modal dialog implementation on #375 ? If not, could you please close this pull

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-16 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492980635 >most selectors are used downstream of the overlay element I've double checked, your right :)

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-15 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492696234 Regarding the location of the dialog in the DOM - in case of a dialog nested inside a form, a page refresh produces invalid markup with

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-15 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492684806 Hi Igor, > my only word of caution is that a big reason why the old modal window was such a mess and so hard to maintain is

[GitHub] [wicket] svenmeier commented on issue #361: WICKET-6666 initial checkin of new ModalDialog

2019-05-14 Thread GitBox
svenmeier commented on issue #361: WICKET- initial checkin of new ModalDialog URL: https://github.com/apache/wicket/pull/361#issuecomment-492198078 Thanks Igor, it's much easier to start with something instead of starting from scratch. I would like to improve some general