[mailto:guillaume.s...@gmail.com]
Sent: Sunday, July 22, 2012 9:18 AM
To: dev@wicket.apache.org
Subject: Re: [vote] deprecate/remove EmailAddressValidator and move
RfcCompliantEmailAddressValidator to core
Hi Martijn,
On Fri, Jul 20, 2012 at 2:49 PM, Martijn Dashorst martijn.dasho...@gmail.com
wrote
@wicket.apache.org
Subject: [vote] deprecate/remove EmailAddressValidator and move
RfcCompliantEmailAddressValidator to core
Date: Fri, Jul 20, 2012 4:50 am
EmailAddressValidator is broken. For example, it doesn't validate
Martijn Dashorst martijn.dasho...@gmail.com properly, which
Hi Martijn,
On Fri, Jul 20, 2012 at 2:49 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
[X] Keep it as currently implemented
Or change their names if they are not clear enough.
I think both implementations cover different use cases. In our apps,
we usually favor a field for the email
[+1] Copy RfcCompliantEmailAddressValidator over EmailAddressValidator,
On Fri, Jul 20, 2012 at 3:49 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
EmailAddressValidator is broken. For example, it doesn't validate
Martijn Dashorst martijn.dasho...@gmail.com properly, which is
standards
[X] Copy RfcCompliantEmailAddressValidator over EmailAddressValidator,
deprecate RfcCompliantEmailAddressValidator
EmailAddressValidator is broken. For example, it doesn't validate
Martijn Dashorst martijn.dasho...@gmail.com properly, which is
standards compliant. Rfc validator does work. The
@wicket.apache.org
Subject: [vote] deprecate/remove EmailAddressValidator and move
RfcCompliantEmailAddressValidator to core
Date: Fri, Jul 20, 2012 4:50 am
EmailAddressValidator is broken. For example, it doesn't validate
Martijn Dashorst martijn.dasho...@gmail.com properly, which is
standards
from my HTC
- Reply message -
From: Martijn Dashorst martijn.dasho...@gmail.com
To: dev@wicket.apache.org dev@wicket.apache.org
Subject: [vote] deprecate/remove EmailAddressValidator and move
RfcCompliantEmailAddressValidator to core
Date: Fri, Jul 20, 2012 4:50 am
My vote:
[+1] Copy RfcCompliantEmailAddressValidator over
EmailAddressValidator, deprecate RfcCompliantEmailAddressValidator
[ ] Deprecate EmailAddressValidator, move
RfcCompliantEmailAddressValidator to core, favor RFC in EmailTextField
[ ] Keep it as currently implemented
Martijn
+1 having the rfc compliant validator in is a good thing
On Jul 20, 2012 2:51 PM, Martijn Dashorst martijn.dasho...@gmail.com
wrote:
My vote:
[+1] Copy RfcCompliantEmailAddressValidator over
EmailAddressValidator, deprecate RfcCompliantEmailAddressValidator
[ ] Deprecate
[+1] Copy RfcCompliantEmailAddressValidator over EmailAddressValidator,
deprecate RfcCompliantEmailAddressValidator
On Fri, Jul 20, 2012 at 3:22 PM, Ron Smits ron.sm...@gmail.com wrote:
+1 having the rfc compliant validator in is a good thing
On Jul 20, 2012 2:51 PM, Martijn Dashorst
[x] Copy RfcCompliantEmailAddressValidator over EmailAddressValidator,
deprecate RfcCompliantEmailAddressValidator
2012/7/20 Martijn Dashorst martijn.dasho...@gmail.com
EmailAddressValidator is broken. For example, it doesn't validate
Martijn Dashorst martijn.dasho...@gmail.com properly,
[+1] Copy ...
Sven
Martijn Dashorst martijn.dasho...@gmail.com schrieb:
My vote:
[+1] Copy RfcCompliantEmailAddressValidator over
EmailAddressValidator, deprecate RfcCompliantEmailAddressValidator
[ ] Deprecate EmailAddressValidator, move
RfcCompliantEmailAddressValidator to core, favor RFC in
[x] Keep it as currently implemented
EmailAddressValidator is too strict, but at least you can see what it does.
The regexp in RfcCompliantEmailAddressValidator is crazy, outdated and
probably very inefficient. IMHO, we should mark it as deprecated. The best
solution would be to use a parser
On Fri, Jul 20, 2012 at 4:13 PM, Emond Papegaaij
emond.papega...@topicus.nl wrote:
[x] Keep it as currently implemented
EmailAddressValidator is too strict, but at least you can see what it does.
The regexp in RfcCompliantEmailAddressValidator is crazy, outdated and
probably very inefficient.
14 matches
Mail list logo
