Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martin Grigorov
+1 On Tue, Sep 27, 2011 at 9:25 PM, b...@actrix.gen.nz wrote: (non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that triggers this issue. Sure it is a corner case. But a very simple one, and the changes

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Andrea Del Bene
+1 +1 On Tue, Sep 27, 2011 at 9:25 PM,b...@actrix.gen.nz wrote: (non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that triggers this issue. Sure it is a corner case. But a very simple one, and the changes

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martijn Dashorst
+1 On Wed, Sep 28, 2011 at 9:13 AM, Martin Grigorov mgrigo...@apache.org wrote: +1 On Tue, Sep 27, 2011 at 9:25 PM,  b...@actrix.gen.nz wrote: (non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Emond Papegaaij
It is your mapper that triggers this issue, therefore it is easy to work around. You only have to prevent the code added for WIKCET-4014 from being called, like this: public Url mapHandler(IRequestHandler requestHandler) { if (requestHandler instanceof ListenerInterfaceRequestHandler)

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martin Grigorov
Please continue this topic in a separate thread. Thanks! :-) On Wed, Sep 28, 2011 at 9:51 AM, Emond Papegaaij emond.papega...@topicus.nl wrote: It is your mapper that triggers this issue, therefore it is easy to work around. You only have to prevent the code added for WIKCET-4014 from being

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Igor Vaynberg
+1 -igor On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5.1 take 2 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Igor Vaynberg
release vote has passed with 3 +1 binding votes. -igor On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5.1 take 2 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts

Re: [vote] release wicket 1.5.1 take 2

2011-09-27 Thread Emond Papegaaij
(non-binding) +1 Our application is running fine on 1.5.1. De reported issues are fixed, as far as we could reproduce them. Wrt WICKET-4087, I think this is a corner case and should be easy to work around, because Bernard already has his own mapper. The change was introduced with the fix for

Re: [vote] release wicket 1.5.1 take 2

2011-09-27 Thread bht
(non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that triggers this issue. Sure it is a corner case. But a very simple one, and the changes might cause other hard to find issues. Most Bugs are corner cases.

Re: [vote] release wicket 1.5.1 take 2

2011-09-26 Thread bht
I have just found an issue https://issues.apache.org/jira/browse/WICKET-4087 Thanks, Bernard

Re: [vote] release wicket 1.5.1

2011-09-25 Thread nhsoft.yhw
Just downloaded the latest code, re-compiled, no error occurred. Wait wicket1.5 next release, I will re-test to see if there are problems. Andrea Del Bene-2 wrote: Hi, you have to update also wicket-util and wicket-request jars with 1.5.1 version. The core jar alone is not enough.

[vote] release wicket 1.5.1 take 2

2011-09-25 Thread Igor Vaynberg
This vote is to release wicket 1.5.1 take 2 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo https://repository.apache.org/content/repositories/orgapachewicket-099/ Changelog

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martin Grigorov
I cannot reproduce any problem with this application. I tried with RC7, 1.5.1 and -SNAPSHOT. I just you got somehow broken .jar of 1.5.1. On Fri, Sep 23, 2011 at 7:37 AM, nhsoft.yhw nhsoft@gmail.com wrote: Sorry I'm late. I created a demo program, use the wicket-1.5.RC7 build, it works.

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martin Grigorov
On Fri, Sep 23, 2011 at 10:21 AM, Martin Grigorov mgrigo...@apache.org wrote: I cannot reproduce any problem with this application. I tried with RC7, 1.5.1 and -SNAPSHOT. I just you got somehow broken .jar of 1.5.1. I think you got somehow broken .jar of 1.5.1 On Fri, Sep 23, 2011 at 7:37

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Andrea Del Bene
Hi, you have to update also wicket-util and wicket-request jars with 1.5.1 version. The core jar alone is not enough. Sorry I'm late. I created a demo program, use the wicket-1.5.RC7 build, it works. But when I use the wicket-core-1.5.1.jar replace wicket-1.5.RC7.jar,

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martijn Dashorst
+1 On Tue, Sep 20, 2011 at 6:40 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5.1 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martin Grigorov
unfortunatelly WICKET-4068 had a typo which breaks for Ajax submits on forms with onsubmit handler fixed with r1174613 but 1.5.1 has the problem. On Fri, Sep 23, 2011 at 11:42 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: +1 On Tue, Sep 20, 2011 at 6:40 PM, Igor Vaynberg

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martijn Dashorst
That would change my +1 to a -1. I'd also like to include a fix for wicket-event.js where we repair IE's inability to produce proper statechangeevents related to domready. More fixes are always better, and I'd hate to delay 1.5.1, but non-working ajax submits for forms is a blocker IMO Martijn

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Emond Papegaaij
The domready issue Martijn is talking about, is WICKET-4080, which I've just created. A 1-line patch is attached. And for what's worth, I'm changing my non-binding +1 to a -1 as well: non- working AJAX submits with onsubmit handlers might break some of our apps. Best regards, Emond On Friday

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Igor Vaynberg
ok. lets call this vote failed, get the fixes in, and i will build 1.5.2 when all the fixes are in. -igor On Fri, Sep 23, 2011 at 5:10 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: That would change my +1 to a -1. I'd also like to include a fix for wicket-event.js where we repair

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martijn Dashorst
On Fri, Sep 23, 2011 at 5:40 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: ok. lets call this vote failed, get the fixes in, and i will build 1.5.2 when all the fixes are in. The issue I raised was WICKET-4080, and that is fixed and closed. Martin fixed WICKET-4068, so we're good to go.

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Martin Grigorov
I think all is already in On Fri, Sep 23, 2011 at 6:40 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: ok. lets call this vote failed, get the fixes in, and i will build 1.5.2 when all the fixes are in. -igor On Fri, Sep 23, 2011 at 5:10 AM, Martijn Dashorst martijn.dasho...@gmail.com

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Igor Vaynberg
yeah, i can do that... -igor On Fri, Sep 23, 2011 at 8:44 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Fri, Sep 23, 2011 at 5:40 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: ok. lets call this vote failed, get the fixes in, and i will build 1.5.2 when all the fixes are in.

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Igor Vaynberg
what about WICKET-4078 and 4071? -igor On Fri, Sep 23, 2011 at 8:46 AM, Martin Grigorov mgrigo...@apache.org wrote: I think all is already in On Fri, Sep 23, 2011 at 6:40 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: ok. lets call this vote failed, get the fixes in, and i will build

Re: [vote] release wicket 1.5.1

2011-09-23 Thread Igor Vaynberg
at this point it doesnt make sense to do a build until sunday-afternoonish cali time. lets fix as many remaining bugs over the weekend and i will run a build sometime sunday. -igor On Fri, Sep 23, 2011 at 9:02 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: yeah, i can do that... -igor

Re: [vote] release wicket 1.5.1

2011-09-22 Thread Andrea Del Bene
+1 to release. This vote is to release wicket 1.5.1 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo https://repository.apache.org/content/repositories/orgapachewicket-081/ Changelog

Re: [vote] release wicket 1.5.1

2011-09-22 Thread Igor Vaynberg
please submit a quickstart with the failing markup. -igor On Tue, Sep 20, 2011 at 10:46 PM, nhsoft.yhw nhsoft@gmail.com wrote: After upgrading to wicket1.5.1 from wicket1.5.0, the original can not be a normal page appears normal resolution, errors occur html parsing problem. No matching

Re: [vote] release wicket 1.5.1

2011-09-22 Thread nhsoft.yhw
Sorry I'm late. I created a demo program, use the wicket-1.5.RC7 build, it works. But when I use the wicket-core-1.5.1.jar replace wicket-1.5.RC7.jar, http://apache-wicket.1842946.n4.nabble.com/file/n3835719/demo.rar demo.rar throw what exceptions: java.lang.NoSuchMethodError:

Re: [vote] release wicket 1.5.1

2011-09-21 Thread nhsoft.yhw
After upgrading to wicket1.5.1 from wicket1.5.0, the original can not be a normal page appears normal resolution, errors occur html parsing problem. No matching close bracket at (line 72, column 59) MarkupStream: [markup =

Re: [vote] release wicket 1.5.1

2011-09-21 Thread Martin Grigorov
can you reproduce it in quickstart app ? please attach it to a ticket in Jira On Wed, Sep 21, 2011 at 8:46 AM, nhsoft.yhw nhsoft@gmail.com wrote: After upgrading to wicket1.5.1 from wicket1.5.0, the original can not be a normal page appears normal resolution, errors occur html parsing

Re: [vote] release wicket 1.5.1

2011-09-21 Thread Martin Grigorov
+1 to release Tested: - svn co + Maven build - test wicket-examples (found just https://issues.apache.org/jira/browse/WICKET-4072) - test the quickstart - produces proper version (1.5.1) and I filed https://issues.apache.org/jira/browse/WICKET-4073 for the new HTTPS support - test the application

Re: [vote] release wicket 1.5.1

2011-09-21 Thread Emond Papegaaij
(non-binding) +1 I've been working with trunk for the past 2 weeks, without issues, or the issues have been fixed. On Wednesday 21 September 2011 10:40:15 Martin Grigorov wrote: +1 to release Tested: - svn co + Maven build - test wicket-examples (found just

[vote] release wicket 1.5.1

2011-09-20 Thread Igor Vaynberg
This vote is to release wicket 1.5.1 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo https://repository.apache.org/content/repositories/orgapachewicket-081/ Changelog