Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Igor Vaynberg
release vote has passed with 3 +1 binding votes. -igor On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg wrote: > This vote is to release wicket 1.5.1 take 2 > > Branch > http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 > > Artifacts > http://people.apache.org/~ivaynberg/wicket-1.5.1/di

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Igor Vaynberg
+1 -igor On Sun, Sep 25, 2011 at 4:07 PM, Igor Vaynberg wrote: > This vote is to release wicket 1.5.1 take 2 > > Branch > http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 > > Artifacts > http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ > > Maven repo > https://repository.apache

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martin Grigorov
Please continue this topic in a separate thread. Thanks! :-) On Wed, Sep 28, 2011 at 9:51 AM, Emond Papegaaij wrote: > It is your mapper that triggers this issue, therefore it is easy to work > around. You only have to prevent the code added for WIKCET-4014 from being > called, like this: > >    

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Emond Papegaaij
It is your mapper that triggers this issue, therefore it is easy to work around. You only have to prevent the code added for WIKCET-4014 from being called, like this: public Url mapHandler(IRequestHandler requestHandler) { if (requestHandler instanceof ListenerInterfaceRequestHandler)

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martijn Dashorst
+1 On Wed, Sep 28, 2011 at 9:13 AM, Martin Grigorov wrote: > +1 > > On Tue, Sep 27, 2011 at 9:25 PM,   wrote: >> (non-binding) -1 >> >> Thanks for reviewing WICKET-4087. >> >> Sorry, I don't have a workaround. This might be a misunderstanding. It >> is the mapper that triggers this issue. Sure it

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Andrea Del Bene
+1 +1 On Tue, Sep 27, 2011 at 9:25 PM, wrote: (non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that triggers this issue. Sure it is a corner case. But a very simple one, and the changes might cause other h

Re: [vote] release wicket 1.5.1 take 2

2011-09-28 Thread Martin Grigorov
+1 On Tue, Sep 27, 2011 at 9:25 PM, wrote: > (non-binding) -1 > > Thanks for reviewing WICKET-4087. > > Sorry, I don't have a workaround. This might be a misunderstanding. It > is the mapper that triggers this issue. Sure it is a corner case. But > a very simple one, and the changes might cause

Re: [vote] release wicket 1.5.1 take 2

2011-09-27 Thread bht
(non-binding) -1 Thanks for reviewing WICKET-4087. Sorry, I don't have a workaround. This might be a misunderstanding. It is the mapper that triggers this issue. Sure it is a corner case. But a very simple one, and the changes might cause other hard to find issues. Most Bugs are corner cases. Be

Re: [vote] release wicket 1.5.1 take 2

2011-09-27 Thread Emond Papegaaij
(non-binding) +1 Our application is running fine on 1.5.1. De reported issues are fixed, as far as we could reproduce them. Wrt WICKET-4087, I think this is a corner case and should be easy to work around, because Bernard already has his own mapper. The change was introduced with the fix for WI

Re: [vote] release wicket 1.5.1 take 2

2011-09-26 Thread bht
I have just found an issue https://issues.apache.org/jira/browse/WICKET-4087 Thanks, Bernard

[vote] release wicket 1.5.1 take 2

2011-09-25 Thread Igor Vaynberg
This vote is to release wicket 1.5.1 take 2 Branch http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ Maven repo https://repository.apache.org/content/repositories/orgapachewicket-099/ Changelog https://issues.apache.org