Re: Dynamic decision which version of jQuery to contribute

2013-05-28 Thread Martin Grigorov
Hi, I've reworked it as Michael suggested - DynamicJQueryResourceReference. Additionally I added caching of the calculated name in the request cycle's metadata, so the name is calculated at most once per request. It will be added only to master branch (7.x) until someone asks to downport it to

Re: Dynamic decision which version of jQuery to contribute

2013-05-28 Thread Sven Meier
Good suggestion, Michael. Sven On 05/28/2013 08:21 AM, Martin Grigorov wrote: Hi, I've reworked it as Michael suggested - DynamicJQueryResourceReference. Additionally I added caching of the calculated name in the request cycle's metadata, so the name is calculated at most once per request. It

Dynamic decision which version of jQuery to contribute

2013-05-27 Thread Martin Grigorov
Hi, At https://issues.apache.org/jira/browse/WICKET-5208 you may see a simple patch that makes JQueryResourceReference more dynamic. With this change Wicket can deliver jQuery 2.x to modern browsers and jQuery 1.x for IE 6/7/8. Pros: smaller jQuery Cons: dynamic calculation by using the user

Re: Dynamic decision which version of jQuery to contribute

2013-05-27 Thread tetsuo
Just not by default, please. On Mon, May 27, 2013 at 6:32 PM, Sebastien seb...@gmail.com wrote: Hi Martin, About the dynamic calculation, can't it be made according to an IApplicationSettings or an IJavaScriptLibrarySettings flag? Maybe could this flag be false by default and the user may

Re: Dynamic decision which version of jQuery to contribute

2013-05-27 Thread Michael Haitz
Hi, why not adding a second JQueryResourceReference? Then you can use the dynamic one or not (without a new setting). getJavaScriptLibrarySettings().setJQueryReference(new DynamicJQueryResourceReference()); cheers, Michael Am 27.05.2013 um 23:32 schrieb Sebastien seb...@gmail.com : Hi