Re: Igor did it!

2010-03-02 Thread Martin Makundi
Now there is time for RFEs ;) ? 2010/3/2 Matej Knopp matej.kn...@gmail.com: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej

Re: Igor did it!

2010-03-02 Thread Johan Compagner
Whoohooo finally i get rid of all the spam messages! On Tue, Mar 2, 2010 at 12:40, Matej Knopp matej.kn...@gmail.com wrote: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej

Re: Igor did it!

2010-03-02 Thread Martin Grigorov
Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! On Tue, 2010-03-02 at 13:44 +0200, Martin Makundi wrote: Now there is time for RFEs ;) ? Now is time to migrate apps and see what are the benefits and what is still missing related to URL mounting

Re: Igor did it!

2010-03-02 Thread Cemal Bayramoglu
wrote: Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! On Tue, 2010-03-02 at 13:44 +0200, Martin Makundi wrote: Now there is time for RFEs ;) ? Now is time to migrate apps and see what are the benefits and what is still missing related to URL

Re: Igor did it!

2010-03-02 Thread Igor Vaynberg
On Tue, Mar 2, 2010 at 7:52 AM, Matej Knopp matej.kn...@gmail.com wrote: On Tue, Mar 2, 2010 at 2:29 PM, Martin Grigorov mcgreg...@e-card.bg wrote: Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! Nah, I've done the fun stuff and Igor've done

Re: Igor did it!

2010-03-02 Thread Major Péter
Hi, Just for fun, I checked what's the last test, which fails (testSimpleStaticTimeFrame). After some debugging I found out, that when you creates timeFormat in org.apache.wicket.util.time.AbstractTime, then you don't specify the Locale, so when you call setCalendar with Locale.ENGLISH and parse

Re: Igor did it!

2010-03-02 Thread Martin Makundi
Yeah.. someone went and localized the h:mm(a---) in java some time ago whose results are surprising. I am not completely convinced it (a) should be locale-specific (am/pm). In my opinnion the expected is wrong here, but on the other hand I am not a linguist: