Re: buildbot failure in on wicket-master

[Martin Grigorov]

Hi,

Please see https://issues.apache.org/jira/browse/INFRA-21065

On Mon, Nov 2, 2020 at 2:39 PM  wrote:

> The Buildbot has detected a new failure on builder wicket-master while
> building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master/builds/1389
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave6_ubuntu
>
> Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-commit' triggered this build
> Build Source Stamp: [branch master]
> 19d8839072c08c3a4dcc0bf5b0bd058ed828511a
> Blamelist: Martin Tzvetanov Grigorov 
>
> BUILD FAILED: failed compile
>
> Sincerely,
>  -The Buildbot
>
>
>
>

Re: buildbot failure in on wicket-master

[Maxim Solodovnik]

This should be some temporary network issues
(failing test trying to connect URL url = new URL("
http://wicket.apache.org/learn/books/wia.png;); )

On Tue, 11 Feb 2020 at 04:40, Emond Papegaaij 
wrote:

> I don't what happened here, but I'm pretty sure that I didn't break
> this with a simple CSS change. The test runs fine on my machine. Did
> something change in the infra?
>
> Emond
>
> On Mon, Feb 10, 2020 at 9:46 PM  wrote:
> >
> > The Buildbot has detected a new failure on builder wicket-master while
> building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master/builds/1245
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: bb_slave6_ubuntu
> >
> > Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-commit' triggered this build
> > Build Source Stamp: [branch master]
> 4d8d8503524dd46c087a398f061685ab310e7856
> > Blamelist: Emond Papegaaij 
> >
> > BUILD FAILED: failed compile
> >
> > Sincerely,
> >  -The Buildbot
> >
> >
> >
>


-- 
WBR
Maxim aka solomax

Re: buildbot failure in on wicket-master

[Emond Papegaaij]

I don't what happened here, but I'm pretty sure that I didn't break
this with a simple CSS change. The test runs fine on my machine. Did
something change in the infra?

Emond

On Mon, Feb 10, 2020 at 9:46 PM  wrote:
>
> The Buildbot has detected a new failure on builder wicket-master while 
> building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master/builds/1245
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave6_ubuntu
>
> Build Reason: The SingleBranchScheduler scheduler named 
> 'on-wicket-master-commit' triggered this build
> Build Source Stamp: [branch master] 4d8d8503524dd46c087a398f061685ab310e7856
> Blamelist: Emond Papegaaij 
>
> BUILD FAILED: failed compile
>
> Sincerely,
>  -The Buildbot
>
>
>

Re: buildbot failure in on wicket-master-java12

[Martin Grigorov]

I will remove the java12 build

On Thu, Jan 9, 2020 at 12:34 PM Tobias Soloschenko
 wrote:

> +1 to remove JDK 12 testing
>
> kind regards
>
> Tobias
>
> > Am 09.01.2020 um 09:52 schrieb Maxim Solodovnik :
> >
> > I would vote for removing JDK12
> > no need to test outdated non-LTS versions IMO
> >
> >> On Thu, 9 Jan 2020 at 15:06, Martin Grigorov 
> wrote:
> >>
> >> Hi team,
> >>
> >> The build for Java 12 has failed due to the removal of the multiple test
> >> methods for the different versions of JDK for
> >> ZonedDateTimeConverter#convertToObject().
> >> JDK 12 is not maintained by JDK providers and this is the reason the
> change
> >> from UCT to UTC is not there.
> >>
> >> Question: should I revert the removal of the multiple test methods or
> >> should I remove the testing for JDK 12 in BuildBot ?
> >> I prefer the latter.
> >>
> >>> On Thu, Jan 9, 2020 at 9:35 AM  wrote:
> >>>
> >>> The Buildbot has detected a new failure on builder wicket-master-java12
> >>> while building wicket. Full details are available at:
> >>>https://ci.apache.org/builders/wicket-master-java12/builds/174
> >>>
> >>> Buildbot URL: https://ci.apache.org/
> >>>
> >>> Buildslave for this Build: bb_slave1_ubuntu
> >>>
> >>> Build Reason: The SingleBranchScheduler scheduler named
> >>> 'on-wicket-master-java12-commit' triggered this build
> >>> Build Source Stamp: [branch master]
> >>> 65e2266d8b205d3768986c3e6ad548cfb3759d35
> >>> Blamelist: Martin Tzvetanov Grigorov 
> >>>
> >>> BUILD FAILED: failed compile
> >>>
> >>> Sincerely,
> >>> -The Buildbot
> >>>
> >>>
> >>>
> >>>
> >>
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>

Re: buildbot failure in on wicket-master-java12

[Tobias Soloschenko]

+1 to remove JDK 12 testing

kind regards

Tobias

> Am 09.01.2020 um 09:52 schrieb Maxim Solodovnik :
> 
> I would vote for removing JDK12
> no need to test outdated non-LTS versions IMO
> 
>> On Thu, 9 Jan 2020 at 15:06, Martin Grigorov  wrote:
>> 
>> Hi team,
>> 
>> The build for Java 12 has failed due to the removal of the multiple test
>> methods for the different versions of JDK for
>> ZonedDateTimeConverter#convertToObject().
>> JDK 12 is not maintained by JDK providers and this is the reason the change
>> from UCT to UTC is not there.
>> 
>> Question: should I revert the removal of the multiple test methods or
>> should I remove the testing for JDK 12 in BuildBot ?
>> I prefer the latter.
>> 
>>> On Thu, Jan 9, 2020 at 9:35 AM  wrote:
>>> 
>>> The Buildbot has detected a new failure on builder wicket-master-java12
>>> while building wicket. Full details are available at:
>>>https://ci.apache.org/builders/wicket-master-java12/builds/174
>>> 
>>> Buildbot URL: https://ci.apache.org/
>>> 
>>> Buildslave for this Build: bb_slave1_ubuntu
>>> 
>>> Build Reason: The SingleBranchScheduler scheduler named
>>> 'on-wicket-master-java12-commit' triggered this build
>>> Build Source Stamp: [branch master]
>>> 65e2266d8b205d3768986c3e6ad548cfb3759d35
>>> Blamelist: Martin Tzvetanov Grigorov 
>>> 
>>> BUILD FAILED: failed compile
>>> 
>>> Sincerely,
>>> -The Buildbot
>>> 
>>> 
>>> 
>>> 
>> 
> 
> 
> -- 
> WBR
> Maxim aka solomax

Re: buildbot failure in on wicket-master-java12

[Maxim Solodovnik]

I would vote for removing JDK12
no need to test outdated non-LTS versions IMO

On Thu, 9 Jan 2020 at 15:06, Martin Grigorov  wrote:

> Hi team,
>
> The build for Java 12 has failed due to the removal of the multiple test
> methods for the different versions of JDK for
> ZonedDateTimeConverter#convertToObject().
> JDK 12 is not maintained by JDK providers and this is the reason the change
> from UCT to UTC is not there.
>
> Question: should I revert the removal of the multiple test methods or
> should I remove the testing for JDK 12 in BuildBot ?
> I prefer the latter.
>
> On Thu, Jan 9, 2020 at 9:35 AM  wrote:
>
> > The Buildbot has detected a new failure on builder wicket-master-java12
> > while building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master-java12/builds/174
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: bb_slave1_ubuntu
> >
> > Build Reason: The SingleBranchScheduler scheduler named
> > 'on-wicket-master-java12-commit' triggered this build
> > Build Source Stamp: [branch master]
> > 65e2266d8b205d3768986c3e6ad548cfb3759d35
> > Blamelist: Martin Tzvetanov Grigorov 
> >
> > BUILD FAILED: failed compile
> >
> > Sincerely,
> >  -The Buildbot
> >
> >
> >
> >
>


-- 
WBR
Maxim aka solomax

Re: buildbot failure in on wicket-master-java13

[Martin Grigorov]

I've created https://issues.apache.org/jira/browse/INFRA-18867 to upgrade
Java 13 and 14 at Buildbot slaves.

On Mon, Aug 12, 2019 at 2:19 PM  wrote:

> The Buildbot has detected a new failure on builder wicket-master-java13
> while building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master-java13/builds/113
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave1_ubuntu
>
> Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-java13-commit' triggered this build
> Build Source Stamp: [branch master]
> 810ac70d77e0816ac44eae8d8a38113c25d7e982
> Blamelist: Martin Tzvetanov Grigorov 
>
> BUILD FAILED: failed compile
>
> Sincerely,
>  -The Buildbot
>
>
>
>

Re: buildbot failure in on wicket-master-java13

[Martin Grigorov]

https://issues.apache.org/jira/browse/INFRA-18609

On Thu, Jun 13, 2019 at 4:43 PM  wrote:

> The Buildbot has detected a new failure on builder wicket-master-java13
> while building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master-java13/builds/85
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave1_ubuntu
>
> Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-java13-commit' triggered this build
> Build Source Stamp: [branch master]
> 96bda7f1fd32ec5c8d1a8dfa5512fa643e2479a7
> Blamelist: Martin Tzvetanov Grigorov 
>
> BUILD FAILED: failed compile
>
> Sincerely,
>  -The Buildbot
>
>
>
>

Re: buildbot failure in on wicket-master

[Andrea Del Bene]

I think there's a problem with buildbot. I will open an issue for the INFRA
team. Thank you for removing references to datetime module. I also agree
that specific websocket implementation should be removed from master.

Andrea.

On Tue, May 22, 2018 at 9:59 AM, Emond Papegaaij  wrote:

> This error still persists and I have no idea why. Locally the build is
> fine.
>
> I've removed some more references to the old datetime module, including
> the
> NOTICE about the bsd license. The userguide still mentions the tomcat and
> jetty9 modules for native-websockets. I think that part should be removed,
> right? AFAIK we now only support SSR356 compliant containers.
>
> Best regards,
> Emond
>
> On vrijdag 18 mei 2018 13:35:42 CEST Emond Papegaaij wrote:
> > I highly doubt my commit caused this failure:
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-compiler-plugin: 3.6.2:compile
> > (default-compile) on project wicket-util: Fatal error compiling: Error
> > creating file with javac arguments: No such file or directory -> [Help 1]
> >
> > Emond
> >
> > On vrijdag 18 mei 2018 13:23:31 CEST build...@apache.org wrote:
> > > The Buildbot has detected a new failure on builder wicket-master while
> > > building wicket. Full details are available at:
> > > https://ci.apache.org/builders/wicket-master/builds/933
> > >
> > > Buildbot URL: https://ci.apache.org/
> > >
> > > Buildslave for this Build: bb_slave1_ubuntu
> > >
> > > Build Reason: The SingleBranchScheduler scheduler named
> > > 'on-wicket-master-commit' triggered this build Build Source Stamp:
> [branch
> > > master] 024153133f79ef0bdd4ddbf0605c092fc9977e44 Blamelist: Emond
> > > Papegaaij
> > > 
> > >
> > > BUILD FAILED: failed compile
> > >
> > > Sincerely,
> > >
> > >  -The Buildbot
>
>
>
>
>

Re: buildbot failure in on wicket-master

[Emond Papegaaij]

This error still persists and I have no idea why. Locally the build is fine.

I've removed some more references to the old datetime module, including the 
NOTICE about the bsd license. The userguide still mentions the tomcat and 
jetty9 modules for native-websockets. I think that part should be removed, 
right? AFAIK we now only support SSR356 compliant containers.

Best regards,
Emond

On vrijdag 18 mei 2018 13:35:42 CEST Emond Papegaaij wrote:
> I highly doubt my commit caused this failure:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin: 3.6.2:compile
> (default-compile) on project wicket-util: Fatal error compiling: Error
> creating file with javac arguments: No such file or directory -> [Help 1]
> 
> Emond
> 
> On vrijdag 18 mei 2018 13:23:31 CEST build...@apache.org wrote:
> > The Buildbot has detected a new failure on builder wicket-master while
> > building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master/builds/933
> > 
> > Buildbot URL: https://ci.apache.org/
> > 
> > Buildslave for this Build: bb_slave1_ubuntu
> > 
> > Build Reason: The SingleBranchScheduler scheduler named
> > 'on-wicket-master-commit' triggered this build Build Source Stamp: [branch
> > master] 024153133f79ef0bdd4ddbf0605c092fc9977e44 Blamelist: Emond
> > Papegaaij
> > 
> > 
> > BUILD FAILED: failed compile
> > 
> > Sincerely,
> > 
> >  -The Buildbot

Re: buildbot failure in on wicket-master

[Sven Meier]

-0 for #chained(), this isn't even a verb (I know, 'of' isn't a verb either)

Regards
Sven


On 17.11.2016 12:22, Martin Grigorov wrote:

On Thu, Nov 17, 2016 at 12:13 PM, Martijn Dashorst <
martijn.dasho...@gmail.com> wrote:


We could also opt to rename map(...) to to(...)

Model.of(account).to(Account::getPerson).to(Person::
getLastName).to(String::toUppercase)


#map() is more widely used in JVM langs



Martijn


On Thu, Nov 17, 2016 at 11:09 AM, Emond Papegaaij
 wrote:

I also think 'chained' better covers the intent. 'map' normally isn't
a read/write transformation.

Emond

On Thu, Nov 17, 2016 at 12:38 AM, Martin Grigorov 

wrote:

+1 for #chained() .

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Nov 15, 2016 at 10:07 PM, Sven Meier  wrote:


Hi,


We could rename the methods taking an IModel as first parameter to
"chained" or "from".

or "map":

 LambdaModel.map(IModel, SerializableFunction,

SerializableBiConsumer)

 LambdaModel.map(IModel, SerializableFunction)

Sven



Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:


IModel.map(Function) indeed is functionally equivalent to
LambdaModel.of(IModel, Function), but its memory footprint is
significantly larger (120 vs 80 bytes). Also, there's no equivalent
method for of(IModel, Function, BiConsumer). Naturally, we can add the
corresponding method, but it will remain much less efficient. These
chained models require an additional object.

We've ran into similar problems many times at Topicus. Javac still is
very buggy when it comes to lambda type inference. IMHO the best
solution is to simply rename the methods to prevent the collisions.

We could rename the methods taking an IModel as first parameter to
"chained" or "from". Another solution would be a builder API, but I
doubt that would make the code more readable.

Best regards,
Emond

On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov <

mgrigo...@apache.org>

wrote:


On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij <
emond.papega...@topicus.nl


wrote:
It seems I've hit a bug in javac:
LambdaModelTest[46,61] reference to of is ambiguous:
   of(SerializableSupplier, SerializableConsumer)
 of(IModel,   SerializableFunction)

This clearly is wrong:
IModel personNameModel = LambdaModel.of(
  () -> person.getName(),
  (name) -> person.setName(name));

The first parameter could match both SerializableSupplier and
IModel,
but the second parameter only matches SerializableConsumer.

Eclipse

has
no
problem with this and compiles the code just fine.

I guess it confuses it with SerializableFunction.

Although, I
agree it should return null to actually match.

IMO we don't
need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.
model.IModel,
org.danekja.java.util.function.serializable.

SerializableFunction)

It gives the same
as org.apache.wicket.model.IModel#map(SerializableFunction
T, R>

mapper).


This now surfaces due to the change in the constructor. This testcase

used
to
call new LambdaModel(...), which had the same signature as the first
'of'.
I
had to change it to use the overloaded factory method.

I see two possible solutions:
   - Change the name of the factory methodes, so they are no longer
overloaded
(suggestions for the names are welcome)
   - Add a cast to the calling code to circumvent the bug.

IMHO both are ugly.

Best regards,
Emond

On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:


The Buildbot has detected a new failure on builder wicket-master

while

building wicket. Full details are available at:
https://ci.apache.org/builders/wicket-master/builds/550

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The SingleBranchScheduler scheduler named
'on-wicket-master-commit' triggered this build Build Source Stamp:


[branch


master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond


Papegaaij




BUILD FAILED: failed compile

Sincerely,
   -The Buildbot







--
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: buildbot failure in on wicket-master

[Martin Grigorov]

On Thu, Nov 17, 2016 at 12:13 PM, Martijn Dashorst <
martijn.dasho...@gmail.com> wrote:

> We could also opt to rename map(...) to to(...)
>
> Model.of(account).to(Account::getPerson).to(Person::
> getLastName).to(String::toUppercase)
>

#map() is more widely used in JVM langs


>
> Martijn
>
>
> On Thu, Nov 17, 2016 at 11:09 AM, Emond Papegaaij
>  wrote:
> > I also think 'chained' better covers the intent. 'map' normally isn't
> > a read/write transformation.
> >
> > Emond
> >
> > On Thu, Nov 17, 2016 at 12:38 AM, Martin Grigorov 
> wrote:
> >> +1 for #chained() .
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Tue, Nov 15, 2016 at 10:07 PM, Sven Meier  wrote:
> >>
> >>> Hi,
> >>>
> >>> >We could rename the methods taking an IModel as first parameter to
> >>> >"chained" or "from".
> >>>
> >>> or "map":
> >>>
> >>> LambdaModel.map(IModel, SerializableFunction,
> SerializableBiConsumer)
> >>>
> >>> LambdaModel.map(IModel, SerializableFunction)
> >>>
> >>> Sven
> >>>
> >>>
> >>>
> >>> Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:
> >>>
>  IModel.map(Function) indeed is functionally equivalent to
>  LambdaModel.of(IModel, Function), but its memory footprint is
>  significantly larger (120 vs 80 bytes). Also, there's no equivalent
>  method for of(IModel, Function, BiConsumer). Naturally, we can add the
>  corresponding method, but it will remain much less efficient. These
>  chained models require an additional object.
> 
>  We've ran into similar problems many times at Topicus. Javac still is
>  very buggy when it comes to lambda type inference. IMHO the best
>  solution is to simply rename the methods to prevent the collisions.
> 
>  We could rename the methods taking an IModel as first parameter to
>  "chained" or "from". Another solution would be a builder API, but I
>  doubt that would make the code more readable.
> 
>  Best regards,
>  Emond
> 
>  On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov <
> mgrigo...@apache.org>
>  wrote:
> 
> > On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij <
> > emond.papega...@topicus.nl
> >
> >> wrote:
> >> It seems I've hit a bug in javac:
> >> LambdaModelTest[46,61] reference to of is ambiguous:
> >>of(SerializableSupplier, SerializableConsumer)
> >>  of(IModel,   SerializableFunction)
> >>
> >> This clearly is wrong:
> >> IModel personNameModel = LambdaModel.of(
> >>  () -> person.getName(),
> >>  (name) -> person.setName(name));
> >>
> >> The first parameter could match both SerializableSupplier and
> >> IModel,
> >> but the second parameter only matches SerializableConsumer.
> Eclipse
> >> has
> >> no
> >> problem with this and compiles the code just fine.
> >>
> >> I guess it confuses it with SerializableFunction.
> > Although, I
> > agree it should return null to actually match.
> >
> > IMO we don't
> > need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.
> > model.IModel,
> > org.danekja.java.util.function.serializable.
> SerializableFunction)
> > It gives the same
> > as org.apache.wicket.model.IModel#map(SerializableFunction T, R>
> > mapper).
> >
> >
> > This now surfaces due to the change in the constructor. This testcase
> >> used
> >> to
> >> call new LambdaModel(...), which had the same signature as the first
> >> 'of'.
> >> I
> >> had to change it to use the overloaded factory method.
> >>
> >> I see two possible solutions:
> >>   - Change the name of the factory methodes, so they are no longer
> >> overloaded
> >> (suggestions for the names are welcome)
> >>   - Add a cast to the calling code to circumvent the bug.
> >>
> >> IMHO both are ugly.
> >>
> >> Best regards,
> >> Emond
> >>
> >> On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
> >>
> >>> The Buildbot has detected a new failure on builder wicket-master
> while
> >>> building wicket. Full details are available at:
> >>> https://ci.apache.org/builders/wicket-master/builds/550
> >>>
> >>> Buildbot URL: https://ci.apache.org/
> >>>
> >>> Buildslave for this Build: bb_slave1_ubuntu
> >>>
> >>> Build Reason: The SingleBranchScheduler scheduler named
> >>> 'on-wicket-master-commit' triggered this build Build Source Stamp:
> >>>
> >> [branch
> >>
> >>> master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
> >>>
> >> Papegaaij
> >>
> >>> 
> >>>
> >>> BUILD FAILED: failed compile
> >>>
> >>> Sincerely,
> >>>   -The Buildbot
> >>>
> >>
> >>
> >>
> >>>

Re: buildbot failure in on wicket-master

[Martijn Dashorst]

We could also opt to rename map(...) to to(...)

Model.of(account).to(Account::getPerson).to(Person::getLastName).to(String::toUppercase)

Martijn


On Thu, Nov 17, 2016 at 11:09 AM, Emond Papegaaij
 wrote:
> I also think 'chained' better covers the intent. 'map' normally isn't
> a read/write transformation.
>
> Emond
>
> On Thu, Nov 17, 2016 at 12:38 AM, Martin Grigorov  
> wrote:
>> +1 for #chained() .
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Tue, Nov 15, 2016 at 10:07 PM, Sven Meier  wrote:
>>
>>> Hi,
>>>
>>> >We could rename the methods taking an IModel as first parameter to
>>> >"chained" or "from".
>>>
>>> or "map":
>>>
>>> LambdaModel.map(IModel, SerializableFunction, SerializableBiConsumer)
>>>
>>> LambdaModel.map(IModel, SerializableFunction)
>>>
>>> Sven
>>>
>>>
>>>
>>> Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:
>>>
 IModel.map(Function) indeed is functionally equivalent to
 LambdaModel.of(IModel, Function), but its memory footprint is
 significantly larger (120 vs 80 bytes). Also, there's no equivalent
 method for of(IModel, Function, BiConsumer). Naturally, we can add the
 corresponding method, but it will remain much less efficient. These
 chained models require an additional object.

 We've ran into similar problems many times at Topicus. Javac still is
 very buggy when it comes to lambda type inference. IMHO the best
 solution is to simply rename the methods to prevent the collisions.

 We could rename the methods taking an IModel as first parameter to
 "chained" or "from". Another solution would be a builder API, but I
 doubt that would make the code more readable.

 Best regards,
 Emond

 On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov 
 wrote:

> On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij <
> emond.papega...@topicus.nl
>
>> wrote:
>> It seems I've hit a bug in javac:
>> LambdaModelTest[46,61] reference to of is ambiguous:
>>of(SerializableSupplier, SerializableConsumer)
>>  of(IModel,   SerializableFunction)
>>
>> This clearly is wrong:
>> IModel personNameModel = LambdaModel.of(
>>  () -> person.getName(),
>>  (name) -> person.setName(name));
>>
>> The first parameter could match both SerializableSupplier and
>> IModel,
>> but the second parameter only matches SerializableConsumer. Eclipse
>> has
>> no
>> problem with this and compiles the code just fine.
>>
>> I guess it confuses it with SerializableFunction.
> Although, I
> agree it should return null to actually match.
>
> IMO we don't
> need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.
> model.IModel,
> org.danekja.java.util.function.serializable.SerializableFunction)
> It gives the same
> as org.apache.wicket.model.IModel#map(SerializableFunction
> mapper).
>
>
> This now surfaces due to the change in the constructor. This testcase
>> used
>> to
>> call new LambdaModel(...), which had the same signature as the first
>> 'of'.
>> I
>> had to change it to use the overloaded factory method.
>>
>> I see two possible solutions:
>>   - Change the name of the factory methodes, so they are no longer
>> overloaded
>> (suggestions for the names are welcome)
>>   - Add a cast to the calling code to circumvent the bug.
>>
>> IMHO both are ugly.
>>
>> Best regards,
>> Emond
>>
>> On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
>>
>>> The Buildbot has detected a new failure on builder wicket-master while
>>> building wicket. Full details are available at:
>>> https://ci.apache.org/builders/wicket-master/builds/550
>>>
>>> Buildbot URL: https://ci.apache.org/
>>>
>>> Buildslave for this Build: bb_slave1_ubuntu
>>>
>>> Build Reason: The SingleBranchScheduler scheduler named
>>> 'on-wicket-master-commit' triggered this build Build Source Stamp:
>>>
>> [branch
>>
>>> master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
>>>
>> Papegaaij
>>
>>> 
>>>
>>> BUILD FAILED: failed compile
>>>
>>> Sincerely,
>>>   -The Buildbot
>>>
>>
>>
>>
>>>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: buildbot failure in on wicket-master

[Emond Papegaaij]

I also think 'chained' better covers the intent. 'map' normally isn't
a read/write transformation.

Emond

On Thu, Nov 17, 2016 at 12:38 AM, Martin Grigorov  wrote:
> +1 for #chained() .
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Nov 15, 2016 at 10:07 PM, Sven Meier  wrote:
>
>> Hi,
>>
>> >We could rename the methods taking an IModel as first parameter to
>> >"chained" or "from".
>>
>> or "map":
>>
>> LambdaModel.map(IModel, SerializableFunction, SerializableBiConsumer)
>>
>> LambdaModel.map(IModel, SerializableFunction)
>>
>> Sven
>>
>>
>>
>> Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:
>>
>>> IModel.map(Function) indeed is functionally equivalent to
>>> LambdaModel.of(IModel, Function), but its memory footprint is
>>> significantly larger (120 vs 80 bytes). Also, there's no equivalent
>>> method for of(IModel, Function, BiConsumer). Naturally, we can add the
>>> corresponding method, but it will remain much less efficient. These
>>> chained models require an additional object.
>>>
>>> We've ran into similar problems many times at Topicus. Javac still is
>>> very buggy when it comes to lambda type inference. IMHO the best
>>> solution is to simply rename the methods to prevent the collisions.
>>>
>>> We could rename the methods taking an IModel as first parameter to
>>> "chained" or "from". Another solution would be a builder API, but I
>>> doubt that would make the code more readable.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov 
>>> wrote:
>>>
 On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij <
 emond.papega...@topicus.nl

> wrote:
> It seems I've hit a bug in javac:
> LambdaModelTest[46,61] reference to of is ambiguous:
>of(SerializableSupplier, SerializableConsumer)
>  of(IModel,   SerializableFunction)
>
> This clearly is wrong:
> IModel personNameModel = LambdaModel.of(
>  () -> person.getName(),
>  (name) -> person.setName(name));
>
> The first parameter could match both SerializableSupplier and
> IModel,
> but the second parameter only matches SerializableConsumer. Eclipse
> has
> no
> problem with this and compiles the code just fine.
>
> I guess it confuses it with SerializableFunction.
 Although, I
 agree it should return null to actually match.

 IMO we don't
 need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.
 model.IModel,
 org.danekja.java.util.function.serializable.SerializableFunction)
 It gives the same
 as org.apache.wicket.model.IModel#map(SerializableFunction
 mapper).


 This now surfaces due to the change in the constructor. This testcase
> used
> to
> call new LambdaModel(...), which had the same signature as the first
> 'of'.
> I
> had to change it to use the overloaded factory method.
>
> I see two possible solutions:
>   - Change the name of the factory methodes, so they are no longer
> overloaded
> (suggestions for the names are welcome)
>   - Add a cast to the calling code to circumvent the bug.
>
> IMHO both are ugly.
>
> Best regards,
> Emond
>
> On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
>
>> The Buildbot has detected a new failure on builder wicket-master while
>> building wicket. Full details are available at:
>> https://ci.apache.org/builders/wicket-master/builds/550
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: bb_slave1_ubuntu
>>
>> Build Reason: The SingleBranchScheduler scheduler named
>> 'on-wicket-master-commit' triggered this build Build Source Stamp:
>>
> [branch
>
>> master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
>>
> Papegaaij
>
>> 
>>
>> BUILD FAILED: failed compile
>>
>> Sincerely,
>>   -The Buildbot
>>
>
>
>
>>

Re: buildbot failure in on wicket-master

[Martin Grigorov]

+1 for #chained() .

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Nov 15, 2016 at 10:07 PM, Sven Meier  wrote:

> Hi,
>
> >We could rename the methods taking an IModel as first parameter to
> >"chained" or "from".
>
> or "map":
>
> LambdaModel.map(IModel, SerializableFunction, SerializableBiConsumer)
>
> LambdaModel.map(IModel, SerializableFunction)
>
> Sven
>
>
>
> Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:
>
>> IModel.map(Function) indeed is functionally equivalent to
>> LambdaModel.of(IModel, Function), but its memory footprint is
>> significantly larger (120 vs 80 bytes). Also, there's no equivalent
>> method for of(IModel, Function, BiConsumer). Naturally, we can add the
>> corresponding method, but it will remain much less efficient. These
>> chained models require an additional object.
>>
>> We've ran into similar problems many times at Topicus. Javac still is
>> very buggy when it comes to lambda type inference. IMHO the best
>> solution is to simply rename the methods to prevent the collisions.
>>
>> We could rename the methods taking an IModel as first parameter to
>> "chained" or "from". Another solution would be a builder API, but I
>> doubt that would make the code more readable.
>>
>> Best regards,
>> Emond
>>
>> On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov 
>> wrote:
>>
>>> On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij <
>>> emond.papega...@topicus.nl
>>>
 wrote:
 It seems I've hit a bug in javac:
 LambdaModelTest[46,61] reference to of is ambiguous:
of(SerializableSupplier, SerializableConsumer)
  of(IModel,   SerializableFunction)

 This clearly is wrong:
 IModel personNameModel = LambdaModel.of(
  () -> person.getName(),
  (name) -> person.setName(name));

 The first parameter could match both SerializableSupplier and
 IModel,
 but the second parameter only matches SerializableConsumer. Eclipse
 has
 no
 problem with this and compiles the code just fine.

 I guess it confuses it with SerializableFunction.
>>> Although, I
>>> agree it should return null to actually match.
>>>
>>> IMO we don't
>>> need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.
>>> model.IModel,
>>> org.danekja.java.util.function.serializable.SerializableFunction)
>>> It gives the same
>>> as org.apache.wicket.model.IModel#map(SerializableFunction
>>> mapper).
>>>
>>>
>>> This now surfaces due to the change in the constructor. This testcase
 used
 to
 call new LambdaModel(...), which had the same signature as the first
 'of'.
 I
 had to change it to use the overloaded factory method.

 I see two possible solutions:
   - Change the name of the factory methodes, so they are no longer
 overloaded
 (suggestions for the names are welcome)
   - Add a cast to the calling code to circumvent the bug.

 IMHO both are ugly.

 Best regards,
 Emond

 On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:

> The Buildbot has detected a new failure on builder wicket-master while
> building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master/builds/550
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave1_ubuntu
>
> Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-commit' triggered this build Build Source Stamp:
>
 [branch

> master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
>
 Papegaaij

> 
>
> BUILD FAILED: failed compile
>
> Sincerely,
>   -The Buildbot
>



>

Re: buildbot failure in on wicket-master

[Sven Meier]

Hi,

>We could rename the methods taking an IModel as first parameter to
>"chained" or "from".

or "map":

LambdaModel.map(IModel, SerializableFunction, SerializableBiConsumer)

LambdaModel.map(IModel, SerializableFunction)

Sven


Am 15.11.2016 um 20:52 schrieb Emond Papegaaij:

IModel.map(Function) indeed is functionally equivalent to
LambdaModel.of(IModel, Function), but its memory footprint is
significantly larger (120 vs 80 bytes). Also, there's no equivalent
method for of(IModel, Function, BiConsumer). Naturally, we can add the
corresponding method, but it will remain much less efficient. These
chained models require an additional object.

We've ran into similar problems many times at Topicus. Javac still is
very buggy when it comes to lambda type inference. IMHO the best
solution is to simply rename the methods to prevent the collisions.

We could rename the methods taking an IModel as first parameter to
"chained" or "from". Another solution would be a builder API, but I
doubt that would make the code more readable.

Best regards,
Emond

On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov  wrote:

On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij  of(IModel,   SerializableFunction)

This clearly is wrong:
IModel personNameModel = LambdaModel.of(
 () -> person.getName(),
 (name) -> person.setName(name));

The first parameter could match both SerializableSupplier and IModel,
but the second parameter only matches SerializableConsumer. Eclipse has
no
problem with this and compiles the code just fine.


I guess it confuses it with SerializableFunction. Although, I
agree it should return null to actually match.

IMO we don't
need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.model.IModel,
org.danekja.java.util.function.serializable.SerializableFunction)
It gives the same
as org.apache.wicket.model.IModel#map(SerializableFunction
mapper).



This now surfaces due to the change in the constructor. This testcase used
to
call new LambdaModel(...), which had the same signature as the first 'of'.
I
had to change it to use the overloaded factory method.

I see two possible solutions:
  - Change the name of the factory methodes, so they are no longer
overloaded
(suggestions for the names are welcome)
  - Add a cast to the calling code to circumvent the bug.

IMHO both are ugly.

Best regards,
Emond

On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:

The Buildbot has detected a new failure on builder wicket-master while
building wicket. Full details are available at:
https://ci.apache.org/builders/wicket-master/builds/550

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The SingleBranchScheduler scheduler named
'on-wicket-master-commit' triggered this build Build Source Stamp:

[branch

master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond

Papegaaij



BUILD FAILED: failed compile

Sincerely,
  -The Buildbot

Re: buildbot failure in on wicket-master

[Emond Papegaaij]

IModel.map(Function) indeed is functionally equivalent to
LambdaModel.of(IModel, Function), but its memory footprint is
significantly larger (120 vs 80 bytes). Also, there's no equivalent
method for of(IModel, Function, BiConsumer). Naturally, we can add the
corresponding method, but it will remain much less efficient. These
chained models require an additional object.

We've ran into similar problems many times at Topicus. Javac still is
very buggy when it comes to lambda type inference. IMHO the best
solution is to simply rename the methods to prevent the collisions.

We could rename the methods taking an IModel as first parameter to
"chained" or "from". Another solution would be a builder API, but I
doubt that would make the code more readable.

Best regards,
Emond

On Tue, Nov 15, 2016 at 8:06 PM, Martin Grigorov  wrote:
> On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij > wrote:
>
>> It seems I've hit a bug in javac:
>> LambdaModelTest[46,61] reference to of is ambiguous:
>>of(SerializableSupplier, SerializableConsumer)
>>  of(IModel,   SerializableFunction)
>>
>> This clearly is wrong:
>> IModel personNameModel = LambdaModel.of(
>> () -> person.getName(),
>> (name) -> person.setName(name));
>>
>> The first parameter could match both SerializableSupplier and IModel,
>> but the second parameter only matches SerializableConsumer. Eclipse has
>> no
>> problem with this and compiles the code just fine.
>>
>
> I guess it confuses it with SerializableFunction. Although, I
> agree it should return null to actually match.
>
> IMO we don't
> need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.model.IModel,
> org.danekja.java.util.function.serializable.SerializableFunction)
> It gives the same
> as org.apache.wicket.model.IModel#map(SerializableFunction
> mapper).
>
>
>>
>> This now surfaces due to the change in the constructor. This testcase used
>> to
>> call new LambdaModel(...), which had the same signature as the first 'of'.
>> I
>> had to change it to use the overloaded factory method.
>>
>> I see two possible solutions:
>>  - Change the name of the factory methodes, so they are no longer
>> overloaded
>> (suggestions for the names are welcome)
>>  - Add a cast to the calling code to circumvent the bug.
>>
>> IMHO both are ugly.
>>
>> Best regards,
>> Emond
>>
>> On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
>> > The Buildbot has detected a new failure on builder wicket-master while
>> > building wicket. Full details are available at:
>> > https://ci.apache.org/builders/wicket-master/builds/550
>> >
>> > Buildbot URL: https://ci.apache.org/
>> >
>> > Buildslave for this Build: bb_slave1_ubuntu
>> >
>> > Build Reason: The SingleBranchScheduler scheduler named
>> > 'on-wicket-master-commit' triggered this build Build Source Stamp:
>> [branch
>> > master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
>> Papegaaij
>> > 
>> >
>> > BUILD FAILED: failed compile
>> >
>> > Sincerely,
>> >  -The Buildbot
>>
>>
>>

Re: buildbot failure in on wicket-master

[Martin Grigorov]

On Tue, Nov 15, 2016 at 2:51 PM, Emond Papegaaij  wrote:

> It seems I've hit a bug in javac:
> LambdaModelTest[46,61] reference to of is ambiguous:
>of(SerializableSupplier, SerializableConsumer)
>  of(IModel,   SerializableFunction)
>
> This clearly is wrong:
> IModel personNameModel = LambdaModel.of(
> () -> person.getName(),
> (name) -> person.setName(name));
>
> The first parameter could match both SerializableSupplier and IModel,
> but the second parameter only matches SerializableConsumer. Eclipse has
> no
> problem with this and compiles the code just fine.
>

I guess it confuses it with SerializableFunction. Although, I
agree it should return null to actually match.

IMO we don't
need org.apache.wicket.model.LambdaModel#of(org.apache.wicket.model.IModel,
org.danekja.java.util.function.serializable.SerializableFunction)
It gives the same
as org.apache.wicket.model.IModel#map(SerializableFunction
mapper).


>
> This now surfaces due to the change in the constructor. This testcase used
> to
> call new LambdaModel(...), which had the same signature as the first 'of'.
> I
> had to change it to use the overloaded factory method.
>
> I see two possible solutions:
>  - Change the name of the factory methodes, so they are no longer
> overloaded
> (suggestions for the names are welcome)
>  - Add a cast to the calling code to circumvent the bug.
>
> IMHO both are ugly.
>
> Best regards,
> Emond
>
> On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
> > The Buildbot has detected a new failure on builder wicket-master while
> > building wicket. Full details are available at:
> > https://ci.apache.org/builders/wicket-master/builds/550
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: bb_slave1_ubuntu
> >
> > Build Reason: The SingleBranchScheduler scheduler named
> > 'on-wicket-master-commit' triggered this build Build Source Stamp:
> [branch
> > master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond
> Papegaaij
> > 
> >
> > BUILD FAILED: failed compile
> >
> > Sincerely,
> >  -The Buildbot
>
>
>

Re: buildbot failure in on wicket-master

[Emond Papegaaij]

It seems I've hit a bug in javac:
LambdaModelTest[46,61] reference to of is ambiguous:
   of(SerializableSupplier, SerializableConsumer)
 of(IModel,   SerializableFunction)

This clearly is wrong:
IModel personNameModel = LambdaModel.of(
() -> person.getName(),
(name) -> person.setName(name));

The first parameter could match both SerializableSupplier and IModel, 
but the second parameter only matches SerializableConsumer. Eclipse has no 
problem with this and compiles the code just fine.

This now surfaces due to the change in the constructor. This testcase used to 
call new LambdaModel(...), which had the same signature as the first 'of'. I 
had to change it to use the overloaded factory method.

I see two possible solutions:
 - Change the name of the factory methodes, so they are no longer overloaded 
(suggestions for the names are welcome)
 - Add a cast to the calling code to circumvent the bug.

IMHO both are ugly.

Best regards,
Emond

On dinsdag 15 november 2016 13:36:56 CET build...@apache.org wrote:
> The Buildbot has detected a new failure on builder wicket-master while
> building wicket. Full details are available at:
> https://ci.apache.org/builders/wicket-master/builds/550
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: bb_slave1_ubuntu
> 
> Build Reason: The SingleBranchScheduler scheduler named
> 'on-wicket-master-commit' triggered this build Build Source Stamp: [branch
> master] b40e9e1cd9ad7a9ffc63ab6c329c8d9c8b78b924 Blamelist: Emond Papegaaij
> 
> 
> BUILD FAILED: failed compile
> 
> Sincerely,
>  -The Buildbot

Re: buildbot failure in on wicket-master

[Martin Grigorov]

This has been fixed.
There is a new problem now:
https://issues.apache.org/jira/browse/INFRA-12877

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Nov 8, 2016 at 11:15 PM, Martijn Dashorst <
martijn.dasho...@gmail.com> wrote:

> Ah Thanks!
>
> I looked into the log, but didn't find anything I could fix.
>
> Martijn
>
>
> On Tue, Nov 8, 2016 at 10:58 PM, Martin Grigorov 
> wrote:
> > https://issues.apache.org/jira/browse/INFRA-12875
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Tue, Nov 8, 2016 at 10:28 PM,  wrote:
> >
> >> The Buildbot has detected a new failure on builder wicket-master while
> >> building wicket. Full details are available at:
> >> https://ci.apache.org/builders/wicket-master/builds/540
> >>
> >> Buildbot URL: https://ci.apache.org/
> >>
> >> Buildslave for this Build: bb_slave1_ubuntu
> >>
> >> Build Reason: The SingleBranchScheduler scheduler named
> >> 'on-wicket-master-commit' triggered this build
> >> Build Source Stamp: [branch master] 7a15297e032c0c8375a8909b891fb6
> >> c79529496b
> >> Blamelist: Martijn Dashorst 
> >>
> >> BUILD FAILED: failed compile
> >>
> >> Sincerely,
> >>  -The Buildbot
> >>
> >>
> >>
> >>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: buildbot failure in on wicket-master

[Martijn Dashorst]

Ah Thanks!

I looked into the log, but didn't find anything I could fix.

Martijn


On Tue, Nov 8, 2016 at 10:58 PM, Martin Grigorov  wrote:
> https://issues.apache.org/jira/browse/INFRA-12875
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Tue, Nov 8, 2016 at 10:28 PM,  wrote:
>
>> The Buildbot has detected a new failure on builder wicket-master while
>> building wicket. Full details are available at:
>> https://ci.apache.org/builders/wicket-master/builds/540
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: bb_slave1_ubuntu
>>
>> Build Reason: The SingleBranchScheduler scheduler named
>> 'on-wicket-master-commit' triggered this build
>> Build Source Stamp: [branch master] 7a15297e032c0c8375a8909b891fb6
>> c79529496b
>> Blamelist: Martijn Dashorst 
>>
>> BUILD FAILED: failed compile
>>
>> Sincerely,
>>  -The Buildbot
>>
>>
>>
>>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com