[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-09-19 Thread via GitHub
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1725541943 It's `WSSecurityException.ErrorCode.FAILURE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-09-19 Thread via GitHub
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1725139230 There now exists: ``` Error: Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.049 s <<< FAILURE! -- in org.apache.wss4j.dom.saml.SamlNegativeTest Error:

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-09-14 Thread via GitHub
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1720686499 This is now done, and I suppose GH workflows should also update to support JDK 17 which is the minimum requirement for OS v5. -- This is an automated message from the Apache Git Service.

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-09-14 Thread via GitHub
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1720483723 V5 is now released. Shall I update this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-01-05 Thread GitBox
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1373111986 No news yet. It generally should happen along with the release of the shibboleth idp v5, and I suspect that might happen in approx a month. Certainly in Q1. Fingers crossed. How do

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-01-04 Thread GitBox
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1370794269 Ok thank you. I am guessing that is likely because wss4j is not using any of the opensaml encoders/decoders that wants to deal with http request and or response(?) since they mainly belong

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2023-01-02 Thread GitBox
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1369421257 @coheigea Small question if I may: I see that v3 release supports jakarta APIs, and yet the release is still based on OpenSAML v4 which has no support for such APIs. Would't this mean that

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2022-10-12 Thread GitBox
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1275780728 I appreciate your update. I am keeping an eye out for the OS release, and will post back here. (Anticipating late December) -- This is an automated message from the Apache Git Service.

[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5

2022-10-11 Thread GitBox
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1275245180 Hello @coheigea is this something that can be included in v4 here? Given OpenSAML v5 does provide support for Jakarta APIs? -- This is an automated message from the Apache Git Service.