[ 
https://issues.apache.org/jira/browse/WSS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958694#comment-13958694
 ] 

Alessio Soldano commented on WSS-496:
-------------------------------------

Proposed patch fixing the issue:

{noformat}
Index: integration/pom.xml
===================================================================
--- integration/pom.xml (revision 1584328)
+++ integration/pom.xml (working copy)
@@ -33,6 +33,12 @@
     <dependencies>
         <dependency>
             <groupId>org.apache.wss4j</groupId>
+            <artifactId>wss4j-ws-security-common</artifactId>
+            <version>${project.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.wss4j</groupId>
             <artifactId>wss4j-ws-security-dom</artifactId>
             <version>${project.version}</version>
             <scope>test</scope>
@@ -51,6 +57,13 @@
             <scope>test</scope>
         </dependency>
         <dependency>
+            <groupId>org.apache.wss4j</groupId>
+            <artifactId>wss4j-ws-security-dom</artifactId>
+            <version>${project.version}</version>
+            <classifier>tests</classifier>
+            <scope>test</scope>    
+        </dependency>
+        <dependency>
             <groupId>org.apache.directory.server</groupId>
             <artifactId>apacheds-kerberos-shared</artifactId>
             <version>1.5.7</version>
Index: ws-security-policy-stax/pom.xml
===================================================================
--- ws-security-policy-stax/pom.xml     (revision 1584328)
+++ ws-security-policy-stax/pom.xml     (working copy)
@@ -64,6 +64,13 @@
             <scope>test</scope>
         </dependency>
         <dependency>
+            <groupId>org.apache.wss4j</groupId>
+            <artifactId>wss4j-ws-security-dom</artifactId>
+            <version>${project.version}</version>
+            <classifier>tests</classifier>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
             <scope>test</scope>
Index: ws-security-stax/pom.xml
===================================================================
--- ws-security-stax/pom.xml    (revision 1584328)
+++ ws-security-stax/pom.xml    (working copy)
@@ -161,6 +161,7 @@
             <artifactId>wss4j-ws-security-dom</artifactId>
             <version>${project.version}</version>
             <classifier>tests</classifier>
+            <scope>test</scope> 
         </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>

{noformat}

> "tests" classifier artifacts should not have compile scope
> ----------------------------------------------------------
>
>                 Key: WSS-496
>                 URL: https://issues.apache.org/jira/browse/WSS-496
>             Project: WSS4J
>          Issue Type: Bug
>          Components: WSS4J Core
>            Reporter: Alessio Soldano
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0.0
>
>
> On trunk (2.0.0-SNAPSHOT), there're some maven artifacts which are built with 
> "tests" classifier and look to be used for tests.
> Unfortunately, the ws-security-stax/pom.xml is not setting the scope for one 
> of them (org.apache.wss4j:wss4j-ws-security-dom:tests), resulting in polluted 
> transitive dependencies trees in any project that consumes Apache WSS4J.
> This is a problem for example because the CryptoFactory uses the classloader 
> for resolving crypto properties and can hence end up reading from the test 
> artifacts while that has nothing to do with the final user application.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org
For additional commands, e-mail: dev-h...@ws.apache.org

Reply via email to