Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-24 Thread Manuri Amaya Perera
Having an OSGi parent for a non-OSGi module is not a problem as we are specifying the needed packaging type(eg: jar) ​ We are just specifying our maven-bundle-plugin in the carbon-parent. Any child module who use it(i.e. specify packaging type as bundle) will inherit the configuration and others

Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-23 Thread Manuri Amaya Perera
Hi, I have created a doc[1] on 1. What configurations should be allowed to be changed by component developers (may have default values or not) 2. What should have default values which cannot be overridden without redeclaring the plugin inside the bundle Please share your thoughts on this. And

Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-23 Thread Afkham Azeez
Can carbon-parent be the parent of non-osgi jars as well? If so should we call it carbon-componet-parent? On Nov 24, 2015 11:13 AM, "Manuri Amaya Perera" wrote: > Hi, > > I have created a doc[1] on > 1. What configurations should be allowed to be changed by component >

Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-23 Thread Manuri Amaya Perera
Hi Azeez, [1] is a non-osgi jar which has the parent carbon-kernel of which the parent is carbon-parent. Why do we need to add "component" ? Doesn't it already sound generic? [1] https://github.com/wso2/carbon-kernel/blob/master/launcher/pom.xml Thank you. On Tue, Nov 24, 2015 at 11:18 AM,

Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-23 Thread Afkham Azeez
We can't make all non-osgi jars make carbon-kernel their parent On Nov 24, 2015 11:37 AM, "Manuri Amaya Perera" wrote: > Hi Azeez, > > [1] is a non-osgi jar which has the parent carbon-kernel of which the > parent is carbon-parent. > Why do we need to add "component" ? Doesn't

[Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-11 Thread Manuri Amaya Perera
Hi, Currently for each carbon component's pom file we need to include the maven bundle plugin. Some of the bundle plugin configuration values such as group id, artifact id and version are repetitively used in each of these components(eg: [1]) We can avoid this repetition by including the bundle

Re: [Dev] [CARBON] Parameterizing the Maven bundle plugin and moving plugin configuration inside carbon-parent pom

2015-11-11 Thread Manuri Amaya Perera
+ architecture@ On Wed, Nov 11, 2015 at 2:46 PM, Manuri Amaya Perera wrote: > Hi, > > Currently for each carbon component's pom file we need to include the > maven bundle plugin. Some of the bundle plugin configuration values such as > group id, artifact id and version are