Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-11 Thread Gobinath
Hi, I defined the number of operands as the number of LogicalStreamProcessors that can be partners. Not is handled by one LogicalStreamProcessor so it can be partner with another LogicalStreamProcessor. Does it make sense? Thanks and Regards, Gobinath On Jul 11, 2017 3:06 PM, "Sriskandarajah

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-10 Thread Gobinath
Hi Suho, I have added the test cases to all the cases you have mentioned except the four listed below because having more than two pattern operands is not supported by Siddhi. I hope it is okay to skip those test cases. WDYT? - every ( (not C and D) and B ) -> A - every ((not C and D) or

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-03 Thread Gobinath
Hi, Sure. I will add test cases for each of these cases. Thanks & Regards, Gobinath On Mon, Jul 3, 2017 at 2:23 PM, Sriskandarajah Suhothayan wrote: > > > On Mon, Jul 3, 2017 at 5:18 PM, Gobinath wrote: > >> Hi, >> >> The following absent event cases are

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-03 Thread Sriskandarajah Suhothayan
On Mon, Jul 3, 2017 at 5:18 PM, Gobinath wrote: > Hi, > > The following absent event cases are implemented and tested so far and now > I am focusing on testing these patterns in the form of *Sequence*. If you > find any cases that I missed or any improvements, please share

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-03 Thread Gobinath
Hi, The following absent event cases are implemented and tested so far and now I am focusing on testing these patterns in the form of *Sequence*. If you find any cases that I missed or any improvements, please share them. A not B for 1sec After the arrival of A, wait for 1 sec & B not arrived

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-02 Thread Gobinath
Thanks, Suho. Sure I will. Thanks & Regards, Gobinath On Sun, Jul 2, 2017 at 6:32 AM, Sriskandarajah Suhothayan wrote: > Thanks merged the PR. > > Can you inform in SOF that you have fixed this issue, and this is the PR. > > Thanks > Suho > > On Sun, Jul 2, 2017 at 6:21 AM,

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-02 Thread Sriskandarajah Suhothayan
Thanks merged the PR. Can you inform in SOF that you have fixed this issue, and this is the PR. Thanks Suho On Sun, Jul 2, 2017 at 6:21 AM, Gobinath wrote: > Hi, > > Please find the PR [1] fixing the following issues in Siddhi. > > 1. Logical pattern not obeying the

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-07-01 Thread Gobinath
Hi, Please find the PR [1] fixing the following issues in Siddhi. 1. Logical pattern not obeying the '*within*' keyword 2. Sequence not obeying the '*every*' keyword 3. Logical pattern '*from* *A or B select...*' not producing the output With this fix, the problems asked in Stack Overflow [2]

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-13 Thread Gobinath
Hi, I've fixed the duplicate output with 'OR' in the PR #354 [1]. According to this fix, the *addState* method of *LogicalPreStateProcessor* treats both PATTERN and SEQUENCE in the same way [2]. It does not break any existing tests but please check whether it makes sense or not. [1]

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Sriskandarajah Suhothayan
I have merged that. +1 this also should give 1 output. Thanks for the fixes. Regards Suho On Mon, May 8, 2017 at 10:18 AM, Nirmal Fernando wrote: > Again, I'd only expect one o/p; > Event{timestamp=1494203709496, data=[WSO2, null, 4.7], isExpired=false} > > On Mon, May 8,

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Nirmal Fernando
Again, I'd only expect one o/p; Event{timestamp=1494203709496, data=[WSO2, null, 4.7], isExpired=false} On Mon, May 8, 2017 at 6:25 AM, Gobinath wrote: > Hi, > > I've found a minor bug and sent the PR [1] with the fix. Similar behavior > is noticed with *or* operator as

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Gobinath
Hi, I've found a minor bug and sent the PR [1] with the fix. Similar behavior is noticed with *or* operator as well (Even after the fix). I have given the code and the output below for your concern. // Query: e1 or e2 -> e3 define stream Stream1 (symbol string, price float, volume int); define

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Gobinath
Sure. I'll check the issue and send a separate PR with the fix. Thanks & Regards, Gobinath On Sun, May 7, 2017 at 1:51 PM, Sriskandarajah Suhothayan wrote: > Yes, it looks like a bug to me, can you check why it's happening. > > Regards > Suho > > On Sun, May 7, 2017 at 8:56 PM,

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Sriskandarajah Suhothayan
Yes, it looks like a bug to me, can you check why it's happening. Regards Suho On Sun, May 7, 2017 at 8:56 PM, Nirmal Fernando wrote: > Looks like a bug to me. I would expect only 1 event. > > On Sun, May 7, 2017 at 8:49 PM, Gobinath wrote: > >> Hi, >>

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Nirmal Fernando
Looks like a bug to me. I would expect only 1 event. On Sun, May 7, 2017 at 8:49 PM, Gobinath wrote: > Hi, > > Thanks for accepting my proposal. I have a question regarding the behavior > of *and* in a pattern. > > // Query: e1 and e2 -> e3 > > define stream Stream1

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-05-07 Thread Gobinath
Hi, Thanks for accepting my proposal. I have a question regarding the behavior of *and* in a pattern. // Query: e1 and e2 -> e3 define stream Stream1 (symbol string, price float, volume int); define stream Stream2 (symbol string, price float, volume int); @info(name = 'query1') from

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-04-17 Thread Gobinath
Hi, Please see the PR at [1]. Please do not merge it. Thanks & Regards, Gobinath [1] https://github.com/wso2/siddhi/pull/313 On Mon, Apr 17, 2017 at 7:44 AM, Sriskandarajah Suhothayan wrote: > Based on first look, it looks great. > > Can you send it as a PR so I can see the

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-04-17 Thread Sriskandarajah Suhothayan
Based on first look, it looks great. Can you send it as a PR so I can see the exact implementations and also give comments. Regards Suho On Mon, Apr 17, 2017 at 5:30 AM, Gobinath wrote: > Hi, > > A prototype is implemented and available at [1]. Currently the query >

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-04-16 Thread Gobinath
Hi, A prototype is implemented and available at [1]. Currently the query support for absent patterns and two simple pattern identifications (e1 -> not e2 and not e1 -> e2) are implemented. Please have a look at the unit test [2] to get the idea. Class names and variable names are subject to

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-03-31 Thread Gobinath
Hi all, Thanks Suho for your feedback. I have made the changes based on your suggestions and submitted the final proposal. Started working on a prototype and will update you soon with the results. Thanks & Regards, Gobinath On Thu, Mar 30, 2017 at 12:28 PM, Sriskandarajah Suhothayan

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-03-30 Thread Sriskandarajah Suhothayan
I have given some feedback on the gsoc site. Suho On Mon, Mar 27, 2017 at 9:03 PM, Gobinath wrote: > Hi all, > > Thanks. I have shared the draft of my proposal titled "Non-Occurrence of > Events for Siddhi Patterns" with WSO2 through GSoC dashboard and requesting > your

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-03-27 Thread Gobinath
Hi all, Thanks. I have shared the draft of my proposal titled "Non-Occurrence of Events for Siddhi Patterns" with WSO2 through GSoC dashboard and requesting your feedback on this. Thanks & Regards, Gobinath On Wed, Mar 15, 2017 at 1:30 PM, Sriskandarajah Suhothayan wrote: >

Re: [Dev] [GSoC][Siddhi][CEP]: Siddhi Pattern for Absence of Events

2017-03-15 Thread Sriskandarajah Suhothayan
Thanks for the GSoC idea, I hope this will be a good way to improve the Siddhi language and make it more powerfull. If time permits we can also add other use-cases of patterns & sequences and improve it further. Since you are still not a commuter I hope these contributions will help you be a