Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-09 Thread Nirmal Fernando
Thanks! On Sat, May 9, 2015 at 12:45 PM, Maheshika Goonetilleke mahesh...@wso2.com wrote: Hi Nirmal Deployed successfully. On Sat, May 9, 2015 at 6:56 AM, Nirmal Fernando nir...@wso2.com wrote: Thanks Guys! On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe kas...@wso2.com wrote: Pr

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-09 Thread Maheshika Goonetilleke
Hi Nirmal Deployed successfully. On Sat, May 9, 2015 at 6:56 AM, Nirmal Fernando nir...@wso2.com wrote: Thanks Guys! On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe kas...@wso2.com wrote: Pr merged. @maheshika, over to you. On May 8, 2015, at 2:48 PM, Jayanga Dissanayake

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-08 Thread Nirmal Fernando
Can we get these PRs reviewed please? On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga sup...@wso2.com wrote: Hi Jayanga, Fixed (1) and (2). As per the offline discussion, (3) was concluded to be OK, so left unchanged. Can you please review and merge the resent PR [a]. [a]

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-08 Thread Jayanga Dissanayake
Hi Kasung, Reviewed the poms in given PR. Please merge. Thanks, Jayanga. *Jayanga Dissanayake* Senior Software Engineer WSO2 Inc. - http://wso2.com/ lean . enterprise . middleware email: jaya...@wso2.com mobile: +94772207259 On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando nir...@wso2.com

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-08 Thread Kasun Gajasinghe
Pr merged. @maheshika, over to you. On May 8, 2015, at 2:48 PM, Jayanga Dissanayake jaya...@wso2.com wrote: Hi Kasung, Reviewed the poms in given PR. Please merge. Thanks, Jayanga. Jayanga Dissanayake Senior Software Engineer WSO2 Inc. - http://wso2.com/ lean . enterprise .

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-08 Thread Nirmal Fernando
Thanks Guys! On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe kas...@wso2.com wrote: Pr merged. @maheshika, over to you. On May 8, 2015, at 2:48 PM, Jayanga Dissanayake jaya...@wso2.com wrote: Hi Kasung, Reviewed the poms in given PR. Please merge. Thanks, Jayanga. *Jayanga

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-07 Thread Niranda Perera
thanks Maheshika On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke mahesh...@wso2.com wrote: Hi Kasun Both were deployed successfully. On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe kas...@wso2.com wrote: Hi Niranda, Released the following orbit bundles. (finally! ;) )

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-07 Thread Maheshika Goonetilleke
Hi Kasun Both were deployed successfully. On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe kas...@wso2.com wrote: Hi Niranda, Released the following orbit bundles. (finally! ;) ) spark-core_2.10 spark-sql_2.10 @Maheshika, can you release these two orbit bundles. Please make sure to

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-07 Thread Jayanga Dissanayake
Hi SupunS, We reviewed the PR and found some issues in it. 1. all groupIds are not in the correct format 2. in import package section you have used *;resolution:=optional which is not recommended. 3. Export-Package section of breeze_2.10, it has some conflicting package name entries Please

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-07 Thread Supun Sethunga
Hi Kasun/Sameera Can you please review and merge the PR [1]. This upgrades the spark-mllib and spark-streaming versions to 1.3.0 (for ML), with parallel to the spark-core version upgrade in BAM. [1] https://github.com/wso2/orbit/pull/87 Thanks, Supun On Thu, May 7, 2015 at 12:02 PM, Niranda

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-05 Thread KasunG Gajasinghe
Hi Niranda, Released the following orbit bundles. (finally! ;) ) spark-core_2.10 spark-sql_2.10 @Maheshika, can you release these two orbit bundles. Please make sure to use JDK 7 for building. On Tue, May 5, 2015 at 12:46 PM, Niranda Perera nira...@wso2.com wrote: Hi Kasun, Could you

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-05-05 Thread Niranda Perera
Hi Kasun, Could you please check this bundle again. I fix the issue, and it did not affect the orbit bundle. rgds On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe kas...@wso2.com wrote: Hi Niranda, I believe the point Supun making is if there are two versions of spark 1.3.0 has made

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-29 Thread Niranda Perera
Hi Kasun, I've done the changes. But could you please hold this for the moment. I came across with a bug. I will let you know once I cleared it out. rgds On Wed, Apr 29, 2015 at 9:49 AM, Niranda Perera nira...@wso2.com wrote: Hi Kasun, I did the changes. could you please check it now?

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-29 Thread KasunG Gajasinghe
Hi Niranda, I believe the point Supun making is if there are two versions of spark 1.3.0 has made there way into a pack, then only one version will be picked up. This is an unlikely scenario. But as a best practice, it'll be better to export the exact version from now on. On Wed, Apr 29, 2015 at

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-28 Thread Niranda Perera
Hi Kasun, I did the changes. could you please check it now? thanks rgds On Tue, Apr 28, 2015 at 9:49 PM, Kasun Gajasinghe kas...@wso2.com wrote: Hi Niranda, Can you also fix the import-packages to not have star imports with resolution optional? Thanks. On Apr 28, 2015, at 1:50 PM,

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-28 Thread Supun Sethunga
Hi Niranda, are you referring to this? Export-Package org.apache.spark.*;version=${spark.version};-split-package:=merge-first /Export-Package Yes exactly. My concern was, what if multiple versions of the same package were in the same osgi environment.. I know its very highly unlikely, but

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-28 Thread Niranda Perera
Hi Supun, let me understand the scenario here. say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v 1.2.1 and we have a component org.wso2.analytics.spark.core which imports org.apache.spark version [1.2.1, 1.4.0). then AFAIK in the OSGI environment,

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-28 Thread Kasun Gajasinghe
Hi Niranda, Can you also fix the import-packages to not have star imports with resolution optional? Thanks. On Apr 28, 2015, at 1:50 PM, Niranda Perera nira...@wso2.com wrote: @Kasun thank you for the clarification I have made the adjustments. can you please check it? rgds On

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-28 Thread Niranda Perera
@Kasun thank you for the clarification I have made the adjustments. can you please check it? rgds On Mon, Apr 27, 2015 at 11:16 AM, KasunG Gajasinghe kas...@wso2.com wrote: Hi Niranda, The Bundle-Classpath tag is as mentioned above is required to over-ride the classes in the original orbit

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-26 Thread Niranda Perera
Hi Sameera, a kind reminder about this PR. thank you On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera nira...@wso2.com wrote: oh. are you referring to the Bundle-Classpathpatch.jar,./Bundle-Classpath line? I did not include it in the orbit bundle. but I checked the bundles in a fresh

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-26 Thread KasunG Gajasinghe
Hi Niranda, The Bundle-Classpath tag is as mentioned above is required to over-ride the classes in the original orbit bundle. Since both the orbit bundle, and patched bundle have the same classes, we need to instruct to give precedence to the patch.jar. Hence, the above tag is required. The

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-26 Thread Niranda Perera
Hi Supun, are you referring to this? Export-Package org.apache.spark.*;version=${spark.version};-split-package:=merge-first /Export-Package well, AFAIK what export-package does is, it exposes the org.apache.spark.* classes in the OSGI environment. since we are not doing any patching for the

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-21 Thread Supun Sethunga
Hi Sameera/Niranda, With parallel to this, Im in the process of migrating the spark Ml-Lib and spark streaming versions for product ML. Just wanted to clear myself, shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1, rather than 1.3.0? Thanks, Supun On Fri, Apr 17, 2015

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-17 Thread Niranda Perera
oh. are you referring to the Bundle-Classpathpatch.jar,./Bundle-Classpath line? I did not include it in the orbit bundle. but I checked the bundles in a fresh carbon server and it seems like the patch gets attached successfully. ​ Screenshot from 2015-04-17 16:20:15.png

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-16 Thread Sameera Jayasoma
Hi Niranda, Does this include fragment-bundle/patch modification also? Thanks, Sameera. On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera nira...@wso2.com wrote: Hi, Kind reminder on this. Best regards Niranda Perera Software Engineer, WSO2 Inc. Mobile: +94-71-554-8430 Twitter: @n1r44

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-16 Thread Niranda Perera
Hi Sameera, No its not. The patch is in org.wso2.analytics.spark.patch component. Its still not committed to carbon - analytics Rgds On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma same...@wso2.com wrote: Hi Niranda, Does this include fragment-bundle/patch modification also? Thanks,

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-16 Thread Anjana Fernando
Niranda, yeah, we would have to put that part to be able to later patch it. A sample can be found here [1]. [1] https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml Cheers, Anjana. On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma same...@wso2.com wrote: I meant to say, do

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-16 Thread Sameera Jayasoma
I meant to say, do we need to add the patch.jar line to the spark bundle as we've done in Tomcat bundle. Thanks, Sameera. On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera nira...@wso2.com wrote: Hi Sameera, No its not. The patch is in org.wso2.analytics.spark.patch component. Its still not

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-15 Thread Niranda Perera
Hi, Kind reminder on this. Best regards Niranda Perera Software Engineer, WSO2 Inc. Mobile: +94-71-554-8430 Twitter: @n1r44 On Apr 14, 2015 19:17, Niranda Perera nira...@wso2.com wrote: Hi Sameera, Could you please review this PR [1] for Spark 1.3.0. this upgrades 1.2.1 to 1.3.0. this

[Dev] [Orbit] Please review the PR for Spark 1.3.0

2015-04-14 Thread Niranda Perera
Hi Sameera, Could you please review this PR [1] for Spark 1.3.0. this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes with some major API changes and we wanted to include those API changes before the DAS (BAM) 3.0.0 alpha cheers [1] https://github.com/wso2/orbit/pull/83 --