Re: [Dev] Shall we implement transformation methods in claim API.

2017-03-19 Thread Johann Nallathamby
On Wed, Mar 15, 2017 at 11:10 AM, Pushpalanka Jayawardhana wrote: > > > On Wed, Mar 15, 2017 at 11:07 AM, Harsha Thirimanna > wrote: > >> Yes, as you said, we have to provide a service by merging the dialect and >> profile. We can provide different service for

Re: [Dev] Shall we implement transformation methods in claim API.

2017-03-14 Thread Pushpalanka Jayawardhana
On Wed, Mar 15, 2017 at 11:07 AM, Harsha Thirimanna wrote: > Yes, as you said, we have to provide a service by merging the dialect and > profile. We can provide different service for that and there will more > aggregate method that can be reusable in future. > +1. To avoid

Re: [Dev] Shall we implement transformation methods in claim API.

2017-03-14 Thread Harsha Thirimanna
Yes, as you said, we have to provide a service by merging the dialect and profile. We can provide different service for that and there will more aggregate method that can be reusable in future. On Wed, Mar 15, 2017 at 10:42 AM, Pushpalanka Jayawardhana wrote: > Hi Harsha, > >

Re: [Dev] Shall we implement transformation methods in claim API.

2017-03-14 Thread Pushpalanka Jayawardhana
Hi Harsha, Please find the comments inline. On Tue, Mar 14, 2017 at 4:32 PM, Harsha Thirimanna wrote: > Hi Lanka, > > Shall we implement these two methods also in claim service side by merging > dialect and profile ? > > public Set transformToNativeDialect(Set

[Dev] Shall we implement transformation methods in claim API.

2017-03-14 Thread Harsha Thirimanna
Hi Lanka, Shall we implement these two methods also in claim service side by merging dialect and profile ? public Set transformToNativeDialect(Set otherDialectClaims, String claimDialect, Optional profile) { public Set transformToOtherDialect(Set nativeDialectClaims, String dialect,