Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-02-03 Thread Samitha Chathuranga
Hi Tharindu, On Mon, Feb 3, 2020 at 4:07 PM Tharindu Dharmarathna wrote: > Hi Samitha, > > Please find my comments inline below. > > On Mon, Feb 3, 2020 at 3:29 PM Samitha Chathuranga > wrote: > >> Hi, >> >> Additionally to this, I could see that there are still the below >> operations executed

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-02-03 Thread Tharindu Dharmarathna
Hi Samitha, Please find my comments inline below. On Mon, Feb 3, 2020 at 3:29 PM Samitha Chathuranga wrote: > Hi, > > Additionally to this, I could see that there are still the below > operations executed in the profile optimization script. > > * - Config changes in below config files* > >-

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-02-03 Thread Samitha Chathuranga
Hi, Additionally to this, I could see that there are still the below operations executed in the profile optimization script. * - Config changes in below config files* - api-manager.xml - enable_policy_deploy, enable_data_publishing, enable_blacklist_condition, enable_decision_connection

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-30 Thread Samitha Chathuranga
And regarding name of the option; > *What is the ideal name for the new option ()?* >> Suggestions: --override, --overrideConfig >> > > How about --skipConfigOptimization ? > +1 for this And if we use this, the default behavior should be overriding the configs. On Fri, Jan 31, 2020 at 9:49 AM Sa

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-30 Thread Samitha Chathuranga
Hi Pubudu, IMHO, I prefer to skip the config override when running the profile > optimization. What if we make this as the default approach? If someone > wants to override the configs, then with profile optimization, they can use > a new flag called --override or something similar as Samitha menti

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Pubudu Gunatilaka
Hi, If we check one of the existing profile toml [1], the values are very common and it cannot be used in real production cases. Sample values contain commonly used hostnames and admin credentials. If we are to use this feature properly with configuration override, users have to change these defa

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Harsha Kumara
I'm thinking on real world scenario where customer will keep one base product archive and add the configs. isn't it easy for them to copy those files just to the profile optimizer tool location? On Wed, Jan 29, 2020 at 3:15 PM Bhathiya Jayasekara wrote: > Hi Samitha, > > On Wed, Jan 29, 2020 at

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Bhathiya Jayasekara
Hi Samitha, On Wed, Jan 29, 2020 at 2:29 PM Samitha Chathuranga wrote: > Hi all, > > Our profile optimization [1] script for 3.0.0 replaces [2] already > available deployment.toml with a per-profile specific updated/optimized > toml file. (i.e. api-devportal.toml, gateway-worker.toml, etc.). Thi

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Samitha Chathuranga
Hi Harsha, On Wed, Jan 29, 2020 at 2:39 PM Harsha Kumara wrote: > Aren't there any place where we can place the profile specific > deployment.toml which tool eventually replace it rather than giving a > separate option? > */wso2am-3.0.0/repository/resources/conf/deployment-templates/* is the l

Re: [Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Harsha Kumara
Aren't there any place where we can place the profile specific deployment.toml which tool eventually replace it rather than giving a separate option? On Wed, Jan 29, 2020 at 2:29 PM Samitha Chathuranga wrote: > Hi all, > > Our profile optimization [1] script for 3.0.0 replaces [2] already > avai

[Dev] APIM Profile optimization script - deployment.toml replacement

2020-01-29 Thread Samitha Chathuranga
Hi all, Our profile optimization [1] script for 3.0.0 replaces [2] already available deployment.toml with a per-profile specific updated/optimized toml file. (i.e. api-devportal.toml, gateway-worker.toml, etc.). This process affects already configured setups, to lose the configurations. A user ru