Re: [Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Nilasini Thirunavukkarasu
Hi, Thanks. Sent the PR. Thanks, Nila. On Wed, Feb 7, 2018 at 12:00 AM, Hasintha Indrajee wrote: > > > On Tue, Feb 6, 2018 at 11:43 PM, Nilasini Thirunavukkarasu < > nilas...@wso2.com> wrote: > >> Hi, >> >> Thank you for the reply. >> >> I have checked it in

Re: [Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Hasintha Indrajee
On Tue, Feb 6, 2018 at 11:43 PM, Nilasini Thirunavukkarasu < nilas...@wso2.com> wrote: > Hi, > > Thank you for the reply. > > I have checked it in identity-inbound-auth-oauth 5.6.x branch which is > used for 5.5.0, the error code was changed from > *unsupported_client_authentication_method >

Re: [Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Nilasini Thirunavukkarasu
Hi, Thank you for the reply. I have checked it in identity-inbound-auth-oauth 5.6.x branch which is used for 5.5.0, the error code was changed from *unsupported_client_authentication_method *but anyhow it has been changed to *invalid_request.*Shouldn't we need to change the error code as

Re: [Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Hasintha Indrajee
On Tue, Feb 6, 2018 at 10:32 PM, Maduranga Siriwardena wrote: > Hi Nilasini, > > Yes, unsupported_client_authentication_method is a incorrect error > message. So we need to fix this. > > I think this should be already fixed in IS 5.5.0 branch. *@Hasintha*, can > you confirm?

Re: [Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Maduranga Siriwardena
Hi Nilasini, Yes, unsupported_client_authentication_method is a incorrect error message. So we need to fix this. I think this should be already fixed in IS 5.5.0 branch. *@Hasintha*, can you confirm? Thanks, On Tue, Feb 6, 2018 at 5:07 PM, Nilasini Thirunavukkarasu wrote:

[Dev] Error code unsupported_client_authentication_method in IS-5.4.1

2018-02-06 Thread Nilasini Thirunavukkarasu
Hi, In IS-5.4.1 if there is no client authentication in the token request, we are giving the error code *unsupported_client_authentication_method*. According to the spec[1], if there is no client authentication or unsupported client authentication, it will fall under "invalid_client".