[Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Nuwan Dias
Hi, This is regarding the issue [1]. When an OAuth2 token is initially created, it is created in the 'Active' state. When revoking a token, its state is changed to 'REVOKED'. But this time, the TIME_CREATED value of that particular database entry is also updated. When looking at the issue, I

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Prabath Siriwardena
It's not rights to update the TIME_CREATED every time we update the record. Can we update it to DATETIME? Thanks regards, -Prabath On Fri, Sep 20, 2013 at 2:12 PM, Nuwan Dias nuw...@wso2.com wrote: Hi, This is regarding the issue [1]. When an OAuth2 token is initially created, it is

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Nuwan Dias
We can, but this would mean that we need to change the code and set the time in all places that do an INSERT to this table. Thanks, NuwanD. On Fri, Sep 20, 2013 at 2:22 PM, Prabath Siriwardena prab...@wso2.comwrote: It's not rights to update the TIME_CREATED every time we update the record.

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Prabath Siriwardena
Do you have ON UPDATE CURRENT_TIMESTAMP against the TIME_CREATED column ? Thanks regards, -Prabath On Fri, Sep 20, 2013 at 2:26 PM, Nuwan Dias nuw...@wso2.com wrote: We can, but this would mean that we need to change the code and set the time in all places that do an INSERT to this table.

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Nuwan Dias
No. Just TIMESTAMP. We thought of manually setting the created time to what it originally was. Since changing the column type requires some effort which will include a need of migrating older version users as well. Thanks, NuwanD. On Fri, Sep 20, 2013 at 3:19 PM, Prabath Siriwardena

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Prabath Siriwardena
Can you please change the script to following and see.. TIME_CREATED TIMESTAMP DEFAULT CURRENT_TIMESTAMP, Thanks regards, -Prabath On Fri, Sep 20, 2013 at 3:27 PM, Nuwan Dias nuw...@wso2.com wrote: No. Just TIMESTAMP. We thought of manually setting the created time to what it originally was.

Re: [Dev] OAuth2 - Having the TIME_CREATED column as a TIMESTAMP type

2013-09-20 Thread Nuwan Dias
Thanks Sumedha, that worked. IS guys, please note to update your db scripts accordingly. Thanks, NuwanD. On Fri, Sep 20, 2013 at 3:39 PM, Sumedha Rubasinghe sume...@wso2.comwrote: MySQL by default updates this. (see http://dev.mysql.com/doc/refman/5.0/en/timestamp-initialization.html) You