Hi all,
After discussing with team I will be implementing this scenario in below
described way,
1. We will have a Interface called *Undeployer* in *appfactory.core* and
this interface will be registered as a OSGi Service.
2. There will be a class called *AbstractStratosUndeployer* in
Hi Mahesh,
On Tue, Nov 4, 2014 at 9:42 PM, Mahesh Chinthaka mahe...@wso2.com wrote:
Hi all ,
I was trying to move the exact functionality in
*org.wso2.carbon.appfactory.core.deploy.ApplicationDeployer.undeployAllArtifactsOfAppFromDepSyncGitRepo()*
to
Hi Janaka,
As Mahesh mentioned some of here are Util methods as private.
@Mahesh
getGitRepoUrlForTenant - rename this method to getRepoUrlForTenant and move
it to RepositoryClient interface. Implement it in GitRepositoryClient
according to the Git.
getServerDeploymentPaths - in this method,
Hi Harsha,
On Tue, Nov 4, 2014 at 10:03 PM, Harsha Thirimanna hars...@wso2.com wrote:
Hi Janaka,
As Mahesh mentioned some of here are Util methods as private.
Agreed. But to add the artifact to the git repo, we need the same
parameters right? Then there is a way that we pass those parameters
sorry, I had sent half of the mail.
getFilesToDelete - you can move this method to AbstractStratosDeployer
getRepositoryProviderAdminUser
getRepositoryProviderAdminPassword
these two methods can move to AppFactoryUtil in common component and make
it public.
*Harsha Thirimanna*
Senior
Hi Janaka,
There are no new utility method. Just keep it in right place as we can
reuse it.
*Harsha Thirimanna*
Senior Software Engineer; WSO2, Inc.; http://wso2.com
* http://www.apache.org/*
*email: **hars...@wso2.com* az...@wso2.com* cell: +94 71 5186770 , +94 *
*774617784twitter:
+1 to move them to AppfactoryUtil. So we can use it every where.
Thanks Regards
Danushka Fernando
Software Engineer
WSO2 inc. http://wso2.com/
Mobile : +94716332729
On Tue, Nov 4, 2014 at 10:13 PM, Harsha Thirimanna hars...@wso2.com wrote:
Hi Janaka,
There are no new utility method. Just
Hi Harsha,
Why cant we just make those methods public and use them ? Since
appfactory.core is already a dependancy in appfactory.deployers
So we can avoid writing the same code twice.
On Tue, Nov 4, 2014 at 10:13 PM, Harsha Thirimanna hars...@wso2.com wrote:
Hi Janaka,
There are no new
Hi Mahesh,
Don't write same code twice. Just move it. Because it is not suite to use
those kind of method that keeping this Service Class. When we are doing
some changes, we may have to re-factor according to the best practices.
WDYT ?
*Harsha Thirimanna*
Senior Software Engineer; WSO2, Inc.;
+1 for refactoring.
@Mahesh : These are good reads. Read these if you are not familiar to
refactoring.
[1] http://sourcemaking.com/refactoring/bad-smells-in-code
[2] http://sourcemaking.com/refactoring/duplicated-code
Thanks Regards
Danushka Fernando
Software Engineer
WSO2 inc.
Hi Harsha,
While following other codes i was able to figure out some usages and below
is what im going to do. Let me know if anything wrong.
*getRepositoryProviderAdminPassword()*
*getRepositoryProviderAdminUser()*
These two can be solved. We can
use DeployerUtil.getRepositoryProviderProperty
+1 to move them to correct Util classes and refactor accordingly. It would
make ApplicationDeployer more cleaner and we could use those utility in
other places as we needed.
On Tue, Nov 4, 2014 at 10:21 PM, Harsha Thirimanna hars...@wso2.com wrote:
Hi Mahesh,
Don't write same code twice. Just
Hi Mahesh,
On Tue, Nov 4, 2014 at 10:51 PM, Mahesh Chinthaka mahe...@wso2.com wrote:
Hi Harsha,
While following other codes i was able to figure out some usages and below
is what im going to do. Let me know if anything wrong.
*getRepositoryProviderAdminPassword()*
Hi Janaka,
We initially decided to implement unDeployArtifact() in AbstractDeployer,
now it seems better to implement it in AbstractStratosDeployer.
+1 to implement it in AbstractStratosDeployer.
@Harsha,
WDYT ?
On Tue, Nov 4, 2014 at 11:00 PM, Janaka Ranabahu jan...@wso2.com wrote:
Hi Mahesh,
Yes +1. Finally I wanted to tell, we should move to the correct place :)
*Harsha Thirimanna*
Senior Software Engineer; WSO2, Inc.; http://wso2.com
* http://www.apache.org/*
*email: **hars...@wso2.com* az...@wso2.com* cell: +94 71 5186770 , +94 *
*774617784twitter: **http://twitter.com/
On Tue, Nov 4, 2014 at 11:06 PM, Mahesh Chinthaka mahe...@wso2.com wrote:
Hi Janaka,
We initially decided to implement unDeployArtifact() in AbstractDeployer,
now it seems better to implement it in AbstractStratosDeployer.
+1 to implement it in AbstractStratosDeployer.
+1 for implementing it
Hi,
Thanks everyone, I will proceed.
On Tue, Nov 4, 2014 at 11:11 PM, Janaka Ranabahu jan...@wso2.com wrote:
On Tue, Nov 4, 2014 at 11:06 PM, Mahesh Chinthaka mahe...@wso2.com
wrote:
Hi Janaka,
We initially decided to implement unDeployArtifact() in AbstractDeployer,
now it seems better
@Mahesh
IIRC you cannot use RepositoryManager.getAppRepositoryURL() instead of
getGitRepoUrlForTenant() since it is used get GIT repo url and what we need
here is S2Git repo url. As Janaka has suggested
AbstractStratosDeployer.generateRepoUrl()
could be used. Please check.
On Tue, Nov 4, 2014 at
Hi Samith,
Thanks , will check and do.
On Tue, Nov 4, 2014 at 11:16 PM, Samith Dassanayake sam...@wso2.com wrote:
@Mahesh
IIRC you cannot use RepositoryManager.getAppRepositoryURL() instead of
getGitRepoUrlForTenant() since it is used get GIT repo url and what we
need here is S2Git repo url.
19 matches
Mail list logo
