Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Thanks for the update Thusitha. Thanks & Regards, Ishara Cooray Senior Software Engineer Mobile : +9477 262 9512 WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware On Tue, Apr 4, 2017 at 8:52 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Ishara, > > We are planning

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi Ishara, We are planning to in co-operating that with the 2.3.0-m2 which scheduled to be released by this week. Thanks Thusitha On Mon, Apr 3, 2017 at 12:18 PM, Ishara Cooray wrote: > Hi Vidura/Thusitha, > > Can we have an update on this please? > > > Thanks & Regards, >

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi Vidura/Thusitha, Can we have an update on this please? Thanks & Regards, Ishara Cooray Senior Software Engineer Mobile : +9477 262 9512 <+94%2077%20262%209512> WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware On Mon, Jan 16, 2017 at 1:13 PM, Thusitha Thilina Dayaratne <

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi Sagara, ViduraN has almost implemented this. We will schedule a meeting tomorrow or day after tomorrow to discuss the current implementation. Thanks Thusitha On Mon, Jan 16, 2017 at 12:44 PM, Sagara Gunathunga wrote: > > Can we have an update or review meeting on this ? >

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Can we have an update or review meeting on this ? Thanks ! On Thu, Jan 5, 2017 at 9:50 AM, Ishara Cooray wrote: > Sounds good. > Thanks Kishanthan. > > Thanks & Regards, > Ishara Cooray > Senior Software Engineer > Mobile : +9477 262 9512 <+94%2077%20262%209512> > WSO2, Inc.

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Sounds good. Thanks Kishanthan. Thanks & Regards, Ishara Cooray Senior Software Engineer Mobile : +9477 262 9512 WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware On Wed, Jan 4, 2017 at 5:30 PM, Kishanthan Thangarajah wrote: > We are working on this. We couldn't

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

We are working on this. We couldn't progress much last week due to other priorities. The plan is to deliver in two weeks time. On Tue, Jan 3, 2017 at 1:40 PM, Ishara Cooray wrote: > Hi, > > What could be the status of this? Do we have a time line defined? > > Thanks & Regards,

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi, What could be the status of this? Do we have a time line defined? Thanks & Regards, Ishara Cooray Senior Software Engineer Mobile : +9477 262 9512 WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware On Fri, Dec 9, 2016 at 2:18 PM, Sagara Gunathunga wrote: > > >

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

On Fri, Dec 9, 2016 at 2:15 PM, Sanjeewa Malalgoda wrote: > Hi All, > Please find inline comments. > > On Fri, Dec 9, 2016 at 12:49 PM, Sagara Gunathunga > wrote: > >> >> >> On Thu, Dec 8, 2016 at 6:59 PM, Ishara Cooray wrote: >> >>> To

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi All, Please find inline comments. On Fri, Dec 9, 2016 at 12:49 PM, Sagara Gunathunga wrote: > > > On Thu, Dec 8, 2016 at 6:59 PM, Ishara Cooray wrote: > >> To overcome the above limitation where we cannot plug custom >> authentication, i came up with the

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

On Thu, Dec 8, 2016 at 6:59 PM, Ishara Cooray wrote: > To overcome the above limitation where we cannot plug custom > authentication, i came up with the below approach. > > Having one interceptor and delegate authentication to an interface. > Implementation of the interface is

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi Ishara, Another possibility for supporting multiple auth types with what you have proposed is to have a collection Authenticator interfaces(using a Map possibly) at the RestAPISecurityInterceptor level. Depending on some condition you could selectively choose what implementation to use at

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Please find my comments in line. Yes for the moment lets use this approach. Lets have 2 interceptors for authenticate and authorization. From that lets provide way to add pluggable authenticators and authorizers. I guess you mean having two interfaces for authenticate and authorization.What if we

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Yes for the moment lets use this approach. Lets have 2 interceptors for authenticate and authorization. From that lets provide way to add pluggable authenticators and authorizers. Also we may be able to route request through multiple authenticators according to predefined order(when we need to

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

To overcome the above limitation where we cannot plug custom authentication, i came up with the below approach. Having one interceptor and delegate authentication to an interface. Implementation of the interface is configurable so that we can plug custom authentication as well. [image: Inline

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

> > Hi Thilina, > > And also if there are multiple interceptors and one interceptor returns > false from its' preCaall then the invocation chain will not continue > further. > > So Is this implies if preCall returns 'true' then the invocation chain > will continue further? > Yes I was thinking

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

On Wed, Dec 7, 2016 at 5:17 PM, Ishara Cooray wrote: > Hi Thilina, > > And also if there are multiple interceptors and one interceptor returns > false from its' preCaall then the invocation chain will not continue > further. > > So Is this implies if preCall returns 'true' then

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

Hi Thilina, And also if there are multiple interceptors and one interceptor returns false from its' preCaall then the invocation chain will not continue further. So Is this implies if preCall returns 'true' then the invocation chain will continue further? If that is the case we can return true

Re: [Dev] [Architecture] [C5] MSF4J Interceptors need to be configurable.

How about supporting JAXRS filters? On Wed, Dec 7, 2016 at 12:52 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Ishara, > > As you have mentioned, with the current architecture we can't set the > specific interceptor for a particular service but rather to all services in > the