Re: [Dev] Shall we use latest APPM in EMM?

2016-04-07 Thread Lakshman Udayakantha
Hi Sajith, Added some comments and fixes in code. can you have a look? Thanks On Wed, Apr 6, 2016 at 8:45 PM, Sajith Abeywardhana wrote: > Hi Lakshman, > > I reviewed some files in PR https://github.com/wso2/carbon-appmgt/pull/250 and > add some comments. Please have a look.

Re: [Dev] Shall we use latest APPM in EMM?

2016-04-06 Thread Sajith Abeywardhana
Hi Lakshman, I reviewed some files in PR https://github.com/wso2/carbon-appmgt/pull/250 and add some comments. Please have a look. Thanks, Sajith. On Wed, Apr 6, 2016 at 7:33 PM, Lakshman Udayakantha wrote: > Hi APPM Team, EMM Team, > > I have created following pull

Re: [Dev] Shall we use latest APPM in EMM?

2016-04-06 Thread Lakshman Udayakantha
Hi APPM Team, EMM Team, I have created following pull requests [1], [2] and [3] for latest APPM and EMM integration. Could you review and merge them? [1] https://github.com/wso2/carbon-appmgt/pull/250 [2] https://github.com/wso2/product-emm/pull/203 [3]

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-23 Thread Lakshman Udayakantha
Hi All, After I have merged the APPM latest version and configuration changes from APPM to EMM and after the above code changes, publisher and store can be browsed and publish apps without any issue. But app installing on devices failed because the code which handles that part are moved to an

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-21 Thread Dinusha Senanayaka
On Mon, Mar 21, 2016 at 4:42 PM, Lakshman Udayakantha wrote: > Hi Dinusha, > > Updated the pull with your suggestions. > Thanks. Merged. > > Thanks > > On Mon, Mar 21, 2016 at 2:57 PM, Dinusha Senanayaka > wrote: > >> Hi Lakshman, >> >> Thanks for fixing

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-21 Thread Lakshman Udayakantha
Hi Dinusha, Updated the pull with your suggestions. Thanks On Mon, Mar 21, 2016 at 2:57 PM, Dinusha Senanayaka wrote: > Hi Lakshman, > > Thanks for fixing this. Added few comments to PR. Please update. > > Regards, > Dinusha. > > On Mon, Mar 21, 2016 at 2:40 PM, Lakshman

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-21 Thread Dinusha Senanayaka
Hi Lakshman, Thanks for fixing this. Added few comments to PR. Please update. Regards, Dinusha. On Mon, Mar 21, 2016 at 2:40 PM, Lakshman Udayakantha wrote: > Hi Dinusha, > > I have moved subscriber persisting code [1] to subscription creation > moment from login moment.

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-21 Thread Lakshman Udayakantha
Hi Dinusha, I have moved subscriber persisting code [1] to subscription creation moment from login moment. Could you review and merge it. [1] https://github.com/wso2/carbon-appmgt/pull/245/files Thanks On Fri, Mar 18, 2016 at 9:30 PM, Dinusha Senanayaka wrote: > Hi All, >

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-20 Thread Chathura Dilan
Hi All, Currently mobile apps does not use any APPM related databases. It only uses the registry. Subscriptions are stored in the registry. On Fri, Mar 18, 2016 at 4:42 AM, Ruwan Abeykoon wrote: > Hi All, > I think APM_SUBSCRIBER is used to check subscription on WebApps or

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Prabath Abeysekera
Hi Dinusha, On Fri, Mar 18, 2016 at 2:19 PM, Dinusha Senanayaka wrote: > Hi Lakshman, > > On Fri, Mar 18, 2016 at 2:08 PM, Lakshman Udayakantha > wrote: > >> Hi, >> >> I am looking into this. After changing the APP Manager feature versions >> in EMM,

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Ruwan Abeykoon
Hi All, I could recall moving some the DB related stuff to Gateway Feature some time back in order to do EMM feature release. Please check if GW feature is included, or if something crept to Store side. Cheers, Ruwan On Fri, Mar 18, 2016 at 3:01 PM, Prabath Abeysekera wrote:

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Lakshman Udayakantha
Hi, I am looking into this. After changing the APP Manager feature versions in EMM, publisher works as expected. It can create and publish mobile apps without any issue. But I can't even login to store. According to backend error, It seems like EMM wants APP Manager related db tables too. I have

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Ruwan Abeykoon
Hi All, I think APM_SUBSCRIBER is used to check subscription on WebApps or Sites. I think adding subscriber to this table can be moved to place where the subscription is added. We might have to revisit and change the SQL queries which is used to check the subscriptions. Cheers, Ruwan On Fri, Mar

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Milan Perera
Hi Dinusha, I totally agree to what you said. Its better if we can do this as soon as possible. Regards, On Thu, Mar 17, 2016 at 2:31 PM, Dinusha Senanayaka wrote: > Hi Milan, > > IMO, if we have version conflicts we should try to fix it. What we have > done so far is not

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Lakshman Udayakantha
Hi Chathura, Yes. It is not because of asset turning off/on feature. I meant that UI has changed a lot in latest APP Manager recently and APPM team didn't get much time to resolve all the bugs reported. As per the offline discussion with LahiruC lot of mobile features has broken with new UI and

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Lakshman Udayakantha
Hi Dinusha, When user is going to login to store, user will add if does not exist, to a table called APM_SUBSCRIBER . This code snippet has removed in EMM store (in APPM 1.1.1 version). That's why earlier this problem is not raised. Anyway what is the purpose of adding user to the APM_SUBSCRIBER

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Milan Perera
Hi Lakshman, As I remember, we have tried it before and in the previous attempt of migrating to the latest APPM feature was failed due to some conflicts in dependencies that were unable to resolve at that time. If im not mistaken, it had conflicts with the IS version which we use in the EMM 200.

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Dinusha Senanayaka
Hi Prabath, On Fri, Mar 18, 2016 at 2:34 PM, Prabath Abeysekera wrote: > Hi Dinusha, > > On Fri, Mar 18, 2016 at 2:19 PM, Dinusha Senanayaka > wrote: > >> Hi Lakshman, >> >> On Fri, Mar 18, 2016 at 2:08 PM, Lakshman Udayakantha > >

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Dinusha Senanayaka
Hi Milan, IMO, if we have version conflicts we should try to fix it. What we have done so far is not correct. We have created a separate branch of AppM for EMM by manually removing the web app related UIs. We have done it for the time being, but this won't scale when it comes to

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-19 Thread Prabath Abeysekera
Hi Dinusha, On Fri, Mar 18, 2016 at 2:54 PM, Dinusha Senanayaka wrote: > Hi Prabath, > > On Fri, Mar 18, 2016 at 2:34 PM, Prabath Abeysekera > wrote: > >> Hi Dinusha, >> >> On Fri, Mar 18, 2016 at 2:19 PM, Dinusha Senanayaka >> wrote: >>

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-18 Thread Dinusha Senanayaka
Hi All, This is something we got from the APIM code and we need to refactor it. In their case, users login to store can create oauth app and subscribe to APIs. App creation also should be done by a subscriber and that's why user is added to SUBSCRIBER table at the login. Then SUBSCRIPTION table

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-18 Thread Lahiru Cooray
+1 for Ruwan's suggestion. Further in current model, Subscriptions(APM_SUBSCRIPTION) are mapped to a Application(APM_APPLICATION) and Application is bound to a subscriber (APM_SUBSCRIBER) Subscriber should ideally contain the users who are subscribed to an App. But currently APM_SUBSCRIBER table

Re: [Dev] Shall we use latest APPM in EMM?

2016-03-18 Thread Dinusha Senanayaka
Hi Lakshman, On Fri, Mar 18, 2016 at 2:08 PM, Lakshman Udayakantha wrote: > Hi, > > I am looking into this. After changing the APP Manager feature versions in > EMM, publisher works as expected. It can create and publish mobile apps > without any issue. But I can't even