Re: [Dev] Retry with authenticators for adaptive authentication.

2018-05-07 Thread gayan gunawardana 
On Mon, May 7, 2018 at 7:17 PM, Maduranga Siriwardena 
wrote:

> Hi devs,
>
> In the Identity Server at the moment "retryAuthenticationEnabled" method
> in the authenticators decide whether the user is allowed to retry the
> authentication with that particular authenticator. Based on the result from
> this method, authenticator itself triggers the retry flow.
>
> Because of this we have a main disadvantage for the implementation of
> adaptive authentication. If retry is enabled, fail call back function in
> JavaScript is not triggered.
>
> So we are planning to change this behavior and send the authentication
> retry flow through the authentication framework. Below is the planned
> behavior.
>
>- Authenticator will retry to authenticate by default.
>- If the fail callback function has other steps to execute,
>authenticator will not retry to authenticate.
>- Developers can disable retry for a authentication sequence by
>setting a parameter in the context.
>
> Isn't it better to invoke fail callback function after pre-configured
number of retry attempts.

> Please provide us with feedback what need to be changed from the above
> mentioned behavior.
>
> Thanks,
> --
> Maduranga Siriwardena
> Senior Software Engineer
> WSO2 Inc; http://wso2.com/
>
> Email: madura...@wso2.com
> Mobile: +94718990591
> Blog: *https://madurangasiriwardena.wordpress.com/
> *
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Gayan
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Issue with MultiAttributeSeparator in IS 5.5.0

2018-05-07 Thread Omindu Rathnaweera 
Hi Gayan,

Can you try with a new user and see whether the MultiAttributeSeparator is
getting affected.

Regards,
Omindu.

On Mon, May 7, 2018 at 11:36 AM gayan gunawardana 
wrote:

>
>
> On Mon, May 7, 2018 at 10:18 AM, Nuwandi Wickramasinghe  > wrote:
>
>> Hi Gayan,
>>
>> What is the type of your UserStoreManager?
>>
> Default LDAP.
>
>>
>> On Sun, May 6, 2018 at 11:48 PM, gayan gunawardana <
>> gmgunaward...@gmail.com> wrote:
>>
>>> Hi Nuwandi,
>>>
>>> Thanks for writing steps [1]. It works in IS 5.3.0 without a problem.
>>> However when I try same steps for IS 5.5.0 even I change
>>> MultiAttributeSeparator it always break values from ','. Could you please
>>> let me know are there any additional steps or public jira regarding the
>>> issue.
>>>
>>> [1]
>>> https://medium.com/@nuwandiwickramasinghe/wso2-identity-server-5-3-0-as-the-identity-provider-for-aws-management-console-dcdddefc2d79
>>>
>>> Thanks,
>>> Gayan
>>>
>>
>>
>>
>> --
>>
>> Best Regards,
>>
>> Nuwandi Wickramasinghe
>>
>> Senior Software Engineer
>>
>> WSO2 Inc.
>>
>> Web : http://wso2.com
>>
>> Mobile : 0719214873
>>
>
>
>
> --
> Gayan
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>


-- 
Omindu Rathnaweera
Senior Software Engineer, WSO2 Inc.
Mobile: +94 771 197 211
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Retry with authenticators for adaptive authentication.

2018-05-07 Thread Maduranga Siriwardena 
Hi devs,

In the Identity Server at the moment "retryAuthenticationEnabled" method in
the authenticators decide whether the user is allowed to retry the
authentication with that particular authenticator. Based on the result from
this method, authenticator itself triggers the retry flow.

Because of this we have a main disadvantage for the implementation of
adaptive authentication. If retry is enabled, fail call back function in
JavaScript is not triggered.

So we are planning to change this behavior and send the authentication
retry flow through the authentication framework. Below is the planned
behavior.

   - Authenticator will retry to authenticate by default.
   - If the fail callback function has other steps to execute,
   authenticator will not retry to authenticate.
   - Developers can disable retry for a authentication sequence by setting
   a parameter in the context.

Please provide us with feedback what need to be changed from the above
mentioned behavior.

Thanks,
-- 
Maduranga Siriwardena
Senior Software Engineer
WSO2 Inc; http://wso2.com/

Email: madura...@wso2.com
Mobile: +94718990591
Blog: *https://madurangasiriwardena.wordpress.com/
*

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Issue with MultiAttributeSeparator in IS 5.5.0

2018-05-07 Thread gayan gunawardana 
On Mon, May 7, 2018 at 10:18 AM, Nuwandi Wickramasinghe 
wrote:

> Hi Gayan,
>
> What is the type of your UserStoreManager?
>
Default LDAP.

>
> On Sun, May 6, 2018 at 11:48 PM, gayan gunawardana <
> gmgunaward...@gmail.com> wrote:
>
>> Hi Nuwandi,
>>
>> Thanks for writing steps [1]. It works in IS 5.3.0 without a problem.
>> However when I try same steps for IS 5.5.0 even I change
>> MultiAttributeSeparator it always break values from ','. Could you please
>> let me know are there any additional steps or public jira regarding the
>> issue.
>>
>> [1] https://medium.com/@nuwandiwickramasinghe/wso2-identity-
>> server-5-3-0-as-the-identity-provider-for-aws-management-
>> console-dcdddefc2d79
>>
>> Thanks,
>> Gayan
>>
>
>
>
> --
>
> Best Regards,
>
> Nuwandi Wickramasinghe
>
> Senior Software Engineer
>
> WSO2 Inc.
>
> Web : http://wso2.com
>
> Mobile : 0719214873
>



-- 
Gayan
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev