Re: [Dev] [IS 5.5.0] Shall we get rid of DB backward compatibility code related to PKCE Support

[Darshana Gunawardana]

Hi Rushmin,

Thanks for bringing this up.. and +1 for the proposal..

PKCE feature added in IS 5.2.0 and IS 5.1.0 to 5.2.0 migration intended to
be done without a schema migration.. That's why the code is written to
handle both cases..

But, we could have get rid of this, from 5.3.0 onwards, since migration to
520-530 mandate db migration hence we could mandate adding these columns as
well..

So, considering the current situation, we can handle adding this column
from the 540-550 migration and get rid from the obsolete code which makes
the OAuth DAOs bulky..

Regards,

On Sun, Feb 18, 2018 at 6:19 PM, Rushmin Fernando  wrote:

> Hi Ruwan,
>
> Sorry if I didn't explain it clearly.
>
> What I meant was ...
>
> The PKCE feature was shipped as an update to IS 5.3.0 initially and it
> had a schema change.
>
> So the code was added in a backward compatible way.
>
> But since 5.5.0 is a minor release we can get rid of the backward
> compatible code since the migration is any way there. (if time permits :-) )
>
> On Sun, Feb 18, 2018 at 6:06 PM, Ruwan Abeykoon  wrote:
>
>> Hi Rushmin,
>> Need clarification, do you mean the table not exist in DB case? DB
>> scripts can be created with migration script.
>>
>> Cheers,
>> Ruwan
>>
>>
>> On Sun, Feb 18, 2018 at 5:12 PM, Rushmin Fernando 
>> wrote:
>>
>>>
>>> AFAIK this code was introduced to protect backward compatibility while
>>> introducing PKCE support sometime back.
>>>
>>> We still see the following log.
>>>
>>> INFO {org.wso2.carbon.identity.oauth2.internal.OAuth2ServiceComponent}
>>> -  PKCE Support enabled.
>>>
>>> Do we still need that code (not only the log but the backward
>>> compatibility code too)?
>>>
>>>
>>> --
>>> *Best Regards*
>>>
>>> *Rushmin Fernando*
>>> *Technical Lead*
>>>
>>> WSO2 Inc.  - Lean . Enterprise . Middleware
>>>
>>> mobile : +94775615183
>>>
>>>
>>>
>>
>>
>> --
>>
>> *Ruwan Abeykoon*
>> *Associate Director/Architect**,*
>> *WSO2, Inc. http://wso2.com  *
>> *lean.enterprise.middleware.*
>>
>>
>
>
> --
> *Best Regards*
>
> *Rushmin Fernando*
> *Technical Lead*
>
> WSO2 Inc.  - Lean . Enterprise . Middleware
>
> mobile : +94775615183
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Regards,


*Darshana Gunawardana*Technical Lead
WSO2 Inc.; http://wso2.com

*E-mail: darsh...@wso2.com *
*Mobile: +94718566859 <+94%2071%20856%206859>*Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [IS 5.5.0] Shall we get rid of DB backward compatibility code related to PKCE Support

[Rushmin Fernando]

Hi Ruwan,

Sorry if I didn't explain it clearly.

What I meant was ...

The PKCE feature was shipped as an update to IS 5.3.0 initially and it had
a schema change.

So the code was added in a backward compatible way.

But since 5.5.0 is a minor release we can get rid of the backward
compatible code since the migration is any way there. (if time permits :-) )

On Sun, Feb 18, 2018 at 6:06 PM, Ruwan Abeykoon  wrote:

> Hi Rushmin,
> Need clarification, do you mean the table not exist in DB case? DB scripts
> can be created with migration script.
>
> Cheers,
> Ruwan
>
>
> On Sun, Feb 18, 2018 at 5:12 PM, Rushmin Fernando 
> wrote:
>
>>
>> AFAIK this code was introduced to protect backward compatibility while
>> introducing PKCE support sometime back.
>>
>> We still see the following log.
>>
>> INFO {org.wso2.carbon.identity.oauth2.internal.OAuth2ServiceComponent}
>> -  PKCE Support enabled.
>>
>> Do we still need that code (not only the log but the backward
>> compatibility code too)?
>>
>>
>> --
>> *Best Regards*
>>
>> *Rushmin Fernando*
>> *Technical Lead*
>>
>> WSO2 Inc.  - Lean . Enterprise . Middleware
>>
>> mobile : +94775615183
>>
>>
>>
>
>
> --
>
> *Ruwan Abeykoon*
> *Associate Director/Architect**,*
> *WSO2, Inc. http://wso2.com  *
> *lean.enterprise.middleware.*
>
>


-- 
*Best Regards*

*Rushmin Fernando*
*Technical Lead*

WSO2 Inc.  - Lean . Enterprise . Middleware

mobile : +94775615183
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [IS 5.5.0] Shall we get rid of DB backward compatibility code related to PKCE Support

[Ruwan Abeykoon]

Hi Rushmin,
Need clarification, do you mean the table not exist in DB case? DB scripts
can be created with migration script.

Cheers,
Ruwan


On Sun, Feb 18, 2018 at 5:12 PM, Rushmin Fernando  wrote:

>
> AFAIK this code was introduced to protect backward compatibility while
> introducing PKCE support sometime back.
>
> We still see the following log.
>
> INFO {org.wso2.carbon.identity.oauth2.internal.OAuth2ServiceComponent} -
> PKCE Support enabled.
>
> Do we still need that code (not only the log but the backward
> compatibility code too)?
>
>
> --
> *Best Regards*
>
> *Rushmin Fernando*
> *Technical Lead*
>
> WSO2 Inc.  - Lean . Enterprise . Middleware
>
> mobile : +94775615183
>
>
>


-- 

*Ruwan Abeykoon*
*Associate Director/Architect**,*
*WSO2, Inc. http://wso2.com  *
*lean.enterprise.middleware.*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] [IS 5.5.0] Shall we get rid of DB backward compatibility code related to PKCE Support

[Rushmin Fernando]

AFAIK this code was introduced to protect backward compatibility while
introducing PKCE support sometime back.

We still see the following log.

INFO {org.wso2.carbon.identity.oauth2.internal.OAuth2ServiceComponent} -
PKCE Support enabled.

Do we still need that code (not only the log but the backward compatibility
code too)?


-- 
*Best Regards*

*Rushmin Fernando*
*Technical Lead*

WSO2 Inc.  - Lean . Enterprise . Middleware

mobile : +94775615183
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev