Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

2017-03-11 Thread Omindu Rathnaweera
Changing this will break the builds on parent v5 right? Don't we need to have versioning for code-quality-tools ? On Sat, Mar 11, 2017 at 10:00 PM, KasunG Gajasinghe wrote: > > Nice. Let's send a PR to https://github.com/wso2/code-quality-tools > > On Sat, Mar 11, 2017 at 2:45

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

2017-03-11 Thread KasunG Gajasinghe
Nice. Let's send a PR to https://github.com/wso2/code-quality-tools On Sat, Mar 11, 2017 at 2:45 PM, Omindu Rathnaweera wrote: > Hi guys, > > Finally found some time to have a look at this. We can use the below > module [1] to enforce the check on the first sentence. I tested

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

2017-03-11 Thread Omindu Rathnaweera
Hi guys, Finally found some time to have a look at this. We can use the below module [1] to enforce the check on the first sentence. I tested this on OSX and it's working. [1] - http://checkstyle.sourceforge.net/config_javadoc.html#SummaryJavadoc Regards, Omindu. On Mon, Mar 6, 2017 at

[Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

2017-03-06 Thread Omindu Rathnaweera
Hi Devs, Noticed that the builds (with wso2 parent v5) done on windows fails with the error "First sentence should end with a period.". Seems like this check can be configured with *checkFirstSentence* rule [1]. Is it possible to enforce this rule for all environments ? [1] -

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

2017-03-06 Thread KasunG Gajasinghe
On Mon, Mar 6, 2017 at 3:22 PM, Omindu Rathnaweera wrote: > Hi Devs, > > Noticed that the builds (with wso2 parent v5) done on windows fails with > the error "First sentence should end with a period.". Seems like this > check can be configured with *checkFirstSentence* rule [1].