Re: [Dev] Commit to Kernal patch009

2014-10-20 Thread Isura Karunaratne
pull request : https://github.com/wso2/carbon4-kernel/pull/53 On Fri, Oct 17, 2014 at 2:20 PM, Isura Karunaratne is...@wso2.com wrote: Hi All, I have done the suggested change. Please commit following https://wso2.org/jira/browse/IDENTITY-2784 On Fri, Oct 17, 2014 at 1:00 PM, Asela

Re: [Dev] Commit to Kernal patch009

2014-10-17 Thread Asela Pathberiya
On Thu, Oct 16, 2014 at 8:01 PM, Johann Nallathamby joh...@wso2.com wrote: Make it a private constant. And the user-mgt.xml change should be optional. + 1 Yes.. it have not been referred from any other. Thanks, Asela. Thanks, Johann. On Thu, Oct 16, 2014 at 7:52 PM, Isura Karunaratne

Re: [Dev] Commit to Kernal patch009

2014-10-17 Thread Isura Karunaratne
Hi All, I have done the suggested change. Please commit following https://wso2.org/jira/browse/IDENTITY-2784 On Fri, Oct 17, 2014 at 1:00 PM, Asela Pathberiya as...@wso2.com wrote: On Thu, Oct 16, 2014 at 8:01 PM, Johann Nallathamby joh...@wso2.com wrote: Make it a private constant. And

Re: [Dev] Commit to Kernal patch009

2014-10-16 Thread Isura Karunaratne
Adding asela On Thu, Oct 16, 2014 at 7:47 PM, Manoj Kumara ma...@wso2.com wrote: Hi Isura, This patch introduce a new public constant and new entry to the user-mgt.xml. We cannot add new API's using patches. Thanks, Manoj *Manoj Kumara* Software Engineer WSO2 Inc. http://wso2.com/