Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-07-05 Thread Uvindra Dias Jayasinha
Thanks Viraj On 5 July 2016 at 15:52, Viraj Senevirathne wrote: > PR is merged https://github.com/wso2/carbon-mediation/pull/671. > > On Tue, Jul 5, 2016 at 3:44 PM, Uvindra Dias Jayasinha > wrote: > >> Ping! >> >> ESB Team can we get the above PR merged

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-07-05 Thread Viraj Senevirathne
PR is merged https://github.com/wso2/carbon-mediation/pull/671. On Tue, Jul 5, 2016 at 3:44 PM, Uvindra Dias Jayasinha wrote: > Ping! > > ESB Team can we get the above PR merged please? > > On 27 June 2016 at 19:26, Uvindra Dias Jayasinha wrote: > >> Thanks

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-07-05 Thread Uvindra Dias Jayasinha
Ping! ESB Team can we get the above PR merged please? On 27 June 2016 at 19:26, Uvindra Dias Jayasinha wrote: > Thanks Kishanthan > > If we were to fix this by calling startTenantFlow() the fix would be a lot > more complicated and may lead to other issues. So I have tested

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-27 Thread Uvindra Dias Jayasinha
Thanks Kishanthan If we were to fix this by calling startTenantFlow() the fix would be a lot more complicated and may lead to other issues. So I have tested the original fix done by Jagath in this case and didn't run into any issues functional wise. Though I could not recreate the issue in the

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-27 Thread Kishanthan Thangarajah
On Mon, Jun 27, 2016 at 12:13 PM, Uvindra Dias Jayasinha wrote: > Before I just apply the stated fix I would like some feedback from the > Carbon team regarding what maybe causing this issue. > > So here is what we are seeing so far, > > 1. IllegalStateException is being thrown

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-27 Thread Uvindra Dias Jayasinha
Ping! Need your feedback Carbon team. On 27 June 2016 at 12:13, Uvindra Dias Jayasinha wrote: > Before I just apply the stated fix I would like some feedback from the > Carbon team regarding what maybe causing this issue. > > So here is what we are seeing so far, > > 1.

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-27 Thread Uvindra Dias Jayasinha
Before I just apply the stated fix I would like some feedback from the Carbon team regarding what maybe causing this issue. So here is what we are seeing so far, 1. IllegalStateException is being thrown by CarbonContextDataHolder.setTenantDomain() 2. The logic in setTenantDomain() is as

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-24 Thread Uvindra Dias Jayasinha
Problem is the issue is intermittent so its difficult to verify but I will test the fix out and send a PR On 24 June 2016 at 13:52, Chanaka Fernando wrote: > Hi Uvindra, > > Could you please verify the fix and send us a PR so that we can merge it? > > On Fri, Jun 24, 2016 at

Re: [Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-24 Thread Chanaka Fernando
Hi Uvindra, Could you please verify the fix and send us a PR so that we can merge it? On Fri, Jun 24, 2016 at 1:02 PM, Uvindra Dias Jayasinha wrote: > Hi All, > > The original issue encountered in [1] was fixed via the resolution of [2]. > > But now this has been reopened and

[Dev] Fixing APIMANAGER-4202 at carbon-mediation level

2016-06-24 Thread Uvindra Dias Jayasinha
Hi All, The original issue encountered in [1] was fixed via the resolution of [2]. But now this has been reopened and in this case the same issue has got exposed, but on this occasion the call stack is different. This is happening when setting the tenant info at [3]. So we need to apply the same