Hi all, Please find the code review notes as follows.
polling interval in the UI hint - seconds output event adapter run time exception should be changed to configuration exception tenantID - don't keep a reference of the tenantID. you should be able to use it in the needed place by using the tenant flow create an array other than a list for event component list because you know the size which contains only objects internally u hv a link list, that should be array of objects containing size of meta, payload, etc,. keep those objects with time properly synchronize link list implementation or use a link blocking queue in UIEventApadter event queue size cannot be constant, it should be taken from the system and it should be configurable if no configuration available - use default - Log and say size 30 is using sending one event by event is wrong you should not send per event. construct all and send as one. 5 events comes once - then send all at once (same logic like in http) convert everything to string 2 events - create strings from those same conversion need to be done once - and reuse it send the same array and iterate and check whether any data exists.. without sending boolean thing JSON - time, data, boolean INDEXZERO, one… 2 also has to be in one format eg: 2 should be INDEXTWO update method “getOSGIService()” in SupertenentEventRetrieverEndPoint check websocket changes take stream id creating parameters to the top no sun related codes in web.xml - use a common one we need to stop passing the tenant id when you are deploying the webapp you get the tenant configuration at that level get tenant id from the tenant flow check dilinis latest code Best Regards, On Wed, Apr 1, 2015 at 12:00 PM, Damith Wickramasinghe <dami...@wso2.com> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > [Code review] Publisher - Output Adapter UI > *When* > Wed Apr 1, 2015 12pm – 1pm Colombo > *Where* > LK Trace Mezzanine Floor Meeting Room - Gondor Ext:1036212 (map > <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Meeting+Room+-+Gondor+Ext:1036212&hl=en> > ) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review > <https://plus.google.com/hangouts/_/wso2.com/code-review?hceid=ZGFtaXRobkB3c28yLmNvbQ.g0m5gung3ap7real1fq29n2dn0> > *Calendar* > ramin...@wso2.com > *Who* > • > Damith Wickramasinghe - organizer > • > Sriskandarajah Suhothayan > • > Ramindu De Silva > • > Rajeev Sampath > • > Tharik Kanaka > • > Mohanadarshan Vivekanandalingam > • > Dilini Muthumala > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=1&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=3&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=2&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account ramin...@wso2.com because you > are subscribed for invitations on calendar ramin...@wso2.com. > > To stop receiving these emails, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- *Ramindu De Silva* Software Engineer WSO2 Inc.: http://wso2.com lean.enterprise.middleware email: ramin...@wso2.com <sanj...@wso2.com> mob: +94 772339350 mob: +94 782731766 On Wed, Apr 1, 2015 at 12:00 PM, Damith Wickramasinghe <dami...@wso2.com> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > [Code review] Publisher - Output Adapter UI > *When* > Wed Apr 1, 2015 12pm – 1pm Colombo > *Where* > LK Trace Mezzanine Floor Meeting Room - Gondor Ext:1036212 (map > <https://maps.google.lk/maps?q=LK+Trace+Mezzanine+Floor+Meeting+Room+-+Gondor+Ext:1036212&hl=en> > ) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review > <https://plus.google.com/hangouts/_/wso2.com/code-review?hceid=ZGFtaXRobkB3c28yLmNvbQ.g0m5gung3ap7real1fq29n2dn0> > *Calendar* > ramin...@wso2.com > *Who* > • > Damith Wickramasinghe - organizer > • > Sriskandarajah Suhothayan > • > Ramindu De Silva > • > Rajeev Sampath > • > Tharik Kanaka > • > Mohanadarshan Vivekanandalingam > • > Dilini Muthumala > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=1&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=3&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&rst=2&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=ZzBtNWd1bmczYXA3cmVhbDFmcTI5bjJkbjAgcmFtaW5kdXNAd3NvMi5jb20&tok=MTYjZGFtaXRobkB3c28yLmNvbWRjZGZjMDdhM2FiN2FjZjEzY2JmZTBlNzUyYjQ1OGQxN2I0MTFmYzk&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account ramin...@wso2.com because you > are subscribed for invitations on calendar ramin...@wso2.com. > > To stop receiving these emails, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- *Ramindu De Silva* Software Engineer WSO2 Inc.: http://wso2.com lean.enterprise.middleware email: ramin...@wso2.com <sanj...@wso2.com> mob: +94 772339350 mob: +94 782731766
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
