Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Johann Nallathamby
Hi Nipuni, Two more suggestions. 1. The same fix needs to be done for the Groups as well. You can define a new property for this also. 2. If these two properties are not there we can go with the default values like before, 'users' and 'groups'. Regards, Johann. On Thu, Aug 14, 2014 at 1:25

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Nipuni Perera
Hi, Please find the attached patch for the issue. I have added a new property to tenant-mgt.xml. Property name=OrganizationalSubContextAttributeValueuser/Property Removed the constant LDAPConstants.USER_CONTEXT_NAME and used the value of newly added property instead.

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Nipuni Perera
Hi, I have added 2 new properties and set values as users and groups as follows, so that they will be used as default values. Property name=OrganizationalSubContextUserContextNameusers/Property Property name=OrganizationalSubContextGroupContextNamegroups/Property I guess a null

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Johann Nallathamby
Hi Nipuni, better have null checks and initialize default value otherwise there could be issues in migrating from old version to new version. Thanks, Johann. On Thu, Aug 14, 2014 at 2:21 PM, Nipuni Perera nip...@wso2.com wrote: Hi, I have added 2 new properties and set values as users and

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Nipuni Perera
Hi, Find the diff attached. Thanks, Nipuni On Thu, Aug 14, 2014 at 3:41 PM, Johann Nallathamby joh...@wso2.com wrote: Hi Nipuni, better have null checks and initialize default value otherwise there could be issues in migrating from old version to new version. Thanks, Johann. On Thu,

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Johann Nallathamby
Hi Nipuni, Isn't the default value 'users' and not 'user'? On Fri, Aug 15, 2014 at 7:59 AM, Nipuni Perera nip...@wso2.com wrote: Hi, Find the diff attached. Thanks, Nipuni On Thu, Aug 14, 2014 at 3:41 PM, Johann Nallathamby joh...@wso2.com wrote: Hi Nipuni, better have null

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-14 Thread Nipuni Perera
Hi, Yes. should be users. corrected. Thanks, Nipuni On Fri, Aug 15, 2014 at 8:37 AM, Johann Nallathamby joh...@wso2.com wrote: Hi Nipuni, Isn't the default value 'users' and not 'user'? On Fri, Aug 15, 2014 at 7:59 AM, Nipuni Perera nip...@wso2.com wrote: Hi, Find the diff attached.

Re: [Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-13 Thread Johann Nallathamby
Hi Nipuni, On Wed, Aug 13, 2014 at 10:52 AM, Nipuni Perera nip...@wso2.com wrote: Hi, I am working on issue[1]. According to the existing implementation the constant LDAPConstants.USER_CONTEXT_NAME has been used in several places to build OrganizationalSubContextAttribute. If the

[Dev] No config in tenant-mgt.xml to read the value of OrganizationalSubContextAttribute

2014-08-12 Thread Nipuni Perera
Hi, I am working on issue[1]. According to the existing implementation the constant LDAPConstants.USER_CONTEXT_NAME has been used in several places to build OrganizationalSubContextAttribute. If the tenant-mgt.xml is updated to read value of property OrganizationalSubContextAttribute as follows,