[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810437#comment-17810437
]
Max edited comment on XALANJ-2725 at 1/24/24 2:56 PM:
--
Hi [~kesh...@alum.mit.edu] ,
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810472#comment-17810472
]
Joe Kesselman commented on XALANJ-2725:
---
TL;DR: I may be fooling myself in how I'm invoking the
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Kesselman reopened XALANJ-2419:
---
This is *PROBABLY* solved, but with the now-checked-in code I'm seeing some odd
behavior where
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519
]
Max edited comment on XALANJ-2725 at 1/24/24 6:16 PM:
--
[~kesh...@alum.mit.edu] ,
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810529#comment-17810529
]
Max commented on XALANJ-2725:
-
For ease of review: [https://github.com/apache/xalan-java/pull/166]
>
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810437#comment-17810437
]
Max commented on XALANJ-2725:
-
Hi [~kesh...@alum.mit.edu] , all good points. Considering that I am not an
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810488#comment-17810488
]
Joe Kesselman commented on XALANJ-2725:
---
Reopened the other issue while I investigate, since I'm
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810526#comment-17810526
]
Jesper Steen Møller commented on XALANJ-2419:
-
Great work getting this forward, Joe!
maxfortun opened a new pull request, #166:
URL: https://github.com/apache/xalan-java/pull/166
https://issues.apache.org/jira/browse/XALANJ-2725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492
]
Max edited comment on XALANJ-2725 at 1/24/24 4:33 PM:
--
Thank you for you wonderful
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492
]
Max commented on XALANJ-2725:
-
Thank you for you wonderful instructions. Setting up and running tests was
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492
]
Max edited comment on XALANJ-2725 at 1/24/24 5:14 PM:
--
Thank you for you wonderful
mukulga merged PR #165:
URL: https://github.com/apache/xalan-java/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519
]
Max commented on XALANJ-2725:
-
Found the issue. Modded the patch. Please take a look.
> Possible
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max updated XALANJ-2725:
Attachment: (was: astral-chars-split-buffer.patch)
> Possible buffer-boundry issue when serializing surrogate
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max updated XALANJ-2725:
Attachment: astral-chars-split-buffer.patch
> Possible buffer-boundry issue when serializing surrogate pairs
>
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519
]
Max edited comment on XALANJ-2725 at 1/24/24 6:08 PM:
--
[~kesh...@alum.mit.edu] ,
jkesselm commented on PR #166:
URL: https://github.com/apache/xalan-java/pull/166#issuecomment-1908848362
Looks more plausible, though I'm still not sure writing out an NCE for an
isolated high surrogate is a win.
I still sorta hate the idea of adding Still More Conditionals to the
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810537#comment-17810537
]
Joe Kesselman commented on XALANJ-2419:
---
ToXMLStream Test Case 2, is having trouble with both
jkesselm commented on code in PR #166:
URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465440629
##
serializer/src/main/java/org/apache/xml/serializer/ToStream.java:
##
@@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {
maxfortun commented on code in PR #166:
URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465446880
##
serializer/src/main/java/org/apache/xml/serializer/ToStream.java:
##
@@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {
[
https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810539#comment-17810539
]
Joe Kesselman commented on XALANJ-2725:
---
Whether numeric entities are returned "unscathed"
maxfortun commented on code in PR #166:
URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465447856
##
serializer/src/main/java/org/apache/xml/serializer/ToStream.java:
##
@@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {
maxfortun commented on code in PR #166:
URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465445384
##
serializer/src/main/java/org/apache/xml/serializer/ToStream.java:
##
@@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {
jkesselm commented on code in PR #166:
URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465440629
##
serializer/src/main/java/org/apache/xml/serializer/ToStream.java:
##
@@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810589#comment-17810589
]
Joe Kesselman commented on XALANJ-2419:
---
Runs fine under Eclipse.
Runs fine under apitests.
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810609#comment-17810609
]
Joe Kesselman commented on XALANJ-2419:
---
Arggh. Found the difference in invocation, I think. It's
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810609#comment-17810609
]
Joe Kesselman edited comment on XALANJ-2419 at 1/25/24 12:59 AM:
-
Arggh.
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810716#comment-17810716
]
Cédric Damioli commented on XALANJ-2419:
I think I may know this one !
It reminds me an issue
[
https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810716#comment-17810716
]
Cédric Damioli edited comment on XALANJ-2419 at 1/25/24 7:37 AM:
-
I
30 matches
Mail list logo