[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810175#comment-17810175 ] Joe Kesselman edited comment on XALANJ-2725 at 1/24/24 2:44 AM:

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810175#comment-17810175 ] Joe Kesselman edited comment on XALANJ-2725 at 1/24/24 2:43 AM:

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810175#comment-17810175 ] Joe Kesselman commented on XALANJ-2725: --- Unfortunately, no, the patch doesn't seem to be working

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810125#comment-17810125 ] Joe Kesselman commented on XALANJ-2419: --- Everything should have been carried forward. That may

[jira] [Comment Edited] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810125#comment-17810125 ] Joe Kesselman edited comment on XALANJ-2419 at 1/23/24 10:41 PM: -

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810119#comment-17810119 ] Cédric Damioli commented on XALANJ-2419: I totally agree with you in theory, but the fact is

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810117#comment-17810117 ] Joe Kesselman commented on XALANJ-2419: --- [~cdamioli] : I believe that was due to some mistakes in

[jira] [Resolved] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Kesselman resolved XALANJ-2419. --- Fix Version/s: The Latest Development Code Resolution: Fixed Fixed on head. Haven't

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810114#comment-17810114 ] Cédric Damioli commented on XALANJ-2419: I may be wrong here, but I think 2.7.2 and 2.7.3 were

Re: [PR] Make sure the new stream tests gate apitest success or failure [xalan-test]

2024-01-23 Thread via GitHub
jkesselm merged PR #9: URL: https://github.com/apache/xalan-test/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Make sure the new stream tests gate apitest success or failure [xalan-test]

2024-01-23 Thread via GitHub
jkesselm opened a new pull request, #9: URL: https://github.com/apache/xalan-test/pull/9 Notes to myself: Apparently we're relying on an explicit list of expected-good tests in build.xml, looking for the Pass-testname files. There is currently one known fail in

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810111#comment-17810111 ] Joe Kesselman commented on XALANJ-2419: --- Merged into Master. Obviously if there seems to be a

Re: [PR] Xalanj 2419 -- Issues serializing astral characters [xalan-test]

2024-01-23 Thread via GitHub
jkesselm merged PR #8: URL: https://github.com/apache/xalan-test/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] XALANJ-2419: Erroneous serialization of astral characters [xalan-java]

2024-01-23 Thread via GitHub
jkesselm merged PR #163: URL: https://github.com/apache/xalan-java/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810065#comment-17810065 ] Max commented on XALANJ-2725: - [~kesh...@alum.mit.edu] , I added a patch I tried with your PR. See if your

[jira] [Updated] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max updated XALANJ-2725: Attachment: astral-chars-split-buffer.patch > Possible buffer-boundry issue when serializing surrogate pairs >

Re: [PR] improving xpath 3.1 function fn:deep-equal's implementation, by adding support for collation argument. adding a new working related test case as well. committing new xercesj implementation ja

2024-01-23 Thread via GitHub
mukulga merged PR #164: URL: https://github.com/apache/xalan-java/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] improving xpath 3.1 function fn:deep-equal's implementation, by adding support for collation argument. adding a new working related test case as well. committing new xercesj implementation jar as

2024-01-23 Thread via GitHub
mukulga opened a new pull request, #164: URL: https://github.com/apache/xalan-java/pull/164 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] XALANJ-2419: Erroneous serialization of astral characters [xalan-java]

2024-01-23 Thread via GitHub
jkesselm opened a new pull request, #163: URL: https://github.com/apache/xalan-java/pull/163 See also https://github.com/apache/xalan-test/compare/master...XALANJ-2419 Note that there is a remaining edge case, https://issues.apache.org/jira/browse/XALANJ-2725, but this PR is a

[PR] Xalanj 2419 -- Issues serializing astral characters [xalan-test]

2024-01-23 Thread via GitHub
jkesselm opened a new pull request, #8: URL: https://github.com/apache/xalan-test/pull/8 See also https://github.com/apache/xalan-java/compare/master...XALANJ-2419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810047#comment-17810047 ] Joe Kesselman commented on XALANJ-2419: --- Opened https://issues.apache.org/jira/browse/XALANJ-2725

[jira] [Created] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Joe Kesselman (Jira)
Joe Kesselman created XALANJ-2725: - Summary: Possible buffer-boundry issue when serializing surrogate pairs Key: XALANJ-2725 URL: https://issues.apache.org/jira/browse/XALANJ-2725 Project: XalanJ2

[jira] [Comment Edited] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810043#comment-17810043 ] Max edited comment on XALANJ-2419 at 1/23/24 5:08 PM: -- [~kesh...@alum.mit.edu] ,

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810043#comment-17810043 ] Max commented on XALANJ-2419: - [~kesh...@alum.mit.edu] , thank you for working on this. As you suggested,

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810039#comment-17810039 ] Joe Kesselman commented on XALANJ-2419: --- Still having trouble with Max's suggestion. Current

[jira] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419 ] Joe Kesselman deleted comment on XALANJ-2419: --- was (Author: JIRAUSER285361): Max's alternative does cause a regression in some of the new tests, assuming I applied it correctly.

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810029#comment-17810029 ] Joe Kesselman commented on XALANJ-2419: --- Max's alternative does cause a regression in some of the