[jira] [Comment Edited] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810716#comment-17810716 ] Cédric Damioli edited comment on XALANJ-2419 at 1/25/24 7:37 AM: - I

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810716#comment-17810716 ] Cédric Damioli commented on XALANJ-2419: I think I may know this one ! It reminds me an issue

[jira] [Comment Edited] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810609#comment-17810609 ] Joe Kesselman edited comment on XALANJ-2419 at 1/25/24 12:59 AM: - Arggh.

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810609#comment-17810609 ] Joe Kesselman commented on XALANJ-2419: --- Arggh. Found the difference in invocation, I think. It's

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810589#comment-17810589 ] Joe Kesselman commented on XALANJ-2419: --- Runs fine under Eclipse. Runs fine under apitests.

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
jkesselm commented on PR #166: URL: https://github.com/apache/xalan-java/pull/166#issuecomment-1908848362 Looks more plausible, though I'm still not sure writing out an NCE for an isolated high surrogate is a win. I still sorta hate the idea of adding Still More Conditionals to the

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
maxfortun commented on code in PR #166: URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465447856 ## serializer/src/main/java/org/apache/xml/serializer/ToStream.java: ## @@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
jkesselm commented on code in PR #166: URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465440629 ## serializer/src/main/java/org/apache/xml/serializer/ToStream.java: ## @@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810539#comment-17810539 ] Joe Kesselman commented on XALANJ-2725: --- Whether numeric entities are returned "unscathed"

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
maxfortun commented on code in PR #166: URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465446880 ## serializer/src/main/java/org/apache/xml/serializer/ToStream.java: ## @@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
maxfortun commented on code in PR #166: URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465445384 ## serializer/src/main/java/org/apache/xml/serializer/ToStream.java: ## @@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {

Re: [PR] UTF16 buffer boundary XALANJ-2725 [xalan-java]

2024-01-24 Thread via GitHub
jkesselm commented on code in PR #166: URL: https://github.com/apache/xalan-java/pull/166#discussion_r1465440629 ## serializer/src/main/java/org/apache/xml/serializer/ToStream.java: ## @@ -1595,23 +1599,40 @@ else if (m_encodingInfo.isInEncoding(ch)) {

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810537#comment-17810537 ] Joe Kesselman commented on XALANJ-2419: --- ToXMLStream Test Case 2, is having trouble with both

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810529#comment-17810529 ] Max commented on XALANJ-2725: - For ease of review: [https://github.com/apache/xalan-java/pull/166] >

[PR] updated [xalan-java]

2024-01-24 Thread via GitHub
maxfortun opened a new pull request, #166: URL: https://github.com/apache/xalan-java/pull/166 https://issues.apache.org/jira/browse/XALANJ-2725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810526#comment-17810526 ] Jesper Steen Møller commented on XALANJ-2419: - Great work getting this forward, Joe!  

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519 ] Max edited comment on XALANJ-2725 at 1/24/24 6:16 PM: -- [~kesh...@alum.mit.edu] ,

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519 ] Max edited comment on XALANJ-2725 at 1/24/24 6:08 PM: -- [~kesh...@alum.mit.edu] ,

[jira] [Updated] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max updated XALANJ-2725: Attachment: astral-chars-split-buffer.patch > Possible buffer-boundry issue when serializing surrogate pairs >

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519 ] Max commented on XALANJ-2725: - Found the issue. Modded the patch. Please take a look. > Possible

[jira] [Updated] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max updated XALANJ-2725: Attachment: (was: astral-chars-split-buffer.patch) > Possible buffer-boundry issue when serializing surrogate

Re: [PR] committing few new working test cases for xpath 3.1 fn:deep-equal function, that make use of this function's collation argument [xalan-java]

2024-01-24 Thread via GitHub
mukulga merged PR #165: URL: https://github.com/apache/xalan-java/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492 ] Max edited comment on XALANJ-2725 at 1/24/24 5:14 PM: -- Thank you for you wonderful

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492 ] Max commented on XALANJ-2725: - Thank you for you wonderful instructions. Setting up and running tests was

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492 ] Max edited comment on XALANJ-2725 at 1/24/24 4:33 PM: -- Thank you for you wonderful

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810488#comment-17810488 ] Joe Kesselman commented on XALANJ-2725: --- Reopened the other issue while I investigate, since I'm

[jira] [Reopened] (XALANJ-2419) Astral characters written as a pair of NCRs with the surrogate scalar values when using UTF-8

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Kesselman reopened XALANJ-2419: --- This is *PROBABLY* solved, but with the now-checked-in code I'm seeing some odd behavior where

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810472#comment-17810472 ] Joe Kesselman commented on XALANJ-2725: --- TL;DR:  I may be fooling myself in how I'm invoking the

[jira] [Comment Edited] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810437#comment-17810437 ] Max edited comment on XALANJ-2725 at 1/24/24 2:56 PM: -- Hi [~kesh...@alum.mit.edu] ,

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810437#comment-17810437 ] Max commented on XALANJ-2725: - Hi [~kesh...@alum.mit.edu] , all good points. Considering that I am not an