[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811452#comment-17811452 ] Joe Kesselman commented on XALANJ-2618: --- I've tested with Java 21 as well, on Linux. Haven't spun

[PR] Improved encoding lookup [xalan-java]

2024-01-26 Thread via GitHub
jkesselm opened a new pull request, #168: URL: https://github.com/apache/xalan-java/pull/168 As [Cédric Damioli](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cdamioli) has pointed out, the logic in Encodings.java relied upon `Hashtable` behavior that changed between Java

Re: [PR] XALANJ-2618 Invalid encodings in Encodings.properties [xalan-java]

2024-01-26 Thread via GitHub
jkesselm commented on PR #167: URL: https://github.com/apache/xalan-java/pull/167#issuecomment-1912916533 We both have solutions (mine is at https://github.com/apache/xalan-java/tree/XALANJ-2618), I think I like my fix a bit better, since it resolves the problem without having to remove

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811445#comment-17811445 ] Cédric Damioli commented on XALANJ-2618: Hi [~kesh...@alum.mit.edu] I can confim that with your

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811444#comment-17811444 ] Joe Kesselman commented on XALANJ-2618: --- Yes, this seems to close the gap in that code. > Error

Re: [jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joseph Kesselman
Yes, this appears to close the hole. I should check with a few more versions of Java, just in case I missed something else. -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: / https://www.amazon.com/dp/B09WJ3H657/ Caveat: Opinionated old geezer with

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811363#comment-17811363 ] Cédric Damioli commented on XALANJ-2618: I'll test your branch. Does your other work on

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811359#comment-17811359 ] Joe Kesselman commented on XALANJ-2618: --- (Actually, with this change, it *might* be possible to

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811357#comment-17811357 ] Joe Kesselman commented on XALANJ-2618: --- A version with that tweak has been posted as branch

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811351#comment-17811351 ] Joe Kesselman commented on XALANJ-2618: --- Tested with putIfAbsent, and that does seem to resolve

[jira] [Comment Edited] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811344#comment-17811344 ] Joe Kesselman edited comment on XALANJ-2618 at 1/26/24 5:18 PM: Or

[jira] [Comment Edited] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811344#comment-17811344 ] Joe Kesselman edited comment on XALANJ-2618 at 1/26/24 5:17 PM: Or

[jira] [Comment Edited] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811344#comment-17811344 ] Joe Kesselman edited comment on XALANJ-2618 at 1/26/24 5:16 PM: Or

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811344#comment-17811344 ] Joe Kesselman commented on XALANJ-2618: --- Or perhaps: Change the properties file so both java and

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811343#comment-17811343 ] Joe Kesselman commented on XALANJ-2618: --- The two hashtables suggest that we originally thought we

[jira] [Comment Edited] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811336#comment-17811336 ] Joe Kesselman edited comment on XALANJ-2618 at 1/26/24 4:49 PM: (Sorry,

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811338#comment-17811338 ] Cédric Damioli commented on XALANJ-2618: The Encodings.properties has three columns. The first

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811337#comment-17811337 ] Joe Kesselman commented on XALANJ-2618: --- (Good catch, by the way!) > Error in

[jira] [Comment Edited] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811336#comment-17811336 ] Joe Kesselman edited comment on XALANJ-2618 at 1/26/24 4:20 PM: Dropping

[jira] [Commented] (XALANJ-2618) Error in org/apache/xml/serializer/Encodings.properties

2024-01-26 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811336#comment-17811336 ] Joe Kesselman commented on XALANJ-2618: --- Dropping 8851-* would be a code regression, and is really