[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820256#comment-17820256 ] Joe Kesselman commented on XALANJ-2725: --- Unfortunately we don't have a lot of unit tests, but the

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-23 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820236#comment-17820236 ] Cédric Damioli commented on XALANJ-2725: Hi [~kesh...@alum.mit.edu], I just made a few tests

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-22 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819805#comment-17819805 ] Joe Kesselman commented on XALANJ-2725: --- Followup: XALANJ-2730 > Possible buffer-boundry issue

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-22 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819800#comment-17819800 ] Joe Kesselman commented on XALANJ-2725: --- I'll open a new work item for the remaining technical

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-21 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819441#comment-17819441 ] Joseph Kessselman commented on XALANJ-2725: --- [~curc...@apache.org] : I believe you were

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-21 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819440#comment-17819440 ] Joseph Kessselman commented on XALANJ-2725: --- Might be best to just note that as technical debt

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-21 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819439#comment-17819439 ] Joseph Kessselman commented on XALANJ-2725: --- Added code for isolated High Surrogate. People do

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-21 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819375#comment-17819375 ] Joseph Kessselman commented on XALANJ-2725: --- (Took me a little while to remember how the

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-21 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819374#comment-17819374 ] Joseph Kessselman commented on XALANJ-2725: --- Checked in a fix for ToStream.characters(), on my

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-17 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818231#comment-17818231 ] Joseph Kessselman commented on XALANJ-2725: --- (Yeah, I know, I'm overcomplicating. I'd just

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-02-17 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818226#comment-17818226 ] Joseph Kessselman commented on XALANJ-2725: --- Resuming looking at this. The main issue I see

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-31 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812766#comment-17812766 ] Max commented on XALANJ-2725: - [~kesh...@alum.mit.edu] , thank you for the heads up, and for actually

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-31 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812757#comment-17812757 ] Joe Kesselman commented on XALANJ-2725: --- FYI, I have other demands on my time for the next two

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-29 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812145#comment-17812145 ] Joseph Kessselman commented on XALANJ-2725: --- (Sigh. Still dealing with half the time being

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-29 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811990#comment-17811990 ] Joseph Kessselman commented on XALANJ-2725: --- Started XALANJ-2725 branches for this, merged

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-29 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811984#comment-17811984 ] Joseph Kessselman commented on XALANJ-2725: --- Thanks for the test contribution. I'm going to

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-29 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811980#comment-17811980 ] Max commented on XALANJ-2725: - [~kesh...@alum.mit.edu] , added a split buffer test case: 

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-28 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811737#comment-17811737 ] Joe Kesselman commented on XALANJ-2725: --- Certainly if there is to be a behavior change that isn't

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-28 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811718#comment-17811718 ] Max commented on XALANJ-2725: - [~kesh...@alum.mit.edu], what do you think about adding an incomplete

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-28 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811716#comment-17811716 ] Joseph Kessselman commented on XALANJ-2725: --- Looking back to the XML Recommendation: {quote}It

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811608#comment-17811608 ] Joseph Kessselman commented on XALANJ-2725: --- Encodings aren't the only place where we use

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811605#comment-17811605 ] Joseph Kessselman commented on XALANJ-2725: --- (I'm trying *not* to reorganize ToStream now. One

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Joseph Kessselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811593#comment-17811593 ] Joseph Kessselman commented on XALANJ-2725: --- Can you share those edge cases? I've been

Re: [jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Joseph Kesselman
, 2024 12:53:00 PM To: dev@xalan.apache.org Subject: [jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs [ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811574#comment-17811574

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Jira
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811574#comment-17811574 ] Cédric Damioli commented on XALANJ-2725: It would be great to solve all open encoding issues and

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-27 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811540#comment-17811540 ] Joe Kesselman commented on XALANJ-2725: --- The basic formatting issue should be solved now. I think

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810539#comment-17810539 ] Joe Kesselman commented on XALANJ-2725: --- Whether numeric entities are returned "unscathed"

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810529#comment-17810529 ] Max commented on XALANJ-2725: - For ease of review: [https://github.com/apache/xalan-java/pull/166] >

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810519#comment-17810519 ] Max commented on XALANJ-2725: - Found the issue. Modded the patch. Please take a look. > Possible

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810492#comment-17810492 ] Max commented on XALANJ-2725: - Thank you for you wonderful instructions. Setting up and running tests was

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810488#comment-17810488 ] Joe Kesselman commented on XALANJ-2725: --- Reopened the other issue while I investigate, since I'm

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810472#comment-17810472 ] Joe Kesselman commented on XALANJ-2725: --- TL;DR:  I may be fooling myself in how I'm invoking the

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-24 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810437#comment-17810437 ] Max commented on XALANJ-2725: - Hi [~kesh...@alum.mit.edu] , all good points. Considering that I am not an

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Joe Kesselman (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810175#comment-17810175 ] Joe Kesselman commented on XALANJ-2725: --- Unfortunately, no, the patch doesn't seem to be working

[jira] [Commented] (XALANJ-2725) Possible buffer-boundry issue when serializing surrogate pairs

2024-01-23 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/XALANJ-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810065#comment-17810065 ] Max commented on XALANJ-2725: - [~kesh...@alum.mit.edu] , I added a patch I tried with your PR. See if your